View GitHub Repository CAT

Schedule Inspection
Subscribe
Passed
Push — master ( 3a4dc7...065c34 )
by Stefan
10:14 queued 26s
created
Status
Category
Toggle Patches
web/lib/admin/PageDecoration.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch 
@@ -66,13 +66,13 @@  discard block
 
 block discarded – undo
66 66 
         $retval = "<div class='sidebar'><p>";
67 67
68 68 
         if ($advancedControls) {
69 
-            $retval .= "<strong>" . _("You are:") . "</strong> ".$_SESSION['name']
69 
+            $retval .= "<strong>"._("You are:")."</strong> ".$_SESSION['name']
70 70 
             ."<br/>
71 71 
               <br/>
72 
-              <a href='" . \core\CAT::getRootUrlPath() . "/admin/overview_user.php'>" . _("Go to your Profile page") . "</a>
73 
-              <a href='" . \core\CAT::getRootUrlPath() . "/admin/inc/logout.php'>" . _("Logout") . "</a> ";
72 
+              <a href='" . \core\CAT::getRootUrlPath()."/admin/overview_user.php'>"._("Go to your Profile page")."</a>
73 
+              <a href='" . \core\CAT::getRootUrlPath()."/admin/inc/logout.php'>"._("Logout")."</a> ";
74 74 
         }
75 
-        $retval .= "<a href='" . \core\CAT::getRootUrlPath() . "/'>" . _("Start page") . "</a>
75 
+        $retval .= "<a href='".\core\CAT::getRootUrlPath()."/'>"._("Start page")."</a>
76 76 
             </p>
77 77 
         </div> <!-- sidebar -->";
78 78 
         \core\common\Entity::outOfThePotatoes();
 
@@ -96,22 +96,22 @@  discard block
 
 block discarded – undo
96 96 
                     <h1>$cap1</h1>
97 97 
                 </div><!--header_captions-->
98 98 
                 <div id='langselection' style='padding-top:20px; padding-left:10px;'>
99 
-                    <form action='$place' method='GET' accept-charset='UTF-8'>" . _("View this page in") . "&nbsp;
99 
+                    <form action='$place' method='GET' accept-charset='UTF-8'>"._("View this page in")."&nbsp;
100 100 
                         <select id='lang' name='lang' onchange='this.form.submit()'>";
101 101
102 102 
         foreach (\config\Master::LANGUAGES as $lang => $getValue) {
103 
-            $retval .= "<option value='$lang' " . (strtoupper($language) == strtoupper($lang) ? "selected" : "" ) . " >" . $getValue['display'] . "</option> ";
103 
+            $retval .= "<option value='$lang' ".(strtoupper($language) == strtoupper($lang) ? "selected" : "")." >".$getValue['display']."</option> ";
104 104 
         }
105 105 
         $retval .= "</select>";
106 106
107 107 
         foreach ($_GET as $getVar => $getValue) {
108 108 
             if ($getVar != "lang" && $getValue != "") {
109 
-                $retval .= "<input type='hidden' name='" . htmlspecialchars($getVar) . "' value='" . htmlspecialchars($getValue) . "'>";
109 
+                $retval .= "<input type='hidden' name='".htmlspecialchars($getVar)."' value='".htmlspecialchars($getValue)."'>";
110 110 
             }
111 111 
         }
112 112 
         $retval .= "</form>
113 113 
                 </div><!--langselection-->";
114 
-        $logoUrl = \core\CAT::getRootUrlPath() . "/resources/images/consortium_logo.png";
114 
+        $logoUrl = \core\CAT::getRootUrlPath()."/resources/images/consortium_logo.png";
115 115 
         $retval .= "<div class='consortium_logo'>
116 116 
                     <img id='test_locate' src='$logoUrl' alt='Consortium Logo'>
117 117 
                 </div> <!-- consortium_logo -->
 
@@ -204,7 +204,7 @@  discard block
 
 block discarded – undo
204 204
205 205 
         if (isset(\config\Master::APPEARANCE['MOTD']) && \config\Master::APPEARANCE['MOTD'] != "") {
206 206 
             $retval .= "<div id='header_MOTD' style='display:inline-block; padding-left:20px;vertical-align:top;'>
207 
-              <p class='MOTD'>" . \config\Master::APPEARANCE['MOTD'] . "</p>
207 
+              <p class='MOTD'>" . \config\Master::APPEARANCE['MOTD']."</p>
208 208 
               </div><!--header_MOTD-->";
209 209 
         }
210 210 
         $retval .= $this->sidebar($advancedControls);
 
@@ -230,9 +230,9 @@  discard block
 
 block discarded – undo
230 230 
           <html xmlns='http://www.w3.org/1999/xhtml' lang='$ourlocale'>
231 231 
           <head lang='$ourlocale'>
232 232 
           <meta http-equiv='Content-Type' content='text/html; charset=UTF-8'>";
233 
-        $cssUrl = \core\CAT::getRootUrlPath() . "/resources/css/cat.css.php";
233 
+        $cssUrl = \core\CAT::getRootUrlPath()."/resources/css/cat.css.php";
234 234 
         $retval .= "<link rel='stylesheet' type='text/css' href='$cssUrl' />";
235 
-        $retval .= "<title>" . htmlspecialchars($pagetitle) . "</title>";
235 
+        $retval .= "<title>".htmlspecialchars($pagetitle)."</title>";
236 236 
         return $retval;
237 237 
     }
238 238 
 
@@ -246,7 +246,7 @@  discard block
 
 block discarded – undo
246 246 
             // we may need to jump up one dir if we are either in admin/ or accountstatus/
247 247 
             // (accountstatus courtesy of my good mood. It's userspace not admin space so
248 248 
             // it shouldn't be using this function any more.)
249 
-            $logoBase = \core\CAT::getRootUrlPath() . "/resources/images";
249 
+            $logoBase = \core\CAT::getRootUrlPath()."/resources/images";
250 250 
             return "<span id='logos' style='position:fixed; left:50%;'><img src='$logoBase/dante.png' alt='DANTE' style='height:23px;width:47px'/>
251 251 
               <img src='$logoBase/eu.png' alt='EU' style='height:23px;width:27px;border-width:0px;'/></span>
252 252 
               <span id='eu_text' style='text-align:right;'><a href='http://ec.europa.eu/dgs/connect/index_en.htm' style='text-decoration:none; vertical-align:top;'>European Commission Communications Networks, Content and Technology</a></span>";
 
@@ -268,9 +268,9 @@  discard block
 
 block discarded – undo
268 268 
             <table style='width:100%'>
269 269 
                 <tr>
270 270 
                     <td style='padding-left:20px; padding-right:20px; text-align:left; vertical-align:top;'>
271 
-                        " . $cat->CAT_COPYRIGHT . "</td>";
271 
+                        " . $cat->CAT_COPYRIGHT."</td>";
272 272 
         if (!empty(\config\Master::APPEARANCE['privacy_notice_url'])) {
273 
-            $retval .= "<td><a href='".\config\Master::APPEARANCE['privacy_notice_url']."'>" . sprintf(_("%s Privacy Notice"),\config\ConfAssistant::CONSORTIUM['display_name']) . "</a></td>";
273 
+            $retval .= "<td><a href='".\config\Master::APPEARANCE['privacy_notice_url']."'>".sprintf(_("%s Privacy Notice"), \config\ConfAssistant::CONSORTIUM['display_name'])."</a></td>";
274 274 
         }
275 275 
         $retval .= "            <td style='padding-left:80px; padding-right:20px; text-align:right; vertical-align:top;'>";
276 276
Please login to merge, or discard this patch.