Passed
Push — release_2_1 ( 94c988...0349ba )
by Tomasz
09:22
created
web/admin/inc/toggleRedirect.inc.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
  *          <base_url>/copyright.php after deploying the software
20 20
  */
21 21
 
22
-require_once dirname(dirname(dirname(dirname(__FILE__)))) . "/config/_config.php";
22
+require_once dirname(dirname(dirname(dirname(__FILE__))))."/config/_config.php";
23 23
 
24 24
 $auth = new \web\lib\admin\Authentication();
25 25
 $loggerInstance = new \core\common\Logging();
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
         $remaining_attribs = $my_profile->beginFlushMethodLevelAttributes($eaptype->getIntegerRep(), NULL);
87 87
         $optionParser->processSubmittedFields($my_profile, $_POST, $_FILES, $eaptype->getIntegerRep(), NULL);
88 88
     }
89
-    $loggerInstance->writeAudit($_SESSION['user'], "MOD", "Profile " . $my_profile->identifier . " - device/EAP-Type settings changed");
89
+    $loggerInstance->writeAudit($_SESSION['user'], "MOD", "Profile ".$my_profile->identifier." - device/EAP-Type settings changed");
90 90
     header("Location: ../overview_installers.php?inst_id=$my_inst->identifier&profile_id=$my_profile->identifier");
91 91
     exit;
92 92
 }
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
     }
101 101
     $captiontext = sprintf(_("device <strong>%s</strong>"), $device['display']);
102 102
     $keyword = "device-specific";
103
-    $extrainput = "<input type='hidden' name='device' value='" . $device_key . "'/>";
103
+    $extrainput = "<input type='hidden' name='device' value='".$device_key."'/>";
104 104
     $dev = $device_key;
105 105
 } elseif ($eaptype !== NULL) {
106 106
     foreach ($my_profile->getAttributes() as $attrib) {
@@ -111,13 +111,13 @@  discard block
 block discarded – undo
111 111
 
112 112
     $captiontext = sprintf(_("EAP-Type <strong>%s</strong>"), $eaptype->getPrintableRep());
113 113
     $keyword = "eap-specific";
114
-    $extrainput = "<input type='hidden' name='eaptype' value='" . $eaptype->getIntegerRep() . "'>";
114
+    $extrainput = "<input type='hidden' name='eaptype' value='".$eaptype->getIntegerRep()."'>";
115 115
     $dev = '';
116 116
 } else {
117 117
     throw new Exception("previous type checks make it impossible to reach this code path.");
118 118
 }
119 119
 ?>
120
-<p><?php echo _("Fine-tuning options for ") . $captiontext; ?></p>
120
+<p><?php echo _("Fine-tuning options for ").$captiontext; ?></p>
121 121
 <hr/>
122 122
 
123 123
 <form action='inc/toggleRedirect.inc.php?inst_id=<?php echo $my_inst->identifier; ?>&amp;profile_id=<?php echo $my_profile->identifier; ?>' method='post' accept-charset='UTF-8'><?php echo $extrainput; ?>
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
 // see if we already have any attributes; if so, display these
126 126
     $interesting_attribs = [];
127 127
     foreach ($attribs as $attrib) {
128
-        if ($attrib['level'] == \core\Options::LEVEL_METHOD && preg_match('/^' . $keyword . ':/', $attrib['name'])) {
128
+        if ($attrib['level'] == \core\Options::LEVEL_METHOD && preg_match('/^'.$keyword.':/', $attrib['name'])) {
129 129
             $interesting_attribs[] = $attrib;
130 130
         }
131 131
     }
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
     echo $optionDisplay->prefilledOptionTable($keyword, $my_inst->federation);
134 134
     if (\config\Master::DB['INST']['readonly'] === FALSE) {
135 135
         ?>
136
-        <button type='button' class='newoption' onclick='getXML("<?php echo $keyword;?>", "<?php echo $my_inst->federation;?>", "<?php echo $dev;?>")'><?php echo _("Add new option"); ?></button>
136
+        <button type='button' class='newoption' onclick='getXML("<?php echo $keyword; ?>", "<?php echo $my_inst->federation; ?>", "<?php echo $dev; ?>")'><?php echo _("Add new option"); ?></button>
137 137
         <br/>
138 138
         <hr/>
139 139
         <button type='submit' name='submitbutton' id='submitbutton' value='<?php echo web\lib\common\FormElements::BUTTON_SAVE; ?>'><?php echo _("Save data"); ?></button>
Please login to merge, or discard this patch.
web/admin/inc/option_xhr.inc.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -19,12 +19,12 @@
 block discarded – undo
19 19
  *          <base_url>/copyright.php after deploying the software
20 20
  */
21 21
 
22
-require_once dirname(dirname(dirname(dirname(__FILE__)))) . "/config/_config.php";
22
+require_once dirname(dirname(dirname(dirname(__FILE__))))."/config/_config.php";
23 23
 
24 24
 \core\CAT::sessionStart();
25 25
 $validator = new \web\lib\common\InputValidation();
26 26
 
27
-if (!isset($_GET["class"] )) {
27
+if (!isset($_GET["class"])) {
28 28
     throw new Exception("Unknown type of option!");
29 29
 }
30 30
 
Please login to merge, or discard this patch.
web/lib/admin/OptionDisplay.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -218,7 +218,7 @@
 block discarded – undo
218 218
                         }
219 219
                     }
220 220
                 }
221
-                 break;
221
+                    break;
222 222
             default:
223 223
                 break;
224 224
         }
Please login to merge, or discard this patch.
Spacing   +43 added lines, -43 removed lines patch added patch discarded remove patch
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
      */
113 113
     public function prefilledOptionTable(string $attributePrefix, $fed)
114 114
     {
115
-        $retval = "<table id='expandable_$attributePrefix" . "_options'>";
115
+        $retval = "<table id='expandable_$attributePrefix"."_options'>";
116 116
 
117 117
         $prepopulate = [];
118 118
         foreach ($this->listOfOptions as $existingAttribute) {
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
                 $prepopulate[] = $existingAttribute;
121 121
             }
122 122
         }
123
-        if (is_array($prepopulate) && ( count($prepopulate) > 0 || $attributePrefix == "device-specific" || $attributePrefix == "eap-specific" )) { // editing... fill with values
123
+        if (is_array($prepopulate) && (count($prepopulate) > 0 || $attributePrefix == "device-specific" || $attributePrefix == "eap-specific")) { // editing... fill with values
124 124
             $retval .= $this->addOptionEdit($attributePrefix, $prepopulate);
125 125
         } else {
126 126
             $retval .= $this->addOptionNew($attributePrefix, $fed);
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
             if (preg_match("/^$class:/", $option['name']) && !preg_match("/($blackListOnPrefill)/", $option['name'])) {
155 155
                 $optiontypearray = $optioninfo->optionType($option['name']);
156 156
                 $loggerInstance->debug(5, "About to execute optiontext with PREFILL!\n");
157
-                $retval .= $this->optiontext([$option['name']], ($optiontypearray["type"] == "file" ? 'ROWID-' . $option['level'] . '-' . $option['row_id'] : $option['value']), $option['lang']);
157
+                $retval .= $this->optiontext([$option['name']], ($optiontypearray["type"] == "file" ? 'ROWID-'.$option['level'].'-'.$option['row_id'] : $option['value']), $option['lang']);
158 158
             }
159 159
         }
160 160
         return $retval;
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
      * @param string $fed   the federation TLD, to determine fed ops preference context
171 171
      * @return array the list of options to display
172 172
      */
173
-    public static function enumerateOptionsToDisplay($class, $fed, $device='')
173
+    public static function enumerateOptionsToDisplay($class, $fed, $device = '')
174 174
     {
175 175
         $optioninfo = \core\Options::instance();
176 176
         $loggerInstance = new \core\common\Logging();
@@ -266,18 +266,18 @@  discard block
 block discarded – undo
266 266
         }
267 267
         $descriptions["media:force_proxy"] = sprintf(_("The format of this option is: IPv4|IPv6|hostname:port . Forcing your users through a content filter of your own is a significant invasion of user self-determination. It also has technical issues. Please thoroughly read the discussion at %s before specifying a proxy with this option. This feature is currently experimental and only has an effect in Apple installers."), "https://github.com/GEANT/CAT/issues/96");
268 268
         $descriptions["managedsp:realmforvlan"] = sprintf(_("If you are also using %s, then your own realm is automatically tagged with the VLAN you choose, there is no need to add it here manually."), \core\ProfileSilverbullet::PRODUCTNAME);
269
-        $descriptions["media:openroaming"] = sprintf(_("By opting in to OpenRoaming, you agree to be bound by the %s."), "eduroam Ecosystem Broker OpenRoaming Identity Provider Policy") .
270
-                " " .
271
-                sprintf(_("Note that your requirement to inform users about the OpenRoaming End User Terms and Conditions is fulfilled when directing your end users to the %s download portal for installer download. Any other means of providing the installers needs to present this information via its own channel."), \config\Master::APPEARANCE['productname']) .
272
-                " " .
273
-                _("You are also aware that for best technical interoperability, you need to add a DNS entry into the DNS zone of your RADIUS realm.") .
274
-                " " .
269
+        $descriptions["media:openroaming"] = sprintf(_("By opting in to OpenRoaming, you agree to be bound by the %s."), "eduroam Ecosystem Broker OpenRoaming Identity Provider Policy").
270
+                " ".
271
+                sprintf(_("Note that your requirement to inform users about the OpenRoaming End User Terms and Conditions is fulfilled when directing your end users to the %s download portal for installer download. Any other means of providing the installers needs to present this information via its own channel."), \config\Master::APPEARANCE['productname']).
272
+                " ".
273
+                _("You are also aware that for best technical interoperability, you need to add a DNS entry into the DNS zone of your RADIUS realm.").
274
+                " ".
275 275
                 _("Read the instructions in the wiki.");
276 276
         \core\common\Entity::outOfThePotatoes();
277 277
         if (!isset($descriptions[$input])) {
278 278
             return "";
279 279
         }
280
-        return "<span class='tooltip' id='S$rowid-tooltip-$input' style='display:" . ($isVisible ? "block" : "none") . "' onclick='alert(\"" . $descriptions[$input] . "\")'><img src='../resources/images/icons/question-mark-icon.png" . "'></span>";
280
+        return "<span class='tooltip' id='S$rowid-tooltip-$input' style='display:".($isVisible ? "block" : "none")."' onclick='alert(\"".$descriptions[$input]."\")'><img src='../resources/images/icons/question-mark-icon.png"."'></span>";
281 281
     }
282 282
 
283 283
     /**
@@ -291,19 +291,19 @@  discard block
 block discarded – undo
291 291
     private function selectElement($rowid, $list)
292 292
     {
293 293
         $jsmagic = "onchange='
294
-                               if (/#ML#/.test(document.getElementById(\"option-S" . $rowid . "-select\").value)) {
294
+                               if (/#ML#/.test(document.getElementById(\"option-S" . $rowid."-select\").value)) {
295 295
                                    document.getElementById(\"S$rowid-input-langselect\").style.display = \"block\";
296 296
                                    } else {
297 297
                                    document.getElementById(\"S$rowid-input-langselect\").style.display = \"none\";
298 298
                                    }";
299 299
         foreach (array_keys($this->htmlDatatypeTexts) as $key) {
300
-            $jsmagic .= "if (/#" . $key . "#/.test(document.getElementById(\"option-S" . $rowid . "-select\").value)) {
301
-                                  document.getElementById(\"S$rowid-input-file\").style.display = \"" . ($key == \core\Options::TYPECODE_FILE ? "block" : "none") . "\";
302
-                                  document.getElementById(\"S$rowid-input-text\").style.display = \"" . ($key == \core\Options::TYPECODE_TEXT ? "block" : "none") . "\";
303
-                                  document.getElementById(\"S$rowid-input-string\").style.display = \"" . ($key == \core\Options::TYPECODE_STRING ? "block" : "none") . "\";
304
-                                  document.getElementById(\"S$rowid-input-enum_openroaming\").style.display = \"" . ($key == \core\Options::TYPECODE_ENUM_OPENROAMING ? "block" : "none") . "\";
305
-                                  document.getElementById(\"S$rowid-input-boolean\").style.display = \"" . ($key == \core\Options::TYPECODE_BOOLEAN ? "block" : "none") . "\";
306
-                                  document.getElementById(\"S$rowid-input-integer\").style.display = \"" . ($key == \core\Options::TYPECODE_INTEGER ? "block" : "none") . "\";
300
+            $jsmagic .= "if (/#".$key."#/.test(document.getElementById(\"option-S".$rowid."-select\").value)) {
301
+                                  document.getElementById(\"S$rowid-input-file\").style.display = \"".($key == \core\Options::TYPECODE_FILE ? "block" : "none")."\";
302
+                                  document.getElementById(\"S$rowid-input-text\").style.display = \"".($key == \core\Options::TYPECODE_TEXT ? "block" : "none")."\";
303
+                                  document.getElementById(\"S$rowid-input-string\").style.display = \"".($key == \core\Options::TYPECODE_STRING ? "block" : "none")."\";
304
+                                  document.getElementById(\"S$rowid-input-enum_openroaming\").style.display = \"".($key == \core\Options::TYPECODE_ENUM_OPENROAMING ? "block" : "none")."\";
305
+                                  document.getElementById(\"S$rowid-input-boolean\").style.display = \"".($key == \core\Options::TYPECODE_BOOLEAN ? "block" : "none")."\";
306
+                                  document.getElementById(\"S$rowid-input-integer\").style.display = \"".($key == \core\Options::TYPECODE_INTEGER ? "block" : "none")."\";
307 307
                              }
308 308
                              ";
309 309
             // hide all tooltips (each is a <span>, and there are no other <span>s)
@@ -334,7 +334,7 @@  discard block
 block discarded – undo
334 334
                 $value = array_shift($list);
335 335
                 $listtype = $optioninfo->optionType($value);
336 336
                 $retval .= $uiElements->displayName($value);
337
-                $retval .= "<input type='hidden' name='option[S$rowid]' value='$value#" . $listtype["type"] . "#" . $listtype["flag"] . "#'/>";
337
+                $retval .= "<input type='hidden' name='option[S$rowid]' value='$value#".$listtype["type"]."#".$listtype["flag"]."#'/>";
338 338
                 $activelisttype = $listtype;
339 339
                 $tooltips = $this->tooltip($rowid, $value, TRUE);
340 340
                 break;
@@ -342,7 +342,7 @@  discard block
 block discarded – undo
342 342
                 $retval .= "<select id='option-S$rowid-select' name='option[S$rowid]' $jsmagic>";
343 343
                 foreach ($list as $value) {
344 344
                     $listtype = $optioninfo->optionType($value);
345
-                    $retval .= "<option id='option-S$rowid-v-$value' value='$value#" . $listtype["type"] . "#" . $listtype["flag"] . "#' ";
345
+                    $retval .= "<option id='option-S$rowid-v-$value' value='$value#".$listtype["type"]."#".$listtype["flag"]."#' ";
346 346
                     if ($iterator == $this->optionIterator) {
347 347
                         $retval .= "selected='selected'";
348 348
                         $activelisttype = $listtype;
@@ -350,7 +350,7 @@  discard block
 block discarded – undo
350 350
                     } else {
351 351
                         $tooltips .= $this->tooltip($rowid, $value, FALSE);
352 352
                     }
353
-                    $retval .= ">" . $uiElements->displayName($value) . "</option>";
353
+                    $retval .= ">".$uiElements->displayName($value)."</option>";
354 354
                     $iterator++;
355 355
                 }
356 356
 
@@ -376,9 +376,9 @@  discard block
 block discarded – undo
376 376
     private function selectLanguage($rowid, $makeVisible)
377 377
     {
378 378
         \core\common\Entity::intoThePotatoes();
379
-        $retval = "<select style='display:" . ($makeVisible ? "block" : "none") . "' name='value[S$rowid-lang]' id='S" . $rowid . "-input-langselect'>
380
-            <option value='' name='select_language' selected>" . _("select language") . "</option>
381
-            <option value='C' name='all_languages'>" . _("default/other languages") . "</option>";
379
+        $retval = "<select style='display:".($makeVisible ? "block" : "none")."' name='value[S$rowid-lang]' id='S".$rowid."-input-langselect'>
380
+            <option value='' name='select_language' selected>" . _("select language")."</option>
381
+            <option value='C' name='all_languages'>" . _("default/other languages")."</option>";
382 382
         foreach (\config\Master::LANGUAGES as $langindex => $possibleLang) {
383 383
             $thislang = $possibleLang['display'];
384 384
             $retval .= "<option value='$langindex' name='$langindex'>$thislang</option>";
@@ -399,7 +399,7 @@  discard block
 block discarded – undo
399 399
     {
400 400
         $retval = "";
401 401
         foreach ($this->htmlDatatypeTexts as $key => $type) {
402
-            $retval .= "<" . $type['html'] . " style='display:" . ($activetype['type'] == $key ? "block" : "none") . "' name='value[S$rowid-$key]' id='S" . $rowid . "-input-" . $key . "'" . $type['tail'] . ">";
402
+            $retval .= "<".$type['html']." style='display:".($activetype['type'] == $key ? "block" : "none")."' name='value[S$rowid-$key]' id='S".$rowid."-input-".$key."'".$type['tail'].">";
403 403
         }
404 404
         return $retval;
405 405
     }
@@ -415,11 +415,11 @@  discard block
 block discarded – undo
415 415
     {
416 416
         // first column: the <select> element with the names of options and their field-toggling JS magic
417 417
         $selectorInfo = $this->selectElement($rowid, $list);
418
-        $retval = "<td>" . $selectorInfo["TEXT"] . "</td>";
418
+        $retval = "<td>".$selectorInfo["TEXT"]."</td>";
419 419
         // second column: the <select> element for language selection - only visible if the active option is multi-lang
420
-        $retval .= "<td>" . $this->selectLanguage($rowid, $selectorInfo['ACTIVE']['flag'] == "ML") . "</td>";
420
+        $retval .= "<td>".$this->selectLanguage($rowid, $selectorInfo['ACTIVE']['flag'] == "ML")."</td>";
421 421
         // third column: the actual input fields; the data type of the active option is visible, all others hidden
422
-        $retval .= "<td>" . $this->inputFields($rowid, $selectorInfo['ACTIVE']) . "</td>";
422
+        $retval .= "<td>".$this->inputFields($rowid, $selectorInfo['ACTIVE'])."</td>";
423 423
         return $retval;
424 424
     }
425 425
 
@@ -443,20 +443,20 @@  discard block
 block discarded – undo
443 443
         $retval .= "<td>";
444 444
         $uiElements = new UIElements();
445 445
         $listtype = $optioninfo->optionType($optionName);
446
-        $retval .= "<span style='display:flex;'>" . $uiElements->displayName($optionName);
447
-        $retval .= $this->tooltip($rowid, $optionName, TRUE) . "</span>";
448
-        $retval .= "<input type='hidden' id='option-S$rowid-select' name='option[S$rowid]' value='$optionName#" . $listtype["type"] . "#" . $listtype["flag"] . "#' ></td>";
446
+        $retval .= "<span style='display:flex;'>".$uiElements->displayName($optionName);
447
+        $retval .= $this->tooltip($rowid, $optionName, TRUE)."</span>";
448
+        $retval .= "<input type='hidden' id='option-S$rowid-select' name='option[S$rowid]' value='$optionName#".$listtype["type"]."#".$listtype["flag"]."#' ></td>";
449 449
 
450 450
         // language tag if any
451 451
         $retval .= "<td>";
452 452
         if ($listtype["flag"] == "ML") {
453 453
 
454
-            $language = "(" . strtoupper($optionLang) . ")";
454
+            $language = "(".strtoupper($optionLang).")";
455 455
             if ($optionLang == 'C') {
456 456
                 $language = _("(default/other languages)");
457 457
             }
458 458
             $retval .= $language;
459
-            $retval .= "<input type='hidden' name='value[S$rowid-lang]' id='S" . $rowid . "-input-langselect' value='" . $optionLang . "' style='display:block'>";
459
+            $retval .= "<input type='hidden' name='value[S$rowid-lang]' id='S".$rowid."-input-langselect' value='".$optionLang."' style='display:block'>";
460 460
         }
461 461
         $retval .= "</td>";
462 462
 // attribute content
@@ -466,12 +466,12 @@  discard block
 block discarded – undo
466 466
             case \core\Options::TYPECODE_COORDINATES:
467 467
                 $this->allLocationCount = $this->allLocationCount + 1;
468 468
                 // display of the locations varies by map provider
469
-                $classname = "\web\lib\admin\Map" . \config\ConfAssistant::MAPPROVIDER['PROVIDER'];
469
+                $classname = "\web\lib\admin\Map".\config\ConfAssistant::MAPPROVIDER['PROVIDER'];
470 470
                 $link = $classname::optionListDisplayCode($optionValue, $this->allLocationCount);
471
-                $retval .= "<input readonly style='display:none' type='text' name='value[S$rowid-" . \core\Options::TYPECODE_TEXT . "]' id='S$rowid-input-text' value='$optionValue'>$link";
471
+                $retval .= "<input readonly style='display:none' type='text' name='value[S$rowid-".\core\Options::TYPECODE_TEXT."]' id='S$rowid-input-text' value='$optionValue'>$link";
472 472
                 break;
473 473
             case \core\Options::TYPECODE_FILE:
474
-                $retval .= "<input readonly type='text' name='value[S$rowid-" . \core\Options::TYPECODE_STRING . "]' id='S" . $rowid . "-input-string' style='display:none' value='" . urlencode($optionValue) . "'>";
474
+                $retval .= "<input readonly type='text' name='value[S$rowid-".\core\Options::TYPECODE_STRING."]' id='S".$rowid."-input-string' style='display:none' value='".urlencode($optionValue)."'>";
475 475
                 $uiElements = new UIElements();
476 476
                 switch ($optionName) {
477 477
                     case "eap:ca_file":
@@ -493,7 +493,7 @@  discard block
 block discarded – undo
493 493
                 break;
494 494
             case \core\Options::TYPECODE_ENUM_OPENROAMING: // is a string after all
495 495
                 $displayedVariant = $this->enumPrettyPrints[$optionValue];
496
-                $retval .= "<strong>$displayedVariant</strong><input type='hidden' name='value[S$rowid-" . $listtype['type'] . "]' id='S" . $rowid . "-input-" . $listtype["type"] . "' value=\"" . htmlspecialchars($optionValue) . "\" style='display:block'>";
496
+                $retval .= "<strong>$displayedVariant</strong><input type='hidden' name='value[S$rowid-".$listtype['type']."]' id='S".$rowid."-input-".$listtype["type"]."' value=\"".htmlspecialchars($optionValue)."\" style='display:block'>";
497 497
                 break;
498 498
             case \core\Options::TYPECODE_STRING:
499 499
             // fall-thorugh is intentional; mostly identical HTML code for the three types
@@ -501,11 +501,11 @@  discard block
 block discarded – undo
501 501
             // fall-thorugh is intentional; mostly identical HTML code for the three types
502 502
             case \core\Options::TYPECODE_TEXT:
503 503
                 $displayedVariant = $optionValue; // for all three types, value tag and actual display are identical
504
-                $retval .= "<strong>$displayedVariant</strong><input type='hidden' name='value[S$rowid-" . $listtype['type'] . "]' id='S" . $rowid . "-input-" . $listtype["type"] . "' value=\"" . htmlspecialchars($optionValue) . "\" style='display:block'>";
504
+                $retval .= "<strong>$displayedVariant</strong><input type='hidden' name='value[S$rowid-".$listtype['type']."]' id='S".$rowid."-input-".$listtype["type"]."' value=\"".htmlspecialchars($optionValue)."\" style='display:block'>";
505 505
                 break;
506 506
             case \core\Options::TYPECODE_BOOLEAN:
507 507
                 $displayedVariant = ($optionValue == "on" ? _("on") : _("off"));
508
-                $retval .= "<strong>$displayedVariant</strong><input type='hidden' name='value[S$rowid-" . $listtype['type'] . "]' id='S" . $rowid . "-input-" . $listtype["type"] . "' value=\"" . htmlspecialchars($optionValue) . "\" style='display:block'>";
508
+                $retval .= "<strong>$displayedVariant</strong><input type='hidden' name='value[S$rowid-".$listtype['type']."]' id='S".$rowid."-input-".$listtype["type"]."' value=\"".htmlspecialchars($optionValue)."\" style='display:block'>";
509 509
                 break;
510 510
             default:
511 511
                 // this should never happen!
@@ -551,10 +551,10 @@  discard block
 block discarded – undo
551 551
        <td>
552 552
           <button type='button' class='delete' onclick='";
553 553
         if ($prefillValue !== NULL && $item == "general:geo_coordinates") {
554
-            $funcname = "Map" . \config\ConfAssistant::MAPPROVIDER['PROVIDER'] . 'DeleteCoord';
555
-            $retval .= 'if (typeof ' . $funcname . ' === "function") { ' . $funcname . '(' . $this->allLocationCount . '); } ';
554
+            $funcname = "Map".\config\ConfAssistant::MAPPROVIDER['PROVIDER'].'DeleteCoord';
555
+            $retval .= 'if (typeof '.$funcname.' === "function") { '.$funcname.'('.$this->allLocationCount.'); } ';
556 556
         }
557
-        $retval .= 'deleteOption("option-S' . $rowid . '")';
557
+        $retval .= 'deleteOption("option-S'.$rowid.'")';
558 558
         $retval .= "'>-</button>
559 559
        </td>
560 560
     </tr>";
Please login to merge, or discard this patch.
devices/Devices-template.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -437,7 +437,7 @@  discard block
 block discarded – undo
437 437
                     ],
438 438
                     'message' => sprintf(_("Before you proceed with installation on Android systems, please make sure that you have installed the %s application. This application is available from these sites: %s and will use the configuration file downloaded from CAT to create all necessary settings."),
439 439
                             "geteduroam",
440
-                            "<a target='_blank' href='https://play.google.com/store/apps/details?id=app.eduroam.geteduroam'>Google Play</a>, <a target='_blank' href='geteduroam-stable.apk'>" . _("as local download") . "</a>"),
440
+                            "<a target='_blank' href='https://play.google.com/store/apps/details?id=app.eduroam.geteduroam'>Google Play</a>, <a target='_blank' href='geteduroam-stable.apk'>"._("as local download")."</a>"),
441 441
  
442 442
                     'geteduroam_text' =>  sprintf(_("Use our app, it will guide you through the setup process:%s"
443 443
                             ."(or download it manually %s.)<p>"
@@ -465,7 +465,7 @@  discard block
 block discarded – undo
465 465
                     'mime' => 'application/eap-config',
466 466
                     'message' => sprintf(_("Before you proceed with installation on Android systems, please make sure that you have installed the %s application. This application is available from these sites: %s and will use the configuration file downloaded from CAT to create all necessary settings."),
467 467
                             "geteduroam",
468
-                            "<a target='_blank' href='https://play.google.com/store/apps/details?id=app.eduroam.geteduroam'>Google Play</a>, <a target='_blank' href='geteduroam-stable.apk'>" . _("as local download") . "</a>"),
468
+                            "<a target='_blank' href='https://play.google.com/store/apps/details?id=app.eduroam.geteduroam'>Google Play</a>, <a target='_blank' href='geteduroam-stable.apk'>"._("as local download")."</a>"),
469 469
                 ],
470 470
             ],              
471 471
 
@@ -482,7 +482,7 @@  discard block
 block discarded – undo
482 482
                     ],
483 483
                     'message' => sprintf(_("Before you proceed with installation on Android systems, please make sure that you have installed the %s application. This application is available from these sites: %s and will use the configuration file downloaded from CAT to create all necessary settings."),
484 484
                             "eduroamCAT",
485
-                            "<a target='_blank' href='https://play.google.com/store/apps/details?id=uk.ac.swansea.eduroamcat'>Google Play</a>, <a target='_blank' href='https://www.amazon.com/dp/B01EACCX0S/'>Amazon Appstore</a>, <a target='_blank' href='eduroamCAT-stable.apk'>" . _("as local download") . "</a>"),
485
+                            "<a target='_blank' href='https://play.google.com/store/apps/details?id=uk.ac.swansea.eduroamcat'>Google Play</a>, <a target='_blank' href='https://www.amazon.com/dp/B01EACCX0S/'>Amazon Appstore</a>, <a target='_blank' href='eduroamCAT-stable.apk'>"._("as local download")."</a>"),
486 486
                     'geteduroam_text' => sprintf(_("Use our app, it will guide you through the setup process:%s"
487 487
                             ."(or download it manually %s.)<p>"
488 488
                         . "After installation, open the app, select your home institution and the app will collect required information "
@@ -509,7 +509,7 @@  discard block
 block discarded – undo
509 509
                     'mime' => 'application/eap-config',
510 510
                     'message' => sprintf(_("Before you proceed with installation on Android systems, please make sure that you have installed the %s application. This application is available from these sites: %s and will use the configuration file downloaded from CAT to create all necessary settings."),
511 511
                             "eduroamCAT",
512
-                            "<a target='_blank' href='https://play.google.com/store/apps/details?id=uk.ac.swansea.eduroamcat'>Google Play</a>, <a target='_blank' href='https://www.amazon.com/dp/B01EACCX0S/'>Amazon Appstore</a>, <a target='_blank' href='eduroamCAT-stable.apk'>" . _("as local download") . "</a>"),
512
+                            "<a target='_blank' href='https://play.google.com/store/apps/details?id=uk.ac.swansea.eduroamcat'>Google Play</a>, <a target='_blank' href='https://www.amazon.com/dp/B01EACCX0S/'>Amazon Appstore</a>, <a target='_blank' href='eduroamCAT-stable.apk'>"._("as local download")."</a>"),
513 513
                 ],
514 514
             ],
515 515
             'android_pie' => [
@@ -523,7 +523,7 @@  discard block
 block discarded – undo
523 523
                     'mime' => 'application/eap-config',
524 524
                     'message' => sprintf(_("Before you proceed with installation on Android systems, please make sure that you have installed the %s application. This application is available from these sites: %s and will use the configuration file downloaded from CAT to create all necessary settings."),
525 525
                             "eduroamCAT",
526
-                            "<a target='_blank' href='https://play.google.com/store/apps/details?id=uk.ac.swansea.eduroamcat'>Google Play</a>, <a target='_blank' href='https://www.amazon.com/dp/B01EACCX0S/'>Amazon Appstore</a>, <a target='_blank' href='eduroamCAT-stable.apk'>" . _("as local download") . "</a>"),
526
+                            "<a target='_blank' href='https://play.google.com/store/apps/details?id=uk.ac.swansea.eduroamcat'>Google Play</a>, <a target='_blank' href='https://www.amazon.com/dp/B01EACCX0S/'>Amazon Appstore</a>, <a target='_blank' href='eduroamCAT-stable.apk'>"._("as local download")."</a>"),
527 527
                 ],
528 528
             ],
529 529
             'android_oreo' => [
@@ -537,7 +537,7 @@  discard block
 block discarded – undo
537 537
                     'mime' => 'application/eap-config',
538 538
                     'message' => sprintf(_("Before you proceed with installation on Android systems, please make sure that you have installed the %s application. This application is available from these sites: %s and will use the configuration file downloaded from CAT to create all necessary settings."),
539 539
                             "eduroamCAT",
540
-                            "<a target='_blank' href='https://play.google.com/store/apps/details?id=uk.ac.swansea.eduroamcat'>Google Play</a>, <a target='_blank' href='https://www.amazon.com/dp/B01EACCX0S/'>Amazon Appstore</a>, <a target='_blank' href='eduroamCAT-stable.apk'>" . _("as local download") . "</a>"),
540
+                            "<a target='_blank' href='https://play.google.com/store/apps/details?id=uk.ac.swansea.eduroamcat'>Google Play</a>, <a target='_blank' href='https://www.amazon.com/dp/B01EACCX0S/'>Amazon Appstore</a>, <a target='_blank' href='eduroamCAT-stable.apk'>"._("as local download")."</a>"),
541 541
                 ],
542 542
             ],
543 543
             'android_nougat' => [
@@ -551,7 +551,7 @@  discard block
 block discarded – undo
551 551
                     'mime' => 'application/eap-config',
552 552
                     'message' => sprintf(_("Before you proceed with installation on Android systems, please make sure that you have installed the %s application. This application is available from these sites: %s and will use the configuration file downloaded from CAT to create all necessary settings."),
553 553
                             "eduroamCAT",
554
-                            "<a target='_blank' href='https://play.google.com/store/apps/details?id=uk.ac.swansea.eduroamcat'>Google Play</a>, <a target='_blank' href='https://www.amazon.com/dp/B01EACCX0S/'>Amazon Appstore</a>, <a target='_blank' href='eduroamCAT-stable.apk'>" . _("as local download") . "</a>"),
554
+                            "<a target='_blank' href='https://play.google.com/store/apps/details?id=uk.ac.swansea.eduroamcat'>Google Play</a>, <a target='_blank' href='https://www.amazon.com/dp/B01EACCX0S/'>Amazon Appstore</a>, <a target='_blank' href='eduroamCAT-stable.apk'>"._("as local download")."</a>"),
555 555
                 ],
556 556
             ],
557 557
             'android_marshmallow' => [
@@ -565,7 +565,7 @@  discard block
 block discarded – undo
565 565
                     'mime' => 'application/eap-config',
566 566
                     'message' => sprintf(_("Before you proceed with installation on Android systems, please make sure that you have installed the %s application. This application is available from these sites: %s and will use the configuration file downloaded from CAT to create all necessary settings."),
567 567
                             "eduroamCAT",
568
-                            "<a target='_blank' href='https://play.google.com/store/apps/details?id=uk.ac.swansea.eduroamcat'>Google Play</a>, <a target='_blank' href='https://www.amazon.com/dp/B01EACCX0S/'>Amazon Appstore</a>, <a target='_blank' href='eduroamCAT-stable.apk'>" . _("as local download") . "</a>"),
568
+                            "<a target='_blank' href='https://play.google.com/store/apps/details?id=uk.ac.swansea.eduroamcat'>Google Play</a>, <a target='_blank' href='https://www.amazon.com/dp/B01EACCX0S/'>Amazon Appstore</a>, <a target='_blank' href='eduroamCAT-stable.apk'>"._("as local download")."</a>"),
569 569
                 ],
570 570
             ],
571 571
             'android_lollipop' => [
@@ -579,7 +579,7 @@  discard block
 block discarded – undo
579 579
                     'mime' => 'application/eap-config',
580 580
                     'message' => sprintf(_("Before you proceed with installation on Android systems, please make sure that you have installed the %s application. This application is available from these sites: %s and will use the configuration file downloaded from CAT to create all necessary settings."),
581 581
                             "eduroamCAT",
582
-                            "<a target='_blank' href='https://play.google.com/store/apps/details?id=uk.ac.swansea.eduroamcat'>Google Play</a>, <a target='_blank' href='https://www.amazon.com/dp/B01EACCX0S/'>Amazon Appstore</a>, <a target='_blank' href='eduroamCAT-stable.apk'>" . _("as local download") . "</a>"),
582
+                            "<a target='_blank' href='https://play.google.com/store/apps/details?id=uk.ac.swansea.eduroamcat'>Google Play</a>, <a target='_blank' href='https://www.amazon.com/dp/B01EACCX0S/'>Amazon Appstore</a>, <a target='_blank' href='eduroamCAT-stable.apk'>"._("as local download")."</a>"),
583 583
                 ],
584 584
             ],
585 585
             'android_kitkat' => [
@@ -593,7 +593,7 @@  discard block
 block discarded – undo
593 593
                     'mime' => 'application/eap-config',
594 594
                     'message' => sprintf(_("Before you proceed with installation on Android systems, please make sure that you have installed the %s application. This application is available from these sites: %s and will use the configuration file downloaded from CAT to create all necessary settings."),
595 595
                             "eduroamCAT",
596
-                            "<a target='_blank' href='https://play.google.com/store/apps/details?id=uk.ac.swansea.eduroamcat'>Google Play</a>, <a target='_blank' href='https://www.amazon.com/dp/B01EACCX0S/'>Amazon Appstore</a>, <a target='_blank' href='eduroamCAT-stable.apk'>" . _("as local download") . "</a>"),
596
+                            "<a target='_blank' href='https://play.google.com/store/apps/details?id=uk.ac.swansea.eduroamcat'>Google Play</a>, <a target='_blank' href='https://www.amazon.com/dp/B01EACCX0S/'>Amazon Appstore</a>, <a target='_blank' href='eduroamCAT-stable.apk'>"._("as local download")."</a>"),
597 597
                 ],
598 598
             ],
599 599
             'android_43' => [
@@ -607,7 +607,7 @@  discard block
 block discarded – undo
607 607
                     'mime' => 'application/eap-config',
608 608
                     'message' => sprintf(_("Before you proceed with installation on Android systems, please make sure that you have installed the %s application. This application is available from these sites: %s and will use the configuration file downloaded from CAT to create all necessary settings."),
609 609
                             "eduroamCAT",
610
-                            "<a target='_blank' href='https://play.google.com/store/apps/details?id=uk.ac.swansea.eduroamcat'>Google Play</a>, <a target='_blank' href='https://www.amazon.com/dp/B01EACCX0S/'>Amazon Appstore</a>, <a target='_blank' href='eduroamCAT-stable.apk'>" . _("as local download") . "</a>"),
610
+                            "<a target='_blank' href='https://play.google.com/store/apps/details?id=uk.ac.swansea.eduroamcat'>Google Play</a>, <a target='_blank' href='https://www.amazon.com/dp/B01EACCX0S/'>Amazon Appstore</a>, <a target='_blank' href='eduroamCAT-stable.apk'>"._("as local download")."</a>"),
611 611
                 ],
612 612
             ],
613 613
 
Please login to merge, or discard this patch.