Passed
Push — master ( 23a6d3...f7b675 )
by Stefan
07:04
created
devices/PP_OSU_XML/DevicePPOSUXML.php 2 patches
Indentation   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -82,10 +82,10 @@  discard block
 block discarded – undo
82 82
     
83 83
     private function aaaServerTrustRoot() {
84 84
         
85
-      $retval = '<Node>
85
+        $retval = '<Node>
86 86
         <NodeName>AAAServerTrustRoot</NodeName>';
87
-      foreach ($this->attributes['internal:CAs'][0] as $oneCert) {
88
-          $retval .= '<Node>
87
+        foreach ($this->attributes['internal:CAs'][0] as $oneCert) {
88
+            $retval .= '<Node>
89 89
                          <NodeName>'.$oneCert['uuid'].'</NodeName>
90 90
                              <Node>
91 91
                                <NodeName>CertSHA256Fingerprint</NodeName>
@@ -93,9 +93,9 @@  discard block
 block discarded – undo
93 93
                              </Node>
94 94
                        </Node>
95 95
                   ';
96
-      }
97
-      $retval .= '</Node>';
98
-      return $retval;
96
+        }
97
+        $retval .= '</Node>';
98
+        return $retval;
99 99
     }
100 100
     
101 101
     private function credentialCreationDate() {
@@ -181,8 +181,8 @@  discard block
 block discarded – undo
181 181
 
182 182
       $content .= $this->aaaServerTrustRoot();
183 183
          */
184
-      $retval .= $this->homeSP();
185
-      $retval .= $this->credential();
184
+        $retval .= $this->homeSP();
185
+        $retval .= $this->credential();
186 186
       
187 187
     $retval .= '</Node>
188 188
   </Node>
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
         $now = new \DateTime();
103 103
         return '<Node>
104 104
           <NodeName>CreationDate</NodeName>
105
-          <Value>'.$now->format("Y-m-d") . "T" . $now->format("H:i:s") . "Z".'</Value>
105
+          <Value>'.$now->format("Y-m-d")."T".$now->format("H:i:s")."Z".'</Value>
106 106
         </Node>';
107 107
     }
108 108
     
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
         <NodeName>HomeSP</NodeName>
112 112
         <Node>
113 113
           <NodeName>FriendlyName</NodeName>
114
-          <Value>'.sprintf(_("%s via Passpoint"),\config\ConfAssistant::CONSORTIUM['display_name']).'</Value>
114
+          <Value>'.sprintf(_("%s via Passpoint"), \config\ConfAssistant::CONSORTIUM['display_name']).'</Value>
115 115
         </Node>
116 116
         <Node>
117 117
           <NodeName>FQDN</NodeName>
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
         foreach (\config\ConfAssistant::CONSORTIUM['interworking-consortium-oi'] as $index => $oneOi) {
126 126
             // according to spec, must be lowercase ASCII without dashes
127 127
             // but sample I got was all uppercase, so let's try with that
128
-            $oiList .= str_replace("-","",trim(strtoupper($oneOi)));
128
+            $oiList .= str_replace("-", "", trim(strtoupper($oneOi)));
129 129
             if ($index < $numberOfOi - 1) {
130 130
                 // according to spec, comma-separated
131 131
                 $oiList .= ",";
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
 Content-Type: application/x-pkcs12
224 224
 Content-Transfer-Encoding: base64
225 225
 
226
-'.chunk_split(base64_encode($this->clientCert['certdataclear']), 76, "\n"). // is PKCS#12, with cleartext key
226
+'.chunk_split(base64_encode($this->clientCert['certdataclear']), 76, "\n").// is PKCS#12, with cleartext key
227 227
 '--{boundary}';
228 228
 
229 229
         // trail this with a double slash and a newline
@@ -243,7 +243,7 @@  discard block
 block discarded – undo
243 243
         // foresee signing.
244 244
         // but if they ever change their mind, we are prepared
245 245
 
246
-        $outputFromSigning = system($this->sign . " installer_profile '$fileName' > /dev/null");
246
+        $outputFromSigning = system($this->sign." installer_profile '$fileName' > /dev/null");
247 247
         if ($outputFromSigning === FALSE) {
248 248
             $this->loggerInstance->debug(2, "Signing the ONC installer $fileName FAILED!\n");
249 249
         }
Please login to merge, or discard this patch.