Passed
Push — release_2_0 ( c69210...fd7f30 )
by Stefan
13:03 queued 10s
created
web/admin/edit_silverbullet.php 1 patch
Spacing   +72 added lines, -72 removed lines patch added patch discarded remove patch
@@ -20,8 +20,8 @@  discard block
 block discarded – undo
20 20
 /*
21 21
  * Class autoloader invocation, should be included prior to any other code at the entry points to the application
22 22
  */
23
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
24
-require_once dirname(dirname(dirname(__FILE__))) . "/core/phpqrcode.php";
23
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
24
+require_once dirname(dirname(dirname(__FILE__)))."/core/phpqrcode.php";
25 25
 const QRCODE_PIXELS_PER_SYMBOL = 12;
26 26
 
27 27
 $auth = new \web\lib\admin\Authentication();
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
     $fed = new \core\Federation($inst->federation);
56 56
     $allowSb = $fed->getAttributes("fed:silverbullet");
57 57
     if (count($allowSb) == 0) {
58
-        throw new Exception("We were told to create a new SB profile, but this " . CONFIG_CONFASSISTANT['CONSORTIUM']['nomenclature_federation'] . " does not allow SB at all!");
58
+        throw new Exception("We were told to create a new SB profile, but this ".CONFIG_CONFASSISTANT['CONSORTIUM']['nomenclature_federation']." does not allow SB at all!");
59 59
     }
60 60
     // okay, new SB profiles are allowed. 
61 61
     // but is there a support:email attribute on inst level?
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
     // Create one.
67 67
     $newProfile = $inst->newProfile(core\AbstractProfile::PROFILETYPE_SILVERBULLET);
68 68
     // and modify the REQUEST_URI to add the new profile ID
69
-    $_SERVER['REQUEST_URI'] = $_SERVER['REQUEST_URI'] . "&profile_id=" . $newProfile->identifier;
69
+    $_SERVER['REQUEST_URI'] = $_SERVER['REQUEST_URI']."&profile_id=".$newProfile->identifier;
70 70
     $_GET['profile_id'] = $newProfile->identifier;
71 71
     $profile = $newProfile;
72 72
 } else {
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
 if (isset($_POST['command'])) {
92 92
     switch ($_POST['command']) {
93 93
         case \web\lib\common\FormElements::BUTTON_CLOSE:
94
-            header("Location: overview_idp.php?inst_id=" . $inst->identifier);
94
+            header("Location: overview_idp.php?inst_id=".$inst->identifier);
95 95
             break;
96 96
         case \web\lib\common\FormElements::BUTTON_TERMSOFUSE:
97 97
             if (isset($_POST['agreement']) && $_POST['agreement'] == 'true') {
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
                         break;
135 135
                     }
136 136
                     $properName = $validator->User($elements[0]);
137
-                    $properDate = new DateTime($elements[1] . " 00:00:00");
137
+                    $properDate = new DateTime($elements[1]." 00:00:00");
138 138
                     $numberOfActivations = $elements[2] ?? 1;
139 139
                     $number = $validator->integer($numberOfActivations);
140 140
                     if ($number === FALSE) { // invalid input received, default to sane
@@ -227,18 +227,18 @@  discard block
 block discarded – undo
227 227
                     // warn and ask for confirmation unless already confirmed
228 228
                     if (!isset($_POST['insecureconfirm']) || $_POST['insecureconfirm'] != "CONFIRM") {
229 229
                         echo $deco->pageheader(_("Insecure mail domain!"), "ADMIN-IDP-USERS");
230
-                        echo "<p>" . sprintf(_("The mail domain of the mail address <strong>%s</strong> is not secure: some or all of the mail servers are not accepting encrypted connections (no consistent support for STARTTLS)."), $properEmail) . "</p>";
231
-                        echo "<p>" . _("The invitation would need to be sent in cleartext across the internet, and can possibly be read and abused by anyone in transit.") . "</p>";
232
-                        echo "<p>" . _("Do you want the system to send this mail anyway?") . "</p>";
230
+                        echo "<p>".sprintf(_("The mail domain of the mail address <strong>%s</strong> is not secure: some or all of the mail servers are not accepting encrypted connections (no consistent support for STARTTLS)."), $properEmail)."</p>";
231
+                        echo "<p>"._("The invitation would need to be sent in cleartext across the internet, and can possibly be read and abused by anyone in transit.")."</p>";
232
+                        echo "<p>"._("Do you want the system to send this mail anyway?")."</p>";
233 233
                         echo $formtext;
234
-                        echo "<button type='submit' class='delete'>" . _("DO NOT SEND") . "</button>";
234
+                        echo "<button type='submit' class='delete'>"._("DO NOT SEND")."</button>";
235 235
                         echo "</form>";
236 236
                         echo $formtext;
237
-                        echo "<input type='hidden' name='command' value='" . \web\lib\common\FormElements::BUTTON_SENDINVITATIONMAILBYCAT . "'</>";
237
+                        echo "<input type='hidden' name='command' value='".\web\lib\common\FormElements::BUTTON_SENDINVITATIONMAILBYCAT."'</>";
238 238
                         echo "<input type='hidden' name='address' value='$properEmail'</>";
239
-                        echo "<input type='hidden' name='token' value='" . $invitationObject->invitationTokenString . "'</>";
239
+                        echo "<input type='hidden' name='token' value='".$invitationObject->invitationTokenString."'</>";
240 240
                         echo "<input type='hidden' name='insecureconfirm' value='CONFIRM'/>";
241
-                        echo "<button type='submit'>" . _("Send anyway.") . "</button>";
241
+                        echo "<button type='submit'>"._("Send anyway.")."</button>";
242 242
                         echo "</form>";
243 243
                         echo $deco->footer();
244 244
                         exit;
@@ -348,19 +348,19 @@  discard block
 block discarded – undo
348 348
         case "NOSTIPULATION":
349 349
             break;
350 350
         case "EMAIL-SENT":
351
-            echo $boundaryPre . $uiElements->boxOkay(_("The e-mail was sent successfully."), _("E-mail OK."), FALSE) . $boundaryPost;
351
+            echo $boundaryPre.$uiElements->boxOkay(_("The e-mail was sent successfully."), _("E-mail OK."), FALSE).$boundaryPost;
352 352
             break;
353 353
         case "EMAIL-NOTSENT":
354
-            echo $boundaryPre . $uiElements->boxError(_("The e-mail was NOT sent."), _("E-mail not OK."), FALSE) . $boundaryPost;
354
+            echo $boundaryPre.$uiElements->boxError(_("The e-mail was NOT sent."), _("E-mail not OK."), FALSE).$boundaryPost;
355 355
             break;
356 356
         case "SMS-SENT":
357
-            echo $boundaryPre . $uiElements->boxOkay(_("The SMS was sent successfully."), _("SMS OK."), FALSE) . $boundaryPost;
357
+            echo $boundaryPre.$uiElements->boxOkay(_("The SMS was sent successfully."), _("SMS OK."), FALSE).$boundaryPost;
358 358
             break;
359 359
         case "SMS-NOTSENT":
360
-            echo $boundaryPre . $uiElements->boxOkay(_("The SMS was NOT sent."), _("SMS not OK."), FALSE) . $boundaryPost;
360
+            echo $boundaryPre.$uiElements->boxOkay(_("The SMS was NOT sent."), _("SMS not OK."), FALSE).$boundaryPost;
361 361
             break;
362 362
         case "SMS-FRAGMENT":
363
-            echo $boundaryPre . $uiElements->boxWarning(_("Only a fragment of the SMS was sent. You should re-send it."), _("SMS Fragment."), FALSE) . $boundaryPost;
363
+            echo $boundaryPre.$uiElements->boxWarning(_("Only a fragment of the SMS was sent. You should re-send it."), _("SMS Fragment."), FALSE).$boundaryPost;
364 364
             break;
365 365
     }
366 366
     ?>
@@ -373,24 +373,24 @@  discard block
 block discarded – undo
373 373
             <?php
374 374
             $bufferCurrentUsers = "<table class='sb-user-table' style='max-width:1920px;'>
375 375
                 <tr class='sb-title-row'>
376
-                    <td>" . _("User") . "</td>
377
-                    <td>" . _("Token/Certificate details") . "</td>
378
-                    <td>" . _("User/Token Expiry") . "</td>
379
-                    <td>" . _("Actions") . "</td>
376
+                    <td>" . _("User")."</td>
377
+                    <td>" . _("Token/Certificate details")."</td>
378
+                    <td>" . _("User/Token Expiry")."</td>
379
+                    <td>" . _("Actions")."</td>
380 380
                 </tr>";
381 381
             $bufferPreviousUsers = "<table class='sb-user-table' style='max-width:1920px;'>
382 382
                 <tr class='sb-title-row'>
383
-                    <td>" . _("User") . "</td>
384
-                    <td>" . _("Certificate details") . "</td>
385
-                    <td>" . _("User Expiry") . "</td>
386
-                    <td>" . _("Actions") . "</td>
383
+                    <td>" . _("User")."</td>
384
+                    <td>" . _("Certificate details")."</td>
385
+                    <td>" . _("User Expiry")."</td>
386
+                    <td>" . _("Actions")."</td>
387 387
                 </tr>";
388 388
 
389 389
             natsort($allUsers);
390 390
             $internalUserCount = 0;
391 391
             foreach ($allUsers as $oneUserId => $oneUserName) {
392 392
                 $expiryDate = $profile->getUserExpiryDate($oneUserId);
393
-                if (isset($activeUsers[$oneUserId]) || (new DateTime() < new DateTime($expiryDate)) ) {
393
+                if (isset($activeUsers[$oneUserId]) || (new DateTime() < new DateTime($expiryDate))) {
394 394
                     $outputBuffer = "bufferCurrentUsers";
395 395
                 } else {
396 396
                     $outputBuffer = "bufferPreviousUsers";
@@ -439,23 +439,23 @@  discard block
 block discarded – undo
439 439
                     $display = empty(devices\Devices::listDevices()[$oneCert->device]['display']) ? $oneCert->device : devices\Devices::listDevices()[$oneCert->device]['display'];
440 440
 
441 441
                     $bufferText = "<div class='sb-certificate-summary ca-summary' $style>
442
-                                    <div class='sb-certificate-details'>" . _("Device:") . " " . $display .
443
-                            "<br>" . _("Serial Number:") . "&nbsp;" . dechex($oneCert->serial) .
444
-                            "<br>" . _("CN:") . "&nbsp;" . explode('@', $oneCert->username)[0] . "@…" .
445
-                            "<br>" . _("Expiry:") . "&nbsp;" . $oneCert->expiry .
446
-                            "<br>" . _("Issued:") . "&nbsp;" . $oneCert->issued .
447
-                            "</div>" .
442
+                                    <div class='sb-certificate-details'>"._("Device:")." ".$display.
443
+                            "<br>"._("Serial Number:")."&nbsp;".dechex($oneCert->serial).
444
+                            "<br>"._("CN:")."&nbsp;".explode('@', $oneCert->username)[0]."@…".
445
+                            "<br>"._("Expiry:")."&nbsp;".$oneCert->expiry.
446
+                            "<br>"._("Issued:")."&nbsp;".$oneCert->issued.
447
+                            "</div>".
448 448
                             "<div style='text-align:right;padding-top: 5px; $buttonStyle'>";
449 449
 
450 450
                     if ($buttonText == "") {
451 451
                         $bufferText .= $formtext
452
-                                . "<input type='hidden' name='certSerial' value='" . $oneCert->serial . "'/>"
453
-                                . "<input type='hidden' name='certAlgo' value='" . $oneCert->ca_type . "'/>"
452
+                                . "<input type='hidden' name='certSerial' value='".$oneCert->serial."'/>"
453
+                                . "<input type='hidden' name='certAlgo' value='".$oneCert->ca_type."'/>"
454 454
                                 . "<button type='submit' "
455 455
                                 . "name='command' "
456
-                                . "value='" . \web\lib\common\FormElements::BUTTON_REVOKECREDENTIAL . "' "
456
+                                . "value='".\web\lib\common\FormElements::BUTTON_REVOKECREDENTIAL."' "
457 457
                                 . "class='delete' "
458
-                                . "onclick='return confirm(\"" . sprintf(_("The device in question will stop functioning with %s. The revocation cannot be undone. Are you sure you want to do this?"), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']) . "\")'>"
458
+                                . "onclick='return confirm(\"".sprintf(_("The device in question will stop functioning with %s. The revocation cannot be undone. Are you sure you want to do this?"), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'])."\")'>"
459 459
                                 . _("Revoke")
460 460
                                 . "</button>"
461 461
                                 . "</form>";
@@ -480,13 +480,13 @@  discard block
 block discarded – undo
480 480
                 }
481 481
                 // wrap the revoked and expired certs in a div that is hidden by default
482 482
                 if ($textRevokedCerts !== "") {
483
-                    $textRevokedCerts = "<span style='text-decoration: underline;' id='$oneUserId-revoked-heading' onclick='document.getElementById(\"$oneUserId-revoked-certs\").style.display = \"block\"; document.getElementById(\"$oneUserId-revoked-heading\").style.display = \"none\";'>" . sprintf(ngettext("(show %d revoked certificate)", "(show %d revoked certificates)", $countRevoked), $countRevoked) . "</span><div id='$oneUserId-revoked-certs' style='display:none;'>" . $textRevokedCerts . "</div>";
483
+                    $textRevokedCerts = "<span style='text-decoration: underline;' id='$oneUserId-revoked-heading' onclick='document.getElementById(\"$oneUserId-revoked-certs\").style.display = \"block\"; document.getElementById(\"$oneUserId-revoked-heading\").style.display = \"none\";'>".sprintf(ngettext("(show %d revoked certificate)", "(show %d revoked certificates)", $countRevoked), $countRevoked)."</span><div id='$oneUserId-revoked-certs' style='display:none;'>".$textRevokedCerts."</div>";
484 484
                 }
485 485
                 if ($textExpiredCerts !== "") {
486
-                    $textExpiredCerts = "<span style='text-decoration: underline;' id='$oneUserId-expired-heading' onclick='document.getElementById(\"$oneUserId-expired-certs\").style.display = \"block\"; document.getElementById(\"$oneUserId-expired-heading\").style.display = \"none\";'>" . sprintf(ngettext("(show %d expired certificate)", "(show %d expired certificates)", $countExpired), $countExpired) . "</span><div id='$oneUserId-expired-certs' style='display:none;'>" . $textExpiredCerts . "</div>";
486
+                    $textExpiredCerts = "<span style='text-decoration: underline;' id='$oneUserId-expired-heading' onclick='document.getElementById(\"$oneUserId-expired-certs\").style.display = \"block\"; document.getElementById(\"$oneUserId-expired-heading\").style.display = \"none\";'>".sprintf(ngettext("(show %d expired certificate)", "(show %d expired certificates)", $countExpired), $countExpired)."</span><div id='$oneUserId-expired-certs' style='display:none;'>".$textExpiredCerts."</div>";
487 487
                 }
488 488
                 // and push out the HTML
489
-                ${$outputBuffer} .= $textActiveCerts . "<br/>" . $textExpiredCerts . " " . $textRevokedCerts . "</td>";
489
+                ${$outputBuffer} .= $textActiveCerts."<br/>".$textExpiredCerts." ".$textRevokedCerts."</td>";
490 490
                 $tokenHtmlBuffer = "";
491 491
                 $hasOnePendingInvite = FALSE;
492 492
                 foreach ($tokensWithoutCerts as $invitationObject) {
@@ -497,38 +497,38 @@  discard block
 block discarded – undo
497 497
                             $tokenHtmlBuffer .= "<tr class='sb-certificate-row'><td></td>";
498 498
                             $jsEncodedBody = str_replace('\n', '%0D%0A', str_replace('"', '', json_encode($invitationObject->invitationMailBody())));
499 499
                             $tokenHtmlBuffer .= "<td>";
500
-                            $tokenHtmlBuffer .= sprintf(_("The invitation token %s is ready for sending! Choose how to send it:"), "<input type='text' readonly='readonly' style='background-color:lightgrey;' size='60' value='" . $invitationObject->link() . "' name='token' class='identifiedtokenarea-" . $invitationObject->identifier . "'>(…)<br/>");
500
+                            $tokenHtmlBuffer .= sprintf(_("The invitation token %s is ready for sending! Choose how to send it:"), "<input type='text' readonly='readonly' style='background-color:lightgrey;' size='60' value='".$invitationObject->link()."' name='token' class='identifiedtokenarea-".$invitationObject->identifier."'>(…)<br/>");
501 501
                             $tokenHtmlBuffer .= "<table>
502
-                                    <tr><td style='vertical-align:bottom;'>" . _("E-Mail:") . "</td><td>
502
+                                    <tr><td style='vertical-align:bottom;'>" . _("E-Mail:")."</td><td>
503 503
                                     $formtext
504
-                                <input type='hidden' value='" . $invitationObject->invitationTokenString . "' name='token'><br/>
504
+                                <input type='hidden' value='".$invitationObject->invitationTokenString."' name='token'><br/>
505 505
                                 <input type='text' name='address' id='address-$invitationObject->identifier'/>
506
-                                <button type='button' onclick='window.location=\"mailto:\"+document.getElementById(\"address-$invitationObject->identifier\").value+\"?subject=" . $invitationObject->invitationMailSubject() . "&amp;body=$jsEncodedBody\"; return false;'>" . _("Local mail client") . "</button>
507
-                                <button type='submit' name='command' onclick='document.getElementById(\"spin\").style.display =\"block\"' value='" . \web\lib\common\FormElements::BUTTON_SENDINVITATIONMAILBYCAT . "'>" . _("Send with CAT") . "</button>
506
+                                <button type='button' onclick='window.location=\"mailto:\"+document.getElementById(\"address-$invitationObject->identifier\").value+\"?subject=".$invitationObject->invitationMailSubject()."&amp;body=$jsEncodedBody\"; return false;'>"._("Local mail client")."</button>
507
+                                <button type='submit' name='command' onclick='document.getElementById(\"spin\").style.display =\"block\"' value='" . \web\lib\common\FormElements::BUTTON_SENDINVITATIONMAILBYCAT."'>"._("Send with CAT")."</button>
508 508
                                     </form>
509 509
                                     </td></tr>
510
-                                    <tr><td style='vertical-align:bottom;'>" . _("SMS:") . "</td><td>
510
+                                    <tr><td style='vertical-align:bottom;'>" . _("SMS:")."</td><td>
511 511
                                     $formtext
512
-                                    <input type='hidden' value='" . $invitationObject->invitationTokenString . "' name='token'><br/>
512
+                                    <input type='hidden' value='".$invitationObject->invitationTokenString."' name='token'><br/>
513 513
                                     <input type='text' name='smsnumber' />
514
-				<button type='submit' name='command' value='" . \web\lib\common\FormElements::BUTTON_SENDINVITATIONSMS . "'>" . _("Send in SMS...") . "</button>
514
+				<button type='submit' name='command' value='" . \web\lib\common\FormElements::BUTTON_SENDINVITATIONSMS."'>"._("Send in SMS...")."</button>
515 515
                                     </form>
516 516
 				</td></tr>
517
-                                    <tr><td style='vertical-align:bottom;'>" . _("Manual:") . "</td><td>
518
-				<button type='button' class='clipboardButton' onclick='clipboardCopy(" . $invitationObject->identifier . ");'>" . _("Copy to Clipboard") . "</button>
517
+                                    <tr><td style='vertical-align:bottom;'>" . _("Manual:")."</td><td>
518
+				<button type='button' class='clipboardButton' onclick='clipboardCopy(" . $invitationObject->identifier.");'>"._("Copy to Clipboard")."</button>
519 519
                                     <form style='display:inline-block;' method='post' action='inc/displayQRcode.inc.php' onsubmit='popupQRWindow(this); return false;' accept-charset='UTF-8'>
520
-                                    <input type='hidden' value='" . $invitationObject->invitationTokenString . "' name='token'><br/>
521
-                                      <button type='submit'>" . _("Display QR code") . "</button>
520
+                                    <input type='hidden' value='" . $invitationObject->invitationTokenString."' name='token'><br/>
521
+                                      <button type='submit'>" . _("Display QR code")."</button>
522 522
                                   </form>
523 523
                                         </td></tr>
524 524
                                         
525 525
                                 </table>
526 526
                                 </td>";
527
-                            $tokenHtmlBuffer .= "<td>" . _("Expiry Date:") . " " . $invitationObject->expiry . " UTC<br>" . _("Activations remaining:") . " " . sprintf(_("%d of %d"), $invitationObject->activationsRemaining, $invitationObject->activationsTotal) . "</td>";
527
+                            $tokenHtmlBuffer .= "<td>"._("Expiry Date:")." ".$invitationObject->expiry." UTC<br>"._("Activations remaining:")." ".sprintf(_("%d of %d"), $invitationObject->activationsRemaining, $invitationObject->activationsTotal)."</td>";
528 528
                             $tokenHtmlBuffer .= "<td>"
529 529
                                     . $formtext
530
-                                    . "<input type='hidden' name='invitationtoken' value='" . $invitationObject->invitationTokenString . "'/>"
531
-                                    . "<button type='submit' name='command' value='" . \web\lib\common\FormElements::BUTTON_REVOKEINVITATION . "' class='delete'>" . _("Revoke") . "</button></form>"
530
+                                    . "<input type='hidden' name='invitationtoken' value='".$invitationObject->invitationTokenString."'/>"
531
+                                    . "<button type='submit' name='command' value='".\web\lib\common\FormElements::BUTTON_REVOKEINVITATION."' class='delete'>"._("Revoke")."</button></form>"
532 532
                                     . "</td></tr>";
533 533
                             break;
534 534
                         case core\SilverbulletInvitation::SB_TOKENSTATUS_EXPIRED:
@@ -544,10 +544,10 @@  discard block
 block discarded – undo
544 544
                 }
545 545
                 ${$outputBuffer} .= "<td>$formtext
546 546
                     <div class='sb-date-container' style='min-width: 200px;'>
547
-                        <span><input type='text' maxlength='19' class='sb-date-picker' name='userexpiry' value='" . $profile->getUserExpiryDate($oneUserId) . "'>&nbsp;(UTC)</span>
547
+                        <span><input type='text' maxlength='19' class='sb-date-picker' name='userexpiry' value='".$profile->getUserExpiryDate($oneUserId)."'>&nbsp;(UTC)</span>
548 548
                     </div>
549 549
                     <input type='hidden' name='userid' value='$oneUserId'/>
550
-                    <button type='submit' name='command' value='" . \web\lib\common\FormElements::BUTTON_CHANGEUSEREXPIRY . "'>" . _("Update") . "</button>
550
+                    <button type='submit' name='command' value='".\web\lib\common\FormElements::BUTTON_CHANGEUSEREXPIRY."'>"._("Update")."</button>
551 551
                     </form>
552 552
                 </td>
553 553
                 <td>
@@ -555,26 +555,26 @@  discard block
 block discarded – undo
555 555
 
556 556
                 if ($hasOnePendingInvite || count($validCerts) > 0) {
557 557
                     $deletionText = sprintf(_("All of the currently active devices will stop functioning with %s. This cannot be undone. While the user can be re-activated later, they will then need to be re-provisioned with new invitation tokens. Are you sure you want to do this?"), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']);
558
-                    ${$outputBuffer} .= $formtext . "
558
+                    ${$outputBuffer} .= $formtext."
559 559
                                     <input type='hidden' name='userid' value='$oneUserId'/>
560 560
                                     <button type='submit' "
561 561
                             . "name='command' "
562
-                            . "value='" . \web\lib\common\FormElements::BUTTON_DEACTIVATEUSER . "' "
562
+                            . "value='".\web\lib\common\FormElements::BUTTON_DEACTIVATEUSER."' "
563 563
                             . "class='delete' "
564
-                            . ( count($validCerts) > 0 ? "onclick='return confirm(\"" . $deletionText . "\")' " : "" )
564
+                            . (count($validCerts) > 0 ? "onclick='return confirm(\"".$deletionText."\")' " : "")
565 565
                             . ">"
566 566
                             . _("Deactivate User")
567 567
                             . "</button>
568 568
                                 </form>";
569 569
                 }
570
-                ${$outputBuffer} .= "<form method='post' action='inc/userStats.inc.php?inst_id=" . $profile->institution . "&profile_id=" . $profile->identifier . "&user_id=$oneUserId' onsubmit='popupStatsWindow(this); return false;' accept-charset='UTF-8'>
571
-                    <button type='submit'>" . _("Show Authentication Records") . "</button>
570
+                ${$outputBuffer} .= "<form method='post' action='inc/userStats.inc.php?inst_id=".$profile->institution."&profile_id=".$profile->identifier."&user_id=$oneUserId' onsubmit='popupStatsWindow(this); return false;' accept-charset='UTF-8'>
571
+                    <button type='submit'>"._("Show Authentication Records")."</button>
572 572
                 </form>";
573 573
                 if (new DateTime() < new DateTime($expiryDate)) {
574
-                    ${$outputBuffer} .= $formtext . "
574
+                    ${$outputBuffer} .= $formtext."
575 575
                     <input type='hidden' name='userid' value='$oneUserId'/>
576
-                    <button type='submit' name='command' value='" . \web\lib\common\FormElements::BUTTON_NEWINVITATION . "'>" . _("New Invitation") . "</button>
577
-                    <label>" . _("Activations:") . "
576
+                    <button type='submit' name='command' value='".\web\lib\common\FormElements::BUTTON_NEWINVITATION."'>"._("New Invitation")."</button>
577
+                    <label>" . _("Activations:")."
578 578
                         <input type='text' name='invitationsquantity' value='5' maxlength='3' style='width: 30px;'/>
579 579
                     </label>
580 580
                     </form>";
@@ -589,10 +589,10 @@  discard block
 block discarded – undo
589 589
             $bufferPreviousUsers .= "</table>";
590 590
             ?>
591 591
             <!-- ... ends here -->
592
-            <h2><?php echo _("Current Users");?></h2>
593
-            <?php echo $bufferCurrentUsers;?>
594
-            <h2><?php echo _("Previous Users");?></h2>
595
-            <?php echo $bufferPreviousUsers;?>
592
+            <h2><?php echo _("Current Users"); ?></h2>
593
+            <?php echo $bufferCurrentUsers; ?>
594
+            <h2><?php echo _("Previous Users"); ?></h2>
595
+            <?php echo $bufferPreviousUsers; ?>
596 596
             
597 597
             <div style="padding: 20px;">
598 598
                 <?php
@@ -601,13 +601,13 @@  discard block
 block discarded – undo
601 601
                                     . ' If all accounts shown as active above are indeed still valid, please check the box below and push "Save".'
602 602
                                     . ' If any of the accounts are stale, please deactivate them by pushing the corresponding button before doing this.'), CONFIG_CONFASSISTANT['SILVERBULLET']['gracetime'] ?? core\ProfileSilverbullet::SB_ACKNOWLEDGEMENT_REQUIRED_DAYS);
603 603
 
604
-                    echo $formtext . "<div style='padding-bottom: 20px;'>"
604
+                    echo $formtext."<div style='padding-bottom: 20px;'>"
605 605
                     . "
606 606
                     <p>$acknowledgeText</p>
607 607
                     <input type='checkbox' name='acknowledge' value='true'>
608
-                    <label>" . sprintf(_("I have verified that all configured users are still eligible for %s."), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']) . "</label>
608
+                    <label>".sprintf(_("I have verified that all configured users are still eligible for %s."), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'])."</label>
609 609
                 </div>
610
-                <button type='submit' name='command' value='" . \web\lib\common\FormElements::BUTTON_ACKUSERELIGIBILITY . "'>" . _("Save") . "</button></form>";
610
+                <button type='submit' name='command' value='" . \web\lib\common\FormElements::BUTTON_ACKUSERELIGIBILITY."'>"._("Save")."</button></form>";
611 611
                 }
612 612
                 ?>
613 613
             </div>
Please login to merge, or discard this patch.