Passed
Push — release_2_0 ( ea195d...a7a74b )
by Stefan
07:43
created
web/admin/edit_idp_result.php 1 patch
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
  *          <base_url>/copyright.php after deploying the software
21 21
  */
22 22
 
23
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
23
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
24 24
 
25 25
 $auth = new \web\lib\admin\Authentication();
26 26
 $loggerInstance = new \core\common\Logging();
@@ -38,15 +38,15 @@  discard block
 block discarded – undo
38 38
 $myInstOriginal = $validator->IdP($_GET['inst_id'], $_SESSION['user']);
39 39
 $instId = $myInstOriginal->identifier;
40 40
 
41
-$hello = _("To whom it may concern,") . "\n\n";
42
-$bye = _("This mail is merely a cross-check because these changes can be security-relevant. If the change was expected, you do not need to take any action.") . "\n\n" .
43
-        _("Greetings, ") . "\n\n" .
41
+$hello = _("To whom it may concern,")."\n\n";
42
+$bye = _("This mail is merely a cross-check because these changes can be security-relevant. If the change was expected, you do not need to take any action.")."\n\n".
43
+        _("Greetings, ")."\n\n".
44 44
         CONFIG['APPEARANCE']['productname_long'];
45 45
 
46 46
 switch ($_POST['submitbutton']) {
47 47
     case web\lib\common\FormElements::BUTTON_DELETE:
48 48
         $myInstOriginal->destroy();
49
-        $loggerInstance->writeAudit($_SESSION['user'], "DEL", "IdP " . $instId);
49
+        $loggerInstance->writeAudit($_SESSION['user'], "DEL", "IdP ".$instId);
50 50
         header("Location: overview_user.php");
51 51
         exit;
52 52
     case web\lib\common\FormElements::BUTTON_FLUSH_AND_RESTART:
@@ -56,9 +56,9 @@  discard block
 block discarded – undo
56 56
         }
57 57
         // flush all IdP attributes and send user to creation wizard
58 58
         $myInstOriginal->flushAttributes();
59
-        $loggerInstance->writeAudit($_SESSION['user'], "DEL", "IdP starting over" . $instId);
60
-        $text = $hello .
61
-                sprintf(_("the %s %s / %s / (previously known as) '%s' has deleted all properties and is starting over freshly. This means that its not recognisable by its name any more, and it may assume a different name in the future. You will get another mail if and when the name change happens."), $ui->nomenclatureInst, strtoupper($myInstOriginal->federation), $myInstOriginal->identifier, $myInstOriginal->name) . "\n\n" .
59
+        $loggerInstance->writeAudit($_SESSION['user'], "DEL", "IdP starting over".$instId);
60
+        $text = $hello.
61
+                sprintf(_("the %s %s / %s / (previously known as) '%s' has deleted all properties and is starting over freshly. This means that its not recognisable by its name any more, and it may assume a different name in the future. You will get another mail if and when the name change happens."), $ui->nomenclatureInst, strtoupper($myInstOriginal->federation), $myInstOriginal->identifier, $myInstOriginal->name)."\n\n".
62 62
                 $bye;
63 63
         $fed = new core\Federation($myInstOriginal->federation);
64 64
         foreach ($fed->listFederationAdmins() as $id) {
@@ -77,19 +77,19 @@  discard block
 block discarded – undo
77 77
             exit(0);
78 78
         }
79 79
         $inst_name = $myInstOriginal->name;
80
-        echo "<h1>" . sprintf(_("Submitted attributes for IdP '%s'"), $inst_name) . "</h1>";
80
+        echo "<h1>".sprintf(_("Submitted attributes for IdP '%s'"), $inst_name)."</h1>";
81 81
         echo "<table>";
82 82
         echo $optionParser->processSubmittedFields($myInstOriginal, $_POST, $_FILES);
83 83
         echo "</table>";
84 84
 // delete cached logo, if present
85
-        $dir = ROOT . '/web/downloads/logos/';
86
-        $globResult = glob($dir . $myInstOriginal->identifier . "_*.png");
85
+        $dir = ROOT.'/web/downloads/logos/';
86
+        $globResult = glob($dir.$myInstOriginal->identifier."_*.png");
87 87
         if ($globResult === FALSE) { // we should catch the improbable error condition
88 88
             $globResult = [];
89 89
         }
90 90
         array_map('unlink', $globResult);
91 91
         $loggerInstance->debug(4, "UNLINK from $dir\n");
92
-        $loggerInstance->writeAudit($_SESSION['user'], "MOD", "IdP " . $myInstOriginal->identifier . " - attributes changed");
92
+        $loggerInstance->writeAudit($_SESSION['user'], "MOD", "IdP ".$myInstOriginal->identifier." - attributes changed");
93 93
 
94 94
 // re-instantiate ourselves... profiles need fresh data
95 95
         $myInstReinstantiated = $validator->IdP($_GET['inst_id'], $_SESSION['user']);
@@ -98,10 +98,10 @@  discard block
 block discarded – undo
98 98
         if (count($significantChanges) > 0) {
99 99
             // send a notification/alert mail to someone we know is in charge
100 100
             /// were made to the *Identity Provider* *LU* / integer number of IdP / (previously known as) Name
101
-            $text = $hello . sprintf(_("significant changes were made to the %s %s / %s / (previously known as) '%s'."), $ui->nomenclatureInst, strtoupper($myInstOriginal->federation), $myInstOriginal->identifier, $myInstOriginal->name) . "\n\n";
101
+            $text = $hello.sprintf(_("significant changes were made to the %s %s / %s / (previously known as) '%s'."), $ui->nomenclatureInst, strtoupper($myInstOriginal->federation), $myInstOriginal->identifier, $myInstOriginal->name)."\n\n";
102 102
             if (isset($significantChanges[\core\IdP::INSTNAME_CHANGED])) {
103
-                $text .= sprintf(_("The %s has changed its name. The details are below:"), $ui->nomenclatureInst) . "\n\n";
104
-                $text .= $significantChanges[\core\IdP::INSTNAME_CHANGED] . "\n\n";
103
+                $text .= sprintf(_("The %s has changed its name. The details are below:"), $ui->nomenclatureInst)."\n\n";
104
+                $text .= $significantChanges[\core\IdP::INSTNAME_CHANGED]."\n\n";
105 105
             }
106 106
             $text .= $bye;
107 107
             // (currently, send hard-wired to NRO - future: for linked insts, check eduroam DBv2 and send to registered admins directly)
@@ -117,15 +117,15 @@  discard block
 block discarded – undo
117 117
 
118 118
         if (isset(CONFIG_CONFASSISTANT['CONSORTIUM']['ssid']) && count(CONFIG_CONFASSISTANT['CONSORTIUM']['ssid']) > 0) {
119 119
             foreach (CONFIG_CONFASSISTANT['CONSORTIUM']['ssid'] as $ssidname) {
120
-                $ssids[] = $ssidname . " " . (isset(CONFIG_CONFASSISTANT['CONSORTIUM']['tkipsupport']) && CONFIG_CONFASSISTANT['CONSORTIUM']['tkipsupport'] === TRUE ? _("(WPA2/AES and WPA/TKIP)") : _("(WPA2/AES)") );
120
+                $ssids[] = $ssidname." ".(isset(CONFIG_CONFASSISTANT['CONSORTIUM']['tkipsupport']) && CONFIG_CONFASSISTANT['CONSORTIUM']['tkipsupport'] === TRUE ? _("(WPA2/AES and WPA/TKIP)") : _("(WPA2/AES)"));
121 121
             }
122 122
         }
123 123
 
124 124
         foreach ($myInstReinstantiated->getAttributes("media:SSID_with_legacy") as $ssidname) {
125
-            $ssids[] = $ssidname['value'] . " " . _("(WPA2/AES and WPA/TKIP)");
125
+            $ssids[] = $ssidname['value']." "._("(WPA2/AES and WPA/TKIP)");
126 126
         }
127 127
         foreach ($myInstReinstantiated->getAttributes("media:SSID") as $ssidname) {
128
-            $ssids[] = $ssidname['value'] . " " . _("(WPA2/AES)");
128
+            $ssids[] = $ssidname['value']." "._("(WPA2/AES)");
129 129
         }
130 130
 
131 131
         echo "<table>";
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
         if (count($ssids) > 0) {
134 134
             $printedlist = "";
135 135
             foreach ($ssids as $names) {
136
-                $printedlist = $printedlist . "$names ";
136
+                $printedlist = $printedlist."$names ";
137 137
             }
138 138
             echo $uiElements->boxOkay(sprintf(_("Your installers will configure the following SSIDs: <strong>%s</strong>"), $printedlist), _("SSIDs configured"));
139 139
         }
@@ -161,7 +161,7 @@  discard block
 block discarded – undo
161 161
                 // did we get an email address? then, show the silverbullet jumpstart button
162 162
                 // otherwise, issue a smartass comment
163 163
                 if (count($myInstReinstantiated->getAttributes("support:email")) > 0) {
164
-                    echo "<form method='post' action='edit_silverbullet.php?inst_id=$myInstReinstantiated->identifier' accept-charset='UTF-8'><button type='submit'>" . sprintf(_("Continue to %s properties"), \core\ProfileSilverbullet::PRODUCTNAME) . "</button></form>";
164
+                    echo "<form method='post' action='edit_silverbullet.php?inst_id=$myInstReinstantiated->identifier' accept-charset='UTF-8'><button type='submit'>".sprintf(_("Continue to %s properties"), \core\ProfileSilverbullet::PRODUCTNAME)."</button></form>";
165 165
                 } else {
166 166
                     echo "<table>";
167 167
                     echo $uiElements->boxError(sprintf(_("You did not submit an e-mail address. This is required for %s. Please go to the %s dashboard and edit your helpdesk settings to include a helpdesk e-mail address."), core\ProfileSilverbullet::PRODUCTNAME, $ui->nomenclatureInst), _("No support e-mail!"));
@@ -169,10 +169,10 @@  discard block
 block discarded – undo
169 169
                 }
170 170
             }
171 171
             if (CONFIG['FUNCTIONALITY_LOCATIONS']['CONFASSISTANT_RADIUS'] == "LOCAL") {
172
-                echo "<br/><form method='post' action='edit_profile.php?inst_id=$myInstReinstantiated->identifier' accept-charset='UTF-8'><button type='submit'>" . _("Continue to RADIUS/EAP profile definition") . "</button></form>";
172
+                echo "<br/><form method='post' action='edit_profile.php?inst_id=$myInstReinstantiated->identifier' accept-charset='UTF-8'><button type='submit'>"._("Continue to RADIUS/EAP profile definition")."</button></form>";
173 173
             }
174 174
         }
175
-        echo "<br/><form method='post' action='overview_idp.php?inst_id=$myInstReinstantiated->identifier' accept-charset='UTF-8'><button type='submit'>" . _("Continue to dashboard") . "</button></form>";
175
+        echo "<br/><form method='post' action='overview_idp.php?inst_id=$myInstReinstantiated->identifier' accept-charset='UTF-8'><button type='submit'>"._("Continue to dashboard")."</button></form>";
176 176
         echo $deco->footer();
177 177
         break;
178 178
     default:
Please login to merge, or discard this patch.