View GitHub Repository CAT

Schedule Inspection
Subscribe
Passed
Push — release_2_1 ( b39e75...0530b6 )
by Stefan
10:21 queued 14s
created
Status
Category
Toggle Patches
web/lib/admin/PageDecoration.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch 
@@ -73,13 +73,13 @@  discard block
 
 block discarded – undo
73 73 
         $retval = "<div class='sidebar'><p>";
74 74
75 75 
         if ($advancedControls) {
76 
-            $retval .= "<strong>" . _("You are:") . "</strong> ".$_SESSION['name']
76 
+            $retval .= "<strong>"._("You are:")."</strong> ".$_SESSION['name']
77 77 
             ."<br/>
78 78 
               <br/>
79 
-              <a href='" . \core\CAT::getRootUrlPath() . "/admin/overview_user.php'>" . _("Go to your Profile page") . "</a>
80 
-              <a href='" . \core\CAT::getRootUrlPath() . "/admin/inc/logout.php'>" . _("Logout") . "</a> ";
79 
+              <a href='" . \core\CAT::getRootUrlPath()."/admin/overview_user.php'>"._("Go to your Profile page")."</a>
80 
+              <a href='" . \core\CAT::getRootUrlPath()."/admin/inc/logout.php'>"._("Logout")."</a> ";
81 81 
         }
82 
-        $retval .= "<a href='" . \core\CAT::getRootUrlPath() . "/'>" . _("Start page") . "</a>
82 
+        $retval .= "<a href='".\core\CAT::getRootUrlPath()."/'>"._("Start page")."</a>
83 83 
             </p>
84 84 
         </div> <!-- sidebar -->";
85 85 
         \core\common\Entity::outOfThePotatoes();
 
@@ -103,23 +103,23 @@  discard block
 
 block discarded – undo
103 103 
                     <h1>$cap1</h1>
104 104 
                 </div><!--header_captions-->
105 105 
                 <div id='langselection' style='padding-top:20px; padding-".$this->start.":10px;'>
106 
-                    <form action='$place' method='GET' accept-charset='UTF-8'>" . _("View this page in") . "&nbsp;
106 
+                    <form action='$place' method='GET' accept-charset='UTF-8'>"._("View this page in")."&nbsp;
107 107 
                         <select id='lang' name='lang' onchange='this.form.submit()'>";
108 108
109 109 
         foreach (\config\Master::LANGUAGES as $lang => $getValue) {
110 
-            $retval .= "<option value='$lang' " . (strtoupper($language) == strtoupper($lang) ? "selected" : "" ) . " >" . $getValue['display'] . "</option> ";
110 
+            $retval .= "<option value='$lang' ".(strtoupper($language) == strtoupper($lang) ? "selected" : "")." >".$getValue['display']."</option> ";
111 111 
         }
112 112 
         $retval .= "</select>";
113 113
114 114 
         foreach ($_GET as $getVar => $getValue) {
115 115 
             $filterValue = filter_input(INPUT_GET, $getVar, FILTER_SANITIZE_STRING);
116 116 
             if ($getVar != "lang" && $getValue != "") {
117 
-                $retval .= "<input type='hidden' name='" . htmlspecialchars($getVar) . "' value='" . htmlspecialchars($filterValue) . "'>";
117 
+                $retval .= "<input type='hidden' name='".htmlspecialchars($getVar)."' value='".htmlspecialchars($filterValue)."'>";
118 118 
             }
119 119 
         }
120 120 
         $retval .= "</form>
121 121 
                 </div><!--langselection-->";
122 
-        $logoUrl = \core\CAT::getRootUrlPath() . "/resources/images/consortium_logo.png";
122 
+        $logoUrl = \core\CAT::getRootUrlPath()."/resources/images/consortium_logo.png";
123 123 
         $retval .= "<div class='consortium_logo'>
124 124 
                     <img id='test_locate' src='$logoUrl' alt='Consortium Logo'>
125 125 
                 </div> <!-- consortium_logo -->
 
@@ -212,7 +212,7 @@  discard block
 
 block discarded – undo
212 212
213 213 
         if (isset(\config\Master::APPEARANCE['MOTD']) && \config\Master::APPEARANCE['MOTD'] != "") {
214 214 
             $retval .= "<div id='header_MOTD' style='display:inline-block; padding-".$this->start.":20px;vertical-align:top;'>
215 
-              <p class='MOTD'>" . \config\Master::APPEARANCE['MOTD'] . "</p>
215 
+              <p class='MOTD'>" . \config\Master::APPEARANCE['MOTD']."</p>
216 216 
               </div><!--header_MOTD-->";
217 217 
         }
218 218 
         $retval .= $this->sidebar($advancedControls);
 
@@ -238,9 +238,9 @@  discard block
 
 block discarded – undo
238 238 
           <html xmlns='http://www.w3.org/1999/xhtml' lang='$ourlocale'".($this->langObject->rtl ? "dir='rtl'" : "").">
239 239 
           <head lang='$ourlocale'>
240 240 
           <meta http-equiv='Content-Type' content='text/html; charset=UTF-8'>";
241 
-        $cssUrl = \core\CAT::getRootUrlPath() . "/resources/css/cat.css.php";
241 
+        $cssUrl = \core\CAT::getRootUrlPath()."/resources/css/cat.css.php";
242 242 
         $retval .= "<link rel='stylesheet' type='text/css' href='$cssUrl' />";
243 
-        $retval .= "<title>" . htmlspecialchars($pagetitle) . "</title>";
243 
+        $retval .= "<title>".htmlspecialchars($pagetitle)."</title>";
244 244 
         return $retval;
245 245 
     }
246 246 
 
@@ -254,7 +254,7 @@  discard block
 
 block discarded – undo
254 254 
             // we may need to jump up one dir if we are either in admin/ or accountstatus/
255 255 
             // (accountstatus courtesy of my good mood. It's userspace not admin space so
256 256 
             // it shouldn't be using this function any more.)
257 
-            $logoBase = \core\CAT::getRootUrlPath() . "/resources/images";
257 
+            $logoBase = \core\CAT::getRootUrlPath()."/resources/images";
258 258 
             return "<span id='logos'><img src='$logoBase/dante.png' alt='DANTE' style='height:23px;width:47px'/>
259 259 
               <img src='$logoBase/eu.png' alt='EU' style='height:23px;width:27px;border-width:0px;'/></span>
260 260 
               <span id='eu_text' style='text-align:right;'><a href='http://ec.europa.eu/dgs/connect/index_en.htm' style='text-decoration:none; vertical-align:top;'>European Commission Communications Networks, Content and Technology</a></span>";
 
@@ -276,9 +276,9 @@  discard block
 
 block discarded – undo
276 276 
             <table style='width:100%'>
277 277 
                 <tr>
278 278 
                     <td style='padding-".$this->start.":20px; padding-".$this->end.":20px; text-align:".$this->start."; vertical-align:top;'>
279 
-                        " . $cat->catCopyright . "</td>";
279 
+                        " . $cat->catCopyright."</td>";
280 280 
         if (!empty(\config\Master::APPEARANCE['privacy_notice_url'])) {
281 
-            $retval .= "<td><a href='".\config\Master::APPEARANCE['privacy_notice_url']."'>" . sprintf(_("%s Privacy Notice"),\config\ConfAssistant::CONSORTIUM['display_name']) . "</a></td>";
281 
+            $retval .= "<td><a href='".\config\Master::APPEARANCE['privacy_notice_url']."'>".sprintf(_("%s Privacy Notice"), \config\ConfAssistant::CONSORTIUM['display_name'])."</a></td>";
282 282 
         }
283 283 
         $retval .= "            <td style='padding-".$this->start.":80px; padding-".$this->end.":20px; text-align:".$this->end."; vertical-align:top;'>";
284 284
Please login to merge, or discard this patch.