Passed
Push — master ( 3bf716...1704bc )
by Tomasz
03:44 queued 14s
created
devices/linux/DeviceLinuxSh.php 3 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -201,7 +201,7 @@
 block discarded – undo
201 201
         }
202 202
 
203 203
         if (!empty($this->attributes['internal:realm'][0])) {
204
-           $config['USER_REALM'] = $this->attributes['internal:realm'][0];
204
+            $config['USER_REALM'] = $this->attributes['internal:realm'][0];
205 205
         }
206 206
 
207 207
         if(!empty($this->attributes['internal:hint_userinput_suffix'][0]) && $this->attributes['internal:hint_userinput_suffix'][0] == 1) {
Please login to merge, or discard this patch.
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
      *
46 46
      */
47 47
     public function writeInstaller() {
48
-        $installerPath = $this->installerBasename . ".py";
48
+        $installerPath = $this->installerBasename.".py";
49 49
         $this->copyFile("eduroam_linux_main.sh", $installerPath);
50 50
         $installer = fopen($installerPath, "a");
51 51
         if ($installer === FALSE) {
@@ -77,9 +77,9 @@  discard block
 block discarded – undo
77 77
         $out .= "<p>";
78 78
         if ($ssidCount > 1) {
79 79
             if ($ssidCount > 2) {
80
-                $out .= sprintf(_("In addition to <strong>%s</strong> the installer will also configure access to the following networks:"), implode(', ', \config\ConfAssistant::CONSORTIUM['ssid'])) . " ";
80
+                $out .= sprintf(_("In addition to <strong>%s</strong> the installer will also configure access to the following networks:"), implode(', ', \config\ConfAssistant::CONSORTIUM['ssid']))." ";
81 81
             } else {
82
-                $out .= sprintf(_("In addition to <strong>%s</strong> the installer will also configure access to:"), implode(', ', \config\ConfAssistant::CONSORTIUM['ssid'])) . " ";
82
+                $out .= sprintf(_("In addition to <strong>%s</strong> the installer will also configure access to:"), implode(', ', \config\ConfAssistant::CONSORTIUM['ssid']))." ";
83 83
             }
84 84
             $iterator = 0;
85 85
             foreach ($this->attributes['internal:SSID'] as $ssid => $v) {
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
      * @return void
117 117
      */
118 118
     private function writeConfigLine($file, $name, $text) {
119
-        $out = $name . '="' . $text . '"\n';
119
+        $out = $name.'="'.$text.'"\n';
120 120
         fwrite($file, wordwrap($out, 70, "\n");
121 121
     }
122 122
 
@@ -197,18 +197,18 @@  discard block
 block discarded – undo
197 197
         }
198 198
 
199 199
         if ($outerId !== NULL) {
200
-            $configRaw['ANONYMOUS_IDENTITY'] = '"' . $outerId . '"';
200
+            $configRaw['ANONYMOUS_IDENTITY'] = '"'.$outerId.'"';
201 201
         }
202 202
 
203 203
         if (!empty($this->attributes['internal:realm'][0])) {
204 204
            $config['USER_REALM'] = $this->attributes['internal:realm'][0];
205 205
         }
206 206
 
207
-        if(!empty($this->attributes['internal:hint_userinput_suffix'][0]) && $this->attributes['internal:hint_userinput_suffix'][0] == 1) {
207
+        if (!empty($this->attributes['internal:hint_userinput_suffix'][0]) && $this->attributes['internal:hint_userinput_suffix'][0] == 1) {
208 208
             $configRaw['HINT_USER_INPUT'] = "True";
209 209
         }
210 210
 
211
-        if(!empty($this->attributes['internal:verify_userinput_suffix'][0]) && $this->attributes['internal:verify_userinput_suffix'][0] == 1) {
211
+        if (!empty($this->attributes['internal:verify_userinput_suffix'][0]) && $this->attributes['internal:verify_userinput_suffix'][0] == 1) {
212 212
             $configRaw['VERIFY_USER_REALM_INPUT'] = "True";
213 213
         }
214 214
 
@@ -223,13 +223,13 @@  discard block
 block discarded – undo
223 223
         if ($tou === '') {
224 224
             fwrite($file, "TOU=\"\"\n");
225 225
         } else {
226
-            fwrite($file, "TOU=\"" . $tou . "\"\n");
226
+            fwrite($file, "TOU=\"".$tou."\"\n");
227 227
         }
228 228
 
229
-        fwrite($file, "CA=\"" . $this->mkCAfile() . "\"\n");
229
+        fwrite($file, "CA=\"".$this->mkCAfile()."\"\n");
230 230
         $sbUserFile = $this->mkSbUserFile();
231 231
         if ($sbUserFile !== '') {
232
-            fwrite($file, "SB_USER_FILE=\"" . $sbUserFile . "\"\n");
232
+            fwrite($file, "SB_USER_FILE=\"".$sbUserFile."\"\n");
233 233
         }
234 234
     }
235 235
 
@@ -281,7 +281,7 @@  discard block
 block discarded – undo
281 281
             }
282 282
             $out .= "'DNS:$oneServer'";
283 283
         }
284
-        return "[" . $out. "]";
284
+        return "[".$out."]";
285 285
     }
286 286
 
287 287
     /**
@@ -295,7 +295,7 @@  discard block
 block discarded – undo
295 295
         foreach ($ssids as $ssid => $cipher) {
296 296
             $outArray[] = "'$ssid'";
297 297
         }
298
-        return '[' . implode(', ', $outArray) . ']';
298
+        return '['.implode(', ', $outArray).']';
299 299
     }
300 300
 
301 301
     /**
@@ -311,7 +311,7 @@  discard block
 block discarded – undo
311 311
                 $outArray[] = "'$ssid'";
312 312
             }
313 313
         }
314
-        return '[' . implode(', ', $outArray) . ']';
314
+        return '['.implode(', ', $outArray).']';
315 315
     }
316 316
 
317 317
     /**
@@ -319,7 +319,7 @@  discard block
 block discarded – undo
319 319
      *
320 320
      * @return string
321 321
      */
322
-    private function mkCAfile(){
322
+    private function mkCAfile() {
323 323
         $out = '';
324 324
         $cAlist = $this->attributes['internal:CAs'][0];
325 325
         foreach ($cAlist as $oneCa) {
@@ -335,7 +335,7 @@  discard block
 block discarded – undo
335 335
      */
336 336
     private function mkIntro() {
337 337
         \core\common\Entity::intoThePotatoes();
338
-        $out = _("This installer has been prepared for {0}") . '\n\n' . _("More information and comments:") . '\n\nE-Mail: {1}\nWWW: {2}\n\n' .
338
+        $out = _("This installer has been prepared for {0}").'\n\n'._("More information and comments:").'\n\nE-Mail: {1}\nWWW: {2}\n\n'.
339 339
             _("Installer created with software from the GEANT project.");
340 340
         \core\common\Entity::outOfThePotatoes();
341 341
         return $out;
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -191,8 +191,7 @@
 block discarded – undo
191 191
 
192 192
         if ($this->selectedEap == \core\common\EAP::EAPTYPE_TLS && isset($this->attributes['eap-specific:tls_use_other_id']) && $this->attributes['eap-specific:tls_use_other_id'][0] == 'on') {
193 193
             $configRaw['USE_OTHER_TLS_ID'] = "True";
194
-        }
195
-        else {
194
+        } else {
196 195
             $configRaw['USE_OTHER_TLS_ID'] = "False";
197 196
         }
198 197
 
Please login to merge, or discard this patch.