Passed
Push — master ( 1adfd2...652786 )
by Stefan
06:27
created
devices/ms/Files/common.inc 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1115,12 +1115,12 @@
 block discarded – undo
1115 1115
         $certUsernameLabel = WindowsCommon::sprintNsis(_("Username:"));
1116 1116
         $certUsernameLength = strlen($certUsernameLabel);
1117 1117
         $labelLength = max($certPasswordLength,$certUsernameLength);
1118
-  ?>
1118
+    ?>
1119 1119
   ${NSD_CreateLabel} 0 0 100% 32u "<?php WindowsCommon::echoNsis(_("Selected file: \$Cert_file"))?>"
1120 1120
   !else
1121 1121
   <?php $certPasswordLabel = WindowsCommon::sprintNsis(_("import password:"));
1122 1122
         $certPasswordLength = strlen($certPasswordLabel);
1123
-  ?>
1123
+    ?>
1124 1124
   !insertmacro debug_cat 4 "Unpacking SB_cert.p12"
1125 1125
   File "SB_cert.p12"
1126 1126
   nsArray::Set Delete_files "SB_cert.p12"
Please login to merge, or discard this patch.
Spacing   +33 added lines, -33 removed lines patch added patch discarded remove patch
@@ -135,10 +135,10 @@  discard block
 block discarded – undo
135 135
 !define MUI_HEADERIMAGE_BITMAP "cat_150.bmp"
136 136
 !define MUI_COMPONENTSPAGE_SMALLDESC
137 137
 
138
-!define WELCOME_HEADER "<?php printf(WindowsCommon::sprintNsis(_("Welcome to the %s installer")),CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'])?>"
139
-!define FAREWELL_HEADER "<?php WindowsCommon::echoNsis( _("Installation complete"))?>"
140
-!define FAREWELL_TEXT	"<?php WindowsCommon::echoNsis( _("Network profiles have been installed."))?>$\r$\n$\n <?php WindowsCommon::echoNsis(  _("Your system is ready."))?>"
141
-!define FAREWELL_FAIL	"<?php WindowsCommon::echoNsis( _("Network installation had errors."))?>$\r$\n$\n <?php WindowsCommon::echoNsis( _("Please contact \${SUPPORT}."))?>"
138
+!define WELCOME_HEADER "<?php printf(WindowsCommon::sprintNsis(_("Welcome to the %s installer")), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'])?>"
139
+!define FAREWELL_HEADER "<?php WindowsCommon::echoNsis(_("Installation complete"))?>"
140
+!define FAREWELL_TEXT	"<?php WindowsCommon::echoNsis(_("Network profiles have been installed."))?>$\r$\n$\n <?php WindowsCommon::echoNsis(_("Your system is ready."))?>"
141
+!define FAREWELL_FAIL	"<?php WindowsCommon::echoNsis(_("Network installation had errors."))?>$\r$\n$\n <?php WindowsCommon::echoNsis(_("Please contact \${SUPPORT}."))?>"
142 142
 ;--------------------------------
143 143
 ;Languages
144 144
 !insertmacro MUI_LANGUAGE "${LANG}"
@@ -146,14 +146,14 @@  discard block
 block discarded – undo
146 146
 ;--------------------------------
147 147
 ; License file
148 148
 !ifdef LICENSE_FILE
149
-LicenseForceSelection checkbox "<?php WindowsCommon::echoNsis( _("Accept"))?>"
149
+LicenseForceSelection checkbox "<?php WindowsCommon::echoNsis(_("Accept"))?>"
150 150
 LicenseText "<?php WindowsCommon::echoNsis(_("If you accept the conditions then select Accept and then click Install to continue."))?>"
151 151
 LicenseData ${LICENSE_FILE}
152 152
 !endif
153 153
 
154 154
 ;-----------------------------------
155 155
 
156
-MiscButtonText "" "" "" "<?php WindowsCommon::echoNsis( _("Finish"))?>"
156
+MiscButtonText "" "" "" "<?php WindowsCommon::echoNsis(_("Finish"))?>"
157 157
 ;----------------------------------
158 158
 ;  FUNCTIONS
159 159
 
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
186 186
 
187 187
 !macro install_ca_cert ca_file ca_fingerprint level
188 188
    !insertmacro debug_cat 2 "locating certificate  SHA=${ca_fingerprint} Level=${level}"
189
-   DetailPrint "<?php WindowsCommon::echoNsis( _("searching for certificate"))?> ${ca_file}"
189
+   DetailPrint "<?php WindowsCommon::echoNsis(_("searching for certificate"))?> ${ca_file}"
190 190
    File "${ca_file}"
191 191
    nsArray::Set Delete_files "${ca_file}"
192 192
    !insertmacro debug_cat 2 "Testing machine store root"
@@ -248,13 +248,13 @@  discard block
 block discarded – undo
248 248
    ${EndIf}
249 249
    !insertmacro debug_cat 2 "installing certificate $TEMP\${ca_file}"
250 250
    !insertmacro debug_cat 3 "Execute: certutil -addstore -user ${level} $TEMP\${ca_file}"
251
-   DetailPrint "<?php WindowsCommon::echoNsis( _("installing certificate"))?> ${ca_file}"
251
+   DetailPrint "<?php WindowsCommon::echoNsis(_("installing certificate"))?> ${ca_file}"
252 252
    nsExec::Exec '"certutil" -addstore -user ${level} "$TEMP"\${ca_file}'
253 253
    Pop $0
254 254
    !insertmacro debug_cat 3 "certutil returned $0"
255 255
    ${If} $0 != 0
256 256
      IfSilent +2
257
-     MessageBox MB_OK|MB_ICONEXCLAMATION "<?php WindowsCommon::echoNsis( _("could not install certificate"))?>  ${ca_file}"
257
+     MessageBox MB_OK|MB_ICONEXCLAMATION "<?php WindowsCommon::echoNsis(_("could not install certificate"))?>  ${ca_file}"
258 258
      !insertmacro debug_cat 1 "could not install certificate ${ca_file}"
259 259
    ${EndIf}
260 260
 no_install_${ca_file}:
@@ -461,26 +461,26 @@  discard block
 block discarded – undo
461 461
   pop $R0
462 462
   ${If} $tkip_count > 0
463 463
     ${If} $aes_count > 1
464
-      StrCpy $R1 "$\r$\n$\n<?php WindowsCommon::echoNsis( _("The non TKIP profiles are preferred. Always use them if you have a choice."))?>"
464
+      StrCpy $R1 "$\r$\n$\n<?php WindowsCommon::echoNsis(_("The non TKIP profiles are preferred. Always use them if you have a choice."))?>"
465 465
     ${Else}
466
-     StrCpy $R1 "$\r$\n$\n<?php WindowsCommon::echoNsis( _("The non TKIP profile is preferred. Always use it if you have a choice."))?>"
466
+     StrCpy $R1 "$\r$\n$\n<?php WindowsCommon::echoNsis(_("The non TKIP profile is preferred. Always use it if you have a choice."))?>"
467 467
     ${EndIf}
468 468
   ${Else}
469 469
     StrCpy $R1 ""
470 470
   ${EndIf}
471 471
   ${If} $profile_count > 0
472
-    StrCpy $welcome_message "<?php WindowsCommon::echoNsis( _("This installer has been prepared for \${ORGANISATION}"))?>.$\r$\n\
473
-<?php WindowsCommon::echoNsis( _("The installer will create the following wireless profiles:"))?>$\r$\n\
472
+    StrCpy $welcome_message "<?php WindowsCommon::echoNsis(_("This installer has been prepared for \${ORGANISATION}"))?>.$\r$\n\
473
+<?php WindowsCommon::echoNsis(_("The installer will create the following wireless profiles:"))?>$\r$\n\
474 474
 $R0.\
475 475
 $R1$\r$\n$\n\
476
-<?php WindowsCommon::echoNsis( _("More information and comments:"))?>$\r$\n\
476
+<?php WindowsCommon::echoNsis(_("More information and comments:"))?>$\r$\n\
477 477
    EMAIL: ${SUPPORT}$\r$\n\
478 478
    WWW: ${URL}"
479 479
 ${Else}
480
-StrCpy $welcome_message "<?php WindowsCommon::echoNsis( _("This installer has been prepared for \${ORGANISATION}"))?>.$\r$\n\
481
-<?php WindowsCommon::echoNsis( _("The installer will create the wireless profile:"))?> $R0.\
480
+StrCpy $welcome_message "<?php WindowsCommon::echoNsis(_("This installer has been prepared for \${ORGANISATION}"))?>.$\r$\n\
481
+<?php WindowsCommon::echoNsis(_("The installer will create the wireless profile:"))?> $R0.\
482 482
 $R1$\r$\n$\n\
483
-<?php WindowsCommon::echoNsis( _("More information and comments:"))?>$\r$\n\
483
+<?php WindowsCommon::echoNsis(_("More information and comments:"))?>$\r$\n\
484 484
    EMAIL: ${SUPPORT}$\r$\n\
485 485
    WWW: ${URL}"
486 486
 ${EndIf}
@@ -506,7 +506,7 @@  discard block
 block discarded – undo
506 506
   SendMessage $HEADLINE ${WM_SETFONT} $HEADLINE_FONT 0
507 507
 ;TRANSLATION
508 508
   nsDialogs::CreateControl STATIC ${WS_VISIBLE}|${WS_CHILD}|${WS_CLIPSIBLINGS} 0 120u 46u -130u -32u "$welcome_message\
509
-$\r$\n$\r$\n<?php WindowsCommon::echoNsis( _("Installer created with software from the GEANT project."))?>"
509
+$\r$\n$\r$\n<?php WindowsCommon::echoNsis(_("Installer created with software from the GEANT project."))?>"
510 510
   Pop $TEXT
511 511
 
512 512
   SetCtlColors $DIALOG "" 0xffffff
@@ -619,18 +619,18 @@  discard block
 block discarded – undo
619 619
     ${If} $wireless_result == 1
620 620
       !insertmacro debug_cat 1 "wlan_test.exe did not find wireless configuration service"
621 621
       IfSilent +2
622
-      MessageBox MB_OK|MB_ICONEXCLAMATION "<?php WindowsCommon::echoNsis( _("Windows wireless configuration service is not enabled. The installer cannot continue."))?>"
622
+      MessageBox MB_OK|MB_ICONEXCLAMATION "<?php WindowsCommon::echoNsis(_("Windows wireless configuration service is not enabled. The installer cannot continue."))?>"
623 623
       Call Cleanup
624 624
     ${EndIf}
625 625
     ${If} $wireless_result == 2
626 626
       IfSilent +2
627
-      MessageBox MB_OK|MB_ICONEXCLAMATION "<?php WindowsCommon::echoNsis( _("No wireless interfaces found. The installer cannot continue."))?>"
627
+      MessageBox MB_OK|MB_ICONEXCLAMATION "<?php WindowsCommon::echoNsis(_("No wireless interfaces found. The installer cannot continue."))?>"
628 628
       Call Cleanup
629 629
     ${EndIf}
630 630
   ${Else}
631 631
     ${If} $wireless_result > 0
632 632
        IfSilent +3
633
-       MessageBox MB_YESNO "<?php WindowsCommon::echoNsis( _("No wireless interfaces found. Wireless access will not be configured. Would you like to continue and configure access on the wired interface?"))?>" IDYES wired_yes
633
+       MessageBox MB_YESNO "<?php WindowsCommon::echoNsis(_("No wireless interfaces found. Wireless access will not be configured. Would you like to continue and configure access on the wired interface?"))?>" IDYES wired_yes
634 634
        Call Cleanup
635 635
        wired_yes:
636 636
        Push 1
@@ -646,7 +646,7 @@  discard block
 block discarded – undo
646 646
     ${If} $wired == 1
647 647
       ${If} $force_wired == 0
648 648
         IfSilent wired
649
-        MessageBox MB_YESNO "<?php WindowsCommon::echoNsis( _("Do you want to enable access on wired interfaces?"))?>" IDYES wired
649
+        MessageBox MB_YESNO "<?php WindowsCommon::echoNsis(_("Do you want to enable access on wired interfaces?"))?>" IDYES wired
650 650
         Push 0
651 651
         Pop $wired
652 652
       ${EndIf}
@@ -687,7 +687,7 @@  discard block
 block discarded – undo
687 687
 ;================================
688 688
 
689 689
 Function ShowInstfiles
690
-  !insertmacro MUI_HEADER_TEXT "<?php WindowsCommon::echoNsis( _("Profiles installation"))?>" " "
690
+  !insertmacro MUI_HEADER_TEXT "<?php WindowsCommon::echoNsis(_("Profiles installation"))?>" " "
691 691
 FunctionEnd
692 692
 ;================================
693 693
 ;  Check if a wireless profile exist and put it on delete list
@@ -706,7 +706,7 @@  discard block
 block discarded – undo
706 706
 
707 707
 Function FindProfile
708 708
   Pop $R8
709
-  DetailPrint "<?php WindowsCommon::echoNsis( _("Checking for profile \$R8"))?>"
709
+  DetailPrint "<?php WindowsCommon::echoNsis(_("Checking for profile \$R8"))?>"
710 710
   !insertmacro debug_cat 2 "Checking for profile $R8"
711 711
   !insertmacro debug_cat 3 "Exec: $Netsh wlan show profiles $R8"
712 712
   nsExec::Exec  '"$Netsh" wlan show profiles "$R8"'
@@ -714,7 +714,7 @@  discard block
 block discarded – undo
714 714
   !insertmacro debug_cat 4 "netsh returned $0"
715 715
   ${If} $0 == 0
716 716
     !insertmacro debug_cat 1 "found profile $R8"
717
-    DetailPrint "<?php WindowsCommon::echoNsis( _("found profile \$R8"))?>"
717
+    DetailPrint "<?php WindowsCommon::echoNsis(_("found profile \$R8"))?>"
718 718
     Push 0
719 719
   ${Else}
720 720
     !insertmacro debug_cat 1 "profile $R8 not found"
@@ -809,7 +809,7 @@  discard block
 block discarded – undo
809 809
     ${If} $Symantec_installed  != 0
810 810
      !insertmacro debug_cat 3 "Symantec problem"
811 811
      IfSilent +2
812
-     MessageBox MB_OK|MB_ICONEXCLAMATION "<?php printf(WindowsCommon::sprintNsis(_("Please READ this message it is IMPORTANT.$\\r$\\nInstallation problems may be due to the fact that Symantec Endpoint Protection is installed on your machine.$\\r$\\nWhile this is a well-known bug of the Symantec product, about which the installer can not do anything, there is a workaround.$\\r$\\nWhen you close this window the installer will exit and an explorer window will be started (it could appear underneath already opened windows). In this window you should see a script named inst_cat. Start it by double-clicking, It will install the profiles. You will need to login to %s with your username and password.")),CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']) ?>"
812
+     MessageBox MB_OK|MB_ICONEXCLAMATION "<?php printf(WindowsCommon::sprintNsis(_("Please READ this message it is IMPORTANT.$\\r$\\nInstallation problems may be due to the fact that Symantec Endpoint Protection is installed on your machine.$\\r$\\nWhile this is a well-known bug of the Symantec product, about which the installer can not do anything, there is a workaround.$\\r$\\nWhen you close this window the installer will exit and an explorer window will be started (it could appear underneath already opened windows). In this window you should see a script named inst_cat. Start it by double-clicking, It will install the profiles. You will need to login to %s with your username and password.")), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']) ?>"
813 813
     Exec '"explorer" /select,"$EXEDIR\inst_cat.cmd"'
814 814
     Quit
815 815
 
@@ -1098,7 +1098,7 @@  discard block
 block discarded – undo
1098 1098
 Function PFXCertificateSelect
1099 1099
   !ifndef SILVERBULLET
1100 1100
 ;TRANSLATION
1101
-!insertmacro MUI_HEADER_TEXT "<?php printf(WindowsCommon::sprintNsis(_("%s installer for")),CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'])?> " "<?php WindowsCommon::echoNsis(_("Install personal certificate"))?>"
1101
+!insertmacro MUI_HEADER_TEXT "<?php printf(WindowsCommon::sprintNsis(_("%s installer for")), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'])?> " "<?php WindowsCommon::echoNsis(_("Install personal certificate"))?>"
1102 1102
 ;TRANSLATION
1103 1103
     IfSilent +2
1104 1104
   MessageBox MB_OK "<?php WindowsCommon::echoNsis(_("Preparing to install personal certificate."))?>$\r$\n<?php WindowsCommon::echoNsis(_("Click OK to continue"))?> "
@@ -1114,7 +1114,7 @@  discard block
 block discarded – undo
1114 1114
         $certPasswordLength = strlen($certPasswordLabel);
1115 1115
         $certUsernameLabel = WindowsCommon::sprintNsis(_("Username:"));
1116 1116
         $certUsernameLength = strlen($certUsernameLabel);
1117
-        $labelLength = max($certPasswordLength,$certUsernameLength);
1117
+        $labelLength = max($certPasswordLength, $certUsernameLength);
1118 1118
   ?>
1119 1119
   ${NSD_CreateLabel} 0 0 100% 32u "<?php WindowsCommon::echoNsis(_("Selected file: \$Cert_file"))?>"
1120 1120
   !else
@@ -1131,11 +1131,11 @@  discard block
 block discarded – undo
1131 1131
   !insertmacro debug_cat 3 "Vista level (Vista without Service pack): $VistaNoSP";
1132 1132
   ${If} $VistaNoSP == 0
1133 1133
     !ifdef PFX_USERNAME
1134
-       !define LABEL_LENGTH "<?php echo($labelLength*3.5)?>u"
1135
-       !define TEXT_START "<?php echo($labelLength*3.5 +5)?>u"
1134
+       !define LABEL_LENGTH "<?php echo($labelLength * 3.5)?>u"
1135
+       !define TEXT_START "<?php echo($labelLength * 3.5 + 5)?>u"
1136 1136
     !else
1137
-       !define LABEL_LENGTH "<?php echo($certPasswordLength*3.5)?>u"
1138
-       !define TEXT_START "<?php echo($certPasswordLength*3.5 +5)?>u"
1137
+       !define LABEL_LENGTH "<?php echo($certPasswordLength * 3.5)?>u"
1138
+       !define TEXT_START "<?php echo($certPasswordLength * 3.5 + 5)?>u"
1139 1139
     !endif
1140 1140
     ${NSD_CreateLabel} 0 35u ${LABEL_LENGTH} 12u "<?php echo $certPasswordLabel?>"
1141 1141
     ${NSD_CreatePassword} ${TEXT_START} 34.5u 120u 12u ""
@@ -1505,7 +1505,7 @@  discard block
 block discarded – undo
1505 1505
 Section "-start"
1506 1506
 SectionIn RO
1507 1507
 
1508
-!insertmacro MUI_HEADER_TEXT "<?php WindowsCommon::echoNsis( _("Installation"))?>" "<?php WindowsCommon::echoNsis( _("Checking for existing wireless profiles"))?>"
1508
+!insertmacro MUI_HEADER_TEXT "<?php WindowsCommon::echoNsis(_("Installation"))?>" "<?php WindowsCommon::echoNsis(_("Checking for existing wireless profiles"))?>"
1509 1509
 !ifndef PWD
1510 1510
 !include "certs.nsh"
1511 1511
 !endif
Please login to merge, or discard this patch.
devices/ms/Files/geant_link.inc 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
   nsArray::Set Delete_files "GEANTLink-ARM64.msi"
93 93
   File "GEANTLink-ARM64.msi"
94 94
   IfSilent +2
95
-  MessageBox MB_OK  "<?php WindowsCommon::echoNsis( _("An additional piece of software 'GEANTlink' needs to be installed. This installation requires Administrator rights; you will be prompted to give permission for that action."))?>"
95
+  MessageBox MB_OK  "<?php WindowsCommon::echoNsis(_("An additional piece of software 'GEANTlink' needs to be installed. This installation requires Administrator rights; you will be prompted to give permission for that action."))?>"
96 96
   !insertmacro debug_cat 1 "Run GEANTLink installer"
97 97
   !insertmacro debug_cat 3 'Execute: msiexec.exe /i "$OUTDIR\GEANTLink-$Platform.msi" REBOOT=Supress'
98 98
   ClearErrors
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
   Pop $rebootRequired
105 105
   ${Else}
106 106
   IfSilent +2
107
-  MessageBox MB_OK "<?php WindowsCommon::echoNsis( _("Error installing GEANTLink.\$\\nEmbedded installer didn't complete succesfully."))?>"
107
+  MessageBox MB_OK "<?php WindowsCommon::echoNsis(_("Error installing GEANTLink.\$\\nEmbedded installer didn't complete succesfully."))?>"
108 108
   Quit
109 109
   ${EndIf}
110 110
   Cont2:
Please login to merge, or discard this patch.
devices/ms/WindowsCommon.php 1 patch
Spacing   +33 added lines, -33 removed lines patch added patch discarded remove patch
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
         if (isset($this->LANGS[$this->languageInstance->getLang()])) {
135 135
             $language = $this->LANGS[$this->languageInstance->getLang()];
136 136
             $this->lang = $language['nsis'];
137
-            $this->codePage = 'cp' . $language['cp'];
137
+            $this->codePage = 'cp'.$language['cp'];
138 138
         } else {
139 139
             $this->lang = 'English';
140 140
             $this->codePage = 'cp1252';
@@ -155,8 +155,8 @@  discard block
 block discarded – undo
155 155
         $out .= sprintf(_("%s installer will be in the form of an EXE file. It will configure %s on your device, by creating wireless network profiles.<p>When you click the download button, the installer will be saved by your browser. Copy it to the machine you want to configure and execute."), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'], CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']);
156 156
         $out .= "<p>";
157 157
         if ($ssidCount > $configCount) {
158
-            $out .= sprintf(ngettext("In addition to <strong>%s</strong> the installer will also configure access to:", "In addition to <strong>%s</strong> the installer will also configure access to the following networks:", $ssidCount - $configCount), implode(', ', $configList)) . " ";
159
-            $out .= '<strong>' . join('</strong>, <strong>', array_diff(array_keys($ssids), $configList)) . '</strong>';
158
+            $out .= sprintf(ngettext("In addition to <strong>%s</strong> the installer will also configure access to:", "In addition to <strong>%s</strong> the installer will also configure access to the following networks:", $ssidCount - $configCount), implode(', ', $configList))." ";
159
+            $out .= '<strong>'.join('</strong>, <strong>', array_diff(array_keys($ssids), $configList)).'</strong>';
160 160
             $out .= "<p>";
161 161
         }
162 162
 // TODO - change this below
@@ -172,8 +172,8 @@  discard block
 block discarded – undo
172 172
             $out .= _("When you are connecting to the network for the first time, Windows will pop up a login box, where you should enter your user name and password. This information will be saved so that you will reconnect to the network automatically each time you are in the range.");
173 173
             if ($ssidCount > 1) {
174 174
                 $out .= "<p>";
175
-                $out .= _("You will be required to enter the same credentials for each of the configured networks:") . " ";
176
-                $out .= '<strong>' . join('</strong>, <strong>', array_keys($ssids)) . '</strong>';
175
+                $out .= _("You will be required to enter the same credentials for each of the configured networks:")." ";
176
+                $out .= '<strong>'.join('</strong>, <strong>', array_keys($ssids)).'</strong>';
177 177
             }
178 178
         }
179 179
         return $out;
@@ -244,11 +244,11 @@  discard block
 block discarded – undo
244 244
         $logoCount = count($logosToPlace);
245 245
         if ($logoCount > 0) {
246 246
             $voffset = $freeTop;
247
-            $freeSpace = (int)round($this->background['freeHeight'] / ($logoCount + 1));
247
+            $freeSpace = (int) round($this->background['freeHeight'] / ($logoCount + 1));
248 248
             foreach ($logosToPlace as $logo) {
249 249
                 $voffset += $freeSpace;
250 250
                 $logoSize = $logo->getImageGeometry();
251
-                $hoffset = (int)round(($bgImageSize['width'] - $logoSize['width']) / 2);
251
+                $hoffset = (int) round(($bgImageSize['width'] - $logoSize['width']) / 2);
252 252
                 $bgImage->compositeImage($logo, $logo->getImageCompose(), $hoffset, $voffset);
253 253
                 $voffset += $logoSize['height'];
254 254
                 }
@@ -269,13 +269,13 @@  discard block
 block discarded – undo
269 269
      * @return string path to signed installer
270 270
      */
271 271
     protected function signInstaller() {
272
-        $fileName = $this->installerBasename . '.exe';
272
+        $fileName = $this->installerBasename.'.exe';
273 273
         if (!$this->sign) {
274 274
             rename("installer.exe", $fileName);
275 275
             return $fileName;
276 276
         }
277 277
         // are actually signing
278
-        $outputFromSigning = system($this->sign . " installer.exe '$fileName' > /dev/null");
278
+        $outputFromSigning = system($this->sign." installer.exe '$fileName' > /dev/null");
279 279
         if ($outputFromSigning === FALSE) {
280 280
             $this->loggerInstance->debug(2, "Signing the WindowsCommon installer $fileName FAILED!\n");
281 281
         }
@@ -289,15 +289,15 @@  discard block
 block discarded – undo
289 289
      */
290 290
     protected function compileNSIS() {
291 291
         if (CONFIG_CONFASSISTANT['NSIS_VERSION'] >= 3) {
292
-            $makensis = CONFIG_CONFASSISTANT['PATHS']['makensis'] . " -INPUTCHARSET UTF8";
292
+            $makensis = CONFIG_CONFASSISTANT['PATHS']['makensis']." -INPUTCHARSET UTF8";
293 293
         } else {
294 294
             $makensis = CONFIG_CONFASSISTANT['PATHS']['makensis'];
295 295
         }
296 296
         $lcAll = getenv("LC_ALL");
297 297
         putenv("LC_ALL=en_US.UTF-8");
298
-        $command = $makensis . ' -V4 cat.NSI > nsis.log 2>&1';
298
+        $command = $makensis.' -V4 cat.NSI > nsis.log 2>&1';
299 299
         system($command);
300
-        putenv("LC_ALL=" . $lcAll);
300
+        putenv("LC_ALL=".$lcAll);
301 301
         $this->loggerInstance->debug(4, "compileNSIS:$command\n");
302 302
     }
303 303
 
@@ -313,10 +313,10 @@  discard block
 block discarded – undo
313 313
             'email' => 'SUPPORT',
314 314
             'url' => 'URL',
315 315
         ];
316
-        $s = "support_" . $type . "_substitute";
316
+        $s = "support_".$type."_substitute";
317 317
         $substitute = $this->translateString($this->$s, $this->codePage);
318
-        $returnValue = !empty($attr['support:' . $type][0]) ? $attr['support:' .  $type][0] : $substitute;
319
-        return '!define ' . $supportString[$type] . ' "' . $returnValue . '"' . "\n";
318
+        $returnValue = !empty($attr['support:'.$type][0]) ? $attr['support:'.$type][0] : $substitute;
319
+        return '!define '.$supportString[$type].' "'.$returnValue.'"'."\n";
320 320
     }
321 321
     
322 322
     /**
@@ -326,20 +326,20 @@  discard block
 block discarded – undo
326 326
      * @return string
327 327
      */
328 328
     protected function writeNsisDefines($attr) {
329
-        $fcontents = "\n" . '!define NSIS_MAJOR_VERSION ' . CONFIG_CONFASSISTANT['NSIS_VERSION'];
329
+        $fcontents = "\n".'!define NSIS_MAJOR_VERSION '.CONFIG_CONFASSISTANT['NSIS_VERSION'];
330 330
         if ($attr['internal:profile_count'][0] > 1) {
331
-            $fcontents .= "\n" . '!define USER_GROUP "' . $this->translateString(str_replace('"', '$\\"', $attr['profile:name'][0]), $this->codePage) . '"
331
+            $fcontents .= "\n".'!define USER_GROUP "'.$this->translateString(str_replace('"', '$\\"', $attr['profile:name'][0]), $this->codePage).'"
332 332
 ';
333 333
         }
334
-        $fcontents .=  '
335
-Caption "' . $this->translateString(sprintf(WindowsCommon::sprintNsis(_("%s installer for %s")), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'], $attr['general:instname'][0]), $this->codePage) . '"
336
-!define APPLICATION "' . $this->translateString(sprintf(WindowsCommon::sprintNsis(_("%s installer for %s")), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'], $attr['general:instname'][0]), $this->codePage) . '"
337
-!define VERSION "' . \core\CAT::VERSION_MAJOR . '.' . \core\CAT::VERSION_MINOR . '"
334
+        $fcontents .= '
335
+Caption "' . $this->translateString(sprintf(WindowsCommon::sprintNsis(_("%s installer for %s")), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'], $attr['general:instname'][0]), $this->codePage).'"
336
+!define APPLICATION "' . $this->translateString(sprintf(WindowsCommon::sprintNsis(_("%s installer for %s")), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'], $attr['general:instname'][0]), $this->codePage).'"
337
+!define VERSION "' . \core\CAT::VERSION_MAJOR.'.'.\core\CAT::VERSION_MINOR.'"
338 338
 !define INSTALLER_NAME "installer.exe"
339
-!define LANG "' . $this->lang . '"
340
-!define LOCALE "' . preg_replace('/\..*$/', '', CONFIG['LANGUAGES'][$this->languageInstance->getLang()]['locale']) . '"
339
+!define LANG "' . $this->lang.'"
340
+!define LOCALE "' . preg_replace('/\..*$/', '', CONFIG['LANGUAGES'][$this->languageInstance->getLang()]['locale']).'"
341 341
 ;--------------------------------
342
-!define ORGANISATION "' . $this->translateString($attr['general:instname'][0], $this->codePage) . '"
342
+!define ORGANISATION "' . $this->translateString($attr['general:instname'][0], $this->codePage).'"
343 343
 ';
344 344
         $fcontents .= $this->getSupport($attr, 'email');
345 345
         $fcontents .= $this->getSupport($attr, 'url');                
@@ -347,18 +347,18 @@  discard block
 block discarded – undo
347 347
             $fcontents .= '!define WIRED
348 348
         ';
349 349
         }
350
-        $fcontents .= '!define PROVIDERID "urn:UUID:' . $this->deviceUUID . '"
350
+        $fcontents .= '!define PROVIDERID "urn:UUID:'.$this->deviceUUID.'"
351 351
 ';
352 352
         if (!empty($attr['internal:realm'][0])) {
353
-            $fcontents .= '!define REALM "' . $attr['internal:realm'][0] . '"
353
+            $fcontents .= '!define REALM "'.$attr['internal:realm'][0].'"
354 354
 ';
355 355
         }
356
-        if(!empty($attr['internal:hint_userinput_suffix'][0]) && $attr['internal:hint_userinput_suffix'][0] == 1) {
357
-            $fcontents .= '!define HINT_USER_INPUT "' . $attr['internal:hint_userinput_suffix'][0] . '"
356
+        if (!empty($attr['internal:hint_userinput_suffix'][0]) && $attr['internal:hint_userinput_suffix'][0] == 1) {
357
+            $fcontents .= '!define HINT_USER_INPUT "'.$attr['internal:hint_userinput_suffix'][0].'"
358 358
 ';
359 359
         }
360
-        if(!empty($attr['internal:verify_userinput_suffix'][0]) && $attr['internal:verify_userinput_suffix'][0] == 1) {
361
-            $fcontents .= '!define VERIFY_USER_REALM_INPUT "' . $attr['internal:verify_userinput_suffix'][0] . '"
360
+        if (!empty($attr['internal:verify_userinput_suffix'][0]) && $attr['internal:verify_userinput_suffix'][0] == 1) {
361
+            $fcontents .= '!define VERIFY_USER_REALM_INPUT "'.$attr['internal:verify_userinput_suffix'][0].'"
362 362
 ';
363 363
         }
364 364
         $fcontents .= $this->msInfoFile($attr);
@@ -379,7 +379,7 @@  discard block
 block discarded – undo
379 379
             $out .= '!define EXTERNAL_INFO "';
380 380
 //  $this->loggerInstance->debug(4,"Info file type ".$attr['support:info_file'][0]['mime']."\n");
381 381
             if ($attr['internal:info_file'][0]['mime'] == 'rtf') {
382
-                $out = '!define LICENSE_FILE "' . $attr['internal:info_file'][0]['name'];
382
+                $out = '!define LICENSE_FILE "'.$attr['internal:info_file'][0]['name'];
383 383
             } elseif ($attr['internal:info_file'][0]['mime'] == 'txt') {
384 384
                 $infoFile = file_get_contents($attr['internal:info_file'][0]['name']);
385 385
                 if ($infoFile === FALSE) {
@@ -388,14 +388,14 @@  discard block
 block discarded – undo
388 388
                 if (CONFIG_CONFASSISTANT['NSIS_VERSION'] >= 3) {
389 389
                     $infoFileConverted = $infoFile;
390 390
                 } else {
391
-                    $infoFileConverted = iconv('UTF-8', $this->codePage . '//TRANSLIT', $infoFile);
391
+                    $infoFileConverted = iconv('UTF-8', $this->codePage.'//TRANSLIT', $infoFile);
392 392
                 }
393 393
                 if ($infoFileConverted !== FALSE && strlen($infoFileConverted) > 0) {
394 394
                     file_put_contents('info_f.txt', $infoFileConverted);
395 395
                     $out = '!define LICENSE_FILE " info_f.txt';
396 396
                 }
397 397
             } else {
398
-                $out = '!define EXTERNAL_INFO "' . $attr['internal:info_file'][0]['name'];
398
+                $out = '!define EXTERNAL_INFO "'.$attr['internal:info_file'][0]['name'];
399 399
             }
400 400
 
401 401
             $out .= "\"\n";
Please login to merge, or discard this patch.