Passed
Push — master ( cca347...f9764c )
by Stefan
04:16
created
web/lib/admin/OptionDisplay.php 1 patch
Doc Comments   +11 added lines, -1 removed lines patch added patch discarded remove patch
@@ -142,6 +142,9 @@  discard block
 block discarded – undo
142 142
         return $retval;
143 143
     }
144 144
 
145
+    /**
146
+     * @param integer $rowid
147
+     */
145 148
     private function selectElement($rowid, $list) {
146 149
         $jsmagic = "onchange='
147 150
                                if (/#ML#/.test(document.getElementById(\"option-S" . $rowid . "-select\").value)) {
@@ -183,6 +186,10 @@  discard block
 block discarded – undo
183 186
         return ["TEXT" => $retval, "ACTIVE" => $activelisttype];
184 187
     }
185 188
 
189
+    /**
190
+     * @param integer $rowid
191
+     * @param boolean $makeVisible
192
+     */
186 193
     private function selectLanguage($rowid, $makeVisible) {
187 194
         $retval = "<select style='display:" . ($makeVisible ? "block" : "none") . "' name='value[S$rowid-lang]' id='S" . $rowid . "-input-langselect'>
188 195
             <option value='' name='select_language' selected>" . _("select language") . "</option>
@@ -208,6 +215,9 @@  discard block
 block discarded – undo
208 215
         OptionDisplay::TYPECODE_TEXT => ["name" => "text", "html" => "textarea cols='30' rows='3'", "tail" => '></textarea'],
209 216
     ];
210 217
 
218
+    /**
219
+     * @param integer $rowid
220
+     */
211 221
     private function inputFields($rowid, $activetype) {
212 222
         $retval = "";
213 223
         foreach (OptionDisplay::HTML_DATATYPE_TEXTS as $key => $type) {
@@ -240,7 +250,7 @@  discard block
 block discarded – undo
240 250
      * @param int $rowid the HTML field base name of the option to be displayed
241 251
      * @param string $optionName the name of the option to display
242 252
      * @param string $optionValue the value of the option to display
243
-     * @param mixed $optionLang the language of the option to display
253
+     * @param null|string $optionLang the language of the option to display
244 254
      * @return string HTML code
245 255
      * @throws Exception
246 256
      */
Please login to merge, or discard this patch.