Summary - Inspection of "there were situations where determineOuterIdString..." - GEANT/CAT - Measure and Improve Code Quality continuously with Scrutinizer

CAT

Passed

by Stefan

created 2018-05-08 09:02 UTC

	Good job, 1 issue was fixed.
D	↗	C	Device_Linux::writeConfigVars() improved

6.12

▶ ± 0

Head	Stefan Winter 2018-05-08 11:02 GMT+0200 there were situations where determineOuterIdString would return the integer 0. That's ugly, I turned it into a NULL now. FOr the Linux device, @twoln may want to check - that code didn't previously check for "0" but I think it should check for now-NULL, and only write AnonymousIdentity setting if it's not NULL
Base	Stefan Winter 2018-05-08 08:47 UTC astounding. yes, the "string" check is superfluous, we always send strings

GEANT / CAT