View GitHub Repository CAT

Schedule Inspection
Subscribe
Passed
Push — master ( 5dbba9...124299 )
by Stefan
05:46
created

Changes

Good job, 1 issue was fixed.
6.11
▶   ± 0
Head
Stefan Winter  
do the queries in the right way
Base
Stefan Winter  
Scrutinizer has a strange comment that mysqli_connect always returns a resource. Reality suggests it can also return FALSE, and the code here was making use of that. Still, maybe the better way is to use the normal DBConnection::handle() function to establish DB connections, with try / catch to fail gracefully in case of Exceptions. It also means there is no "manual" access to CONFIG by the SanityTests function any more. @twoln