View GitHub Repository CAT

Schedule Inspection
Subscribe
Passed
Push — master ( 75ab4e...5dbba9 )
by Stefan
07:16
created

Changes

1 issue (minor) was introduced.
3 issues were fixed.
C ↘ F SanityTests::databases_test() got worse
6.11
▼   -0.02
Head
Stefan Winter  
Scrutinizer has a strange comment that mysqli_connect always returns a resource. Reality suggests it can also return FALSE, and the code here was making use of that. Still, maybe the better way is to use the normal DBConnection::handle() function to establish DB connections, with try / catch to fail gracefully in case of Exceptions. It also means there is no "manual" access to CONFIG by the SanityTests function any more. @twoln
Base
Stefan Winter  
learn.to/type