Passed
Push — release_2_0 ( 932589...7e922d )
by Stefan
08:45
created
web/skins/modern/Divs.php 1 patch
Spacing   +33 added lines, -33 removed lines patch added patch discarded remove patch
@@ -49,11 +49,11 @@  discard block
 block discarded – undo
49 49
         $location = $this->Gui->skinObject->findResourceUrl("IMAGES", "consortium_logo.png");
50 50
         if ($location !== FALSE) {
51 51
             $retval .= "<div id='cat_logo'>
52
-            <a href='" . CONFIG_CONFASSISTANT['CONSORTIUM']['homepage'] . "'><img id='logo_img' src='$location' alt='Consortium Logo'/></a>
52
+            <a href='" . CONFIG_CONFASSISTANT['CONSORTIUM']['homepage']."'><img id='logo_img' src='$location' alt='Consortium Logo'/></a>
53 53
             <span>Configuration Assistant Tool</span>
54 54
             </div>";
55 55
         }
56
-        $retval .= "<div id='motd'>" . (isset(CONFIG['APPEARANCE']['MOTD']) ? CONFIG['APPEARANCE']['MOTD'] : '&nbsp') . "</div>";
56
+        $retval .= "<div id='motd'>".(isset(CONFIG['APPEARANCE']['MOTD']) ? CONFIG['APPEARANCE']['MOTD'] : '&nbsp')."</div>";
57 57
         $loc2 = $this->Gui->skinObject->findResourceUrl("IMAGES", "icons/menu.png");
58 58
         if ($loc2 !== FALSE) {
59 59
             $retval .= "<img id='hamburger' src='$loc2' alt='Menu'/>";
@@ -71,13 +71,13 @@  discard block
 block discarded – undo
71 71
     public function divUserWelcome() {
72 72
         $retval = "
73 73
 <div id='user_welcome'> <!-- this information is shown just before the download -->
74
-    <strong>" . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_PAGEHEADING] . "</strong>
74
+    <strong>" . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_PAGEHEADING]."</strong>
75 75
     <p>
76 76
     <span id='download_info'>
77 77
     <!-- the empty href is dynamically exchanged with the actual path by jQuery at runtime -->
78
-        " . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_DOWNLOAD] . "
78
+        " . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_DOWNLOAD]."
79 79
     </span>
80
-    <p>" . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_HEADING] . "
80
+    <p>" . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_HEADING]."
81 81
     <br/>
82 82
     <br/>";
83 83
         switch (CONFIG_CONFASSISTANT['CONSORTIUM']['name']) {
@@ -87,12 +87,12 @@  discard block
 block discarded – undo
87 87
         }
88 88
         $retval .= "
89 89
     </p>
90
-    <p>" . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_USAGE] . "
91
-    <p>" . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_PROBLEMS] . "
92
-    <p>" . (false ? $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_TERMS] : "") . "
90
+    <p>" . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_USAGE]."
91
+    <p>" . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_PROBLEMS]."
92
+    <p>" . (false ? $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_TERMS] : "")."
93 93
     </p>
94 94
     <p>
95
-    <a href='javascript:back_to_downloads()'><strong>" . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_BACKTODOWNLOADS] . "</strong></a>
95
+    <a href='javascript:back_to_downloads()'><strong>" . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_BACKTODOWNLOADS]."</strong></a>
96 96
     </p>
97 97
 </div> <!-- id='user_welcomer_page' -->
98 98
 ";
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
     public function divSilverbullet() {
103 103
         $retval = "
104 104
 <div id='silverbullet'>"
105
-                . $this->Gui->textTemplates->templates[user\SB_GO_AWAY] .
105
+                . $this->Gui->textTemplates->templates[user\SB_GO_AWAY].
106 106
                 "</div>
107 107
     ";
108 108
         return $retval;
@@ -115,10 +115,10 @@  discard block
 block discarded – undo
115 115
         }
116 116
         return "
117 117
 <div id='welcome_top1'>
118
-    " . $this->Gui->textTemplates->templates[user\HEADING_TOPLEVEL_GREET] . "
118
+    " . $this->Gui->textTemplates->templates[user\HEADING_TOPLEVEL_GREET]."
119 119
 </div>
120 120
 <div id='top_invite'>
121
-    " . $this->Gui->textTemplates->templates[user\HEADING_TOPLEVEL_PURPOSE] . $retval . "
121
+    " . $this->Gui->textTemplates->templates[user\HEADING_TOPLEVEL_PURPOSE].$retval."
122 122
 </div>";
123 123
     }
124 124
 
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
         $retval = "
127 127
 <div id='roller'>
128 128
     <div id='slides'>
129
-        <span id='line1'>" . $this->Gui->textTemplates->templates[user\FRONTPAGE_ROLLER_EASY] . "</span>
129
+        <span id='line1'>" . $this->Gui->textTemplates->templates[user\FRONTPAGE_ROLLER_EASY]."</span>
130 130
         <span id='line2'></span>
131 131
         <span id='line3'></span>
132 132
         <span id='line4'>";
@@ -178,9 +178,9 @@  discard block
 block discarded – undo
178 178
     public function divProfiles() {
179 179
         return "
180 180
 <div id='profiles'> <!-- this is the profile selection filled during run time -->
181
-    <div id='profiles_h' class='sub_h'>" . $this->Gui->textTemplates->templates[user\PROFILE_SELECTION] . "
181
+    <div id='profiles_h' class='sub_h'>" . $this->Gui->textTemplates->templates[user\PROFILE_SELECTION]."
182 182
     </div>" .
183
-                "<select id='profile_list'></select><div id='profile_desc' class='profile_desc'></div>" .
183
+                "<select id='profile_list'></select><div id='profile_desc' class='profile_desc'></div>".
184 184
                 "</div>";
185 185
     }
186 186
 
@@ -194,7 +194,7 @@  discard block
 block discarded – undo
194 194
     public function divInstitution($selectButton = TRUE) {
195 195
         $retval = "<div id='institution_name'>
196 196
     <span id='inst_name_span'></span> <div id='inst_extra_text'></div><!-- this will be filled with the IdP name -->" .
197
-                ($selectButton ? "<a  id='select_another' class='signin' href=\"\">" . $this->Gui->textTemplates->templates[user\INSTITUTION_SELECTION] . "</a>" : "") .
197
+                ($selectButton ? "<a  id='select_another' class='signin' href=\"\">".$this->Gui->textTemplates->templates[user\INSTITUTION_SELECTION]."</a>" : "").
198 198
                 "</div>";
199 199
         $retval .= $this->emptyImage('idp_logo', 'IdP Logo');
200 200
         return $retval;
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
     public function divOtherinstallers() {
209 209
         $retval = "
210 210
 <div class='sub_h'>
211
-    <div id='other_installers'>" . $this->Gui->textTemplates->templates[user\DOWNLOAD_CHOOSE] . "
211
+    <div id='other_installers'>" . $this->Gui->textTemplates->templates[user\DOWNLOAD_CHOOSE]."
212 212
          <table id='device_list' style='padding:0px;'>";
213 213
 
214 214
         foreach ($this->Gui->listDevices(isset($_REQUEST['hidden']) ? $_REQUEST['hidden'] : 0) as $group => $deviceGroup) {
@@ -216,18 +216,18 @@  discard block
 block discarded – undo
216 216
             $deviceIndex = 0;
217 217
 
218 218
             $imgTag = "";
219
-            $imgLocation = $this->Gui->skinObject->findResourceUrl("IMAGES", "vendorlogo/" . $group . ".png");
219
+            $imgLocation = $this->Gui->skinObject->findResourceUrl("IMAGES", "vendorlogo/".$group.".png");
220 220
             if ($imgLocation !== FALSE) {
221
-                $imgTag = '<img src="' . $imgLocation . '" alt="' . $group . ' Device" title="' . $group . ' Device">';
221
+                $imgTag = '<img src="'.$imgLocation.'" alt="'.$group.' Device" title="'.$group.' Device">';
222 222
             }
223
-            $retval .= '<tbody><tr><td class="vendor" rowspan="' . $groupIndex . '">' . $imgTag . '</td>';
223
+            $retval .= '<tbody><tr><td class="vendor" rowspan="'.$groupIndex.'">'.$imgTag.'</td>';
224 224
             foreach ($deviceGroup as $d => $D) {
225 225
                 if ($deviceIndex) {
226 226
                     $retval .= '<tr>';
227 227
                 }
228
-                $retval .= "<td><button id='" . $d . "'>" . $D['display'] . "</button>"
229
-                        . "<div class='device_info' id='info_" . $d . "'></div></td>"
230
-                        . "<td><button class='more_info_b' id='info_b_" . $d . "'>i</button></td></tr>\n";
228
+                $retval .= "<td><button id='".$d."'>".$D['display']."</button>"
229
+                        . "<div class='device_info' id='info_".$d."'></div></td>"
230
+                        . "<td><button class='more_info_b' id='info_b_".$d."'>i</button></td></tr>\n";
231 231
                 $deviceIndex++;
232 232
             }
233 233
             $retval .= "</tbody>";
@@ -241,15 +241,15 @@  discard block
 block discarded – undo
241 241
     }
242 242
 
243 243
     public function divGuessOs($operatingSystem) {
244
-        $vendorlogo = $this->Gui->skinObject->findResourceUrl("IMAGES", "vendorlogo/" . $operatingSystem['group'] . ".png");
244
+        $vendorlogo = $this->Gui->skinObject->findResourceUrl("IMAGES", "vendorlogo/".$operatingSystem['group'].".png");
245 245
         $vendorstyle = "";
246 246
         if ($vendorlogo !== FALSE) {
247
-            $vendorstyle = "style='background-image:url(\"" . $vendorlogo . "\")'";
247
+            $vendorstyle = "style='background-image:url(\"".$vendorlogo."\")'";
248 248
         }
249 249
         $deleteIcon = $this->Gui->skinObject->findResourceUrl("IMAGES", "icons/delete_32.png");
250 250
         $deleteImg = "";
251 251
         if ($deleteIcon !== FALSE) {
252
-            $deleteImg = "<img id='cross_icon_" . $operatingSystem['device'] . "' src='$deleteIcon' >";
252
+            $deleteImg = "<img id='cross_icon_".$operatingSystem['device']."' src='$deleteIcon' >";
253 253
         }
254 254
         return "
255 255
 <div class='sub_h' id='guess_os'>
@@ -257,23 +257,23 @@  discard block
 block discarded – undo
257 257
     <table id='browser'>
258 258
         <tr>
259 259
             <td>
260
-                <button class='large_button guess_os' $vendorstyle id='g_" . $operatingSystem['device'] . "'>
260
+                <button class='large_button guess_os' $vendorstyle id='g_".$operatingSystem['device']."'>
261 261
                     $deleteImg
262
-                    <div class='download_button_text_1' id='download_button_header_" . $operatingSystem['device'] . "'> " . $this->Gui->textTemplates->templates[user\DOWNLOAD_MESSAGE] . "
262
+                    <div class='download_button_text_1' id='download_button_header_".$operatingSystem['device']."'> ".$this->Gui->textTemplates->templates[user\DOWNLOAD_MESSAGE]."
263 263
                     </div>
264 264
                     <div class='download_button_text'>" .
265
-                $operatingSystem['display'] . "
265
+                $operatingSystem['display']."
266 266
                     </div>
267 267
                 </button>
268
-                <div class='device_info' id='info_g_" . $operatingSystem['device'] . "'></div>
268
+                <div class='device_info' id='info_g_" . $operatingSystem['device']."'></div>
269 269
           </td>
270 270
           <td style='vertical-align:top'>
271
-               <button class='more_info_b large_button' id='g_info_b_" . $operatingSystem['device'] . "'>i</button>
271
+               <button class='more_info_b large_button' id='g_info_b_" . $operatingSystem['device']."'>i</button>
272 272
           </td>
273 273
       </tr>
274 274
     </table> <!-- id='browser' -->
275 275
     <div class='sub_h'>
276
-       <a href='javascript:other_installers()'>" . $this->Gui->textTemplates->templates[user\DOWNLOAD_CHOOSE] . "</a>
276
+       <a href='javascript:other_installers()'>" . $this->Gui->textTemplates->templates[user\DOWNLOAD_CHOOSE]."</a>
277 277
     </div>
278 278
 </div> <!-- id='guess_os' -->";
279 279
     }
@@ -289,7 +289,7 @@  discard block
 block discarded – undo
289 289
             </td>";
290 290
 
291 291
         if (!empty(CONFIG['APPEARANCE']['privacy_notice_url'])) {
292
-            $retval .= "<td><a href='" . CONFIG['APPEARANCE']['privacy_notice_url'] . "'>" . sprintf(_("%s Privacy Notice"), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']) . "</a></td>";
292
+            $retval .= "<td><a href='".CONFIG['APPEARANCE']['privacy_notice_url']."'>".sprintf(_("%s Privacy Notice"), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'])."</a></td>";
293 293
         }
294 294
         $retval .= "<td>";
295 295
         if (CONFIG_CONFASSISTANT['CONSORTIUM']['name'] == "eduroam" && isset(CONFIG_CONFASSISTANT['CONSORTIUM']['deployment-voodoo']) && CONFIG_CONFASSISTANT['CONSORTIUM']['deployment-voodoo'] == "Operations Team") {
Please login to merge, or discard this patch.