Test Failed
Push — master ( 0ce5e6...f89993 )
by Stefan
10:35
created
devices/ms/WindowsCommon.php 1 patch
Spacing   +33 added lines, -33 removed lines patch added patch discarded remove patch
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
         if (isset(self::LANGS[$this->languageInstance->getLang()])) {
135 135
             $language = self::LANGS[$this->languageInstance->getLang()];
136 136
             $this->lang = $language['nsis'];
137
-            $this->codePage = 'cp' . $language['cp'];
137
+            $this->codePage = 'cp'.$language['cp'];
138 138
         } else {
139 139
             $this->lang = 'English';
140 140
             $this->codePage = 'cp1252';
@@ -155,8 +155,8 @@  discard block
 block discarded – undo
155 155
         $out .= sprintf(_("%s installer will be in the form of an EXE file. It will configure %s on your device, by creating wireless network profiles.<p>When you click the download button, the installer will be saved by your browser. Copy it to the machine you want to configure and execute."), \config\ConfAssistant::CONSORTIUM['display_name'], \config\ConfAssistant::CONSORTIUM['display_name']);
156 156
         $out .= "<p>";
157 157
         if ($ssidCount > $configCount) {
158
-            $out .= sprintf(ngettext("In addition to <strong>%s</strong> the installer will also configure access to:", "In addition to <strong>%s</strong> the installer will also configure access to the following networks:", $ssidCount - $configCount), implode(', ', $configList)) . " ";
159
-            $out .= '<strong>' . join('</strong>, <strong>', array_diff(array_keys($ssids), $configList)) . '</strong>';
158
+            $out .= sprintf(ngettext("In addition to <strong>%s</strong> the installer will also configure access to:", "In addition to <strong>%s</strong> the installer will also configure access to the following networks:", $ssidCount - $configCount), implode(', ', $configList))." ";
159
+            $out .= '<strong>'.join('</strong>, <strong>', array_diff(array_keys($ssids), $configList)).'</strong>';
160 160
             $out .= "<p>";
161 161
         }
162 162
 // TODO - change this below
@@ -172,8 +172,8 @@  discard block
 block discarded – undo
172 172
             $out .= _("When you are connecting to the network for the first time, Windows will pop up a login box, where you should enter your user name and password. This information will be saved so that you will reconnect to the network automatically each time you are in the range.");
173 173
             if ($ssidCount > 1) {
174 174
                 $out .= "<p>";
175
-                $out .= _("You will be required to enter the same credentials for each of the configured networks:") . " ";
176
-                $out .= '<strong>' . join('</strong>, <strong>', array_keys($ssids)) . '</strong>';
175
+                $out .= _("You will be required to enter the same credentials for each of the configured networks:")." ";
176
+                $out .= '<strong>'.join('</strong>, <strong>', array_keys($ssids)).'</strong>';
177 177
             }
178 178
         }
179 179
         return $out;
@@ -245,11 +245,11 @@  discard block
 block discarded – undo
245 245
         $logoCount = count($logosToPlace);
246 246
         if ($logoCount > 0) {
247 247
             $voffset = $freeTop;
248
-            $freeSpace = (int)round($this->background['freeHeight'] / ($logoCount + 1));
248
+            $freeSpace = (int) round($this->background['freeHeight'] / ($logoCount + 1));
249 249
             foreach ($logosToPlace as $logo) {
250 250
                 $voffset += $freeSpace;
251 251
                 $logoSize = $logo->getImageGeometry();
252
-                $hoffset = (int)round(($bgImageSize['width'] - $logoSize['width']) / 2);
252
+                $hoffset = (int) round(($bgImageSize['width'] - $logoSize['width']) / 2);
253 253
                 $bgImage->compositeImage($logo, $logo->getImageCompose(), $hoffset, $voffset);
254 254
                 $voffset += $logoSize['height'];
255 255
                 }
@@ -270,13 +270,13 @@  discard block
 block discarded – undo
270 270
      * @return string path to signed installer
271 271
      */
272 272
     protected function signInstaller() {
273
-        $fileName = $this->installerBasename . '.exe';
273
+        $fileName = $this->installerBasename.'.exe';
274 274
         if (!$this->sign) {
275 275
             rename("installer.exe", $fileName);
276 276
             return $fileName;
277 277
         }
278 278
         // are actually signing
279
-        $outputFromSigning = system($this->sign . " installer.exe '$fileName' > /dev/null");
279
+        $outputFromSigning = system($this->sign." installer.exe '$fileName' > /dev/null");
280 280
         if ($outputFromSigning === FALSE) {
281 281
             $this->loggerInstance->debug(2, "Signing the WindowsCommon installer $fileName FAILED!\n");
282 282
         }
@@ -290,15 +290,15 @@  discard block
 block discarded – undo
290 290
      */
291 291
     protected function compileNSIS() {
292 292
         if (\config\ConfAssistant::NSIS_VERSION >= 3) {
293
-            $makensis = \config\ConfAssistant::PATHS['makensis'] . " -INPUTCHARSET UTF8";
293
+            $makensis = \config\ConfAssistant::PATHS['makensis']." -INPUTCHARSET UTF8";
294 294
         } else {
295 295
             $makensis = \config\ConfAssistant::PATHS['makensis'];
296 296
         }
297 297
         $lcAll = getenv("LC_ALL");
298 298
         putenv("LC_ALL=en_US.UTF-8");
299
-        $command = $makensis . ' -V4 cat.NSI > nsis.log 2>&1';
299
+        $command = $makensis.' -V4 cat.NSI > nsis.log 2>&1';
300 300
         system($command);
301
-        putenv("LC_ALL=" . $lcAll);
301
+        putenv("LC_ALL=".$lcAll);
302 302
         $this->loggerInstance->debug(4, "compileNSIS:$command\n");
303 303
     }
304 304
 
@@ -314,10 +314,10 @@  discard block
 block discarded – undo
314 314
             'email' => 'SUPPORT',
315 315
             'url' => 'URL',
316 316
         ];
317
-        $s = "support_" . $type . "_substitute";
317
+        $s = "support_".$type."_substitute";
318 318
         $substitute = $this->translateString($this->$s, $this->codePage);
319
-        $returnValue = !empty($attr['support:' . $type][0]) ? $attr['support:' .  $type][0] : $substitute;
320
-        return '!define ' . $supportString[$type] . ' "' . $returnValue . '"' . "\n";
319
+        $returnValue = !empty($attr['support:'.$type][0]) ? $attr['support:'.$type][0] : $substitute;
320
+        return '!define '.$supportString[$type].' "'.$returnValue.'"'."\n";
321 321
     }
322 322
     
323 323
     /**
@@ -327,20 +327,20 @@  discard block
 block discarded – undo
327 327
      * @return string
328 328
      */
329 329
     protected function writeNsisDefines($attr) {
330
-        $fcontents = "\n" . '!define NSIS_MAJOR_VERSION ' . \config\ConfAssistant::NSIS_VERSION;
330
+        $fcontents = "\n".'!define NSIS_MAJOR_VERSION '.\config\ConfAssistant::NSIS_VERSION;
331 331
         if ($attr['internal:profile_count'][0] > 1) {
332
-            $fcontents .= "\n" . '!define USER_GROUP "' . $this->translateString(str_replace('"', '$\\"', $attr['profile:name'][0]), $this->codePage) . '"
332
+            $fcontents .= "\n".'!define USER_GROUP "'.$this->translateString(str_replace('"', '$\\"', $attr['profile:name'][0]), $this->codePage).'"
333 333
 ';
334 334
         }
335
-        $fcontents .=  '
336
-Caption "' . $this->translateString(sprintf(WindowsCommon::sprintNsis(_("%s installer for %s")), \config\ConfAssistant::CONSORTIUM['display_name'], $attr['general:instname'][0]), $this->codePage) . '"
337
-!define APPLICATION "' . $this->translateString(sprintf(WindowsCommon::sprintNsis(_("%s installer for %s")), \config\ConfAssistant::CONSORTIUM['display_name'], $attr['general:instname'][0]), $this->codePage) . '"
338
-!define VERSION "' . \core\CAT::VERSION_MAJOR . '.' . \core\CAT::VERSION_MINOR . '"
335
+        $fcontents .= '
336
+Caption "' . $this->translateString(sprintf(WindowsCommon::sprintNsis(_("%s installer for %s")), \config\ConfAssistant::CONSORTIUM['display_name'], $attr['general:instname'][0]), $this->codePage).'"
337
+!define APPLICATION "' . $this->translateString(sprintf(WindowsCommon::sprintNsis(_("%s installer for %s")), \config\ConfAssistant::CONSORTIUM['display_name'], $attr['general:instname'][0]), $this->codePage).'"
338
+!define VERSION "' . \core\CAT::VERSION_MAJOR.'.'.\core\CAT::VERSION_MINOR.'"
339 339
 !define INSTALLER_NAME "installer.exe"
340
-!define LANG "' . $this->lang . '"
341
-!define LOCALE "' . preg_replace('/\..*$/', '', \config\Master::LANGUAGES[$this->languageInstance->getLang()]['locale']) . '"
340
+!define LANG "' . $this->lang.'"
341
+!define LOCALE "' . preg_replace('/\..*$/', '', \config\Master::LANGUAGES[$this->languageInstance->getLang()]['locale']).'"
342 342
 ;--------------------------------
343
-!define ORGANISATION "' . $this->translateString($attr['general:instname'][0], $this->codePage) . '"
343
+!define ORGANISATION "' . $this->translateString($attr['general:instname'][0], $this->codePage).'"
344 344
 ';
345 345
         $fcontents .= $this->getSupport($attr, 'email');
346 346
         $fcontents .= $this->getSupport($attr, 'url');                
@@ -348,18 +348,18 @@  discard block
 block discarded – undo
348 348
             $fcontents .= '!define WIRED
349 349
         ';
350 350
         }
351
-        $fcontents .= '!define PROVIDERID "urn:UUID:' . $this->deviceUUID . '"
351
+        $fcontents .= '!define PROVIDERID "urn:UUID:'.$this->deviceUUID.'"
352 352
 ';
353 353
         if (!empty($attr['internal:realm'][0])) {
354
-            $fcontents .= '!define REALM "' . $attr['internal:realm'][0] . '"
354
+            $fcontents .= '!define REALM "'.$attr['internal:realm'][0].'"
355 355
 ';
356 356
         }
357
-        if(!empty($attr['internal:hint_userinput_suffix'][0]) && $attr['internal:hint_userinput_suffix'][0] == 1) {
358
-            $fcontents .= '!define HINT_USER_INPUT "' . $attr['internal:hint_userinput_suffix'][0] . '"
357
+        if (!empty($attr['internal:hint_userinput_suffix'][0]) && $attr['internal:hint_userinput_suffix'][0] == 1) {
358
+            $fcontents .= '!define HINT_USER_INPUT "'.$attr['internal:hint_userinput_suffix'][0].'"
359 359
 ';
360 360
         }
361
-        if(!empty($attr['internal:verify_userinput_suffix'][0]) && $attr['internal:verify_userinput_suffix'][0] == 1) {
362
-            $fcontents .= '!define VERIFY_USER_REALM_INPUT "' . $attr['internal:verify_userinput_suffix'][0] . '"
361
+        if (!empty($attr['internal:verify_userinput_suffix'][0]) && $attr['internal:verify_userinput_suffix'][0] == 1) {
362
+            $fcontents .= '!define VERIFY_USER_REALM_INPUT "'.$attr['internal:verify_userinput_suffix'][0].'"
363 363
 ';
364 364
         }
365 365
         $fcontents .= $this->msInfoFile($attr);
@@ -380,7 +380,7 @@  discard block
 block discarded – undo
380 380
             $out .= '!define EXTERNAL_INFO "';
381 381
 //  $this->loggerInstance->debug(4,"Info file type ".$attr['support:info_file'][0]['mime']."\n");
382 382
             if ($attr['internal:info_file'][0]['mime'] == 'rtf') {
383
-                $out = '!define LICENSE_FILE "' . $attr['internal:info_file'][0]['name'];
383
+                $out = '!define LICENSE_FILE "'.$attr['internal:info_file'][0]['name'];
384 384
             } elseif ($attr['internal:info_file'][0]['mime'] == 'txt') {
385 385
                 $infoFile = file_get_contents($attr['internal:info_file'][0]['name']);
386 386
                 if ($infoFile === FALSE) {
@@ -389,14 +389,14 @@  discard block
 block discarded – undo
389 389
                 if (\config\ConfAssistant::NSIS_VERSION >= 3) {
390 390
                     $infoFileConverted = $infoFile;
391 391
                 } else {
392
-                    $infoFileConverted = iconv('UTF-8', $this->codePage . '//TRANSLIT', $infoFile);
392
+                    $infoFileConverted = iconv('UTF-8', $this->codePage.'//TRANSLIT', $infoFile);
393 393
                 }
394 394
                 if ($infoFileConverted !== FALSE && strlen($infoFileConverted) > 0) {
395 395
                     file_put_contents('info_f.txt', $infoFileConverted);
396 396
                     $out = '!define LICENSE_FILE " info_f.txt';
397 397
                 }
398 398
             } else {
399
-                $out = '!define EXTERNAL_INFO "' . $attr['internal:info_file'][0]['name'];
399
+                $out = '!define EXTERNAL_INFO "'.$attr['internal:info_file'][0]['name'];
400 400
             }
401 401
 
402 402
             $out .= "\"\n";
Please login to merge, or discard this patch.
utils/notify_invitation_expiry.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 
22 22
 // please run this as a cron job every hour
23 23
 
24
-require_once dirname(dirname(__FILE__)) . "/config/_config.php";
24
+require_once dirname(dirname(__FILE__))."/config/_config.php";
25 25
 
26 26
 // iterate through all federations and see if there are recently expired 
27 27
 // invitations for any of them
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
     $admins = $this_fed->listFederationAdmins();
56 56
     $mailtext = "Hello,
57 57
 
58
-invitation tokens for the following new ". \config\ConfAssistant::CONSORTIUM['nomenclature_institution'] ." have recently expired:
58
+invitation tokens for the following new ". \config\ConfAssistant::CONSORTIUM['nomenclature_institution']." have recently expired:
59 59
 
60 60
 ";
61 61
     foreach ($listofinstnames as $instname) {
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
     if ($numberofexistingidps > 0) {
66 66
         $mailtext .= "
67 67
 
68
-Additionally, $numberofexistingidps invitations for an existing ". \config\ConfAssistant::CONSORTIUM['nomenclature_institution']." have expired.
68
+Additionally, $numberofexistingidps invitations for an existing ".\config\ConfAssistant::CONSORTIUM['nomenclature_institution']." have expired.
69 69
         ";
70 70
     }
71 71
     $mailtext .= "
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 
74 74
 Greetings,
75 75
 
76
-A humble " . \config\Master::APPEARANCE['productname'] . " cron job
76
+A humble " . \config\Master::APPEARANCE['productname']." cron job
77 77
 ";
78 78
 
79 79
     foreach ($admins as $admin) {
Please login to merge, or discard this patch.
config/Master-template.php 2 patches
Indentation   -1 removed lines patch added patch discarded remove patch
@@ -148,7 +148,6 @@
 block discarded – undo
148 148
          *    mails, just configure the signing cert with these parameters. All must
149 149
          *    be non-NULL for signing to happen. If you don't need a keypass, make 
150 150
          *    it an empty string instead.
151
-
152 151
          * @var array
153 152
          */
154 153
         const MAILSETTINGS = [// we always use Submission
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -214,7 +214,7 @@  discard block
 block discarded – undo
214 214
                 'db' => 'cat',
215 215
                 'user' => 'someuser',
216 216
                 'pass' => 'somepass',
217
-                'readonly' => FALSE,],
217
+                'readonly' => FALSE, ],
218 218
             // this DB stores diagnostics data. The connection details can be
219 219
             // identical to INST as there is no table overlap
220 220
             'DIAGNOSTICS' => [
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
                 'db' => 'cat',
223 223
                 'user' => 'someuser',
224 224
                 'pass' => 'somepass',
225
-                'readonly' => FALSE,],
225
+                'readonly' => FALSE, ],
226 226
             // this slice of DB user is about the downloads table. The corresponding
227 227
             // DB user should have write access to update statistics and the cache
228 228
             // locations of installers. 
@@ -232,7 +232,7 @@  discard block
 block discarded – undo
232 232
                 'db' => 'cat',
233 233
                 'user' => 'someuser',
234 234
                 'pass' => 'somepass',
235
-                'readonly' => FALSE,],
235
+                'readonly' => FALSE, ],
236 236
             // this slice of DB use is about user management in the user_options
237 237
             // table. Giving the corresponding user only read-only access means that
238 238
             // all user properties have to "magically" occur in the table by OOB
@@ -243,7 +243,7 @@  discard block
 block discarded – undo
243 243
                 'db' => 'cat',
244 244
                 'user' => 'someuser',
245 245
                 'pass' => 'somepass',
246
-                'readonly' => FALSE,],
246
+                'readonly' => FALSE, ],
247 247
             /*   If you use this tool in conjunction with an external customer management database, you can configure that every 
248 248
              * institution entry in CAT MUST correspond to a customer entry in an external database. If you want this, set this
249 249
              * config variable to TRUE.
@@ -263,7 +263,7 @@  discard block
 block discarded – undo
263 263
                 'db' => 'customer_db',
264 264
                 'user' => 'customerservice',
265 265
                 'pass' => '2lame4u',
266
-                'readonly' => TRUE,],
266
+                'readonly' => TRUE, ],
267 267
             'enforce-external-sync' => TRUE,
268 268
         ];
269 269
         /**
Please login to merge, or discard this patch.
web/resources/css/cat.css.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
  *          <base_url>/copyright.php after deploying the software
20 20
  */
21 21
 
22
-require dirname(dirname(dirname(dirname(__FILE__)))) . "/config/_config.php";
22
+require dirname(dirname(dirname(dirname(__FILE__))))."/config/_config.php";
23 23
 $colour1 = \config\Master::APPEARANCE['colour1'];
24 24
 $colour2 = \config\Master::APPEARANCE['colour2'];
25 25
 header('Content-type: text/css; charset=utf-8');
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
 }
30 30
 
31 31
 body {
32
-    background: <?php echo $colour1;?>;
32
+    background: <?php echo $colour1; ?>;
33 33
     color: #000000;
34 34
     font-family:Verdana, Arial, Helvetica, sans-serif;
35 35
     font-size:11px;
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
 }
45 45
 
46 46
 button {
47
-    background: <?php echo $colour2;?>; 
47
+    background: <?php echo $colour2; ?>; 
48 48
     color: #FFFFFF; 
49 49
     min-height: 23px;
50 50
     border-left-style: outset; 
@@ -395,7 +395,7 @@  discard block
 block discarded – undo
395 395
 
396 396
 span.edu_cat {
397 397
     font-weight: bold;
398
-    color: <?php echo $colour2;?>;
398
+    color: <?php echo $colour2; ?>;
399 399
 }
400 400
 
401 401
 span.tooltip {
@@ -491,7 +491,7 @@  discard block
 block discarded – undo
491 491
     border-bottom-style:solid;
492 492
     border-top-width:5px; 
493 493
     border-bottom-width:5px; 
494
-    border-color: <?php echo $colour1;?>; 
494
+    border-color: <?php echo $colour1; ?>; 
495 495
     padding-left:30px;
496 496
 }
497 497
 
@@ -561,7 +561,7 @@  discard block
 block discarded – undo
561 561
 }
562 562
 
563 563
 #close_button {
564
-    background: <?php echo $colour2;?>; 
564
+    background: <?php echo $colour2; ?>; 
565 565
     color: #FFFFFF; 
566 566
     height: 23px;
567 567
     border-left-style: inset; 
@@ -636,7 +636,7 @@  discard block
 block discarded – undo
636 636
     width: 30em; 
637 637
     padding-left: 10px; 
638 638
     padding-right: 0px; 
639
-    background: <?php echo $colour2;?>; 
639
+    background: <?php echo $colour2; ?>; 
640 640
     color: white; 
641 641
     box-shadow: 10px 10px 5px #888888;
642 642
 }
@@ -683,7 +683,7 @@  discard block
 block discarded – undo
683 683
     padding-top: 4px; 
684 684
     padding-bottom: 12px; 
685 685
     padding-left: 30px; 
686
-    background: <?php echo $colour1;?>; 
686
+    background: <?php echo $colour1; ?>; 
687 687
     text-align: left; 
688 688
     text-shadow: 10px 10px 5px #888888;
689 689
 }
@@ -693,9 +693,9 @@  discard block
 block discarded – undo
693 693
     border-bottom-style:solid;
694 694
     border-top-width:5px;
695 695
     border-bottom-width:5px;
696
-    border-color: <?php echo $colour1;?>;
696
+    border-color: <?php echo $colour1; ?>;
697 697
     padding-left:30px;
698
-    color: <?php echo $colour2;?>;
698
+    color: <?php echo $colour2; ?>;
699 699
 }
700 700
 
701 701
 #heading h1 { 
@@ -714,7 +714,7 @@  discard block
 block discarded – undo
714 714
     text-align: justify;
715 715
     border-bottom-style:solid;
716 716
     border-bottom-width:5px;
717
-    border-color: <?php echo $colour1;?>;
717
+    border-color: <?php echo $colour1; ?>;
718 718
     font-size: 11px;
719 719
     font-weight: normal;
720 720
 }
@@ -761,7 +761,7 @@  discard block
 block discarded – undo
761 761
 
762 762
 #faq {
763 763
     padding: 20px;
764
-    color: <?php echo $colour2;?>;
764
+    color: <?php echo $colour2; ?>;
765 765
     background: #ffffff;
766 766
 }
767 767
 
@@ -813,7 +813,7 @@  discard block
 block discarded – undo
813 813
 
814 814
 #line1 {
815 815
     top:145px;
816
-    color: <?php echo $colour2;?>;
816
+    color: <?php echo $colour2; ?>;
817 817
     font-size:20px;
818 818
 }
819 819
 
@@ -860,7 +860,7 @@  discard block
 block discarded – undo
860 860
 
861 861
 #front_page_leftmenu {
862 862
     border-right:solid; 
863
-    border-color: <?php echo $colour1;?>; 
863
+    border-color: <?php echo $colour1; ?>; 
864 864
     border-width:5px; 
865 865
     min-height:400px; 
866 866
     padding-left: 10px; 
@@ -885,11 +885,11 @@  discard block
 block discarded – undo
885 885
 }
886 886
 
887 887
 a:link {
888
-    color:<?php echo $colour2;?>;
888
+    color:<?php echo $colour2; ?>;
889 889
 }
890 890
 
891 891
 a:visited {
892
-    color:<?php echo $colour2;?>;
892
+    color:<?php echo $colour2; ?>;
893 893
 }
894 894
 
895 895
 a:hover {
@@ -897,7 +897,7 @@  discard block
 block discarded – undo
897 897
 }
898 898
 
899 899
 a:active {
900
-    color:<?php echo $colour2;?>;
900
+    color:<?php echo $colour2; ?>;
901 901
 }
902 902
 
903 903
 .comment {
Please login to merge, or discard this patch.
web/diag/diag.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -42,8 +42,8 @@
 block discarded – undo
42 42
     $auth->authenticate();
43 43
 }
44 44
 if (isset($_SESSION['admin_diag_auth'])) {
45
-   $admin =  1;
46
-   unset($_SESSION['admin_diag_auth']);
45
+    $admin =  1;
46
+    unset($_SESSION['admin_diag_auth']);
47 47
 }
48 48
 $Gui = new \web\lib\user\Gui();
49 49
 $skinObject = new \web\lib\user\Skinjob($_REQUEST['skin'] ?? $_SESSION['skin'] ?? $fedskin[0] ?? \config\Master::APPEARANCE['skins'][0]);
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
  *          <base_url>/copyright.php after deploying the software
20 20
  */
21 21
 
22
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
22
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
23 23
 $admin = filter_input(INPUT_GET, 'admin', FILTER_VALIDATE_INT);
24 24
 $auth = new \web\lib\admin\Authentication();
25 25
 $isauth = 0;
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
             unset($q_el[$idx]);
34 34
             $q_r = preg_replace("/\?.*/", "", $_SERVER['REQUEST_URI']);
35 35
             if (count($q_el)) {
36
-                $q_r = $q_r . '?' . implode('&', $q_el);
36
+                $q_r = $q_r.'?'.implode('&', $q_el);
37 37
             }
38 38
             $_SERVER['REQUEST_URI'] = $q_r;
39 39
         }
@@ -42,11 +42,11 @@  discard block
 block discarded – undo
42 42
     $auth->authenticate();
43 43
 }
44 44
 if (isset($_SESSION['admin_diag_auth'])) {
45
-   $admin =  1;
45
+   $admin = 1;
46 46
    unset($_SESSION['admin_diag_auth']);
47 47
 }
48 48
 $Gui = new \web\lib\user\Gui();
49 49
 $skinObject = new \web\lib\user\Skinjob($_REQUEST['skin'] ?? $_SESSION['skin'] ?? $fedskin[0] ?? \config\Master::APPEARANCE['skins'][0]);
50
-require "../skins/" . $skinObject->skin . "/diag/diag.php";
50
+require "../skins/".$skinObject->skin."/diag/diag.php";
51 51
 
52 52
 
Please login to merge, or discard this patch.
web/diag/action_realmcheck.php 1 patch
Spacing   +57 added lines, -57 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
  *          <base_url>/copyright.php after deploying the software
20 20
  */
21 21
 
22
-require_once dirname(dirname(__DIR__)) . "/config/_config.php";
22
+require_once dirname(dirname(__DIR__))."/config/_config.php";
23 23
 
24 24
 $loggerInstance = new \core\common\Logging();
25 25
 
@@ -55,13 +55,13 @@  discard block
 block discarded – undo
55 55
         $testsuite = new \core\diag\RADIUSTests($check_realm, $my_profile->getRealmCheckOuterUsername(), $my_profile->getEapMethodsinOrderOfPreference(1), $my_profile->getCollapsedAttributes()['eap:server_name'], $my_profile->getCollapsedAttributes()["eap:ca_file"]);
56 56
         $rfc7585suite = new \core\diag\RFC7585Tests($check_realm);
57 57
     } else {
58
-        $error_message = _("You asked for a realm check, but we don't know the realm for this profile!") . "</p>";
58
+        $error_message = _("You asked for a realm check, but we don't know the realm for this profile!")."</p>";
59 59
     }
60 60
 } else { // someone else's realm... only shallow checks
61 61
     $check_realm = $validator->realm($realm ?? $_SESSION['check_realm'] ?? "");
62 62
     if ($check_realm !== FALSE) {
63 63
         $_SESSION['check_realm'] = $check_realm;
64
-        $testsuite = new \core\diag\RADIUSTests($check_realm, "@" . $check_realm);
64
+        $testsuite = new \core\diag\RADIUSTests($check_realm, "@".$check_realm);
65 65
         $rfc7585suite = new \core\diag\RFC7585Tests($check_realm);
66 66
     } else {
67 67
         $error_message = _("No valid realm name given, cannot execute any checks!");
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
     var listofcas = "<?php echo _("You should update your list of accredited CAs") ?>";
110 110
     var getitfrom = "<?php echo _("Get it from here.") ?>";
111 111
     var listsource = "<?php echo \config\Diagnostics::RADIUSTESTS['accreditedCAsURL'] ?>";
112
-    var moretext = "<?php echo _("more") . "&raquo;" ?>";
112
+    var moretext = "<?php echo _("more")."&raquo;" ?>";
113 113
     var lesstext = "<?php echo "&laquo" ?>";
114 114
     var morealltext = "<?php echo _("Show detailed information for all tests") ?>";
115 115
     var unknownca_code = "<?php echo \core\diag\RADIUSTests::CERTPROB_UNKNOWN_CA ?>";
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
                         }
247 247
                     }
248 248
                     cliinfo = cliinfo + '<li><table><tbody><tr><td class="icon_td"><img class="icon" src="' + icons[level] + '" style="width: 24px;"></td><td>' + state;
249
-                    cliinfo = cliinfo + ' <?php echo "(" . sprintf(_("elapsed time: %sms."), "'+data.ca[key].certificate[c].time_millisec+'&nbsp;") . ")"; ?>' + add + '</td></tr>';
249
+                    cliinfo = cliinfo + ' <?php echo "(".sprintf(_("elapsed time: %sms."), "'+data.ca[key].certificate[c].time_millisec+'&nbsp;").")"; ?>' + add + '</td></tr>';
250 250
                     cliinfo = cliinfo + '</tbody></table></ul></li>';
251 251
                     if (data.ca[key].certificate[c].finalerror === 1) {
252 252
                         cliinfo = cliinfo + '<li>' + restskipped + '</li>';
@@ -416,8 +416,8 @@  discard block
 block discarded – undo
416 416
 <?php
417 417
 foreach (\config\Diagnostics::RADIUSTESTS['UDP-hosts'] as $hostindex => $host) {
418 418
     print "
419
-$(\"#live_src" . $hostindex . "_img\").attr('src',icon_loading);
420
-$(\"#live_src" . $hostindex . "_img\").show();
419
+$(\"#live_src" . $hostindex."_img\").attr('src',icon_loading);
420
+$(\"#live_src" . $hostindex."_img\").show();
421 421
     $.ajax({
422 422
         url: 'radius_tests.php?src=0&hostindex=$hostindex&realm='+realm,
423 423
         type: 'POST',
@@ -447,15 +447,15 @@  discard block
 block discarded – undo
447 447
 <?php
448 448
 foreach (\config\Diagnostics::RADIUSTESTS['UDP-hosts'] as $hostindex => $host) {
449 449
     if ($my_profile !== NULL) {
450
-        $extraarg = "profile_id: " . $my_profile->identifier . ", ";
450
+        $extraarg = "profile_id: ".$my_profile->identifier.", ";
451 451
     } else {
452 452
         $extraarg = "";
453 453
     }
454 454
     print "
455
-$(\"#src" . $hostindex . "_img\").attr('src',icon_loading);
455
+$(\"#src" . $hostindex."_img\").attr('src',icon_loading);
456 456
 $(\"#src$hostindex\").html('');
457 457
 running_ajax_stat++;
458
-$.get('radius_tests.php',{test_type: 'udp', $extraarg realm: realm, src: $hostindex, lang: '" . $gui->languageInstance->getLang() . "', hostindex: '$hostindex'  }, udp, 'json');
458
+$.get('radius_tests.php',{test_type: 'udp', $extraarg realm: realm, src: $hostindex, lang: '".$gui->languageInstance->getLang()."', hostindex: '$hostindex'  }, udp, 'json');
459 459
 
460 460
 ";
461 461
 }
@@ -482,7 +482,7 @@  discard block
 block discarded – undo
482 482
     if ($check_realm === FALSE) {
483 483
         print "<p>$error_message</p>";
484 484
     } else {
485
-        print "<h1>" . sprintf(_("Realm testing for: %s"), $check_realm) . "</h1>\n";
485
+        print "<h1>".sprintf(_("Realm testing for: %s"), $check_realm)."</h1>\n";
486 486
         ?>
487 487
         <div id="debug_out" style="display: none"></div>
488 488
         <div id="tabs" style="min-width: 600px; max-width:800px">
@@ -499,12 +499,12 @@  discard block
 block discarded – undo
499 499
                     </legend>
500 500
                     <?php
501 501
                     // NAPTR existence check
502
-                    echo "<strong>" . _("DNS chekcs") . "</strong><div>";
502
+                    echo "<strong>"._("DNS chekcs")."</strong><div>";
503 503
                     $naptr = $rfc7585suite->relevantNAPTR();
504 504
                     if ($naptr != \core\diag\RADIUSTests::RETVAL_NOTCONFIGURED) {
505 505
                         echo "<table>";
506 506
                         // output in friendly words
507
-                        echo "<tr><td>" . _("Checking NAPTR existence:") . "</td><td>";
507
+                        echo "<tr><td>"._("Checking NAPTR existence:")."</td><td>";
508 508
                         switch ($naptr) {
509 509
                             case \core\diag\RFC7585Tests::RETVAL_NONAPTR:
510 510
                                 echo _("This realm has no NAPTR records.");
@@ -519,7 +519,7 @@  discard block
 block discarded – undo
519 519
 
520 520
                         // compliance checks for NAPTRs
521 521
                         if ($naptr > 0) {
522
-                            echo "<tr><td>" . _("Checking NAPTR compliance (flag = S and regex = {empty}):") . "</td><td>";
522
+                            echo "<tr><td>"._("Checking NAPTR compliance (flag = S and regex = {empty}):")."</td><td>";
523 523
                             $naptr_valid = $rfc7585suite->relevantNAPTRcompliance();
524 524
                             switch ($naptr_valid) {
525 525
                                 case \core\diag\RADIUSTests::RETVAL_OK:
@@ -536,7 +536,7 @@  discard block
 block discarded – undo
536 536
 
537 537
                         if ($naptr > 0 && $naptr_valid == \core\diag\RADIUSTests::RETVAL_OK) {
538 538
                             $srv = $rfc7585suite->relevantNAPTRsrvResolution();
539
-                            echo "<tr><td>" . _("Checking SRVs:") . "</td><td>";
539
+                            echo "<tr><td>"._("Checking SRVs:")."</td><td>";
540 540
                             switch ($srv) {
541 541
                                 case \core\diag\RADIUSTests::RETVAL_SKIPPED:
542 542
                                     echo _("This check was skipped.");
@@ -552,7 +552,7 @@  discard block
 block discarded – undo
552 552
                         // IP addresses for the hosts
553 553
                         if ($naptr > 0 && $naptr_valid == \core\diag\RADIUSTests::RETVAL_OK && $srv > 0) {
554 554
                             $hosts = $rfc7585suite->relevantNAPTRhostnameResolution();
555
-                            echo "<tr><td>" . _("Checking IP address resolution:") . "</td><td>";
555
+                            echo "<tr><td>"._("Checking IP address resolution:")."</td><td>";
556 556
                             switch ($srv) {
557 557
                                 case \core\diag\RADIUSTests::RETVAL_SKIPPED:
558 558
                                     echo _("This check was skipped.");
@@ -568,12 +568,12 @@  discard block
 block discarded – undo
568 568
 
569 569
                         echo "</table><br/><br/>";
570 570
                         if (count($testsuite->listerrors()) == 0) {
571
-                            echo sprintf(_("Realm is <strong>%s</strong> "), _(($naptr > 0 ? "DYNAMIC" : "STATIC"))) . _("with no DNS errors encountered. Congratulations!");
571
+                            echo sprintf(_("Realm is <strong>%s</strong> "), _(($naptr > 0 ? "DYNAMIC" : "STATIC")))._("with no DNS errors encountered. Congratulations!");
572 572
                         } else {
573
-                            echo sprintf(_("Realm is <strong>%s</strong> "), _(($naptr > 0 ? "DYNAMIC" : "STATIC"))) . _("but there were DNS errors! Check them!") . " " . _("You should re-run the tests after fixing the errors; more errors might be uncovered at that point. The exact error causes are listed below.");
573
+                            echo sprintf(_("Realm is <strong>%s</strong> "), _(($naptr > 0 ? "DYNAMIC" : "STATIC")))._("but there were DNS errors! Check them!")." "._("You should re-run the tests after fixing the errors; more errors might be uncovered at that point. The exact error causes are listed below.");
574 574
                             echo "<div class='notacceptable'><table>";
575 575
                             foreach ($testsuite->listerrors() as $details) {
576
-                                echo "<tr><td>" . $details['TYPE'] . "</td><td>" . $details['TARGET'] . "</td></tr>";
576
+                                echo "<tr><td>".$details['TYPE']."</td><td>".$details['TARGET']."</td></tr>";
577 577
                             }
578 578
                             echo "</table></div>";
579 579
                         }
@@ -589,25 +589,25 @@  discard block
 block discarded – undo
589 589
                  $("#dynamic_tests").show();
590 590
               ';
591 591
                         foreach ($rfc7585suite->NAPTR_hostname_records as $hostindex => $addr) {
592
-                            $host = ($addr['family'] == "IPv6" ? "[" : "") . $addr['IP'] . ($addr['family'] == "IPv6" ? "]" : "") . ":" . $addr['port'];
592
+                            $host = ($addr['family'] == "IPv6" ? "[" : "").$addr['IP'].($addr['family'] == "IPv6" ? "]" : "").":".$addr['port'];
593 593
                             print "
594 594
                             running_ajax_dyn++;
595
-                            $.ajax({url:'radius_tests.php', data:{test_type: 'capath', realm: realm, src: '$host', lang: '" . $gui->languageInstance->getLang() . "', hostindex: '$hostindex' }, error: eee, success: capath, dataType: 'json'}); 
595
+                            $.ajax({url:'radius_tests.php', data:{test_type: 'capath', realm: realm, src: '$host', lang: '".$gui->languageInstance->getLang()."', hostindex: '$hostindex' }, error: eee, success: capath, dataType: 'json'}); 
596 596
                             running_ajax_dyn++;
597
-                            $.ajax({url:'radius_tests.php', data:{test_type: 'clients', realm: realm, src: '$host', lang: '" . $gui->languageInstance->getLang() . "', hostindex: '$hostindex' }, error: eee, success: clients, dataType: 'json'}); 
597
+                            $.ajax({url:'radius_tests.php', data:{test_type: 'clients', realm: realm, src: '$host', lang: '".$gui->languageInstance->getLang()."', hostindex: '$hostindex' }, error: eee, success: clients, dataType: 'json'}); 
598 598
                        ";
599 599
                         }
600 600
                         echo "}
601 601
               </script><hr>";
602 602
                     } else {
603
-                        echo "<tr><td>" . _("Dynamic discovery test is not configured") . "</td><td>";
603
+                        echo "<tr><td>"._("Dynamic discovery test is not configured")."</td><td>";
604 604
                     }
605
-                    echo "<strong>" . _("Static connectivity tests") . "</strong>
605
+                    echo "<strong>"._("Static connectivity tests")."</strong>
606 606
          <table><tr>
607 607
          <td class='icon_td'><img src='../resources/images/icons/loading51.gif' id='main_static_ico' class='icon'></td><td id='main_static_result' style='display:none'>&nbsp;</td>
608 608
          </tr></table>";
609 609
                     if ($naptr > 0) {
610
-                        echo "<hr><strong>" . _("Dynamic connectivity tests") . "</strong>
610
+                        echo "<hr><strong>"._("Dynamic connectivity tests")."</strong>
611 611
          <table><tr>
612 612
          <td class='icon_td'><img src='../resources/images/icons/loading51.gif' id='main_dynamic_ico' class='icon'></td><td id='main_dynamic_result' style='display:none'>&nbsp;</td>
613 613
          </tr></table>";
@@ -627,12 +627,12 @@  discard block
 block discarded – undo
627 627
                     print "<p>";
628 628
                     foreach (\config\Diagnostics::RADIUSTESTS['UDP-hosts'] as $hostindex => $host) {
629 629
                         print "<hr>";
630
-                        printf(_("Testing from: %s"), "<strong>" . \config\Diagnostics::RADIUSTESTS['UDP-hosts'][$hostindex]['display_name'] . "</strong>");
630
+                        printf(_("Testing from: %s"), "<strong>".\config\Diagnostics::RADIUSTESTS['UDP-hosts'][$hostindex]['display_name']."</strong>");
631 631
                         print "<table id='results$hostindex'  style='width:100%' class='udp_results'>
632 632
 <tr>
633
-<td class='icon_td'><img src='../resources/images/icons/loading51.gif' id='src" . $hostindex . "_img'></td>
633
+<td class='icon_td'><img src='../resources/images/icons/loading51.gif' id='src".$hostindex."_img'></td>
634 634
 <td id='src$hostindex' colspan=2>
635
-" . _("testing...") . "
635
+"._("testing...")."
636 636
 </td>
637 637
 </tr>
638 638
 </table>";
@@ -651,21 +651,21 @@  discard block
 block discarded – undo
651 651
 
652 652
                     <?php
653 653
                     echo "<div id='dynamic_tests'><fieldset class='option_container'>
654
-                <legend><strong>" . _("DYNAMIC connectivity tests") . "</strong></legend>";
654
+                <legend><strong>" . _("DYNAMIC connectivity tests")."</strong></legend>";
655 655
 
656 656
                     $resultstoprint = [];
657 657
                     if (count($rfc7585suite->NAPTR_hostname_records) > 0) {
658
-                        $resultstoprint[] = '<table style="align:right; display: none;" id="dynamic_result_fail">' . _("Some errors were found during the tests, see below") . '</table><table style="align:right; display: none;" id="dynamic_result_pass">' . _("All tests passed, congratulations!") . '</table>';
659
-                        $resultstoprint[] = '<div style="align:right;"><a href="" class="moreall">' . _('Show detailed information for all tests') . '</a></div>' . '<p><strong>' . _("Checking server handshake...") . "</strong><p>";
658
+                        $resultstoprint[] = '<table style="align:right; display: none;" id="dynamic_result_fail">'._("Some errors were found during the tests, see below").'</table><table style="align:right; display: none;" id="dynamic_result_pass">'._("All tests passed, congratulations!").'</table>';
659
+                        $resultstoprint[] = '<div style="align:right;"><a href="" class="moreall">'._('Show detailed information for all tests').'</a></div>'.'<p><strong>'._("Checking server handshake...")."</strong><p>";
660 660
                         foreach ($rfc7585suite->NAPTR_hostname_records as $hostindex => $addr) {
661
-                            $bracketaddr = ($addr["family"] == "IPv6" ? "[" . $addr["IP"] . "]" : $addr["IP"]);
662
-                            $resultstoprint[] = '<p><strong>' . $bracketaddr . ' TCP/' . $addr['port'] . '</strong>';
661
+                            $bracketaddr = ($addr["family"] == "IPv6" ? "[".$addr["IP"]."]" : $addr["IP"]);
662
+                            $resultstoprint[] = '<p><strong>'.$bracketaddr.' TCP/'.$addr['port'].'</strong>';
663 663
                             $resultstoprint[] = '<ul style="list-style-type: none;" class="caresult"><li>';
664 664
                             $resultstoprint[] = "<table id='caresults$hostindex'  style='width:100%'>
665 665
 <tr>
666
-<td class='icon_td'><img src='../resources/images/icons/loading51.gif' id='srcca" . $hostindex . "_img'></td>
666
+<td class='icon_td'><img src='../resources/images/icons/loading51.gif' id='srcca".$hostindex."_img'></td>
667 667
 <td id='srcca$hostindex'>
668
-" . _("testing...") . "
668
+"._("testing...")."
669 669
 </td>
670 670
 </tr>
671 671
 </table>";
@@ -673,12 +673,12 @@  discard block
 block discarded – undo
673 673
                         }
674 674
                         $clientstest = [];
675 675
                         foreach ($rfc7585suite->NAPTR_hostname_records as $hostindex => $addr) {
676
-                            $clientstest[] = '<p><strong>' . $addr['IP'] . ' TCP/' . $addr['port'] . '</strong></p><ol>';
676
+                            $clientstest[] = '<p><strong>'.$addr['IP'].' TCP/'.$addr['port'].'</strong></p><ol>';
677 677
                             $clientstest[] = "<span id='clientresults$hostindex$clinx'><table style='width:100%'>
678 678
 <tr>
679
-<td class='icon_td'><img src='../resources/images/icons/loading51.gif' id='srcclient" . $hostindex . "_img'></td>
679
+<td class='icon_td'><img src='../resources/images/icons/loading51.gif' id='srcclient".$hostindex."_img'></td>
680 680
 <td id='srcclient$hostindex'>
681
-" . _("testing...") . "
681
+"._("testing...")."
682 682
 </td>
683 683
 </tr>
684 684
 </table></span>";
@@ -686,7 +686,7 @@  discard block
 block discarded – undo
686 686
                         }
687 687
                         echo '<div style="align:right;">';
688 688
                         echo join('', $resultstoprint);
689
-                        echo '<span id="clientstest" style="display: none;"><p><hr><b>' . _('Checking if certificates from  CAs are accepted...') . '</b><p>' . _('A few client certificates will be tested to check if servers are resistant to some certificate problems.') . '<p>';
689
+                        echo '<span id="clientstest" style="display: none;"><p><hr><b>'._('Checking if certificates from  CAs are accepted...').'</b><p>'._('A few client certificates will be tested to check if servers are resistant to some certificate problems.').'<p>';
690 690
                         print join('', $clientstest);
691 691
                         echo '</span>';
692 692
                         echo '</div>';
@@ -700,7 +700,7 @@  discard block
 block discarded – undo
700 700
                 //     check if truncates/dies on Operator-Name
701 701
                 if ($my_profile !== NULL) {
702 702
                     echo "<div id='tabs-4'><fieldset class='option_container'>
703
-                <legend><strong>" . _("Live login test") . "</strong></legend>";
703
+                <legend><strong>" . _("Live login test")."</strong></legend>";
704 704
                     $prof_compl = $my_profile->getEapMethodsinOrderOfPreference(1);
705 705
                     if (count($prof_compl) > 0) {
706 706
                         $passwordReqired = FALSE;
@@ -713,34 +713,34 @@  discard block
 block discarded – undo
713 713
                                 $clientCertRequired = TRUE;
714 714
                             }
715 715
                         }
716
-                        echo "<div id='disposable_credential_container'><p>" . _("If you enter an existing login credential here, you can test the actual authentication from various checkpoints all over the world.") . "</p>
717
-                    <p>" . _("The test will use all EAP types you have set in your profile information to check whether the right CAs and server names are used, and of course whether the login with these credentials and the given EAP type actually worked. If you have set anonymous outer ID, the test will use that.") . "</p>
718
-                    <p>" . _("Note: the tool purposefully does not offer you to save these credentials, and they will never be saved in any way on the server side. Please use only <strong>temporary test accounts</strong> here; permanently valid test accounts in the wild are considered harmful!") . "</p></div>
716
+                        echo "<div id='disposable_credential_container'><p>"._("If you enter an existing login credential here, you can test the actual authentication from various checkpoints all over the world.")."</p>
717
+                    <p>" . _("The test will use all EAP types you have set in your profile information to check whether the right CAs and server names are used, and of course whether the login with these credentials and the given EAP type actually worked. If you have set anonymous outer ID, the test will use that.")."</p>
718
+                    <p>" . _("Note: the tool purposefully does not offer you to save these credentials, and they will never be saved in any way on the server side. Please use only <strong>temporary test accounts</strong> here; permanently valid test accounts in the wild are considered harmful!")."</p></div>
719 719
                     <form enctype='multipart/form-data' id='live_form' accept-charset='UTF-8'>
720 720
                     <input type='hidden' name='test_type' value='udp_login'>
721
-                    <input type='hidden' name='lang' value='" . $gui->languageInstance->getLang() . "'>
722
-                    <input type='hidden' name='profile_id' value='" . $my_profile->identifier . "'>
721
+                    <input type='hidden' name='lang' value='" . $gui->languageInstance->getLang()."'>
722
+                    <input type='hidden' name='profile_id' value='" . $my_profile->identifier."'>
723 723
                     <table id='live_tests'>";
724 724
 // if any password based EAP methods are available enable this section
725 725
                         if ($passwordReqired) {
726
-                            echo "<tr><td colspan='2'><strong>" . _("Password-based EAP types") . "</strong></td></tr>
727
-                        <tr><td>" . _("Real (inner) username:") . "</td><td><input type='text' id='username' class='mandatory' name='username'/></td></tr>";
728
-                            echo "<tr><td>" . _("Anonymous outer ID (optional):") . "</td><td><input type='text' id='outer_username' name='outer_username'/></td></tr>";
729
-                            echo "<tr><td>" . _("Password:") . "</td><td><input type='text' id='password' class='mandatory' name='password'/></td></tr>";
726
+                            echo "<tr><td colspan='2'><strong>"._("Password-based EAP types")."</strong></td></tr>
727
+                        <tr><td>" . _("Real (inner) username:")."</td><td><input type='text' id='username' class='mandatory' name='username'/></td></tr>";
728
+                            echo "<tr><td>"._("Anonymous outer ID (optional):")."</td><td><input type='text' id='outer_username' name='outer_username'/></td></tr>";
729
+                            echo "<tr><td>"._("Password:")."</td><td><input type='text' id='password' class='mandatory' name='password'/></td></tr>";
730 730
                         }
731 731
                         // ask for cert + privkey if TLS-based method is active
732 732
                         if ($clientCertRequired) {
733
-                            echo "<tr><td colspan='2'><strong>" . _("Certificate-based EAP types") . "</strong></td></tr>
734
-                        <tr><td>" . _("Certificate file (.p12 or .pfx):") . "</td><td><input type='file' id='cert' accept='application/x-pkcs12' name='cert'/></td></tr>
735
-                        <tr><td>" . _("Certificate password, if any:") . "</td><td><input type='text' id='privkey' name='privkey_pass'/></td></tr>
736
-                        <tr><td>" . _("Username, if different from certificate Subject:") . "</td><td><input type='text' id='tls_username' name='tls_username'/></td></tr>";
733
+                            echo "<tr><td colspan='2'><strong>"._("Certificate-based EAP types")."</strong></td></tr>
734
+                        <tr><td>" . _("Certificate file (.p12 or .pfx):")."</td><td><input type='file' id='cert' accept='application/x-pkcs12' name='cert'/></td></tr>
735
+                        <tr><td>" . _("Certificate password, if any:")."</td><td><input type='text' id='privkey' name='privkey_pass'/></td></tr>
736
+                        <tr><td>" . _("Username, if different from certificate Subject:")."</td><td><input type='text' id='tls_username' name='tls_username'/></td></tr>";
737 737
                         }
738
-                        echo "<tr><td colspan='2'><button id='submit_credentials'>" . _("Submit credentials") . "</button></td></tr></table></form>";
738
+                        echo "<tr><td colspan='2'><button id='submit_credentials'>"._("Submit credentials")."</button></td></tr></table></form>";
739 739
                         echo "<div id='live_login_results' style='display:none'>";
740 740
                         foreach (\config\Diagnostics::RADIUSTESTS['UDP-hosts'] as $hostindex => $host) {
741 741
                             print "<hr>";
742
-                            printf(_("Testing from: %s"), "<strong>" . \config\Diagnostics::RADIUSTESTS['UDP-hosts'][$hostindex]['display_name'] . "</strong>");
743
-                            print "<span style='position:relative'><img src='../resources/images/icons/loading51.gif' id='live_src" . $hostindex . "_img' style='width:24px; position: absolute; left: 20px; bottom: 0px; '></span>";
742
+                            printf(_("Testing from: %s"), "<strong>".\config\Diagnostics::RADIUSTESTS['UDP-hosts'][$hostindex]['display_name']."</strong>");
743
+                            print "<span style='position:relative'><img src='../resources/images/icons/loading51.gif' id='live_src".$hostindex."_img' style='width:24px; position: absolute; left: 20px; bottom: 0px; '></span>";
744 744
                             print "<div id='eap_test$hostindex' class='eap_test_results'></div>";
745 745
                         }
746 746
                         echo "</div>";
@@ -757,7 +757,7 @@  discard block
 block discarded – undo
757 757
             if (isset($_POST['comefrom'])) {
758 758
                 $return = htmlspecialchars_decode($_POST['comefrom'])."?inst_id=".$my_inst->identifier;
759 759
                 echo "<form method='post' action='$return' accept-charset='UTF-8'>
760
-                    <button type='submit' name='submitbutton' value='" . web\lib\common\FormElements::BUTTON_CLOSE . "'>" . sprintf(_("Return to %s administrator area"), core\common\Entity::$nomenclature_inst) . "</button>"
760
+                    <button type='submit' name='submitbutton' value='".web\lib\common\FormElements::BUTTON_CLOSE."'>".sprintf(_("Return to %s administrator area"), core\common\Entity::$nomenclature_inst)."</button>"
761 761
                 . "</form>";
762 762
             }
763 763
             if ($check_realm !== FALSE) {
Please login to merge, or discard this patch.
web/admin/edit_participant.php 1 patch
Spacing   +31 added lines, -31 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
  *          <base_url>/copyright.php after deploying the software
20 20
  */
21 21
 
22
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
22
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
23 23
 
24 24
 $auth = new \web\lib\admin\Authentication();
25 25
 $deco = new \web\lib\admin\PageDecoration();
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 $inst_name = $my_inst->name;
40 40
 
41 41
 if ($wizardStyle) {
42
-    echo $deco->defaultPagePrelude(sprintf(_("%s: %s enrollment wizard (step 2)"), \config\Master::APPEARANCE['productname'],  $uiElements->nomenclatureParticipant));
42
+    echo $deco->defaultPagePrelude(sprintf(_("%s: %s enrollment wizard (step 2)"), \config\Master::APPEARANCE['productname'], $uiElements->nomenclatureParticipant));
43 43
 } else {
44 44
     echo $deco->defaultPagePrelude(sprintf(_("%s: Editing %s '%s'"), \config\Master::APPEARANCE['productname'], $uiElements->nomenclatureParticipant, $inst_name));
45 45
 }
@@ -94,12 +94,12 @@  discard block
 block discarded – undo
94 94
         </table>
95 95
     </div>
96 96
     <?php
97
-    echo "<form enctype='multipart/form-data' action='edit_participant_result.php?inst_id=$my_inst->identifier" . ($wizardStyle ? "&wizard=true" : "") . "' method='post' accept-charset='UTF-8'>
98
-              <input type='hidden' name='MAX_FILE_SIZE' value='" . \config\Master::CONFIG['MAX_UPLOAD_SIZE'] . "'>";
97
+    echo "<form enctype='multipart/form-data' action='edit_participant_result.php?inst_id=$my_inst->identifier".($wizardStyle ? "&wizard=true" : "")."' method='post' accept-charset='UTF-8'>
98
+              <input type='hidden' name='MAX_FILE_SIZE' value='" . \config\Master::CONFIG['MAX_UPLOAD_SIZE']."'>";
99 99
 
100 100
     if ($wizardStyle) {
101
-        echo "<p>" .
102
-        sprintf(_("Hello, newcomer. The %s is new to us. This wizard will ask you several questions about it, so that we can generate beautiful profiles for you in the end. All of the information below is optional, but it is important to fill out as many fields as possible for the benefit of your end users."), $uiElements->nomenclatureParticipant) . "</p>";
101
+        echo "<p>".
102
+        sprintf(_("Hello, newcomer. The %s is new to us. This wizard will ask you several questions about it, so that we can generate beautiful profiles for you in the end. All of the information below is optional, but it is important to fill out as many fields as possible for the benefit of your end users."), $uiElements->nomenclatureParticipant)."</p>";
103 103
     }
104 104
     $optionDisplay = new web\lib\admin\OptionDisplay($idpoptions, "IdP");
105 105
     ?>
@@ -107,11 +107,11 @@  discard block
 block discarded – undo
107 107
         <legend><strong><?php echo _("General Information"); ?></strong></legend>
108 108
         <?php
109 109
         if ($wizardStyle) {
110
-            echo "<p>" .
111
-            _("Some properties are valid across all deployment profiles. This is the place where you can describe those properties in a fine-grained way. The solicited information is used as follows:") . "</p>
110
+            echo "<p>".
111
+            _("Some properties are valid across all deployment profiles. This is the place where you can describe those properties in a fine-grained way. The solicited information is used as follows:")."</p>
112 112
                       <ul>
113
-                         <li>" . _("<strong>Logo</strong>: When you submit a logo, we will embed this logo into all installers where a custom logo is possible. We accept any image format, but for best results, we suggest SVG. If you don't upload a logo, we will use the generic logo instead (see top-right corner of this page).") . "</li>
114
-                         <li>" . sprintf(_("<strong>Name</strong>: The %s may have names in multiple languages. It is recommended to always populate at least the 'default/other' language, as it is used as a fallback if the system does not have a name in the exact language the user requests a download in."),$uiElements->nomenclatureParticipant) . "</li>";
113
+                         <li>" . _("<strong>Logo</strong>: When you submit a logo, we will embed this logo into all installers where a custom logo is possible. We accept any image format, but for best results, we suggest SVG. If you don't upload a logo, we will use the generic logo instead (see top-right corner of this page).")."</li>
114
+                         <li>" . sprintf(_("<strong>Name</strong>: The %s may have names in multiple languages. It is recommended to always populate at least the 'default/other' language, as it is used as a fallback if the system does not have a name in the exact language the user requests a download in."), $uiElements->nomenclatureParticipant)."</li>";
115 115
             echo "</ul>";
116 116
         }
117 117
         echo $optionDisplay->prefilledOptionTable("general");
@@ -125,47 +125,47 @@  discard block
 block discarded – undo
125 125
         <legend><strong><?php echo _("Media Properties"); ?></strong></legend>
126 126
         <?php
127 127
         if ($wizardStyle) {
128
-            echo "<p>" .
129
-            sprintf(_("In this section, you define on which media %s should be configured on user devices."), \config\ConfAssistant::CONSORTIUM['display_name']) . "</p>
128
+            echo "<p>".
129
+            sprintf(_("In this section, you define on which media %s should be configured on user devices."), \config\ConfAssistant::CONSORTIUM['display_name'])."</p>
130 130
           <ul>";
131 131
             echo "<li>";
132
-            echo "<strong>" . ( count(\config\ConfAssistant::CONSORTIUM['ssid']) > 0 ? _("Additional SSIDs:") : _("SSIDs:")) . " </strong>";
132
+            echo "<strong>".(count(\config\ConfAssistant::CONSORTIUM['ssid']) > 0 ? _("Additional SSIDs:") : _("SSIDs:"))." </strong>";
133 133
             if (count(\config\ConfAssistant::CONSORTIUM['ssid']) > 0) {
134 134
                 $ssidlist = "";
135 135
                 foreach (\config\ConfAssistant::CONSORTIUM['ssid'] as $ssid) {
136
-                    $ssidlist .= ", '<strong>" . $ssid . "</strong>'";
136
+                    $ssidlist .= ", '<strong>".$ssid."</strong>'";
137 137
                 }
138 138
                 $ssidlist = substr($ssidlist, 2);
139 139
                 echo sprintf(ngettext("We will always configure this SSID for WPA2/AES: %s.", "We will always configure these SSIDs for WPA2/AES: %s.", count(\config\ConfAssistant::CONSORTIUM['ssid'])), $ssidlist);
140 140
                 if (\config\ConfAssistant::CONSORTIUM['tkipsupport']) {
141
-                    echo " " . _("They will also be configured for WPA/TKIP if the device supports multiple encryption types.");
141
+                    echo " "._("They will also be configured for WPA/TKIP if the device supports multiple encryption types.");
142 142
                 }
143
-                echo "<br/>" . sprintf(_("It is also possible to define custom additional SSIDs with the options '%s' and '%s' below."), $uiElements->displayName("media:SSID"), $uiElements->displayName("media:SSID_with_legacy"));
143
+                echo "<br/>".sprintf(_("It is also possible to define custom additional SSIDs with the options '%s' and '%s' below."), $uiElements->displayName("media:SSID"), $uiElements->displayName("media:SSID_with_legacy"));
144 144
             } else {
145 145
                 echo _("Please configure which SSIDs should be configured in the installers.");
146 146
             }
147
-            echo " " . _("By default, we will only configure the SSIDs with WPA2/AES encryption. By using the '(with WPA/TKIP)' option you can specify that we should include legacy support for WPA/TKIP where possible.");
147
+            echo " "._("By default, we will only configure the SSIDs with WPA2/AES encryption. By using the '(with WPA/TKIP)' option you can specify that we should include legacy support for WPA/TKIP where possible.");
148 148
             echo "</li>";
149 149
 
150 150
             echo "<li>";
151
-            echo "<strong>" . ( count(\config\ConfAssistant::CONSORTIUM['ssid']) > 0 ? _("Additional Hotspot 2.0 / Passpoint Consortia:") : _("Hotspot 2.0 / Passpoint Consortia:")) . " </strong>";
151
+            echo "<strong>".(count(\config\ConfAssistant::CONSORTIUM['ssid']) > 0 ? _("Additional Hotspot 2.0 / Passpoint Consortia:") : _("Hotspot 2.0 / Passpoint Consortia:"))." </strong>";
152 152
             if (count(\config\ConfAssistant::CONSORTIUM['interworking-consortium-oi']) > 0) {
153 153
                 $consortiumlist = "";
154 154
                 foreach (\config\ConfAssistant::CONSORTIUM['interworking-consortium-oi'] as $oi) {
155
-                    $consortiumlist .= ", '<strong>" . $oi . "</strong>'";
155
+                    $consortiumlist .= ", '<strong>".$oi."</strong>'";
156 156
                 }
157 157
                 $consortiumlist = substr($consortiumlist, 2);
158 158
                 echo sprintf(ngettext("We will always configure this Consortium OI: %s.", "We will always configure these Consortium OIs: %s.", count(\config\ConfAssistant::CONSORTIUM['interworking-consortium-oi'])), $consortiumlist);
159 159
 
160
-                echo "<br/>" . sprintf(_("It is also possible to define custom additional OIs with the option '%s' below."), $uiElements->displayName("media:consortium_OI"));
160
+                echo "<br/>".sprintf(_("It is also possible to define custom additional OIs with the option '%s' below."), $uiElements->displayName("media:consortium_OI"));
161 161
             } else {
162 162
                 echo _("Please configure which Consortium OIs should be configured in the installers.");
163 163
             }
164 164
             echo "</li>";
165
-            echo "<li><strong>" . _("Support for wired IEEE 802.1X:") . " </strong>"
166
-            . _("If you want to configure your users' devices with IEEE 802.1X support for wired ethernet, please check the corresponding box. Note that this makes the installation process a bit more difficult on some platforms (Windows: needs administrator privileges; Apple: attempting to install a profile with wired support on a device without an active wired ethernet card will fail).") .
165
+            echo "<li><strong>"._("Support for wired IEEE 802.1X:")." </strong>"
166
+            . _("If you want to configure your users' devices with IEEE 802.1X support for wired ethernet, please check the corresponding box. Note that this makes the installation process a bit more difficult on some platforms (Windows: needs administrator privileges; Apple: attempting to install a profile with wired support on a device without an active wired ethernet card will fail).").
167 167
             "</li>";
168
-            echo "<li><strong>" . _("Removal of bootstrap/onboarding SSIDs:") . " </strong>"
168
+            echo "<li><strong>"._("Removal of bootstrap/onboarding SSIDs:")." </strong>"
169 169
             . _("If you use a captive portal to distribute configurations, you may want to unconfigure/disable that SSID after the bootstrap process. With this option, the SSID will either be removed, or be defined as 'Only connect manually'.")
170 170
             . "</li>";
171 171
             echo "</ul>";
@@ -181,16 +181,16 @@  discard block
 block discarded – undo
181 181
             echo "<p>"._("This section can be used to upload specific Terms of Use for your users and to display details of how your users can reach your local helpdesk.")."</p>";
182 182
             
183 183
             if (\config\Master::CONFIG['FUNCTIONALITY_LOCATIONS']['CONFASSISTANT_RADIUS'] == "LOCAL") {
184
-                echo "<p>" .
184
+                echo "<p>".
185 185
                         
186
-                sprintf(_("Do you provide helpdesk services for your users? If so, it would be nice if you would tell us the pointers to this helpdesk."),$uiElements->nomenclatureParticipant)  . "</p>" .
187
-                "<p>" .
188
-                _("If you enter a value here, it will be added to the installers for all your users, and will be displayed on the download page. If you operate separate helpdesks for different user groups (we call this 'profiles') specify per-profile helpdesk information later in this wizard. If you operate no help desk at all, just leave these fields empty.") . "</p>";
186
+                sprintf(_("Do you provide helpdesk services for your users? If so, it would be nice if you would tell us the pointers to this helpdesk."), $uiElements->nomenclatureParticipant)."</p>".
187
+                "<p>".
188
+                _("If you enter a value here, it will be added to the installers for all your users, and will be displayed on the download page. If you operate separate helpdesks for different user groups (we call this 'profiles') specify per-profile helpdesk information later in this wizard. If you operate no help desk at all, just leave these fields empty.")."</p>";
189 189
                 if (\config\Master::CONFIG['FUNCTIONALITY_LOCATIONS']['CONFASSISTANT_SILVERBULLET'] == "LOCAL") {
190
-                echo "<p>" . sprintf(_("For %s deployments, providing at least a local e-mail contact is required."), core\ProfileSilverbullet::PRODUCTNAME) ." " . _("This is the contact point for your end users' level 1 support.") . "</p>";
190
+                echo "<p>".sprintf(_("For %s deployments, providing at least a local e-mail contact is required."), core\ProfileSilverbullet::PRODUCTNAME)." "._("This is the contact point for your end users' level 1 support.")."</p>";
191 191
                 }
192 192
             } elseif (\config\Master::CONFIG['FUNCTIONALITY_LOCATIONS']['CONFASSISTANT_SILVERBULLET'] == "LOCAL") {
193
-                echo "<p>". _("Providing at least a local support e-mail contact is required.")." "._("This is the contact point for your end users' level 1 support.")."</p>";
193
+                echo "<p>"._("Providing at least a local support e-mail contact is required.")." "._("This is the contact point for your end users' level 1 support.")."</p>";
194 194
             }
195 195
             
196 196
         }
@@ -200,8 +200,8 @@  discard block
 block discarded – undo
200 200
         <button type='button' class='newoption' onclick='getXML("support")'><?php echo _("Add new option"); ?></button></fieldset>
201 201
     <?php
202 202
     if ($wizardStyle) {
203
-        echo "<p>" . sprintf(_("When you are sure that everything is correct, please click on %sContinue ...%s"), "<button type='submit' name='submitbutton' value='" . web\lib\common\FormElements::BUTTON_CONTINUE . "'>", "</button>") . "</p></form>";
203
+        echo "<p>".sprintf(_("When you are sure that everything is correct, please click on %sContinue ...%s"), "<button type='submit' name='submitbutton' value='".web\lib\common\FormElements::BUTTON_CONTINUE."'>", "</button>")."</p></form>";
204 204
     } else {
205
-        echo "<div><button type='submit' name='submitbutton' value='" . web\lib\common\FormElements::BUTTON_SAVE . "'>" . _("Save data") . "</button> <button type='button' class='delete' name='abortbutton' value='abort' onclick='javascript:window.location = \"overview_user.php\"'>" . _("Discard changes") . "</button></div></form>";
205
+        echo "<div><button type='submit' name='submitbutton' value='".web\lib\common\FormElements::BUTTON_SAVE."'>"._("Save data")."</button> <button type='button' class='delete' name='abortbutton' value='abort' onclick='javascript:window.location = \"overview_user.php\"'>"._("Discard changes")."</button></div></form>";
206 206
     }
207 207
     echo $deco->footer();
Please login to merge, or discard this patch.
web/admin/overview_federation.php 1 patch
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
  *          <base_url>/copyright.php after deploying the software
20 20
  */
21 21
 
22
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
22
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
23 23
 
24 24
 $deco = new \web\lib\admin\PageDecoration();
25 25
 $uiElements = new web\lib\admin\UIElements();
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
             <?php echo $uiElements->infoblock($user->getAttributes(), "user", "User"); ?>
48 48
             <tr>
49 49
                 <td>
50
-                    <?php echo "" . _("Unique Identifier") ?>
50
+                    <?php echo ""._("Unique Identifier") ?>
51 51
                 </td>
52 52
                 <td>
53 53
                 </td>
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
     $mgmt = new \core\UserManagement();
63 63
 
64 64
     if (!$user->isFederationAdmin()) {
65
-        echo "<p>" . sprintf(_("You are not a %s manager."), $uiElements->nomenclatureFed) . "</p>";
65
+        echo "<p>".sprintf(_("You are not a %s manager."), $uiElements->nomenclatureFed)."</p>";
66 66
         echo $deco->footer();
67 67
         exit(0);
68 68
     }
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
                 <!-- fed properties -->
80 80
                 <tr>
81 81
                     <td>
82
-                        <?php echo "" . _("Country") ?>
82
+                        <?php echo ""._("Country") ?>
83 83
                     </td>
84 84
                     <td>
85 85
                     </td>
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
                     default:
161 161
                         throw new Exception("Error: unknown encryption status of invitation!?!");
162 162
                 }
163
-                echo $uiElements->boxRemark(ngettext("The invitation email was sent successfully.", "All invitation emails were sent successfully.", $counter) . " " . $cryptText, _("Sent successfully."));
163
+                echo $uiElements->boxRemark(ngettext("The invitation email was sent successfully.", "All invitation emails were sent successfully.", $counter)." ".$cryptText, _("Sent successfully."));
164 164
                 break;
165 165
             case "FAILURE":
166 166
                 echo $uiElements->boxError(_("No invitation email could be sent!"), _("Sending failure!"));
@@ -180,7 +180,7 @@  discard block
 block discarded – undo
180 180
                     default:
181 181
                         throw new Exception("Error: unknown encryption status of invitation!?!");
182 182
                 }
183
-                echo $uiElements->boxWarning(sprintf(_("Some invitation emails were sent successfully (%s in total), the others failed."), $counter) . " " . $cryptText, _("Partial success."));
183
+                echo $uiElements->boxWarning(sprintf(_("Some invitation emails were sent successfully (%s in total), the others failed."), $counter)." ".$cryptText, _("Partial success."));
184 184
                 break;
185 185
             case "INVALIDSYNTAX":
186 186
                 echo $uiElements->boxError(_("The invitation email address was malformed, no invitation was sent!"), _("The invitation email address was malformed, no invitation was sent!"));
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
         echo "</table></div>";
192 192
     }
193 193
     if (\config\ConfAssistant::CONSORTIUM['name'] == 'eduroam') {
194
-        $helptext = "<h3>" . sprintf(_("Need help? Refer to the <a href='%s'>%s manual</a>"), "https://wiki.geant.org/x/fgBwBg", $uiElements->nomenclatureFed) . "</h3>";
194
+        $helptext = "<h3>".sprintf(_("Need help? Refer to the <a href='%s'>%s manual</a>"), "https://wiki.geant.org/x/fgBwBg", $uiElements->nomenclatureFed)."</h3>";
195 195
     } else {
196 196
         $helptext = "";
197 197
     }
@@ -205,7 +205,7 @@  discard block
 block discarded – undo
205 205
             $pending_invites = $mgmt->listPendingInvitations();
206 206
 
207 207
             if (\config\Master::DB['enforce-external-sync']) {
208
-                echo "<th>" . sprintf(_("%s Database Sync Status"), \config\ConfAssistant::CONSORTIUM['display_name']) . "</th>";
208
+                echo "<th>".sprintf(_("%s Database Sync Status"), \config\ConfAssistant::CONSORTIUM['display_name'])."</th>";
209 209
             }
210 210
             ?>
211 211
             <th>
@@ -220,7 +220,7 @@  discard block
 block discarded – undo
220 220
         foreach ($feds as $onefed) {
221 221
             $thefed = new \core\Federation(strtoupper($onefed['value']));
222 222
             /// nomenclature for 'federation', federation name, nomenclature for 'inst'
223
-            echo "<tr><td colspan='8'><strong>" . sprintf(_("The following %s are in your %s %s:"), $uiElements->nomenclatureInst, $uiElements->nomenclatureFed, '<span style="color:green">' . $thefed->name . '</span>') . "</strong></td></tr>";
223
+            echo "<tr><td colspan='8'><strong>".sprintf(_("The following %s are in your %s %s:"), $uiElements->nomenclatureInst, $uiElements->nomenclatureFed, '<span style="color:green">'.$thefed->name.'</span>')."</strong></td></tr>";
224 224
 
225 225
             // extract only pending invitations for *this* fed
226 226
             $display_pendings = FALSE;
@@ -245,27 +245,27 @@  discard block
 block discarded – undo
245 245
                 // deployment status; need to dive into profiles for this
246 246
                 // show happy eyeballs if at least one profile is configured/showtime                    
247 247
                 echo "<td>";
248
-                echo ($idp_instance->maxProfileStatus() >= \core\IdP::PROFILES_CONFIGURED ? "C" : "" ) . " " . ($idp_instance->maxProfileStatus() >= \core\IdP::PROFILES_SHOWTIME ? "V" : "" );
248
+                echo ($idp_instance->maxProfileStatus() >= \core\IdP::PROFILES_CONFIGURED ? "C" : "")." ".($idp_instance->maxProfileStatus() >= \core\IdP::PROFILES_SHOWTIME ? "V" : "");
249 249
                 echo "</td>";
250 250
                 // name
251 251
                 echo "<td>
252
-                         <input type='hidden' name='inst' value='" . $index . "'>" . $idp_instance->name . "
252
+                         <input type='hidden' name='inst' value='" . $index."'>".$idp_instance->name."
253 253
                       </td>";
254 254
                 // external DB sync, if configured as being necessary
255 255
                 if (\config\Master::DB['enforce-external-sync']) {
256 256
                     echo "<td style='display: ruby;'>";
257 257
                     if ($readonly === FALSE) {
258
-                        echo "<form method='post' action='inc/manageDBLink.inc.php?inst_id=" . $idp_instance->identifier . "' onsubmit='popupRedirectWindow(this); return false;' accept-charset='UTF-8'>
259
-                                    <button type='submit'>" . _("Manage DB Link") . "</button></form>&nbsp;&nbsp;";
258
+                        echo "<form method='post' action='inc/manageDBLink.inc.php?inst_id=".$idp_instance->identifier."' onsubmit='popupRedirectWindow(this); return false;' accept-charset='UTF-8'>
259
+                                    <button type='submit'>" . _("Manage DB Link")."</button></form>&nbsp;&nbsp;";
260 260
                     }
261 261
                     switch ($idp_instance->getExternalDBSyncState()) {
262 262
                         case \core\IdP::EXTERNAL_DB_SYNCSTATE_NOTSUBJECTTOSYNCING:
263 263
                             break;
264 264
                         case \core\IdP::EXTERNAL_DB_SYNCSTATE_SYNCED:
265
-                            echo "<div class='acceptable'>" . _("Linked") . "</div>";
265
+                            echo "<div class='acceptable'>"._("Linked")."</div>";
266 266
                             break;
267 267
                         case \core\IdP::EXTERNAL_DB_SYNCSTATE_NOT_SYNCED:
268
-                            echo "<div class='notacceptable'>" . _("NOT linked") . "</div>";
268
+                            echo "<div class='notacceptable'>"._("NOT linked")."</div>";
269 269
 
270 270
 
271 271
                             break;
@@ -278,9 +278,9 @@  discard block
 block discarded – undo
278 278
                 echo "<td>";
279 279
                 if ($readonly === FALSE) {
280 280
                     echo "<div style='white-space: nowrap;'>
281
-                                  <form method='post' action='inc/manageAdmins.inc.php?inst_id=" . $index . "' onsubmit='popupRedirectWindow(this); return false;' accept-charset='UTF-8'>
281
+                                  <form method='post' action='inc/manageAdmins.inc.php?inst_id=" . $index."' onsubmit='popupRedirectWindow(this); return false;' accept-charset='UTF-8'>
282 282
                                       <button type='submit'>" .
283
-                    _("Add/Remove Administrators") . "
283
+                    _("Add/Remove Administrators")."
284 284
                                       </button>
285 285
                                   </form>
286 286
                                 </div>";
@@ -293,7 +293,7 @@  discard block
 block discarded – undo
293 293
                 echo "<tr>
294 294
                             <td colspan='2'>
295 295
                                <strong>" .
296
-                sprintf(_("Pending invitations in the %s:"), $uiElements->nomenclatureFed) . "
296
+                sprintf(_("Pending invitations in the %s:"), $uiElements->nomenclatureFed)."
297 297
                                </strong>
298 298
                             </td>
299 299
                          </tr>";
@@ -301,17 +301,17 @@  discard block
 block discarded – undo
301 301
                     if (strtoupper($oneinvite['country']) == strtoupper($thefed->tld)) {
302 302
                         echo "<tr>
303 303
                                     <td>" .
304
-                        $oneinvite['name'] . "
304
+                        $oneinvite['name']."
305 305
                                     </td>
306 306
                                     <td>" .
307
-                        $oneinvite['mail'] . "
307
+                        $oneinvite['mail']."
308 308
                                     </td>
309 309
                                     <td colspan=2>";
310 310
                         if ($readonly === FALSE) {
311 311
                             echo "<form method='post' action='overview_federation.php' accept-charset='UTF-8'>
312
-                                <input type='hidden' name='invitation_id' value='" . $oneinvite['token'] . "'/>
313
-                                <button class='delete' type='submit' name='submitbutton' value='" . web\lib\common\FormElements::BUTTON_DELETE . "'>" . _("Revoke Invitation") . "</button> "
314
-                              . sprintf(_("(expires %s)"),$oneinvite['expiry'])
312
+                                <input type='hidden' name='invitation_id' value='" . $oneinvite['token']."'/>
313
+                                <button class='delete' type='submit' name='submitbutton' value='" . web\lib\common\FormElements::BUTTON_DELETE."'>"._("Revoke Invitation")."</button> "
314
+                              . sprintf(_("(expires %s)"), $oneinvite['expiry'])
315 315
                               .     "</form>";
316 316
                         }
317 317
                         echo "      </td>
Please login to merge, or discard this patch.
web/admin/overview_user.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 
22 22
 namespace core;
23 23
 
24
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
24
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
25 25
 
26 26
 $instMgmt = new \core\UserManagement();
27 27
 $deco = new \web\lib\admin\PageDecoration();
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
             <?php echo $uiElements->infoblock($user->getAttributes(), "user", "User"); ?>
52 52
             <tr>
53 53
                 <td>
54
-                    <?php echo "" . _("Unique Identifier") ?>
54
+                    <?php echo ""._("Unique Identifier") ?>
55 55
                 </td>
56 56
                 <td>
57 57
                 </td>
@@ -64,14 +64,14 @@  discard block
 block discarded – undo
64 64
     <div>
65 65
         <?php
66 66
         if (\config\Master::DB['USER']['readonly'] === FALSE) {
67
-            echo "<a href='edit_user.php'><button>" . _("Edit User Details") . "</button></a>";
67
+            echo "<a href='edit_user.php'><button>"._("Edit User Details")."</button></a>";
68 68
         }
69 69
 
70 70
         if ($user->isFederationAdmin()) {
71
-            echo "<form action='overview_federation.php' method='GET' accept-charset='UTF-8'><button type='submit'>" . sprintf(_('Click here for %s management tasks'), $uiElements->nomenclatureFed) . "</button></form>";
71
+            echo "<form action='overview_federation.php' method='GET' accept-charset='UTF-8'><button type='submit'>".sprintf(_('Click here for %s management tasks'), $uiElements->nomenclatureFed)."</button></form>";
72 72
         }
73 73
         if ($user->isSuperadmin()) {
74
-            echo "<form action='112365365321.php' method='GET' accept-charset='UTF-8'><button type='submit'>" . _('Click here to access the superadmin page') . "</button></form>";
74
+            echo "<form action='112365365321.php' method='GET' accept-charset='UTF-8'><button type='submit'>"._('Click here to access the superadmin page')."</button></form>";
75 75
         }
76 76
         ?>
77 77
     </div>
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
         if (\config\Master::CONFIG['FUNCTIONALITY_LOCATIONS']['CONFASSISTANT_SILVERBULLET'] == "LOCAL") {
84 84
             $target = "https://wiki.geant.org/x/SSNwBg"; // Managed IdP manual
85 85
         }
86
-        $helptext = "<h3 style='display:inline;'>" . sprintf(_("(Need help? Refer to the <a href='%s'>%s administrator manual</a>)"), $target, $uiElements->nomenclatureInst) . "</h3>";
86
+        $helptext = "<h3 style='display:inline;'>".sprintf(_("(Need help? Refer to the <a href='%s'>%s administrator manual</a>)"), $target, $uiElements->nomenclatureInst)."</h3>";
87 87
     } else {
88 88
         $helptext = "";
89 89
     }
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
         // we need to run the Federation constructor
93 93
         $cat = new \core\CAT;
94 94
         /// first parameter: number of Identity Providers; second param is the literal configured term for 'Identity Provider' (you may or may not be able to add a plural suffix for your locale)
95
-        echo "<h2>" . sprintf(ngettext("You are managing the following <span style='display:none'>%d </span>%s:", "You are managing the following <strong>%d</strong> %s:", sizeof($hasInst)), sizeof($hasInst), $uiElements->nomenclatureParticipant) . "</h2>";
95
+        echo "<h2>".sprintf(ngettext("You are managing the following <span style='display:none'>%d </span>%s:", "You are managing the following <strong>%d</strong> %s:", sizeof($hasInst)), sizeof($hasInst), $uiElements->nomenclatureParticipant)."</h2>";
96 96
         $instlist = [];
97 97
         $my_idps = [];
98 98
         $myFeds = [];
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
     <?php
137 137
     foreach ($myFeds as $fed_id => $fed_name) {
138 138
 /// nomenclature 'fed', fed name, nomenclature 'inst'
139
-        echo "<tr><td colspan='4'><strong>" . sprintf(_("%s %s: %s list"), $uiElements->nomenclatureFed, $fed_name, $uiElements->nomenclatureParticipant) . "</strong></td></tr>";
139
+        echo "<tr><td colspan='4'><strong>".sprintf(_("%s %s: %s list"), $uiElements->nomenclatureFed, $fed_name, $uiElements->nomenclatureParticipant)."</strong></td></tr>";
140 140
 
141 141
         $fedOrganisations = $my_idps[$fed_id];
142 142
         asort($fedOrganisations);
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
             $the_inst = $oneinst['object'];
146 146
 
147 147
             echo "<tr>"
148
-            . "<td>" . $oneinst['name'] . "</td>";
148
+            . "<td>".$oneinst['name']."</td>";
149 149
             echo "<td>";
150 150
             $admins = $the_inst->listOwners();
151 151
             $blessedUser = FALSE;
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
                     $coadmin = new \core\User($username['ID']);
155 155
                     $coadmin_name = $coadmin->getAttributes('user:realname');
156 156
                     if (count($coadmin_name) > 0) {
157
-                        echo $coadmin_name[0]['value'] . "<br/>";
157
+                        echo $coadmin_name[0]['value']."<br/>";
158 158
                         unset($admins[$number]);
159 159
                     }
160 160
                 } else { // don't list self
@@ -200,7 +200,7 @@  discard block
 block discarded – undo
200 200
             echo "</td><td>"; // danger zone 
201 201
             ?>
202 202
             <form action='edit_participant_result.php?inst_id=<?php echo $the_inst->identifier; ?>' method='post' accept-charset='UTF-8'>
203
-                <button class='delete' type='submit' name='submitbutton' value='<?php echo \web\lib\common\FormElements::BUTTON_DELETE; ?>' onclick="return confirm('<?php echo ( \config\ConfAssistant::CONSORTIUM['selfservice_registration'] === NULL ? sprintf(_("After deleting the %s, you can not recreate it yourself - you need a new invitation token from the %s administrator!"), $uiElements->nomenclatureInst, $uiElements->nomenclatureFed) . " " : "" ) . sprintf(_("Do you really want to delete your %s %s?"), $uiElements->nomenclatureParticipant, $my_inst->name); ?>')"><?php echo sprintf(_("Delete %s"), $uiElements->nomenclatureParticipant); ?></button>
203
+                <button class='delete' type='submit' name='submitbutton' value='<?php echo \web\lib\common\FormElements::BUTTON_DELETE; ?>' onclick="return confirm('<?php echo (\config\ConfAssistant::CONSORTIUM['selfservice_registration'] === NULL ? sprintf(_("After deleting the %s, you can not recreate it yourself - you need a new invitation token from the %s administrator!"), $uiElements->nomenclatureInst, $uiElements->nomenclatureFed)." " : "").sprintf(_("Do you really want to delete your %s %s?"), $uiElements->nomenclatureParticipant, $my_inst->name); ?>')"><?php echo sprintf(_("Delete %s"), $uiElements->nomenclatureParticipant); ?></button>
204 204
             </form>
205 205
             <form action='edit_participant_result.php?inst_id=<?php echo $the_inst->identifier; ?>' method='post' accept-charset='UTF-8'>
206 206
                 <button class='delete' type='submit' name='submitbutton' value='<?php echo \web\lib\common\FormElements::BUTTON_FLUSH_AND_RESTART; ?>' onclick="return confirm('<?php echo sprintf(_("This action will delete all properties of the %s and start over the configuration from scratch. Do you really want to reset all settings of the %s %s?"), $uiElements->nomenclatureParticipant, $uiElements->nomenclatureParticipant, $my_inst->name); ?>')"><?php echo sprintf(_("Reset all %s settings"), $uiElements->nomenclatureParticipant); ?></button>
@@ -211,18 +211,18 @@  discard block
 block discarded – undo
211 211
     }
212 212
     echo "</table>";
213 213
 } else {
214
-    echo "<h2>" . sprintf(_("You are not managing any %s."), $uiElements->nomenclatureInst) . "</h2>";
214
+    echo "<h2>".sprintf(_("You are not managing any %s."), $uiElements->nomenclatureInst)."</h2>";
215 215
 }
216 216
 if (\config\Master::DB['INST']['readonly'] === FALSE) {
217 217
     if (\config\ConfAssistant::CONSORTIUM['selfservice_registration'] === NULL) {
218
-        echo "<p>" . sprintf(_("Please ask your %s administrator to invite you to become an %s administrator."), $uiElements->nomenclatureFed, $uiElements->nomenclatureParticipant) . "</p>";
218
+        echo "<p>".sprintf(_("Please ask your %s administrator to invite you to become an %s administrator."), $uiElements->nomenclatureFed, $uiElements->nomenclatureParticipant)."</p>";
219 219
         echo "<hr/>
220 220
              <div style='white-space: nowrap;'>
221 221
                 <form action='action_enrollment.php' method='get' accept-charset='UTF-8'>" .
222
-        sprintf(_("Did you receive an invitation token to manage an %s? Please paste it here:"), $uiElements->nomenclatureParticipant) .
222
+        sprintf(_("Did you receive an invitation token to manage an %s? Please paste it here:"), $uiElements->nomenclatureParticipant).
223 223
         "        <input type='text' id='token' name='token'/>
224 224
                     <button type='submit'>" .
225
-        _("Go!") . "
225
+        _("Go!")."
226 226
                     </button>
227 227
                 </form>
228 228
              </div>";
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
             <div style='white-space: nowrap;'>
232 232
         <form action='action_enrollment.php' method='get'><button type='submit' accept-charset='UTF-8'>
233 233
                 <input type='hidden' id='token' name='token' value='SELF-REGISTER'/>" .
234
-        sprintf(_("New %s Registration"), $uiElements->nomenclatureParticipant) . "
234
+        sprintf(_("New %s Registration"), $uiElements->nomenclatureParticipant)."
235 235
             </button>
236 236
         </form>
237 237
         </div>";
Please login to merge, or discard this patch.