Inspection of "Merge pull request #200 from GCTC-NTGC/qf_update_s..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ff14d5...cd3eaf )

by Grant

created 2018-06-19 04:00 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -240,7 +240,7 @@
 block discarded – undo
                         $loginLink .= "?response_type=" . URL_RESPONSE_TYPES;
                         if (strpos($url, 'admin') !== false) {
                             $loginLink .= "&redirect_uri=" . urlencode(REDIRECT_URI_ADMIN);
-                        } else {
+                        }else {
                             $loginLink .= "&redirect_uri=" . urlencode(REDIRECT_URI);
                         }
                         $loginLink .= "&nonce=" . $nonce;

Please login to merge, or discard this patch.

public_html/tc/services/FullJobApplication.php 1 patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -59,7 +59,7 @@  discard block
 block discarded – undo
                             exit;
                         }
                         
-                    } else if ($user->getUser_role() === "administrator") {
+                    }else if ($user->getUser_role() === "administrator") {
                         //an administrator has permission if they created the job this application is for
                         
                         $jobPoster = JobPosterController::getJobPosterById($locale, $fullJobApplication->getJob_poster_application()->getApplication_job_poster_id());
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
                             exit;
                         }
                         
-                    } else {
+                    }else {
                         header('HTTP/1.0 401 Unauthorized');
                         echo json_encode(array("failed" => "This user does not have permissions to view job applications"), JSON_FORCE_OBJECT);
                         exit;
@@ -77,17 +77,17 @@  discard block
 block discarded – undo
 
                     $json = json_encode($fullJobApplication, JSON_PRETTY_PRINT);
                     echo($json);
-                } else {
+                }else {
                     header('HTTP/1.0 401 Unauthorized');
                     echo json_encode(array("failed" => "Invalid token"), JSON_FORCE_OBJECT);
                     exit;
                 }
-            } else {
+            }else {
                 header('HTTP/1.0 401 Unauthorized');
                 echo json_encode(array("failed" => 'Invalid token, please reauthorize user'), JSON_FORCE_OBJECT);
                 exit;
             }
-        } else {
+        }else {
             header('HTTP/1.0 401 Unauthorized');
             echo json_encode(array("failed" => 'No authorization token provided'), JSON_FORCE_OBJECT);
             exit;

Please login to merge, or discard this patch.

public_html/tc/services/SubmitJobApplication.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -64,22 +64,22 @@
 block discarded – undo
                         $json = json_encode($result, JSON_PRETTY_PRINT);
                         echo($json);
                         
-                    } else {
+                    }else {
                         header('HTTP/1.0 401 Unauthorized');
                         echo json_encode(array("failed" => "Invalid token"), JSON_FORCE_OBJECT);
                         exit;
                     }
-                } else {
+                }else {
                     header('HTTP/1.0 401 Unauthorized');
                     echo json_encode(array("failed" => "No user id provided"), JSON_FORCE_OBJECT);
                     exit;
                 }
-            } else {
+            }else {
                 header('HTTP/1.0 401 Unauthorized');
                 echo json_encode(array("failed" => 'Invalid arguments provided'), JSON_FORCE_OBJECT);
                 exit;
             }
-        } else {
+        }else {
             header('HTTP/1.0 401 Unauthorized');
             echo json_encode(array("failed" => 'No authorization token provided'), JSON_FORCE_OBJECT);
             exit;

Please login to merge, or discard this patch.

public_html/tc/services/ApplicationMicroReferenceService.php 1 patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -35,7 +35,7 @@  discard block
 block discarded – undo
             $result = MicroReferenceController::getAllMicroReferencesForJobApplication($jobPosterApplicationId, $locale);
             $json = json_encode($result, JSON_PRETTY_PRINT);
             echo($json);
-        } else {
+        }else {
             $result = array();
             $json = json_encode($result, JSON_PRETTY_PRINT);
             echo($json);
@@ -59,12 +59,12 @@  discard block
 block discarded – undo
 
                 $json = json_encode($result, JSON_PRETTY_PRINT);
                 echo($json);
-            } else {
+            }else {
                 header('HTTP/1.0 403 Forbidden');
                 echo json_encode(array("failed" => "Only Draft applications can be modified."), JSON_FORCE_OBJECT);
                 exit;
             }
-        } else {
+        }else {
             $result = array();
             $json = json_encode($result, JSON_PRETTY_PRINT);
             echo($json);
@@ -97,12 +97,12 @@  discard block
 block discarded – undo
 
                 $json = json_encode($result, JSON_PRETTY_PRINT);
                 echo($json);
-            } else {
+            }else {
                 header('HTTP/1.0 403 Forbidden');
                 echo json_encode(array("failed" => "Only Draft applications can be modified."), JSON_FORCE_OBJECT);
                 exit;
             }
-        } else {
+        }else {
             $result = array();
             $json = json_encode($result, JSON_PRETTY_PRINT);
             echo($json);

Please login to merge, or discard this patch.

public_html/tc/services/FullJobApplicationByJobAndUser.php 1 patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -48,14 +48,14 @@  discard block
 block discarded – undo
                             echo json_encode(array("failed" => "Requested job application does not belong to this user"), JSON_FORCE_OBJECT);
                             exit;
                         }
-                    } else if ($user->getUser_role() === "administrator") {
+                    }else if ($user->getUser_role() === "administrator") {
                         $jobPoster = JobPosterController::getJobPosterById($locale, $jobPosterId);
                         if ($jobPoster->getManager_user_id() != $user->getUser_id()) {
                             header('HTTP/1.0 401 Unauthorized');
                             echo json_encode(array("failed" => "This user is not authorized to view applications for this job"), JSON_FORCE_OBJECT);
                             exit;
                         }
-                    } else {
+                    }else {
                         header('HTTP/1.0 401 Unauthorized');
                         echo json_encode(array("failed" => "This user does not have permissions to view job applications"), JSON_FORCE_OBJECT);
                         exit;
@@ -72,17 +72,17 @@  discard block
 block discarded – undo
 
                     $json = json_encode($fullJobApplication, JSON_PRETTY_PRINT);
                     echo($json);
-                } else {
+                }else {
                     header('HTTP/1.0 401 Unauthorized');
                     echo json_encode(array("failed" => "Invalid token"), JSON_FORCE_OBJECT);
                     exit;
                 }
-            } else {
+            }else {
                 header('HTTP/1.0 401 Unauthorized');
                 echo json_encode(array("failed" => 'Invalid token, please reauthorize user'), JSON_FORCE_OBJECT);
                 exit;
             }
-        } else {
+        }else {
             header('HTTP/1.0 401 Unauthorized');
             echo json_encode(array("failed" => 'No authorization token provided'), JSON_FORCE_OBJECT);
             exit;

Please login to merge, or discard this patch.

public_html/tc/services/ApplicationWorkSample.php 1 patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -35,7 +35,7 @@  discard block
 block discarded – undo
             $result = WorkSampleController::getAllWorkSamplesForJobApplication($jobPosterApplicationId, $locale);
             $json = json_encode($result, JSON_PRETTY_PRINT);
             echo($json);
-        } else {
+        }else {
             $result = array();
             $json = json_encode($result, JSON_PRETTY_PRINT);
             echo($json);
@@ -59,12 +59,12 @@  discard block
 block discarded – undo
 
                 $json = json_encode($result, JSON_PRETTY_PRINT);
                 echo($json);
-            } else {
+            }else {
                 header('HTTP/1.0 403 Forbidden');
                 echo json_encode(array("failed" => "Only Draft applications can be modified."), JSON_FORCE_OBJECT);
                 exit;
             }
-        } else {
+        }else {
             $result = array();
             $json = json_encode($result, JSON_PRETTY_PRINT);
             echo($json);
@@ -95,12 +95,12 @@  discard block
 block discarded – undo
 
                 $json = json_encode($result, JSON_PRETTY_PRINT);
                 echo($json);
-            } else {
+            }else {
                 header('HTTP/1.0 403 Forbidden');
                 echo json_encode(array("failed" => "Only Draft applications can be modified."), JSON_FORCE_OBJECT);
                 exit;
             }
-        } else {
+        }else {
             $result = array();
             $json = json_encode($result, JSON_PRETTY_PRINT);
             echo($json);

Please login to merge, or discard this patch.

public_html/tc/services/Locale.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -39,7 +39,7 @@
 block discarded – undo
             $result = ContentController::getContentByLocale($locale);
             $json = json_encode($result, JSON_PRETTY_PRINT);
             echo($json);
-        } else {
+        }else {
             $result = array();
             $json = json_encode($result, JSON_PRETTY_PRINT);
             echo($json);

Please login to merge, or discard this patch.

public_html/tc/controller/TeamCultureController.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -16,7 +16,7 @@
 block discarded – undo
         $previousEntry = TeamCultureDAO::getTeamCultureNonLocalizedForManagerProfile($managerProfileId);
         if ($previousEntry) {
             $result = TeamCultureDAO::updateTeamCultureForManagerProfile($teamCulture, $managerProfileId);
-        } else {
+        }else {
             $result = TeamCultureDAO::createTeamCultureForManagerProfile($teamCulture, $managerProfileId);
         }
         return $result;

Please login to merge, or discard this patch.

public_html/tc/controller/ProfilePicController.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -21,7 +21,7 @@
 block discarded – undo
     public static function getProfilePic($user_id) {
         if (ProfilePicDAO::profilePicExistsForUser($user_id)) {
                     return ProfilePicDAO::getProfilePic($user_id);
-        } else {
+        }else {
                     return NULL;
         }
     }

Please login to merge, or discard this patch.

		@@ -240,7 +240,7 @@
		block discarded – undo
240	240	$loginLink .= "?response_type=" . URL_RESPONSE_TYPES;
241	241	if (strpos($url, 'admin') !== false) {
242	242	$loginLink .= "&redirect_uri=" . urlencode(REDIRECT_URI_ADMIN);
243		- } else {
	243	+ }else {
244	244	$loginLink .= "&redirect_uri=" . urlencode(REDIRECT_URI);
245	245	}
246	246	$loginLink .= "&nonce=" . $nonce;

		@@ -59,7 +59,7 @@ discard block
		block discarded – undo
59	59	exit;
60	60	}
61	61
62		- } else if ($user->getUser_role() === "administrator") {
	62	+ }else if ($user->getUser_role() === "administrator") {
63	63	//an administrator has permission if they created the job this application is for
64	64
65	65	$jobPoster = JobPosterController::getJobPosterById($locale, $fullJobApplication->getJob_poster_application()->getApplication_job_poster_id());
		@@ -69,7 +69,7 @@ discard block
		block discarded – undo
69	69	exit;
70	70	}
71	71
72		- } else {
	72	+ }else {
73	73	header('HTTP/1.0 401 Unauthorized');
74	74	echo json_encode(array("failed" => "This user does not have permissions to view job applications"), JSON_FORCE_OBJECT);
75	75	exit;
		@@ -77,17 +77,17 @@ discard block
		block discarded – undo
77	77
78	78	$json = json_encode($fullJobApplication, JSON_PRETTY_PRINT);
79	79	echo($json);
80		- } else {
	80	+ }else {
81	81	header('HTTP/1.0 401 Unauthorized');
82	82	echo json_encode(array("failed" => "Invalid token"), JSON_FORCE_OBJECT);
83	83	exit;
84	84	}
85		- } else {
	85	+ }else {
86	86	header('HTTP/1.0 401 Unauthorized');
87	87	echo json_encode(array("failed" => 'Invalid token, please reauthorize user'), JSON_FORCE_OBJECT);
88	88	exit;
89	89	}
90		- } else {
	90	+ }else {
91	91	header('HTTP/1.0 401 Unauthorized');
92	92	echo json_encode(array("failed" => 'No authorization token provided'), JSON_FORCE_OBJECT);
93	93	exit;

		@@ -64,22 +64,22 @@
		block discarded – undo
64	64	$json = json_encode($result, JSON_PRETTY_PRINT);
65	65	echo($json);
66	66
67		- } else {
	67	+ }else {
68	68	header('HTTP/1.0 401 Unauthorized');
69	69	echo json_encode(array("failed" => "Invalid token"), JSON_FORCE_OBJECT);
70	70	exit;
71	71	}
72		- } else {
	72	+ }else {
73	73	header('HTTP/1.0 401 Unauthorized');
74	74	echo json_encode(array("failed" => "No user id provided"), JSON_FORCE_OBJECT);
75	75	exit;
76	76	}
77		- } else {
	77	+ }else {
78	78	header('HTTP/1.0 401 Unauthorized');
79	79	echo json_encode(array("failed" => 'Invalid arguments provided'), JSON_FORCE_OBJECT);
80	80	exit;
81	81	}
82		- } else {
	82	+ }else {
83	83	header('HTTP/1.0 401 Unauthorized');
84	84	echo json_encode(array("failed" => 'No authorization token provided'), JSON_FORCE_OBJECT);
85	85	exit;

		@@ -48,14 +48,14 @@ discard block
		block discarded – undo
48	48	echo json_encode(array("failed" => "Requested job application does not belong to this user"), JSON_FORCE_OBJECT);
49	49	exit;
50	50	}
51		- } else if ($user->getUser_role() === "administrator") {
	51	+ }else if ($user->getUser_role() === "administrator") {
52	52	$jobPoster = JobPosterController::getJobPosterById($locale, $jobPosterId);
53	53	if ($jobPoster->getManager_user_id() != $user->getUser_id()) {
54	54	header('HTTP/1.0 401 Unauthorized');
55	55	echo json_encode(array("failed" => "This user is not authorized to view applications for this job"), JSON_FORCE_OBJECT);
56	56	exit;
57	57	}
58		- } else {
	58	+ }else {
59	59	header('HTTP/1.0 401 Unauthorized');
60	60	echo json_encode(array("failed" => "This user does not have permissions to view job applications"), JSON_FORCE_OBJECT);
61	61	exit;
		@@ -72,17 +72,17 @@ discard block
		block discarded – undo
72	72
73	73	$json = json_encode($fullJobApplication, JSON_PRETTY_PRINT);
74	74	echo($json);
75		- } else {
	75	+ }else {
76	76	header('HTTP/1.0 401 Unauthorized');
77	77	echo json_encode(array("failed" => "Invalid token"), JSON_FORCE_OBJECT);
78	78	exit;
79	79	}
80		- } else {
	80	+ }else {
81	81	header('HTTP/1.0 401 Unauthorized');
82	82	echo json_encode(array("failed" => 'Invalid token, please reauthorize user'), JSON_FORCE_OBJECT);
83	83	exit;
84	84	}
85		- } else {
	85	+ }else {
86	86	header('HTTP/1.0 401 Unauthorized');
87	87	echo json_encode(array("failed" => 'No authorization token provided'), JSON_FORCE_OBJECT);
88	88	exit;

		@@ -35,7 +35,7 @@ discard block
		block discarded – undo
35	35	$result = MicroReferenceController::getAllMicroReferencesForJobApplication($jobPosterApplicationId, $locale);
36	36	$json = json_encode($result, JSON_PRETTY_PRINT);
37	37	echo($json);
38		- } else {
	38	+ }else {
39	39	$result = array();
40	40	$json = json_encode($result, JSON_PRETTY_PRINT);
41	41	echo($json);
		@@ -59,12 +59,12 @@ discard block
		block discarded – undo
59	59
60	60	$json = json_encode($result, JSON_PRETTY_PRINT);
61	61	echo($json);
62		- } else {
	62	+ }else {
63	63	header('HTTP/1.0 403 Forbidden');
64	64	echo json_encode(array("failed" => "Only Draft applications can be modified."), JSON_FORCE_OBJECT);
65	65	exit;
66	66	}
67		- } else {
	67	+ }else {
68	68	$result = array();
69	69	$json = json_encode($result, JSON_PRETTY_PRINT);
70	70	echo($json);
		@@ -97,12 +97,12 @@ discard block
		block discarded – undo
97	97
98	98	$json = json_encode($result, JSON_PRETTY_PRINT);
99	99	echo($json);
100		- } else {
	100	+ }else {
101	101	header('HTTP/1.0 403 Forbidden');
102	102	echo json_encode(array("failed" => "Only Draft applications can be modified."), JSON_FORCE_OBJECT);
103	103	exit;
104	104	}
105		- } else {
	105	+ }else {
106	106	$result = array();
107	107	$json = json_encode($result, JSON_PRETTY_PRINT);
108	108	echo($json);

		@@ -35,7 +35,7 @@ discard block
		block discarded – undo
35	35	$result = WorkSampleController::getAllWorkSamplesForJobApplication($jobPosterApplicationId, $locale);
36	36	$json = json_encode($result, JSON_PRETTY_PRINT);
37	37	echo($json);
38		- } else {
	38	+ }else {
39	39	$result = array();
40	40	$json = json_encode($result, JSON_PRETTY_PRINT);
41	41	echo($json);
		@@ -59,12 +59,12 @@ discard block
		block discarded – undo
59	59
60	60	$json = json_encode($result, JSON_PRETTY_PRINT);
61	61	echo($json);
62		- } else {
	62	+ }else {
63	63	header('HTTP/1.0 403 Forbidden');
64	64	echo json_encode(array("failed" => "Only Draft applications can be modified."), JSON_FORCE_OBJECT);
65	65	exit;
66	66	}
67		- } else {
	67	+ }else {
68	68	$result = array();
69	69	$json = json_encode($result, JSON_PRETTY_PRINT);
70	70	echo($json);
		@@ -95,12 +95,12 @@ discard block
		block discarded – undo
95	95
96	96	$json = json_encode($result, JSON_PRETTY_PRINT);
97	97	echo($json);
98		- } else {
	98	+ }else {
99	99	header('HTTP/1.0 403 Forbidden');
100	100	echo json_encode(array("failed" => "Only Draft applications can be modified."), JSON_FORCE_OBJECT);
101	101	exit;
102	102	}
103		- } else {
	103	+ }else {
104	104	$result = array();
105	105	$json = json_encode($result, JSON_PRETTY_PRINT);
106	106	echo($json);

		@@ -39,7 +39,7 @@
		block discarded – undo
39	39	$result = ContentController::getContentByLocale($locale);
40	40	$json = json_encode($result, JSON_PRETTY_PRINT);
41	41	echo($json);
42		- } else {
	42	+ }else {
43	43	$result = array();
44	44	$json = json_encode($result, JSON_PRETTY_PRINT);
45	45	echo($json);

		@@ -16,7 +16,7 @@
		block discarded – undo
16	16	$previousEntry = TeamCultureDAO::getTeamCultureNonLocalizedForManagerProfile($managerProfileId);
17	17	if ($previousEntry) {
18	18	$result = TeamCultureDAO::updateTeamCultureForManagerProfile($teamCulture, $managerProfileId);
19		- } else {
	19	+ }else {
20	20	$result = TeamCultureDAO::createTeamCultureForManagerProfile($teamCulture, $managerProfileId);
21	21	}
22	22	return $result;

		@@ -21,7 +21,7 @@
		block discarded – undo
21	21	public static function getProfilePic($user_id) {
22	22	if (ProfilePicDAO::profilePicExistsForUser($user_id)) {
23	23	return ProfilePicDAO::getProfilePic($user_id);
24		- } else {
	24	+ }else {
25	25	return NULL;
26	26	}
27	27	}

GCTC-NTGC / TalentCloud

Push — master ( ff14d5...cd3eaf )

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch