Inspection of "Merge pull request #200 from GCTC-NTGC/qf_update_s..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ff14d5...cd3eaf )

by Grant

created 2018-06-19 04:00 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -38,7 +38,7 @@
 block discarded – undo
                 
                 $json = json_encode($jobApplicationsWithAnswers, JSON_PRETTY_PRINT);
                 echo($json);
-            } else {
+            }else {
                 $result = array();
                 $json = json_encode($result, JSON_PRETTY_PRINT);
                 echo($json);

Please login to merge, or discard this patch.

public_html/tc/services/ApplicationDeclarationService.php 1 patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@  discard block
 block discarded – undo
                 $result = SkillDeclarationController::getAllSkillDeclarationsForJobApplication($jobPosterApplicationId);
                 $json = json_encode($result, JSON_PRETTY_PRINT);
                 echo($json);
-            } else {
+            }else {
                 $result = array();
                 $json = json_encode($result, JSON_PRETTY_PRINT);
                 echo($json);
@@ -79,14 +79,14 @@  discard block
 block discarded – undo
                 
                     $json = json_encode($result, JSON_PRETTY_PRINT);
                     echo($json);
-                } else {
+                }else {
                     header('HTTP/1.0 403 Forbidden');
                     echo json_encode(array("failed"=>"Only Draft applications can be modified."), JSON_FORCE_OBJECT);
                     exit;
                 }
                
                 
-            } else {
+            }else {
                 $result = array();
                 $json = json_encode($result, JSON_PRETTY_PRINT);
                 echo($json);
@@ -117,13 +117,13 @@  discard block
 block discarded – undo
 
                     $json = json_encode($result, JSON_PRETTY_PRINT);
                     echo($json);
-                } else {
+                }else {
                     header('HTTP/1.0 403 Forbidden');
                     echo json_encode(array("failed"=>"Only Draft applications can be modified."), JSON_FORCE_OBJECT);
                     exit;
                 }        
                 
-            } else {
+            }else {
                 $result = array();
                 $json = json_encode($result, JSON_PRETTY_PRINT);
                 echo($json);

Please login to merge, or discard this patch.

public_html/tc/services/TeamCulture.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -38,7 +38,7 @@
 block discarded – undo
                 $result = TeamCultureController::getTeamCultureByManagerProfileId($managerProfileId, $locale);
                 $json = json_encode($result, JSON_PRETTY_PRINT);
                 echo($json);
-            } else {
+            }else {
                 $result = array();
                 $json = json_encode($result, JSON_PRETTY_PRINT);
                 echo($json);

Please login to merge, or discard this patch.

public_html/tc/services/ProfilePic.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -37,11 +37,11 @@  discard block
 block discarded – undo
                 if ($result == NULL) {
                     http_response_code(404);
                     echo('No profile image uploaded for this user.');
-                } else {
+                }else {
                     header("Content-type: " . $result->getType());
                     echo($result->getImage());
                 }
-            } else {
+            }else {
                 $result = array();
                 $json = json_encode($result, JSON_PRETTY_PRINT);
                 echo($json);
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
                 //echo($profile_pic->getImage());
                 echo($result);
                 //echo('{"profilepic":"upload failed"}');
-            } else {
+            }else {
                 $result = array();
                 $json = json_encode($result, JSON_PRETTY_PRINT);
                 echo($json);

Please login to merge, or discard this patch.

public_html/tc/services/WorkEnvironmentByManagerProfile.php 1 patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -38,7 +38,7 @@  discard block
 block discarded – undo
                 $result = WorkEnvironmentController::getWorkEnivronmentByManagerProfile($managerProfileId);
                 $json = json_encode($result, JSON_PRETTY_PRINT);
                 echo($json);
-            } else {
+            }else {
                 $result = array();
                 $json = json_encode($result, JSON_PRETTY_PRINT);
                 echo($json);
@@ -86,23 +86,23 @@  discard block
 block discarded – undo
                             $resultJson = json_encode($result, JSON_PRETTY_PRINT);
                             echo($resultJson);                
                             
-                        } else {
+                        }else {
                             header('HTTP/1.0 401 Unauthorized');
                             echo json_encode(array("failed"=>"Invalid token"), JSON_FORCE_OBJECT);
                             exit;
                         }
 
-                    } else {
+                    }else {
                         header('HTTP/1.0 401 Unauthorized');
                         echo json_encode(array("failed"=>"No manager profile id provided"), JSON_FORCE_OBJECT);
                         exit;
                     }
-                } else {
+                }else {
                     header('HTTP/1.0 401 Unauthorized');
                     echo json_encode(array("failed"=>'Invalid token, please reauthorize user'), JSON_FORCE_OBJECT);
                     exit;
                 }
-            } else {
+            }else {
                 header('HTTP/1.0 401 Unauthorized');
                 echo json_encode(array("failed"=>'No authorization token provided'), JSON_FORCE_OBJECT);
                 exit;

Please login to merge, or discard this patch.

public_html/tc/services/JobApplication.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -40,7 +40,7 @@
 block discarded – undo
                 
                 $json = json_encode($jobApplicationWithAnswers, JSON_PRETTY_PRINT);
                 echo($json);
-            } else {
+            }else {
                 $result = array();
                 $json = json_encode($result, JSON_PRETTY_PRINT);
                 echo($json);

Please login to merge, or discard this patch.

public_html/tc/services/TeamCultureNonLocalized.php 1 patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -36,7 +36,7 @@  discard block
 block discarded – undo
                 $result = TeamCultureController::getTeamCultureNonLocalizedByManagerProfileId($managerProfileId);
                 $json = json_encode($result, JSON_PRETTY_PRINT);
                 echo($json);
-            } else {
+            }else {
                 $result = array();
                 $json = json_encode($result, JSON_PRETTY_PRINT);
                 echo($json);
@@ -79,23 +79,23 @@  discard block
 block discarded – undo
                             $resultJson = json_encode($result, JSON_PRETTY_PRINT);
                             echo($resultJson);
 
-                        } else {
+                        }else {
                             header('HTTP/1.0 401 Unauthorized');
                             echo json_encode(array("failed"=>"Invalid token"), JSON_FORCE_OBJECT);
                             exit;
                         }
 
-                    } else {
+                    }else {
                         header('HTTP/1.0 401 Unauthorized');
                         echo json_encode(array("failed"=>"No manager profile id provided"), JSON_FORCE_OBJECT);
                         exit;
                     }
-                } else {
+                }else {
                     header('HTTP/1.0 401 Unauthorized');
                     echo json_encode(array("failed"=>'Invalid token, please reauthorize user'), JSON_FORCE_OBJECT);
                     exit;
                 }
-            } else {
+            }else {
                 header('HTTP/1.0 401 Unauthorized');
                 echo json_encode(array("failed"=>'No authorization token provided'), JSON_FORCE_OBJECT);
                 exit;

Please login to merge, or discard this patch.

public_html/tc/services/JobApplicationByJobAndUser.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -47,7 +47,7 @@  discard block
 block discarded – undo
                 
                 $json = json_encode($jobApplicationWithAnswers, JSON_PRETTY_PRINT);
                 echo($json);
-            } else {
+            }else {
                 $result = array();
                 $json = json_encode($result, JSON_PRETTY_PRINT);
                 echo($json);
@@ -100,13 +100,13 @@  discard block
 block discarded – undo
                     $result = JobApplicationController::getJobApplicationWithAnswersById($prevId);
                     $json = json_encode($result, JSON_PRETTY_PRINT);
                     echo($json);
-                } else {
+                }else {
                     //Previous application exist, but is not a draft, so cannot be updated
                     header('HTTP/1.0 403 Forbidden');
                     echo json_encode(array("failed"=>"Only Draft applications can be modified."), JSON_FORCE_OBJECT);
                     exit;
                 } 
-            } else {
+            }else {
                 //No previous application exists, so a new one can be created
                 $applicationId = JobApplicationController::createJobApplicationWithAnswers($jobApplicationWithAnswers);
                 $result = JobApplicationController::getJobApplicationWithAnswersById($applicationId);

Please login to merge, or discard this patch.

public_html/tc/services/JobSeekers.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -35,7 +35,7 @@
 block discarded – undo
             $result = JobSeekerController::getJobSeekers();
             $json = json_encode($result, JSON_PRETTY_PRINT);
             echo($json);
-        } else {
+        }else {
             $result = array();
             $json = json_encode($result, JSON_PRETTY_PRINT);
             echo($json);

Please login to merge, or discard this patch.

		@@ -38,7 +38,7 @@ discard block
		block discarded – undo
38	38	$result = WorkEnvironmentController::getWorkEnivronmentByManagerProfile($managerProfileId);
39	39	$json = json_encode($result, JSON_PRETTY_PRINT);
40	40	echo($json);
41		- } else {
	41	+ }else {
42	42	$result = array();
43	43	$json = json_encode($result, JSON_PRETTY_PRINT);
44	44	echo($json);
		@@ -86,23 +86,23 @@ discard block
		block discarded – undo
86	86	$resultJson = json_encode($result, JSON_PRETTY_PRINT);
87	87	echo($resultJson);
88	88
89		- } else {
	89	+ }else {
90	90	header('HTTP/1.0 401 Unauthorized');
91	91	echo json_encode(array("failed"=>"Invalid token"), JSON_FORCE_OBJECT);
92	92	exit;
93	93	}
94	94
95		- } else {
	95	+ }else {
96	96	header('HTTP/1.0 401 Unauthorized');
97	97	echo json_encode(array("failed"=>"No manager profile id provided"), JSON_FORCE_OBJECT);
98	98	exit;
99	99	}
100		- } else {
	100	+ }else {
101	101	header('HTTP/1.0 401 Unauthorized');
102	102	echo json_encode(array("failed"=>'Invalid token, please reauthorize user'), JSON_FORCE_OBJECT);
103	103	exit;
104	104	}
105		- } else {
	105	+ }else {
106	106	header('HTTP/1.0 401 Unauthorized');
107	107	echo json_encode(array("failed"=>'No authorization token provided'), JSON_FORCE_OBJECT);
108	108	exit;

		@@ -40,7 +40,7 @@
		block discarded – undo
40	40
41	41	$json = json_encode($jobApplicationWithAnswers, JSON_PRETTY_PRINT);
42	42	echo($json);
43		- } else {
	43	+ }else {
44	44	$result = array();
45	45	$json = json_encode($result, JSON_PRETTY_PRINT);
46	46	echo($json);

		@@ -47,7 +47,7 @@ discard block
		block discarded – undo
47	47
48	48	$json = json_encode($jobApplicationWithAnswers, JSON_PRETTY_PRINT);
49	49	echo($json);
50		- } else {
	50	+ }else {
51	51	$result = array();
52	52	$json = json_encode($result, JSON_PRETTY_PRINT);
53	53	echo($json);
		@@ -100,13 +100,13 @@ discard block
		block discarded – undo
100	100	$result = JobApplicationController::getJobApplicationWithAnswersById($prevId);
101	101	$json = json_encode($result, JSON_PRETTY_PRINT);
102	102	echo($json);
103		- } else {
	103	+ }else {
104	104	//Previous application exist, but is not a draft, so cannot be updated
105	105	header('HTTP/1.0 403 Forbidden');
106	106	echo json_encode(array("failed"=>"Only Draft applications can be modified."), JSON_FORCE_OBJECT);
107	107	exit;
108	108	}
109		- } else {
	109	+ }else {
110	110	//No previous application exists, so a new one can be created
111	111	$applicationId = JobApplicationController::createJobApplicationWithAnswers($jobApplicationWithAnswers);
112	112	$result = JobApplicationController::getJobApplicationWithAnswersById($applicationId);

		@@ -38,7 +38,7 @@
		block discarded – undo
38	38
39	39	$json = json_encode($jobApplicationsWithAnswers, JSON_PRETTY_PRINT);
40	40	echo($json);
41		- } else {
	41	+ }else {
42	42	$result = array();
43	43	$json = json_encode($result, JSON_PRETTY_PRINT);
44	44	echo($json);

		@@ -33,7 +33,7 @@ discard block
		block discarded – undo
33	33	$result = SkillDeclarationController::getAllSkillDeclarationsForJobApplication($jobPosterApplicationId);
34	34	$json = json_encode($result, JSON_PRETTY_PRINT);
35	35	echo($json);
36		- } else {
	36	+ }else {
37	37	$result = array();
38	38	$json = json_encode($result, JSON_PRETTY_PRINT);
39	39	echo($json);
		@@ -79,14 +79,14 @@ discard block
		block discarded – undo
79	79
80	80	$json = json_encode($result, JSON_PRETTY_PRINT);
81	81	echo($json);
82		- } else {
	82	+ }else {
83	83	header('HTTP/1.0 403 Forbidden');
84	84	echo json_encode(array("failed"=>"Only Draft applications can be modified."), JSON_FORCE_OBJECT);
85	85	exit;
86	86	}
87	87
88	88
89		- } else {
	89	+ }else {
90	90	$result = array();
91	91	$json = json_encode($result, JSON_PRETTY_PRINT);
92	92	echo($json);
		@@ -117,13 +117,13 @@ discard block
		block discarded – undo
117	117
118	118	$json = json_encode($result, JSON_PRETTY_PRINT);
119	119	echo($json);
120		- } else {
	120	+ }else {
121	121	header('HTTP/1.0 403 Forbidden');
122	122	echo json_encode(array("failed"=>"Only Draft applications can be modified."), JSON_FORCE_OBJECT);
123	123	exit;
124	124	}
125	125
126		- } else {
	126	+ }else {
127	127	$result = array();
128	128	$json = json_encode($result, JSON_PRETTY_PRINT);
129	129	echo($json);

		@@ -38,7 +38,7 @@
		block discarded – undo
38	38	$result = TeamCultureController::getTeamCultureByManagerProfileId($managerProfileId, $locale);
39	39	$json = json_encode($result, JSON_PRETTY_PRINT);
40	40	echo($json);
41		- } else {
	41	+ }else {
42	42	$result = array();
43	43	$json = json_encode($result, JSON_PRETTY_PRINT);
44	44	echo($json);

		@@ -37,11 +37,11 @@ discard block
		block discarded – undo
37	37	if ($result == NULL) {
38	38	http_response_code(404);
39	39	echo('No profile image uploaded for this user.');
40		- } else {
	40	+ }else {
41	41	header("Content-type: " . $result->getType());
42	42	echo($result->getImage());
43	43	}
44		- } else {
	44	+ }else {
45	45	$result = array();
46	46	$json = json_encode($result, JSON_PRETTY_PRINT);
47	47	echo($json);
		@@ -83,7 +83,7 @@ discard block
		block discarded – undo
83	83	//echo($profile_pic->getImage());
84	84	echo($result);
85	85	//echo('{"profilepic":"upload failed"}');
86		- } else {
	86	+ }else {
87	87	$result = array();
88	88	$json = json_encode($result, JSON_PRETTY_PRINT);
89	89	echo($json);

		@@ -36,7 +36,7 @@ discard block
		block discarded – undo
36	36	$result = TeamCultureController::getTeamCultureNonLocalizedByManagerProfileId($managerProfileId);
37	37	$json = json_encode($result, JSON_PRETTY_PRINT);
38	38	echo($json);
39		- } else {
	39	+ }else {
40	40	$result = array();
41	41	$json = json_encode($result, JSON_PRETTY_PRINT);
42	42	echo($json);
		@@ -79,23 +79,23 @@ discard block
		block discarded – undo
79	79	$resultJson = json_encode($result, JSON_PRETTY_PRINT);
80	80	echo($resultJson);
81	81
82		- } else {
	82	+ }else {
83	83	header('HTTP/1.0 401 Unauthorized');
84	84	echo json_encode(array("failed"=>"Invalid token"), JSON_FORCE_OBJECT);
85	85	exit;
86	86	}
87	87
88		- } else {
	88	+ }else {
89	89	header('HTTP/1.0 401 Unauthorized');
90	90	echo json_encode(array("failed"=>"No manager profile id provided"), JSON_FORCE_OBJECT);
91	91	exit;
92	92	}
93		- } else {
	93	+ }else {
94	94	header('HTTP/1.0 401 Unauthorized');
95	95	echo json_encode(array("failed"=>'Invalid token, please reauthorize user'), JSON_FORCE_OBJECT);
96	96	exit;
97	97	}
98		- } else {
	98	+ }else {
99	99	header('HTTP/1.0 401 Unauthorized');
100	100	echo json_encode(array("failed"=>'No authorization token provided'), JSON_FORCE_OBJECT);
101	101	exit;

		@@ -35,7 +35,7 @@
		block discarded – undo
35	35	$result = JobSeekerController::getJobSeekers();
36	36	$json = json_encode($result, JSON_PRETTY_PRINT);
37	37	echo($json);
38		- } else {
	38	+ }else {
39	39	$result = array();
40	40	$json = json_encode($result, JSON_PRETTY_PRINT);
41	41	echo($json);

GCTC-NTGC / TalentCloud

Push — master ( ff14d5...cd3eaf )

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch