Passed
Push — task/common-translation-packag... ( 852212...2abece )
by Grant
07:25
created
app/Http/Resources/CriteriaResource.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,6 +14,6 @@
 block discarded – undo
14 14
      */
15 15
     public function toArray($request)
16 16
     {
17
-        return parent::toArray($request);
17
+        return parent::toArray ($request);
18 18
     }
19 19
 }
Please login to merge, or discard this patch.
app/Http/Controllers/Api/CriteriaController.php 1 patch
Spacing   +27 added lines, -27 removed lines patch added patch discarded remove patch
@@ -20,8 +20,8 @@  discard block
 block discarded – undo
20 20
      */
21 21
     public function indexByJob(JobPoster $jobPoster)
22 22
     {
23
-        $criteriaByJob = Criteria::where('job_poster_id', $jobPoster->id)->get();
24
-        return CriteriaResource::collection($criteriaByJob);
23
+        $criteriaByJob = Criteria::where ('job_poster_id', $jobPoster->id)->get ();
24
+        return CriteriaResource::collection ($criteriaByJob);
25 25
     }
26 26
 
27 27
     /**
@@ -33,38 +33,38 @@  discard block
 block discarded – undo
33 33
      */
34 34
     public function batchUpdate(Request $request, JobPoster $jobPoster)
35 35
     {
36
-        $newCriteria = collect($request->input()); // TODO: switch to validated
36
+        $newCriteria = collect ($request->input ()); // TODO: switch to validated
37 37
         $oldCriteria = $jobPoster->criteria;
38 38
 
39 39
         $updatedIds = [];
40 40
 
41 41
         // First, delete old criteria that weren't resubmitted, and update those that were.
42 42
         foreach ($oldCriteria as $criteria) {
43
-            $newData = $newCriteria->firstWhere('id', $criteria['id']);
43
+            $newData = $newCriteria->firstWhere ('id', $criteria['id']);
44 44
             if ($newData) {
45 45
                 $updatedIds[] = $criteria->id;
46
-                $this->updateCriteria($criteria, $newData);
46
+                $this->updateCriteria ($criteria, $newData);
47 47
             } else {
48
-                $this->deleteCriteria($criteria);
48
+                $this->deleteCriteria ($criteria);
49 49
             }
50 50
         }
51 51
 
52 52
         $isUnsaved = function ($criteria, $savedIds): bool {
53
-            return !array_key_exists('id', $criteria) || !in_array($criteria['id'], $savedIds);
53
+            return !array_key_exists ('id', $criteria) || !in_array ($criteria['id'], $savedIds);
54 54
         };
55 55
 
56 56
         // Now, save any new criteria that remain.
57 57
         foreach ($newCriteria as $criteriaData) {
58
-            if ($isUnsaved($criteriaData, $updatedIds)) {
59
-                $criteria = new Criteria();
58
+            if ($isUnsaved ($criteriaData, $updatedIds)) {
59
+                $criteria = new Criteria ();
60 60
                 $criteria->job_poster_id = $jobPoster->id;
61
-                $fillableData = collect($criteriaData)->except(['id', 'job_poster_id'])->toArray();
62
-                $criteria->fill($fillableData);
63
-                $this->createCriteria($criteria);
61
+                $fillableData = collect ($criteriaData)->except (['id', 'job_poster_id'])->toArray ();
62
+                $criteria->fill ($fillableData);
63
+                $this->createCriteria ($criteria);
64 64
             }
65 65
         }
66 66
 
67
-        return CriteriaResource::collection($jobPoster->fresh()->criteria);
67
+        return CriteriaResource::collection ($jobPoster->fresh ()->criteria);
68 68
     }
69 69
 
70 70
     /**
@@ -75,12 +75,12 @@  discard block
 block discarded – undo
75 75
      */
76 76
     protected function createCriteria(Criteria $criteria)
77 77
     {
78
-        $criteria->save();
79
-        $notification = $this->makeAssessmentPlanNotification(
78
+        $criteria->save ();
79
+        $notification = $this->makeAssessmentPlanNotification (
80 80
             'CREATE',
81 81
             $criteria
82 82
         );
83
-        $notification->save();
83
+        $notification->save ();
84 84
 
85 85
         return $criteria;
86 86
     }
@@ -98,19 +98,19 @@  discard block
 block discarded – undo
98 98
         if ($oldCriteria->skill_level_id != $newData['skill_level_id']
99 99
             || $oldCriteria->skill_id != $newData['skill_id']
100 100
         ) {
101
-            $notification = $this->makeAssessmentPlanNotification(
101
+            $notification = $this->makeAssessmentPlanNotification (
102 102
                 'UPDATE',
103 103
                 $oldCriteria,
104 104
                 $newData['skill_id'],
105 105
                 $newData['skill_level_id'],
106 106
                 $newData['criteria_type_id']
107 107
             );
108
-            $notification->save();
108
+            $notification->save ();
109 109
         }
110 110
         // Get just the data that can be changed.
111
-        $fillableData = collect($newData)->except(['id', 'job_poster_id'])->toArray();
112
-        $oldCriteria->fill($fillableData);
113
-        $oldCriteria->save();
111
+        $fillableData = collect ($newData)->except (['id', 'job_poster_id'])->toArray ();
112
+        $oldCriteria->fill ($fillableData);
113
+        $oldCriteria->save ();
114 114
     }
115 115
 
116 116
     /**
@@ -121,15 +121,15 @@  discard block
 block discarded – undo
121 121
      */
122 122
     protected function deleteCriteria(Criteria $criteria): void
123 123
     {
124
-        $notification = $notification = $this->makeAssessmentPlanNotification(
124
+        $notification = $notification = $this->makeAssessmentPlanNotification (
125 125
             'DELETE',
126 126
             $criteria
127 127
         );
128
-        $notification->save();
128
+        $notification->save ();
129 129
 
130 130
         // Delete assessments related to this criteria.
131
-        Assessment::where('criterion_id', $criteria->id)->delete();
132
-        $criteria->delete();
131
+        Assessment::where ('criterion_id', $criteria->id)->delete ();
132
+        $criteria->delete ();
133 133
     }
134 134
 
135 135
     /**
@@ -148,8 +148,8 @@  discard block
 block discarded – undo
148 148
         $newSkillId = null,
149 149
         $newSkillLevelId = null,
150 150
         $newCriteriaTypeId = null
151
-    ) {
152
-        $notification = new AssessmentPlanNotification();
151
+    ){
152
+        $notification = new AssessmentPlanNotification ();
153 153
         $notification->job_poster_id = $criteria->job_poster_id;
154 154
         $notification->type = $type;
155 155
         $notification->criteria_id = $criteria->id;
Please login to merge, or discard this patch.