RegistrationValidator::managerRegistrationExtraRules() - Code Metrics - Inspection of "Merge pull request #1443 from GCTC-NTGC/feature/de..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — dev ( 03a84b...1c649f )

by Chris

created 2019-09-26 18:08 UTC

managerRegistrationExtraRules() A

↳ Parent: RegistrationValidator

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	3
dl	0
loc	5
rs	10
c	1
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace App\Services\Validation;

use Illuminate\Support\Facades\Validator;
use App\Services\Validation\Rules\PasswordFormatRule;

class RegistrationValidator
{
    public static function basicRules()

    {
        return [
            'name' => 'required|string|max:255',
            'email' => 'required|string|email|max:255|unique:users',
            'password' => [
                'required',
                'min:8',
                new PasswordFormatRule,
                'confirmed'
            ],
        ];
    }

    public static function managerRegistrationExtraRules()

    {
        return [
            'department' => 'required|integer',
            'gov_email' => 'nullable|required_unless:department,0|string|email|unique:users', // gov_email is required unless department is set to 0 (Not in Goverment)

        ];
    }

    /**
     * Get a validator for an incoming registration request.
     *
     * @param  array $data Incoming registration data.

     * @return \Illuminate\Contracts\Validation\Validator
     */
    public static function userValidator(array $data)

    {
        return Validator::make($data, self::basicRules());
    }

    /**
     * Get a validator for an incoming Manager registration request.
     *
     * @param  array $data Incoming registration data.

     * @return \Illuminate\Contracts\Validation\Validator
     */
    public static function managerValidator(array $data)

    {
        $managerRules = array_merge(self::basicRules(), self::managerRegistrationExtraRules());
        return Validator::make($data, $managerRules);
    }

    /**
     * Get a validator for an incoming finishManagerRegistration request.
     *
     * @param  array $data Incoming registration data.

     * @return \Illuminate\Contracts\Validation\Validator
     */
    public static function finalizeManagerValidator(array $data)

    {
        return Validator::make($data, self::managerRegistrationExtraRules());
    }
}


1			<?php
2
3			namespace App\Services\Validation;
4
5			use Illuminate\Support\Facades\Validator;
6			use App\Services\Validation\Rules\PasswordFormatRule;
7
8			class RegistrationValidator
9			{
10			public static function basicRules()
			1 ignored issue – show introduced 2019-09-24 16:31 UTC by Report Bug Copy Issue Report Method \App\Services\Validation\RegistrationValidator::basicRules() does not have return type hint nor @return annotation for its return value. Loading history... Coding Style Documentation introduced 2019-09-24 16:31 UTC by Report Bug Copy Issue Report Missing doc comment for function basicRules() Loading history...
11			{
12			return [
13			'name' => 'required\|string\|max:255',
14			'email' => 'required\|string\|email\|max:255\|unique:users',
15			'password' => [
16			'required',
17			'min:8',
18			new PasswordFormatRule,
19			'confirmed'
20			],
21			];
22			}
23
24			public static function managerRegistrationExtraRules()
			1 ignored issue – show introduced 2019-09-24 16:31 UTC by Report Bug Copy Issue Report Method \App\Services\Validation\RegistrationValidator::managerRegistrationExtraRules() does not have return type hint nor @return annotation for its return value. Loading history... Coding Style Documentation introduced 2019-09-24 16:31 UTC by Report Bug Copy Issue Report Missing doc comment for function managerRegistrationExtraRules() Loading history...
25			{
26			return [
27			'department' => 'required\|integer',
28			'gov_email' => 'nullable\|required_unless:department,0\|string\|email\|unique:users', // gov_email is required unless department is set to 0 (Not in Goverment)
			1 ignored issue – show Coding Style Documentation introduced 2019-09-13 14:33 UTC by Report Bug Copy Issue Report Inline comments must start with a capital letter Loading history...
29			];
30			}
31
32			/**
33			* Get a validator for an incoming registration request.
34			*
35			* @param array $data Incoming registration data.
			0 ignored issues – show introduced 2019-09-24 16:31 UTC by Report Bug Copy Issue Report @param annotation of method \App\Services\Validation\RegistrationValidator::userValidator() does not specify type hint for items of its traversable parameter $data. Loading history...
36			* @return \Illuminate\Contracts\Validation\Validator
37			*/
38			public static function userValidator(array $data)
			0 ignored issues – show introduced 2019-09-24 16:31 UTC by Report Bug Copy Issue Report Method \App\Services\Validation\RegistrationValidator::userValidator() does not have return type hint for its return value but it should be possible to add it based on @return annotation "\Illuminate\Contracts\Validation\Validator". Loading history...
39			{
40			return Validator::make($data, self::basicRules());
41			}
42
43			/**
44			* Get a validator for an incoming Manager registration request.
45			*
46			* @param array $data Incoming registration data.
			0 ignored issues – show introduced 2019-09-24 16:31 UTC by Report Bug Copy Issue Report @param annotation of method \App\Services\Validation\RegistrationValidator::managerValidator() does not specify type hint for items of its traversable parameter $data. Loading history...
47			* @return \Illuminate\Contracts\Validation\Validator
48			*/
49			public static function managerValidator(array $data)
			0 ignored issues – show introduced 2019-09-24 16:31 UTC by Report Bug Copy Issue Report Method \App\Services\Validation\RegistrationValidator::managerValidator() does not have return type hint for its return value but it should be possible to add it based on @return annotation "\Illuminate\Contracts\Validation\Validator". Loading history...
50			{
51			$managerRules = array_merge(self::basicRules(), self::managerRegistrationExtraRules());
52			return Validator::make($data, $managerRules);
53			}
54
55			/**
56			* Get a validator for an incoming finishManagerRegistration request.
57			*
58			* @param array $data Incoming registration data.
			0 ignored issues – show introduced 2019-09-24 16:31 UTC by Report Bug Copy Issue Report @param annotation of method \App\Services\Validation\RegistrationValidator::finalizeManagerValidator() does not specify type hint for items of its traversable parameter $data. Loading history...
59			* @return \Illuminate\Contracts\Validation\Validator
60			*/
61			public static function finalizeManagerValidator(array $data)
			0 ignored issues – show introduced 2019-09-24 16:31 UTC by Report Bug Copy Issue Report Method \App\Services\Validation\RegistrationValidator::finalizeManagerValidator() does not have return type hint for its return value but it should be possible to add it based on @return annotation "\Illuminate\Contracts\Validation\Validator". Loading history...
62			{
63			return Validator::make($data, self::managerRegistrationExtraRules());
64			}
65			}
66

GCTC-NTGC / TalentCloud

Push — dev ( 03a84b...1c649f )

managerRegistrationExtraRules() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like