App\Services\Validation\RegistrationValidator

Complexity

Total Complexity

5

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Importance

Changes	3
Bugs	1	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	userValidator()	0	3	1
A	basicRules()	0	10	1
A	managerValidator()	0	4	1
A	managerRegistrationExtraRules()	0	5	1
A	finalizeManagerValidator()	0	3	1

<?php

namespace App\Services\Validation;

use Illuminate\Support\Facades\Validator;
use App\Services\Validation\Rules\PasswordFormatRule;

class RegistrationValidator
{
    public static function basicRules()

Method \App\Services\Validation\RegistrationValidator::basicRules() does not have return type hint nor @return annotation for its return value.

Missing doc comment for function basicRules()

    {
        return [
            'name' => 'required|string|max:255',
            'email' => 'required|string|email|max:255|unique:users',
            'password' => [
                'required',
                'min:8',
                new PasswordFormatRule,
                'confirmed'
            ],
        ];
    }

    public static function managerRegistrationExtraRules()

Method \App\Services\Validation\RegistrationValidator::managerRegistrationExtraRules() does not have return type hint nor @return annotation for its return value.

Missing doc comment for function managerRegistrationExtraRules()

    {
        return [
            'department' => 'required|integer',
            'gov_email' => 'nullable|required_unless:department,0|string|email|unique:users', // gov_email is required unless department is set to 0 (Not in Goverment)

Inline comments must start with a capital letter

        ];
    }

    /**
     * Get a validator for an incoming registration request.
     *
     * @param  array $data Incoming registration data.

@param annotation of method \App\Services\Validation\RegistrationValidator::userValidator() does not specify type hint for items of its traversable parameter $data.

     * @return \Illuminate\Contracts\Validation\Validator
     */
    public static function userValidator(array $data)

Method \App\Services\Validation\RegistrationValidator::userValidator() does not have return type hint for its return value but it should be possible to add it based on @return annotation "\Illuminate\Contracts\Validation\Validator".

    {
        return Validator::make($data, self::basicRules());
    }

    /**
     * Get a validator for an incoming Manager registration request.
     *
     * @param  array $data Incoming registration data.

@param annotation of method \App\Services\Validation\RegistrationValidator::managerValidator() does not specify type hint for items of its traversable parameter $data.

     * @return \Illuminate\Contracts\Validation\Validator
     */
    public static function managerValidator(array $data)

Method \App\Services\Validation\RegistrationValidator::managerValidator() does not have return type hint for its return value but it should be possible to add it based on @return annotation "\Illuminate\Contracts\Validation\Validator".

    {
        $managerRules = array_merge(self::basicRules(), self::managerRegistrationExtraRules());
        return Validator::make($data, $managerRules);
    }

    /**
     * Get a validator for an incoming finishManagerRegistration request.
     *
     * @param  array $data Incoming registration data.

@param annotation of method \App\Services\Validation\RegistrationValidator::finalizeManagerValidator() does not specify type hint for items of its traversable parameter $data.

     * @return \Illuminate\Contracts\Validation\Validator
     */
    public static function finalizeManagerValidator(array $data)

Method \App\Services\Validation\RegistrationValidator::finalizeManagerValidator() does not have return type hint for its return value but it should be possible to add it based on @return annotation "\Illuminate\Contracts\Validation\Validator".

    {
        return Validator::make($data, self::managerRegistrationExtraRules());
    }
}