GCTC-NTGC / TalentCloud

app/Models/Criteria.php

Indentation +2 added lines, -2 removed lines

@@ -28,8 +28,8 @@
  * @property string $level_description The localized description of the skill level (accounts for skill type).
  *
  *  Localized Properties:
-  * @property string $description
-  * @property string $specificity
+ * @property string $description
+ * @property string $specificity
  */
 class Criteria extends BaseModel
 {

app/Models/JobPoster.php

Spacing +2 added lines, -2 removed lines

@@ -366,7 +366,7 @@ 
      */
     public function submitted_applications() // phpcs:ignore
     {
-        return $this->hasMany(\App\Models\JobApplication::class)->whereDoesntHave('application_status', function ($query): void {
+        return $this->hasMany(\App\Models\JobApplication::class)->whereDoesntHave('application_status', function($query): void {
             $query->where('name', 'draft');
         });
     }
@@ -555,7 +555,7 @@ 
     public function getClassificationMessageAttribute()
     {
         if ($this->classification_id !== null && $this->classification_level !== null) {
-            return $this->classification->key . '-0' . $this->classification_level;
+            return $this->classification->key.'-0'.$this->classification_level;
         }
         return null;
     }

app/Models/Manager.php

Spacing +1 added lines, -1 removed lines

@@ -187,7 +187,7 @@
     public function getFullNameAttribute(): string
     {
         if ($this->user !== null) {
-            return $this->user->first_name . ' ' . $this->user->last_name;
+            return $this->user->first_name.' '.$this->user->last_name;
         }
         return '';
     }

app/Http/Controllers/JobController.php

Spacing +2 added lines, -2 removed lines

@@ -126,12 +126,12 @@
         // TODO: replace route('manager.show',manager.id) in templates with link using slug.
         $criteria = [
             'essential' => $jobPoster->criteria->filter(
-                function ($value, $key) {
+                function($value, $key) {
                     return $value->criteria_type->name == 'essential';
                 }
             ),
             'asset' => $jobPoster->criteria->filter(
-                function ($value, $key) {
+                function($value, $key) {
                     return $value->criteria_type->name == 'asset';
                 }
             ),

database/factories/JobPosterFactory.php

Spacing +8 added lines, -8 removed lines

@@ -17,7 +17,7 @@ 
 
 $faker_fr = Faker\Factory::create('fr');
 
-$factory->define(JobPoster::class, function (Faker\Generator $faker) use ($faker_fr) {
+$factory->define(JobPoster::class, function(Faker\Generator $faker) use ($faker_fr) {
     $closeDate = $faker->dateTimeBetween('now', '1 months')->format('Y-m-d');
     $openDate = $faker->dateTimeBetween('-1 months', 'now')->format('Y-m-d');
     $startDate = $faker->dateTimeBetween('1 months', '2 months')->format('Y-m-d');
@@ -60,7 +60,7 @@ 
         'security_clearance_id' => SecurityClearance::inRandomOrder()->first()->id,
         'language_requirement_id' => LanguageRequirement::inRandomOrder()->first()->id,
         'remote_work_allowed' => $faker->boolean(50),
-        'manager_id' => function () {
+        'manager_id' => function() {
             return factory(Manager::class)->create()->id;
         },
         'team_size' => $faker->numberBetween(5, 30),
@@ -98,7 +98,7 @@ 
     ];
 });
 
-$factory->afterCreating(JobPoster::class, function ($jp) : void {
+$factory->afterCreating(JobPoster::class, function($jp) : void {
     $jp->criteria()->saveMany(factory(Criteria::class, 5)->make([
         'job_poster_id' => $jp->id
     ]));
@@ -113,7 +113,7 @@ 
 $factory->state(
     JobPoster::class,
     'byUpgradedManager',
-    ['manager_id' => function () {
+    ['manager_id' => function() {
             return factory(Manager::class)->state('upgraded')->create()->id;
     }]
 );
@@ -121,7 +121,7 @@ 
 $factory->state(
     JobPoster::class,
     'published',
-    function (Faker\Generator $faker) {
+    function(Faker\Generator $faker) {
         return [
             'published' => true,
             'published_at' => $faker->dateTimeBetween('-1 months', '-3 weeks')
@@ -132,7 +132,7 @@ 
 $factory->state(
     JobPoster::class,
     'closed',
-    function (Faker\Generator $faker) {
+    function(Faker\Generator $faker) {
         return [
             'published' => true,
             'published_at' => $faker->dateTimeBetween('-1 months', '-3 weeks'),
@@ -144,7 +144,7 @@ 
 $factory->state(
     JobPoster::class,
     'draft',
-    function (Faker\Generator $faker) {
+    function(Faker\Generator $faker) {
         return [
             'published' => false,
             'open_date_time' => ptDayStartToUtcTime($faker->dateTimeBetween('5 days', '10 days')->format('Y-m-d')),
@@ -158,7 +158,7 @@ 
 $factory->state(
     JobPoster::class,
     'review_requested',
-    function (Faker\Generator $faker) {
+    function(Faker\Generator $faker) {
         return [
             'published' => false,
             'open_date_time' => ptDayStartToUtcTime($faker->dateTimeBetween('5 days', '10 days')->format('Y-m-d')),

app/Traits/RememberDeviceTrait.php

Spacing +3 added lines, -3 removed lines

@@ -20,8 +20,8 @@ 
      */
     public function getRememberDeviceToken()
     {
-        if (! empty($this->getRememberDeviceTokenName())) {
-            return (string) $this->{$this->getRememberDeviceTokenName()};
+        if (!empty($this->getRememberDeviceTokenName())) {
+            return (string)$this->{$this->getRememberDeviceTokenName()};
         }
     }
 
@@ -33,7 +33,7 @@ 
      */
     public function setRememberDeviceToken($value)
     {
-        if (! empty($this->getRememberDeviceTokenName())) {
+        if (!empty($this->getRememberDeviceTokenName())) {
             // Make sure new value is immediately saved to db, as well as to model object.
             $this->where('id', $this->id)->update([$this->getRememberDeviceTokenName() => $value]);
             $this->{$this->getRememberDeviceTokenName()} = $value;

app/Http/Middleware/Google2FA.php

Indentation +3 added lines, -3 removed lines

@@ -23,9 +23,9 @@
             $remember = $request->cookie($user->getRememberDeviceKey());
             // If tokens do not match, cookie is no longer valid.
             if ($remember !== null && $remember !== $user->getRememberDeviceToken()) {
-                 Cookie::queue(
-                     Cookie::forget($user->getRememberDeviceKey())
-                 );
+                    Cookie::queue(
+                        Cookie::forget($user->getRememberDeviceKey())
+                    );
             }
 
             if ($authenticator->isAuthenticated() || ($remember !== null && $remember === $user->getRememberDeviceToken())) {

app/Http/Controllers/Auth/TwoFactorController.php

Indentation +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
             $user->email,
             $secret
         );
-         $profile_url = '';
+            $profile_url = '';
         if (WhichPortal::isApplicantPortal()) {
             $profile_url = route('settings.edit');
         } elseif (WhichPortal::isManagerPortal()) {

routes/web.php

Spacing +18 added lines, -18 removed lines

@@ -19,10 +19,10 @@ 
         'prefix' => LaravelLocalization::setLocale(),
         'middleware' => ['localeSessionRedirect', 'localizationRedirect', 'localeViewPath']
     ],
-    function (): void {
+    function(): void {
         /* Routes used for local demos */
         /* If creating public demos, make sure to add a meta robots noindex, nofollow tag */
-        Route::group(['prefix' => 'demo'], function (): void {
+        Route::group(['prefix' => 'demo'], function(): void {
 
             /* Temporary Blog Index */
             Route::view('blog', 'common/blog-index')->middleware('localOnly')->name('blog');
@@ -51,13 +51,13 @@ 
             Route::view('builder-08', 'manager/builder-08')->middleware('localOnly')->name('jpb8');
         });
 
-        Route::group(['prefix' => config('app.applicant_prefix')], function (): void {
+        Route::group(['prefix' => config('app.applicant_prefix')], function(): void {
 
             Route::get('two-factor/use-recovery-code', 'Auth\RecoveryCodeController@use')->name('recovery_codes.use');
             Route::post('two-factor/use-recovery-code', 'Auth\RecoveryCodeController@authenticate')->name('recovery_codes.authenticate');
 
             /* Require being logged in */
-            Route::middleware(['auth'])->group(function () : void {
+            Route::middleware(['auth'])->group(function() : void {
 
                 /* Managers */
                 Route::get('managers/{manager}', 'ManagerProfileController@show')
@@ -69,7 +69,7 @@ 
              * IF user is logged in AND has activated 2fa, require one-time password.
              * This should include all routes except those related to authentication, to avoid loops.
              */
-            Route::middleware(['2fa'])->group(function (): void {
+            Route::middleware(['2fa'])->group(function(): void {
                 Route::post('/2fa', 'Auth\TwoFactorController@redirectToExpected')->name('2fa');
 
                 /* Home */
@@ -83,7 +83,7 @@ 
                     ->name('jobs.show');
 
                 /* Require being logged in as applicant */
-                Route::middleware(['auth', 'role:applicant'])->group(function (): void {
+                Route::middleware(['auth', 'role:applicant'])->group(function(): void {
 
                     // Application permissions are handled within the controller instead of with middleware.
                     /* Applications */
@@ -253,9 +253,9 @@ 
         });
 
         /* Manager Portal =========================================================== */
-        Route::group(['prefix' => config('app.manager_prefix')], function (): void {
+        Route::group(['prefix' => config('app.manager_prefix')], function(): void {
 
-            Route::middleware(['finishManagerRegistration'])->group(function (): void {
+            Route::middleware(['finishManagerRegistration'])->group(function(): void {
 
                 Route::get('two-factor/use-recovery-code', 'Auth\RecoveryCodeController@use')->name('manager.recovery_codes.use');
                 Route::post('two-factor/use-recovery-code', 'Auth\RecoveryCodeController@authenticate')->name('manager.recovery_codes.authenticate');
@@ -264,7 +264,7 @@ 
                  * IF user is logged in AND has activated 2fa, require one-time password.
                  * This should include all routes except those related to authentication, to avoid loops.
                  */
-                Route::middleware(['2fa'])->group(function (): void {
+                Route::middleware(['2fa'])->group(function(): void {
 
                     Route::post('/2fa', 'Auth\TwoFactorController@redirectToExpected')->name('manager.2fa');
 
@@ -282,7 +282,7 @@ 
                         'ManagerProfileController@faq'
                     )->name('manager.faq.section');
 
-                    Route::middleware(['auth', 'role:manager'])->group(function (): void {
+                    Route::middleware(['auth', 'role:manager'])->group(function(): void {
 
                         Route::get('profile', 'ManagerProfileController@editAuthenticated')->name('manager.profile');
 
@@ -297,7 +297,7 @@ 
                             ->name('manager.profile.update');
 
                         /* Reviewing applications/applicants requires two-factor authentication */
-                        Route::middleware(['2fa.required'])->group(function (): void {
+                        Route::middleware(['2fa.required'])->group(function(): void {
                             Route::get('jobs/{jobPoster}/applications', 'ApplicationByJobController@index')
                                 ->where('jobPoster', '[0-9]+')
                                 ->middleware('can:reviewApplicationsFor,jobPoster')
@@ -430,7 +430,7 @@ 
 
             // These routes must be excluded from the finishManagerRegistration middleware
             // to avoid an infinite loop of redirects.
-            Route::middleware(['auth', 'role:manager'])->group(function (): void {
+            Route::middleware(['auth', 'role:manager'])->group(function(): void {
                 Route::get('first-visit', 'Auth\FirstVisitController@showFirstVisitManagerForm')
                     ->name('manager.first_visit');
                 Route::post('finish_registration', 'Auth\FirstVisitController@finishManagerRegistration')
@@ -456,7 +456,7 @@ 
         /* AJAX calls =============================================================== */
 
         /* Require being logged in */
-        Route::middleware(['auth'])->group(function (): void {
+        Route::middleware(['auth'])->group(function(): void {
 
             Route::delete('courses/{course}', 'CourseController@destroy')
                 ->middleware('can:delete,course')
@@ -521,7 +521,7 @@ 
                 'prefix' => 'admin',
                 'middleware' => ['auth', 'role:admin']
             ],
-            function (): void {
+            function(): void {
                 /* Edit Job */
                 Route::get('jobs/{jobPoster}/edit', 'JobController@edit')
                     ->where('jobPoster', '[0-9]+')
@@ -542,7 +542,7 @@ 
     'prefix' => 'admin',
     'middleware' => ['auth', 'role:admin']
     ],
-    function (): void {
+    function(): void {
         // This page is non-localized, because the middleware that redirects to localized
         // pages changes POSTs to GETs and messes up the request.
         Route::post('jobs/create/as-manager/{manager}', 'JobController@createAsManager')
@@ -564,7 +564,7 @@ 
 /* ALL NON-LOCALIZED ROUTES **/
 
 /* API routes - currently using same default http auth, but not localized */
-Route::group(['prefix' => 'api'], function (): void {
+Route::group(['prefix' => 'api'], function(): void {
     // Protected by a gate in the controller, instead of policy middleware.
     Route::get('jobs/{jobPoster}/assessment-plan', 'AssessmentPlanController@getForJob');
     // Public, not protected by policy or gate.
@@ -607,7 +607,7 @@ 
         ->name('api.jobs.submit');
     Route::resource('jobs', 'Api\JobApiController')->only([
         'show', 'store', 'update'
-    ])->names([ // Specify custom names because default names collied with existing routes.
+    ])->names([// Specify custom names because default names collied with existing routes.
         'show' => 'api.jobs.show',
         'store' => 'api.jobs.store',
         'update' => 'api.jobs.update'
@@ -615,7 +615,7 @@ 
 
     Route::resource('managers', 'Api\ManagerApiController')->only([
         'show', 'update'
-    ])->names([ // Specify custom names because default names collied with existing routes.
+    ])->names([// Specify custom names because default names collied with existing routes.
         'show' => 'api.managers.show',
         'update' => 'api.managers.update'
     ]);