App\Listeners\LogApplicationRetrieved::handle()

Complexity

Conditions	3
Paths	3

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

0

<?php
    public function handle(ApplicationRetrieved $event)
    {
        $application = $event->application;

        if (Auth::check()) {
            $user = Auth::user();

            //Don't bother logging when an applicant views their own application
            if ($application->applicant->user->id != $user->id) {

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                $applicationText = "{id=".$application->id.", status=".$application->application_status->name."}";
                $userText = "{id=".$user->id.", email=".$user->email.", role=".$user->user_role->name."}";

Accessing email on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

Accessing user_role on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                Log::notice("Application viewed: application ".$applicationText." viewed by user ".$userText);
            }
        } else {
            $applicationText = "{id=".$application->id.", status=".$application->application_status->name."}";
            Log::notice("Application retrieved: application ".$applicationText." retrieved with no user logged in");
        }