App\Listeners\LogApplicationRetrieved

Complexity

Total Complexity

4

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	handle()	0	16	3
A	__construct()	0	2	1

<?php

Missing file doc comment

namespace App\Listeners;

use App\Events\ApplicationRetrieved;
use Illuminate\Queue\InteractsWithQueue;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Support\Facades\Log;
use Illuminate\Support\Facades\Auth;

class LogApplicationRetrieved

Missing doc comment for class LogApplicationRetrieved

{
    /**
     * Create the event listener.
     *
     * @return void
     */
    public function __construct()
    {
        //
    }

    /**
     * Handle the event.
     *
     * @param  AppliationRetrieved  $event

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @return void

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function handle(ApplicationRetrieved $event)
    {
        $application = $event->application;

        if (Auth::check()) {
            $user = Auth::user();

            //Don't bother logging when an applicant views their own application
            if ($application->applicant->user->id != $user->id) {

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                $applicationText = "{id=".$application->id.", status=".$application->application_status->name."}";
                $userText = "{id=".$user->id.", email=".$user->email.", role=".$user->user_role->name."}";

Accessing email on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

Accessing user_role on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                Log::notice("Application viewed: application ".$applicationText." viewed by user ".$userText);
            }
        } else {
            $applicationText = "{id=".$application->id.", status=".$application->application_status->name."}";
            Log::notice("Application retrieved: application ".$applicationText." retrieved with no user logged in");
        }
    }
}