App\Listeners\ApplicationStatusChanged::handle()

Complexity

Conditions	4
Paths	6

Size

Total Lines	23
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

0

<?php
    public function handle(ApplicationSaved $event)
    {
        $application = $event->application;

        if (Auth::check()) {
            $user = Auth::user();
            $userText = "{id=".$user->id.", email=".$user->email."}";

Accessing email on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        } else {
            $userText = "{null}";
        }

        //Log when application is first created
        if($application->wasRecentlyCreated) {

Expected "if (...) {\n"; found "if(...) {\n"

            $applicationText = "{id=".$application->id.", status=".$application->application_status->name."}";

            Log::notice("Application created: application ".$applicationText." has been created by user ".$userText);
        }
        //Log if application status has been changed
        else if ($application->application_status_id != $application->getOriginal('application_status_id')) {

Expected "} else if (...) \n"; found "\n //Log if application status has been changed\n else if (...) {\n"

            $applicationText = "{id=".$application->id."}";
            $statusText = "{".$application->application_status->name."}";

            Log::notice("Application status changed: application ".$applicationText." has been changed to ".$statusText." by user ".$userText);
        }