App\Listeners\ApplicationStatusChanged

Complexity

Total Complexity

5

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	2	1
A	handle()	0	23	4

<?php

Missing file doc comment

namespace App\Listeners;

use App\Events\ApplicationSaved;
use Illuminate\Queue\InteractsWithQueue;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Support\Facades\Log;
use Illuminate\Support\Facades\Auth;

class ApplicationStatusChanged

Missing doc comment for class ApplicationStatusChanged

{
    /**
     * Create the event listener.
     *
     * @return void
     */
    public function __construct()
    {
        //
    }

    /**
     * Handle the event.
     *
     * @param  ApplicationSaved  $event

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @return void

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function handle(ApplicationSaved $event)
    {
        $application = $event->application;

        if (Auth::check()) {
            $user = Auth::user();
            $userText = "{id=".$user->id.", email=".$user->email."}";

Accessing email on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        } else {
            $userText = "{null}";
        }

        //Log when application is first created
        if($application->wasRecentlyCreated) {

Expected "if (...) {\n"; found "if(...) {\n"

            $applicationText = "{id=".$application->id.", status=".$application->application_status->name."}";

            Log::notice("Application created: application ".$applicationText." has been created by user ".$userText);
        }
        //Log if application status has been changed
        else if ($application->application_status_id != $application->getOriginal('application_status_id')) {

Expected "} else if (...) \n"; found "\n //Log if application status has been changed\n else if (...) {\n"

            $applicationText = "{id=".$application->id."}";
            $statusText = "{".$application->application_status->name."}";

            Log::notice("Application status changed: application ".$applicationText." has been changed to ".$statusText." by user ".$userText);
        }
    }
}