WorkSamplesController::edit() - Code Metrics - Inspection of "New complicated applicant profile is fully functio..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — dev (#319)

by Tristan

created 2018-09-14 15:10 UTC

WorkSamplesController::edit() A

↳ Parent: WorkSamplesController

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
eloc	6
dl	0
loc	8
ccs	0
cts	7
cp	0
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	2
crap	2

<?php


namespace App\Http\Controllers;

use Illuminate\Support\Facades\Lang;
use Illuminate\Http\Request;
use Barryvdh\Debugbar\Facade as Debugbar;
use App\Http\Controllers\Controller;
use App\Models\Skill;
use App\Models\Applicant;
use App\Models\WorkSample;
use App\Models\Lookup\FileType;

class WorkSamplesController extends Controller

{

    /**
     * Display the Work Samples associated with the applicant.
     *
     * @param  \App\Models\Applicant  $applicant

     * @return \Illuminate\Http\Response

     */
    public function show(Applicant $applicant)
    public function show(/** @scrutinizer ignore-unused */ Applicant $applicant)
    {
        //

    }

    /**
     * Show the form for editing the applicant's work samples
     *
     * @param  Request  $request

     * @param  \App\Models\Applicant  $applicant

     * @return \Illuminate\Http\Response

     */
    public function edit(Request $request, Applicant $applicant)
    {
        return view('applicant/profile_05_portfolio', [

            'applicant' => $applicant,
            'profile' => Lang::get('applicant/profile_work_samples'), //TODO
            'relative_template' => Lang::get('common/relatives'),
            'file_types' => FileType::all(),
            'form_submit_action' => route('profile.work_samples.update', $applicant),
            'form_submit_action' => route('profile.work_samples.update', /** @scrutinizer ignore-type */ $applicant),
        ]);
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
    }

    /**
     * Update the applicant's workSamples in storage.
     *
     * @param  \Illuminate\Http\Request  $request

     * @param  \App\Models\Applicant  $applicant

     * @return \Illuminate\Http\Response

     */
    public function update(Request $request, Applicant $applicant)
    {

        $input = $request->input();

        $workSamples = $input['work_samples'];

        //Delete old workSamples that weren't resubmitted
        //Note: this must be done before adding new workSamples, so we don't delete
        // them right after adding them
        foreach($applicant->work_samples as $oldWorkSample) {

            //Check if no workSamples were resubmitted, or if this specific one wasn't
            if (!isset($workSamples['old']) ||
                !isset($workSamples['old'][$oldWorkSample->id])) {

                $oldWorkSample->delete();
            }
        }

        //Save new workSamples
        if (isset($workSamples['new'])) {
            foreach($workSamples['new'] as $workSampleInput) {

                $workSample = new WorkSample();
                $workSample->applicant_id = $applicant->id;
                $workSample->fill([

                    'name' => $workSampleInput['name'],
                    'date_created' => isset($workSampleInput['date_created']) ? $workSampleInput['date_created'] : null,
                    'file_type_id' => $workSampleInput['file_type_id'],
                    'url' => $workSampleInput['url'],
                    'description' => $workSampleInput['description'],
                ]);
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.

                $workSample->save();

                $skillDeclarationIds =$this->getRelativeIds($workSampleInput, 'skills');
                $workSample->skill_declarations()->sync($skillDeclarationIds);
            }
        }

        //Update old workSamples
        if (isset($workSamples['old'])) {
            foreach($workSamples['old'] as $id=>$workSampleInput) {

                //Ensure this workSample belongs to this applicant
                $workSample = $applicant->work_samples->firstWhere('id', $id);
                if ($workSample != null) {
                    $workSample->fill([

                        'name' => $workSampleInput['name'],
                        'date_created' => isset($workSampleInput['date_created']) ? $workSampleInput['date_created'] : null,
                        'file_type_id' => $workSampleInput['file_type_id'],
                        'url' => $workSampleInput['url'],
                        'description' => $workSampleInput['description'],
                    ]);
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
                    $workSample->save();

                    $skillDeclarationIds =$this->getRelativeIds($workSampleInput, 'skills');
                    $workSample->skill_declarations()->sync($skillDeclarationIds);
                } else {
                    Debugbar::warning('Applicant '.$applicant->id.' attempted to update workSample with invalid id '.$id);
                }
            }
        }

        return redirect( route('profile.work_samples.edit', $applicant) );
        return redirect( route('profile.work_samples.edit', /** @scrutinizer ignore-type */ $applicant) );
        // Debugbar::info($input);
        // return view('applicant/profile_04_workSamples', [
        //     'applicant' => $applicant,
        //     'profile' => Lang::get('applicant/profile_workSamples'),
        //     'relative_template' => Lang::get('common/relatives'),
        //     'skills' => Skill::all(),
        //     'relationships' => Relationship::all(),
        //     'form_submit_action' => route('profile.workSamples.update', $applicant),
        // ]);
    }

}


GCTC-NTGC / TalentCloud

Pull Request — dev (#319)

WorkSamplesController::edit() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like