App\Http\Controllers\WorkSamplesController

Complexity

Total Complexity

13

Size/Duplication

Total Lines	102
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	show()	0	2	1
A	edit()	0	8	1
B	update()	0	62	11

<?php

Missing file doc comment

namespace App\Http\Controllers;

use Illuminate\Support\Facades\Lang;
use Illuminate\Http\Request;
use Barryvdh\Debugbar\Facade as Debugbar;
use App\Http\Controllers\Controller;
use App\Models\Skill;
use App\Models\Applicant;
use App\Models\WorkSample;
use App\Models\Lookup\FileType;

class WorkSamplesController extends Controller

Missing doc comment for class WorkSamplesController

{

    /**
     * Display the Work Samples associated with the applicant.
     *
     * @param  \App\Models\Applicant  $applicant

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function show(Applicant $applicant)

The parameter $applicant is not used and could be removed.

    {
        //

    }

    /**
     * Show the form for editing the applicant's work samples
     *
     * @param  Request  $request

Missing parameter comment

Expected 15 spaces after parameter type; 2 found

     * @param  \App\Models\Applicant  $applicant

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function edit(Request $request, Applicant $applicant)
    {
        return view('applicant/profile_05_portfolio', [

The expression return view('applicant/profile_05_portfolio', array('applicant' => $applicant, 'profile' => Illuminate\Support\Facades\Lang::get('applicant/profile_work_samples'), 'relative_template' => Illuminate\Support\Facades\Lang::get('common/relatives'), 'file_types' => App\Models\Lookup\FileType::all(), 'form_submit_action' => route('profile.work_samples.update', $applicant))) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

The opening parenthesis of a multi-line function call should be the last content on the line.

            'applicant' => $applicant,
            'profile' => Lang::get('applicant/profile_work_samples'), //TODO
            'relative_template' => Lang::get('common/relatives'),
            'file_types' => FileType::all(),
            'form_submit_action' => route('profile.work_samples.update', $applicant),

$applicant of type App\Models\Applicant is incompatible with the type array expected by parameter $parameters of route().

        ]);

For multi-line function calls, the closing parenthesis should be on a new line.

    }

    /**
     * Update the applicant's workSamples in storage.
     *
     * @param  \Illuminate\Http\Request  $request

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @param  \App\Models\Applicant  $applicant

Missing parameter comment

Expected 4 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function update(Request $request, Applicant $applicant)
    {

        $input = $request->input();

        $workSamples = $input['work_samples'];

        //Delete old workSamples that weren't resubmitted
        //Note: this must be done before adding new workSamples, so we don't delete
        // them right after adding them
        foreach($applicant->work_samples as $oldWorkSample) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

            //Check if no workSamples were resubmitted, or if this specific one wasn't
            if (!isset($workSamples['old']) ||
                !isset($workSamples['old'][$oldWorkSample->id])) {

Each line in a multi-line IF statement must begin with a boolean operator

Closing parenthesis of a multi-line IF statement must be on a new line

                $oldWorkSample->delete();
            }
        }

        //Save new workSamples
        if (isset($workSamples['new'])) {
            foreach($workSamples['new'] as $workSampleInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                $workSample = new WorkSample();
                $workSample->applicant_id = $applicant->id;
                $workSample->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

                    'name' => $workSampleInput['name'],
                    'date_created' => isset($workSampleInput['date_created']) ? $workSampleInput['date_created'] : null,
                    'file_type_id' => $workSampleInput['file_type_id'],
                    'url' => $workSampleInput['url'],
                    'description' => $workSampleInput['description'],
                ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                $workSample->save();

                $skillDeclarationIds =$this->getRelativeIds($workSampleInput, 'skills');
                $workSample->skill_declarations()->sync($skillDeclarationIds);
            }
        }

        //Update old workSamples
        if (isset($workSamples['old'])) {
            foreach($workSamples['old'] as $id=>$workSampleInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                //Ensure this workSample belongs to this applicant
                $workSample = $applicant->work_samples->firstWhere('id', $id);
                if ($workSample != null) {
                    $workSample->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

                        'name' => $workSampleInput['name'],
                        'date_created' => isset($workSampleInput['date_created']) ? $workSampleInput['date_created'] : null,
                        'file_type_id' => $workSampleInput['file_type_id'],
                        'url' => $workSampleInput['url'],
                        'description' => $workSampleInput['description'],
                    ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                    $workSample->save();

                    $skillDeclarationIds =$this->getRelativeIds($workSampleInput, 'skills');
                    $workSample->skill_declarations()->sync($skillDeclarationIds);
                } else {
                    Debugbar::warning('Applicant '.$applicant->id.' attempted to update workSample with invalid id '.$id);
                }
            }
        }

        return redirect( route('profile.work_samples.edit', $applicant) );

The expression return redirect(route('profile.work_samples.edit', $applicant)) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

$applicant of type App\Models\Applicant is incompatible with the type array expected by parameter $parameters of route().

        // Debugbar::info($input);
        // return view('applicant/profile_04_workSamples', [
        //     'applicant' => $applicant,
        //     'profile' => Lang::get('applicant/profile_workSamples'),
        //     'relative_template' => Lang::get('common/relatives'),
        //     'skills' => Skill::all(),
        //     'relationships' => Relationship::all(),
        //     'form_submit_action' => route('profile.workSamples.update', $applicant),
        // ]);
    }

}