App\Services\Validation\ExperienceValidator::validate()

Complexity

Conditions	1
Paths	1

Size

Total Lines	29
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function validate(Request $request, Applicant $applicant)

The parameter $applicant is not used and could be removed.

The type App\Services\Validation\Request was not found. Did you mean Request? If so, make sure to prefix the type with \.

You must use "/**" style comments for a function comment

    {
       $request->validate([

Opening statement of multi-line function call not indented correctly; expected 4 spaces but found 7

The opening parenthesis of a multi-line function call should be the last content on the line.

            'degrees[:template][:id][area_of_study]' => [
                'required',
                
            ],
            'degrees[:template][:id][institution]' => [
                'nullable', // Institution is nullable because applicant might have acquired the skills/knowledge on their own or some other way.
                'max:255',
                
           ],
            'courses[:template][:id][name]' => [
                'required',
            ],
            'courses[:template][:id][institution]' => [
                'required', // If someone declares a course we should require them to say where they completed this course.
            ],
            'work_experiences[:template][:id][role]' => [
                'required', // If they decide to fill out Equivalent Experience, a Role should be well defined,
                
            ], 
            'work_experiences[:template][:id][company]' => [
                'nullable', // Not every role belongs to a Company or Group. Someone could be a Hobbyist and as such might be hesistant to put something else down here. So nullable.
                
            ],
            'work_experiences[:template][:id][description]' => [
                'required',
                'min:2500' // Hiring managers will probably like atleast a paragraph's worth of information here. Since you tend to have to back up Equivalent Experience more often than other forms of "Experience".
            ]
}