App\Services\Validation\ExperienceValidator

Complexity

Total Complexity

1

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	validate()	0	29	1

<?php

Missing file doc comment

namespace App\Services\Validation;

use App\Http\Controllers\ExperienceController;


class ExperienceValidator

Missing doc comment for class ExperienceValidator

{
/* 
 * Requires error message implementation and proper namespace usage. 
 */

    public function validate(Request $request, Applicant $applicant)

The parameter $applicant is not used and could be removed.

The type App\Services\Validation\Request was not found. Did you mean Request? If so, make sure to prefix the type with \.

You must use "/**" style comments for a function comment

    {
       $request->validate([

Opening statement of multi-line function call not indented correctly; expected 4 spaces but found 7

The opening parenthesis of a multi-line function call should be the last content on the line.

            'degrees[:template][:id][area_of_study]' => [
                'required',
                
            ],
            'degrees[:template][:id][institution]' => [
                'nullable', // Institution is nullable because applicant might have acquired the skills/knowledge on their own or some other way.
                'max:255',
                
           ],
            'courses[:template][:id][name]' => [
                'required',
            ],
            'courses[:template][:id][institution]' => [
                'required', // If someone declares a course we should require them to say where they completed this course.
            ],
            'work_experiences[:template][:id][role]' => [
                'required', // If they decide to fill out Equivalent Experience, a Role should be well defined,
                
            ], 
            'work_experiences[:template][:id][company]' => [
                'nullable', // Not every role belongs to a Company or Group. Someone could be a Hobbyist and as such might be hesistant to put something else down here. So nullable.
                
            ],
            'work_experiences[:template][:id][description]' => [
                'required',
                'min:2500' // Hiring managers will probably like atleast a paragraph's worth of information here. Since you tend to have to back up Equivalent Experience more often than other forms of "Experience".
            ]
            
        ]);

For multi-line function calls, the closing parenthesis should be on a new line.

    } 
}