GCTC-NTGC / TalentCloud

app/Models/User.php

Indentation +7 added lines, -7 removed lines

@@ -190,10 +190,10 @@ 
     }
 
     /**
-    * Check if the user has the specified role.
-    * @param string $role This may be either 'applicant', 'manager', 'hr_advisor' or 'admin'.
-    * @return boolean
-    */
+     * Check if the user has the specified role.
+     * @param string $role This may be either 'applicant', 'manager', 'hr_advisor' or 'admin'.
+     * @return boolean
+     */
     public function hasRole($role)
     {
         switch ($role) {
@@ -214,8 +214,8 @@ 
      * Set this user to the specified role.
      *
      * @param string $role Must be either 'applicant', 'manager', 'hr_advisor' or 'admin'.
-    * @return void
-    */
+     * @return void
+     */
     public function setRole(string $role): void
     {
         $this->user_role()->associate(UserRole::where('name', $role)->firstOrFail());
@@ -250,7 +250,7 @@ 
      * Returns a user's full name.
      *
      * @return string
-    */
+     */
     public function getFullNameAttribute(): string
     {
         return $this->first_name . ' ' . $this->last_name;

app/Http/ViewComposers/MenuComposer.php

Indentation +2 added lines, -2 removed lines

@@ -238,12 +238,12 @@
                 'logout_link' => route('hr_advisor.logout'),
             ];
         } elseif (WhichPortal::isAdminPortal()) {
-             $loginModals = [
+                $loginModals = [
                 'modals' => Lang::get('common/login_modals'),
                 'register_link' => route('register'),
                 'login_link' => backpack_url('login'),
                 'logout_link' => backpack_url('logout'),
-             ];
+                ];
         } else {
             $loginModals = [
                 'modals' => Lang::get('common/login_modals'),

app/Models/HrAdvisor.php

Spacing +1 added lines, -1 removed lines

@@ -76,7 +76,7 @@
     public function getNameAttribute(): string
     {
         if ($this->user !== null) {
-            return $this->user->first_name . ' ' . $this->user->last_name;
+            return $this->user->first_name.' '.$this->user->last_name;
         }
         return '';
     }

routes/web.php

Spacing +18 added lines, -18 removed lines

@@ -18,10 +18,10 @@ 
         'prefix' => LaravelLocalization::setLocale(),
         'middleware' => ['localeSessionRedirect', 'localizationRedirect', 'localeViewPath']
     ],
-    function () : void {
+    function() : void {
         /** ADD ALL LOCALIZED ROUTES INSIDE THIS GROUP **/
 
-        Route::group(['prefix' => 'demo'], function () : void {
+        Route::group(['prefix' => 'demo'], function() : void {
 
             /* Temporary Blog Index */
             Route::view('blog', 'common/blog-index')->middleware('localOnly')->name('blog');
@@ -51,7 +51,7 @@ 
         });
 
 
-        Route::group(['prefix' => config('app.applicant_prefix')], function () : void {
+        Route::group(['prefix' => config('app.applicant_prefix')], function() : void {
 
             /* Home */
             Route::get('/', 'HomepageController@applicant')->name('home');
@@ -64,7 +64,7 @@ 
                 ->name('jobs.show');
 
             /* Require being logged in */
-            Route::middleware(['auth'])->group(function () : void {
+            Route::middleware(['auth'])->group(function() : void {
                 /* Managers */
                 Route::get('managers/{manager}', 'ManagerProfileController@show')
                     ->middleware('can:view,manager')
@@ -72,7 +72,7 @@ 
             });
 
             /* Require being logged in as applicant */
-            Route::middleware(['auth', 'role:applicant'])->group(function () : void {
+            Route::middleware(['auth', 'role:applicant'])->group(function() : void {
 
             // Application permissions are handled within the controller instead of with middleware
                 /* Applications */
@@ -207,9 +207,9 @@ 
 
         Route::group([
             'prefix' => config('app.manager_prefix'),
-        ], function (): void {
+        ], function(): void {
 
-            Route::middleware(['finishManagerRegistration'])->group(function (): void {
+            Route::middleware(['finishManagerRegistration'])->group(function(): void {
 
                 /* Home */
                 Route::get('/', 'HomepageController@manager')->name('manager.home');
@@ -225,7 +225,7 @@ 
                     'ManagerProfileController@faq'
                 )->name('manager.faq.section');
 
-                Route::middleware(['auth', 'role:manager'])->group(function (): void {
+                Route::middleware(['auth', 'role:manager'])->group(function(): void {
 
                     Route::get('profile', 'ManagerProfileController@editAuthenticated')->name('manager.profile');
 
@@ -322,7 +322,7 @@ 
             });
 
             // These routes must be excluded from the finishManagerRegistration middleware to avoid an infinite loop of redirects
-            Route::middleware(['auth', 'role:manager'])->group(function (): void {
+            Route::middleware(['auth', 'role:manager'])->group(function(): void {
                 Route::get('first-visit', 'Auth\FirstVisitController@showFirstVisitManagerForm')
                     ->name('manager.first_visit');
                 Route::post('finish_registration', 'Auth\FirstVisitController@finishManagerRegistration')
@@ -348,7 +348,7 @@ 
         /* AJAX calls =============================================================== */
 
         /* Require being logged in */
-        Route::middleware(['auth'])->group(function () : void {
+        Route::middleware(['auth'])->group(function() : void {
 
             Route::delete('courses/{course}', 'CourseController@destroy')
                 ->middleware('can:delete,course')
@@ -413,7 +413,7 @@ 
                 'prefix' => 'admin',
                 'middleware' => ['auth', 'role:admin']
             ],
-            function (): void {
+            function(): void {
                 /* Edit Job */
                 Route::get('jobs/{jobPoster}/edit', 'JobController@edit')
                     ->where('jobPoster', '[0-9]+')
@@ -430,15 +430,15 @@ 
 
         Route::group([
             'prefix' => config('app.hr_prefix'),
-        ], function (): void {
+        ], function(): void {
 
-            Route::middleware(['finishHrRegistration'])->group(function (): void {
+            Route::middleware(['finishHrRegistration'])->group(function(): void {
 
                 Route::get('/', 'HomepageController@hr_advisor')->name('hr_advisor.home');
             });
 
             // These routes must be excluded from the finishHrAdvisorRegistration middleware to avoid an infinite loop of redirects
-            Route::middleware(['auth', 'role:hr_advisor'])->group(function (): void {
+            Route::middleware(['auth', 'role:hr_advisor'])->group(function(): void {
                 Route::get('first-visit', 'Auth\FirstVisitController@showFirstVisitHrForm')
                     ->name('hr_advisor.first_visit');
                 Route::post('finish_registration', 'Auth\FirstVisitController@finishHrRegistration')
@@ -469,7 +469,7 @@ 
         'prefix' => 'admin',
         'middleware' => ['auth', 'role:admin']
     ],
-    function (): void {
+    function(): void {
         // This page is non-localized, because the middleware that redirects to localized pages changes POSTs to GETs and messes up the request.
         Route::post('jobs/create/as-manager/{manager}', 'JobController@createAsManager')
             ->middleware('can:create,App\Models\JobPoster')
@@ -483,7 +483,7 @@ 
 
 
 /** API routes - currently using same default http auth, but not localized */
-Route::group(['prefix' => 'api'], function (): void {
+Route::group(['prefix' => 'api'], function(): void {
     // Protected by a gate in the controller, instead of policy middleware
     Route::get('jobs/{jobPoster}/assessment-plan', 'AssessmentPlanController@getForJob');
     // Public, not protected by policy or gate
@@ -528,7 +528,7 @@ 
         ->name('api.jobs.submit');
     Route::resource('jobs', 'Api\JobApiController')->only([
         'show', 'store', 'update'
-    ])->names([ // Specify custom names because default names collied with existing routes.
+    ])->names([// Specify custom names because default names collied with existing routes.
         'show' => 'api.jobs.show',
         'store' => 'api.jobs.store',
         'update' => 'api.jobs.update'
@@ -536,7 +536,7 @@ 
 
     Route::resource('managers', 'Api\ManagerApiController')->only([
         'show', 'update'
-    ])->names([ // Specify custom names because default names collied with existing routes
+    ])->names([// Specify custom names because default names collied with existing routes
         'show' => 'api.managers.show',
         'update' => 'api.managers.update'
     ]);

app/Providers/AuthServiceProvider.php

Spacing +1 added lines, -1 removed lines

@@ -65,7 +65,7 @@
      */
     protected function defineGates(): void
     {
-        Gate::define('view-assessment-plan', function ($user, $jobPoster) {
+        Gate::define('view-assessment-plan', function($user, $jobPoster) {
             return $user->isAdmin() ||
                 $user->isManager() && $jobPoster->manager->user_id === $user->id;
         });

app/Policies/JobPolicy.php

Indentation +7 added lines, -7 removed lines

@@ -103,13 +103,13 @@
             $jobPoster->isClosed();
     }
 
-     /**
-     * Determine whether the user can view the comments.
-     *
-     * @param \App\Models\User $user
-     * @param \App\Models\JobPoster $jobPoster
-     * @return bool
-     */
+        /**
+         * Determine whether the user can view the comments.
+         *
+         * @param \App\Models\User $user
+         * @param \App\Models\JobPoster $jobPoster
+         * @return bool
+         */
     public function viewComments(User $user, JobPoster $jobPoster) : bool
     {
         // Only the manager that created a comment can view the comment.

database/seeds/CommentSeeder.php

Spacing +1 added lines, -1 removed lines

@@ -15,7 +15,7 @@
     {
         $job_posters = JobPoster::all();
 
-        $job_posters->each(function ($job_poster) {
+        $job_posters->each(function($job_poster) {
             $job_poster->comments()->saveMany(factory(App\Models\Comment::class, 3)->make());
         });
     }

database/factories/UserFactory.php

Spacing +11 added lines, -11 removed lines

@@ -24,14 +24,14 @@ 
 
 $faker_fr = Faker\Factory::create('fr');
 
-$factory->define(User::class, function (Faker\Generator $faker) {
+$factory->define(User::class, function(Faker\Generator $faker) {
     static $password;
 
     return [
         'first_name' => $faker->firstName(),
         'last_name' => $faker->lastName(),
         'email' => $faker->unique()->safeEmail(),
-        'password' => $password ? : $password = Hash::make('password'),
+        'password' => $password ?: $password = Hash::make('password'),
         'is_confirmed' => 1,
         'user_role_id' => UserRole::where('name', 'basic')->first()->id, // Users should default to basic user role.
         'remember_token' => str_random(10),
@@ -39,7 +39,7 @@ 
     ];
 });
 
-$factory->state(User::class, 'upgradedManager', function (Faker\Generator $faker) {
+$factory->state(User::class, 'upgradedManager', function(Faker\Generator $faker) {
     return [
         'user_role_id' => UserRole::where('name', 'upgradedManager')->first()->id,
         'gov_email' => $faker->unique()->safeEmail(),
@@ -66,29 +66,29 @@ 
     'is_priority' => true
 ]);
 
-$factory->define(Applicant::class, function (Faker\Generator $faker) {
+$factory->define(Applicant::class, function(Faker\Generator $faker) {
     return [
         'twitter_username' => $faker->firstName(),
         'linkedin_url' => null,
         'tagline' => $faker->paragraph(),
         'personal_website' => $faker->url(),
         'is_snapshot' => false,
-        'user_id' => function () {
+        'user_id' => function() {
             return factory(User::class)->states('applicant')->create()->id;
         },
     ];
 });
 
-$factory->define(HrAdvisor::class, function () {
+$factory->define(HrAdvisor::class, function() {
     return [
         'department_id' => null,
-        'user_id' => function () {
+        'user_id' => function() {
             return factory(User::class)->state('hr_advisor')->create()->id;
         },
     ];
 });
 
-$factory->define(Manager::class, function (Faker\Generator $faker) use ($faker_fr) {
+$factory->define(Manager::class, function(Faker\Generator $faker) use ($faker_fr) {
     return [
         'twitter_username' => $faker->firstName(),
         'linkedin_url' => null,
@@ -99,7 +99,7 @@ 
         'development_opportunity_frequency_id' => Frequency::inRandomOrder()->first()->id,
         'refuse_low_value_work_frequency_id' => Frequency::inRandomOrder()->first()->id,
         'years_experience' => $faker->numberBetween(2, 25),
-        'user_id' => function () use ($faker) {
+        'user_id' => function() use ($faker) {
             return factory(User::class)->create([
                 'gov_email' => $faker->unique()->safeEmail(),
             ])->id;
@@ -128,12 +128,12 @@ 
 });
 
 $factory->state(Manager::class, 'upgraded', [
-    'user_id' => function () {
+    'user_id' => function() {
         return factory(User::class)->state('upgradedManager')->create()->id;
     },
 ]);
 
-$factory->afterCreating(Manager::class, function ($manager) : void {
+$factory->afterCreating(Manager::class, function($manager) : void {
     $manager->team_culture()->save(factory(TeamCulture::class)->create([
         'manager_id' => $manager->id,
     ]));