UpdateJobPoster::rules() - Code Metrics - Inspection of "Add validation to Update JobPoster api request" - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/job_api_route ( e4c64b )

by Tristan

created 2019-05-15 19:40 UTC

UpdateJobPoster::rules() A

↳ Parent: UpdateJobPoster

Complexity

Conditions	1
Paths	1

Size

Total Lines	18
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	16
CRAP Score	1

Importance

Changes

Metric	Value
eloc	16
dl	0
loc	18
ccs	16
cts	16
cp	1
rs	9.7333
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	1

<?php

namespace App\Http\Requests;

use Illuminate\Foundation\Http\FormRequest;
use App\Services\Validation\Rules\DepartmentRule;
use App\Services\Validation\Rules\ProvinceRule;
use App\Services\Validation\Rules\SecurityClearanceRule;
use App\Services\Validation\Rules\LanguageRequirementRule;
use Illuminate\Support\Facades\Config;

class UpdateJobPoster extends FormRequest
{
    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool

     */
    public function authorize()

    {
        return true;
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array

     */
    public function rules()

    {
        $dateFormat = Config::get('app.api_datetime_format');
        $dateFormatRule = "date_format:\"$dateFormat\"";
        return [
            'term_qty' => 'required|numeric',
            'open_date_time' =>["required", $dateFormatRule],
            'close_date_time' => ["required", $dateFormatRule],
            'start_date_time' =>["required", $dateFormatRule],
            'department_id' => ['required', new DepartmentRule()],
            'province_id' => ['required', new ProvinceRule()],
            'security_clearance_id' => ['required', new SecurityClearanceRule()],
            'language_requirement_id' => ['required', new LanguageRequirementRule()],
            'salary_min' => 'required|numeric',
            'salary_max' => 'required|numeric',
            'noc' => 'required|numeric',
            'classification' => 'required|regex:/[A-Z]{2}-[0-9]{2}/',
            'remote_work_allowed' => 'required|boolean',
        ];
    }
}


1		<?php
2
3		namespace App\Http\Requests;
4
5		use Illuminate\Foundation\Http\FormRequest;
6		use App\Services\Validation\Rules\DepartmentRule;
7		use App\Services\Validation\Rules\ProvinceRule;
8		use App\Services\Validation\Rules\SecurityClearanceRule;
9		use App\Services\Validation\Rules\LanguageRequirementRule;
10		use Illuminate\Support\Facades\Config;
11
12		class UpdateJobPoster extends FormRequest
13		{
14		/**
15		* Determine if the user is authorized to make this request.
16		*
17		* @return bool
		1 ignored issue – show Coding Style introduced 2019-05-15 19:49 UTC by Report Bug Copy Issue Report Expected "boolean" but found "bool" for function return type Loading history...
18		*/
19	2	public function authorize()
		0 ignored issues – show introduced 2019-05-15 19:49 UTC by Report Bug Copy Issue Report Method \App\Http\Requests\UpdateJobPoster::authorize() does not have return type hint for its return value but it should be possible to add it based on @return annotation "bool". Loading history...
20		{
21	2	return true;
22		}
23
24		/**
25		* Get the validation rules that apply to the request.
26		*
27		* @return array
		0 ignored issues – show introduced 2019-05-15 19:49 UTC by Report Bug Copy Issue Report @return annotation of method \App\Http\Requests\UpdateJobPoster::rules() does not specify type hint for items of its traversable return value. Loading history...
28		*/
29	2	public function rules()
		0 ignored issues – show introduced 2019-05-15 19:49 UTC by Report Bug Copy Issue Report Method \App\Http\Requests\UpdateJobPoster::rules() does not have return type hint for its return value but it should be possible to add it based on @return annotation "array". Loading history...
30		{
31	2	$dateFormat = Config::get('app.api_datetime_format');
32	2	$dateFormatRule = "date_format:\"$dateFormat\"";
33		return [
34	2	'term_qty' => 'required\|numeric',
35	2	'open_date_time' =>["required", $dateFormatRule],
36	2	'close_date_time' => ["required", $dateFormatRule],
37	2	'start_date_time' =>["required", $dateFormatRule],
38	2	'department_id' => ['required', new DepartmentRule()],
39	2	'province_id' => ['required', new ProvinceRule()],
40	2	'security_clearance_id' => ['required', new SecurityClearanceRule()],
41	2	'language_requirement_id' => ['required', new LanguageRequirementRule()],
42	2	'salary_min' => 'required\|numeric',
43	2	'salary_max' => 'required\|numeric',
44	2	'noc' => 'required\|numeric',
45	2	'classification' => 'required\|regex:/[A-Z]{2}-[0-9]{2}/',
46	2	'remote_work_allowed' => 'required\|boolean',
47		];
48		}
49		}
50

GCTC-NTGC / TalentCloud

Push — feature/job_api_route ( e4c64b )

UpdateJobPoster::rules() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like