App\Http\Requests\UpdateJobPoster

Complexity

Total Complexity

2

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	rules()	0	18	1
A	authorize()	0	3	1

<?php

namespace App\Http\Requests;

use Illuminate\Foundation\Http\FormRequest;
use App\Services\Validation\Rules\DepartmentRule;
use App\Services\Validation\Rules\ProvinceRule;
use App\Services\Validation\Rules\SecurityClearanceRule;
use App\Services\Validation\Rules\LanguageRequirementRule;
use Illuminate\Support\Facades\Config;

class UpdateJobPoster extends FormRequest
{
    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool

Expected "boolean" but found "bool" for function return type

     */
    public function authorize()

Method \App\Http\Requests\UpdateJobPoster::authorize() does not have return type hint for its return value but it should be possible to add it based on @return annotation "bool".

    {
        return true;
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array

@return annotation of method \App\Http\Requests\UpdateJobPoster::rules() does not specify type hint for items of its traversable return value.

     */
    public function rules()

Method \App\Http\Requests\UpdateJobPoster::rules() does not have return type hint for its return value but it should be possible to add it based on @return annotation "array".

    {
        $dateFormat = Config::get('app.api_datetime_format');
        $dateFormatRule = "date_format:\"$dateFormat\"";
        return [
            'term_qty' => 'required|numeric',
            'open_date_time' =>["required", $dateFormatRule],
            'close_date_time' => ["required", $dateFormatRule],
            'start_date_time' =>["required", $dateFormatRule],
            'department_id' => ['required', new DepartmentRule()],
            'province_id' => ['required', new ProvinceRule()],
            'security_clearance_id' => ['required', new SecurityClearanceRule()],
            'language_requirement_id' => ['required', new LanguageRequirementRule()],
            'salary_min' => 'required|numeric',
            'salary_max' => 'required|numeric',
            'noc' => 'required|numeric',
            'classification' => 'required|regex:/[A-Z]{2}-[0-9]{2}/',
            'remote_work_allowed' => 'required|boolean',
        ];
    }
}