App\Http\Controllers\ManagerProfileController::update()

Complexity

Conditions	7
Paths	20

Size

Total Lines	104
Code Lines	72

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	56

Importance

Changes

0

<?php
    public function update(Request $request, Manager $manager) {

Method \App\Http\Controllers\ManagerProfileController::update() does not have return type hint for its return value but it should be possible to add it based on @return annotation "\Illuminate\Http\Response".

        $input = $request->input();

        //TODO: remove control of name in production
        $manager->user->name = $input['name'];
        $manager->user->save();

        $manager->fill([
            'department_id' => $input['department'],
            'twitter_username' => $input['twitter_username'],
            'linkedin_url' => $input['linkedin_url'],
            //'work_review_frequency_id' => [],
            //'stay_late_frequency_id' => [],
            //'engage_team_frequency_id' => [],
            //'development_opportunity_frequency_id',
            //'refuse_low_value_work_frequency_id',
            'years_experience' => $input['years_experience'],
            'en' => [
                'about_me' => $input['about_me']['en'],
                //'greatest_accomplishment',
                'branch' =>  $input['branch']['en'],
                'division' => $input['division']['en'],
                'position' => $input['position']['en'],
                'leadership_style' => $input['leadership_style']['en'],
                'employee_learning' => $input['employee_learning']['en'],
                'expectations' => $input['expectations']['en'],
                'education' => $input['education']['en'],
                'career_journey' => $input['career_journey']['en'],
                'learning_path' => $input['learning_path']['en']
            ],
            'fr' => [
                'about_me' => $input['about_me']['fr'],
                //'greatest_accomplishment',
                'branch' =>  $input['branch']['fr'],
                'division' => $input['division']['fr'],
                'position' => $input['position']['fr'],
                'leadership_style' => $input['leadership_style']['fr'],
                'employee_learning' => $input['employee_learning']['fr'],
                'expectations' => $input['expectations']['fr'],
                'education' => $input['education']['fr'],
                'career_journey' => $input['career_journey']['fr'],
                'learning_path' => $input['learning_path']['fr']
            ]
        ]);

        $manager->save();

        $work_environment = $manager->work_environment;
        $work_environment->fill([
            'en' => [
                'things_to_know' => $input['things_to_know']['en']
            ],
            'fr' => [
                'things_to_know' => $input['things_to_know']['fr']
            ]
        ]);
        //Slider select inputs can be missing from input if nothing was selected
        if (isset($input['telework'])) {
            $work_environment->telework_allowed_frequency_id = $input['telework'];
        }
        if (isset($input['flex_hours'])) {
            $work_environment->flexible_hours_frequency_id = $input['flex_hours'];
        }
        $work_environment->save();

        $team_culture = $manager->team_culture;
        $team_culture->fill([
            'team_size' => $input['team_size'],
            'gc_directory_url' => $input['gc_directory_url'],
            'en' => [
                'operating_context' => $input['operating_context']['en'],
                'what_we_value' => $input['what_we_value']['en'],
                'how_we_work' => $input['how_we_work']['en']
            ],
            'fr' => [
                'operating_context' => $input['operating_context']['fr'],
                'what_we_value' => $input['what_we_value']['fr'],
                'how_we_work' => $input['how_we_work']['fr']
            ]
        ]);
        $team_culture->save();

        //TODO: save workplace Photos

        //Use the button that was clicked to decide which element to redirect to
        switch ($input['submit']) {
            case 'about_me':
                $hash = '#managerProfileSectionAbout';
                break;
            case 'team_culture':
                $hash = '#managerProfileSectionCulture';
                break;
            case 'work_environment':
                $hash = '#managerProfileSectionEnvrionment';
                break;
            case 'leadership':
                $hash = '#managerProfileSectionLeadership';
                break;
            default:
                $hash = "";
                break;
        }

        return redirect( route('manager.profile.edit', $manager).$hash );

The expression return redirect(route('manager.profile.edit', $manager) . $hash) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

    }