App\Http\Controllers\ManagerProfileController

Complexity

Total Complexity

12

Size/Duplication

Total Lines	225
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	show()	0	47	1
A	edit()	0	33	3
A	editAuthenticated()	0	4	1
B	update()	0	104	7

<?php

namespace App\Http\Controllers;

use Illuminate\Support\Facades\Lang;
use Illuminate\Http\Request;
use App\Http\Controllers\Controller;
use App\Models\Lookup\Frequency;
use App\Models\Lookup\Department;
use App\Models\WorkEnvironment;
use App\Models\TeamCulture;
use App\Models\Manager;

class ManagerProfileController extends Controller {

    /**
     * Show a manager profile
     *
     * @param  Request  $request

Missing parameter comment

Expected 13 spaces after parameter type; 2 found

     * @param  \App\Models\Manager  $manager

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response
     */
    public function show(Request $request, Manager $manager) {

The parameter $request is not used and could be removed.

Method \App\Http\Controllers\ManagerProfileController::show() does not have return type hint for its return value but it should be possible to add it based on @return annotation "\Illuminate\Http\Response".

        $manager_profile = Lang::get('applicant/manager_profile');

        $manager_profile_sections = [
            [
                "title" => $manager_profile['section_titles']['approach'],
                "questions" => [
                    [
                        "title" => $manager_profile['questions']['leadership_style'],
                        "answer" => $manager->leadership_style
                    ],
                    [
                        "title" => $manager_profile['questions']['employee_expectations'],
                        "answer" => $manager->expectations
                    ],
                    [
                        "title" => $manager_profile['questions']['employee_learning'],
                        "answer" => $manager->employee_learning
                    ]
                ]
            ],
            [
                "title" => $manager_profile['section_titles']['about_me'],
                "questions" => [
                    [
                        "title" => $manager_profile['questions']['career_journey'],
                        "answer" => $manager->career_journey
                    ],
                    [
                        "title" => $manager_profile['questions']['learning_path'],
                        "answer" => $manager->learning_path
                    ],
                    [
                        "title" => $manager_profile['questions']['about_me'],
                        "answer" => $manager->about_me
                    ]
                ]
            ]
        ];


        return view('applicant/manager', [

The expression return view('applicant/manager', array('manager_profile' => $manager_profile, 'urls' => Illuminate\Support\Facades\Lang::get('common/urls'), 'manager' => $manager, 'manager_profile_photo_url' => '/images/user.png', 'manager_profile_sections' => $manager_profile_sections)) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

            "manager_profile" => $manager_profile,
            'urls' => Lang::get('common/urls'),
            'manager' => $manager,
            'manager_profile_photo_url' => '/images/user.png', //TODO get real photo
            "manager_profile_sections" => $manager_profile_sections,
        ]);
    }

    /**
     * Show the form for editing the logged-in manager's profile
     *
     * @param  Request $request

Missing parameter comment

     * @return \Illuminate\Http\RedirectResponse
     */
    public function editAuthenticated(Request $request): \Illuminate\Http\RedirectResponse
    {
        $manager = $request->user()->manager;
        return redirect(route('manager.profile.edit', $manager));
    }

    /**
     * Show the form for editing the logged-in user's manager profile
     *
     * @param  Request  $request

Missing parameter comment

Expected 13 spaces after parameter type; 2 found

     * @param  \App\Models\Manager  $manager

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response
     */
    public function edit(Request $request, Manager $manager) {

Method \App\Http\Controllers\ManagerProfileController::edit() does not have return type hint for its return value but it should be possible to add it based on @return annotation "\Illuminate\Http\Response".

        //TODO: Improve workplace photos, and reference them in template direction from WorkEnvironment model
        $workplacePhotos = [];
        if ($manager->work_environment != null) {
            foreach($manager->work_environment->workplace_photo_captions as $photoCaption) {

Expected 1 space(s) after FOREACH keyword; 0 found

                $workplacePhotos[] = [
                    'id' => $photoCaption->id,
                    'alt' => $photoCaption->description,
                    'alt_fr' => $photoCaption->description,
                    'url' => '/images/user.png'
                ];
            }
        }

        $frequencies = Frequency::all();

        return view('manager/profile', [

The expression return view('manager/profile', array('profile_l10n' => Illuminate\Support\Facades\Lang::get('manager/profile'), 'urls' => Illuminate\Support\Facades\Lang::get('common/urls'), 'user' => $manager->user, 'manager' => $manager, 'manager_profile_photo_url' => '/images/user.png', 'team_culture' => $manager->team_culture, 'work_environment' => $manager->work_environment, 'workplace_photos' => $workplacePhotos, 'departments' => App\Models\Lookup\Department::all(), 'telework_options' => $frequencies, 'flex_hour_options' => $frequencies, 'radio_options' => $frequencies)) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

            /* Localization */
            'profile_l10n' => Lang::get('manager/profile'),

            /* Data */
            'urls' => Lang::get('common/urls'),
            'user' => $manager->user,
            'manager' => $manager,
            'manager_profile_photo_url' => '/images/user.png', //TODO get real photo
            'team_culture' => $manager->team_culture,
            'work_environment' => $manager->work_environment,
            'workplace_photos' => $workplacePhotos,
            'departments' => Department::all(),
            'telework_options' => $frequencies,
            'flex_hour_options' => $frequencies,
            'radio_options' => $frequencies
        ]);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @param  \App\Models\Manager  $manager

Missing parameter comment

Expected 6 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, Manager $manager) {

Method \App\Http\Controllers\ManagerProfileController::update() does not have return type hint for its return value but it should be possible to add it based on @return annotation "\Illuminate\Http\Response".

        $input = $request->input();

        //TODO: remove control of name in production
        $manager->user->name = $input['name'];
        $manager->user->save();

        $manager->fill([
            'department_id' => $input['department'],
            'twitter_username' => $input['twitter_username'],
            'linkedin_url' => $input['linkedin_url'],
            //'work_review_frequency_id' => [],
            //'stay_late_frequency_id' => [],
            //'engage_team_frequency_id' => [],
            //'development_opportunity_frequency_id',
            //'refuse_low_value_work_frequency_id',
            'years_experience' => $input['years_experience'],
            'en' => [
                'about_me' => $input['about_me']['en'],
                //'greatest_accomplishment',
                'branch' =>  $input['branch']['en'],
                'division' => $input['division']['en'],
                'position' => $input['position']['en'],
                'leadership_style' => $input['leadership_style']['en'],
                'employee_learning' => $input['employee_learning']['en'],
                'expectations' => $input['expectations']['en'],
                'education' => $input['education']['en'],
                'career_journey' => $input['career_journey']['en'],
                'learning_path' => $input['learning_path']['en']
            ],
            'fr' => [
                'about_me' => $input['about_me']['fr'],
                //'greatest_accomplishment',
                'branch' =>  $input['branch']['fr'],
                'division' => $input['division']['fr'],
                'position' => $input['position']['fr'],
                'leadership_style' => $input['leadership_style']['fr'],
                'employee_learning' => $input['employee_learning']['fr'],
                'expectations' => $input['expectations']['fr'],
                'education' => $input['education']['fr'],
                'career_journey' => $input['career_journey']['fr'],
                'learning_path' => $input['learning_path']['fr']
            ]
        ]);

        $manager->save();

        $work_environment = $manager->work_environment;
        $work_environment->fill([
            'en' => [
                'things_to_know' => $input['things_to_know']['en']
            ],
            'fr' => [
                'things_to_know' => $input['things_to_know']['fr']
            ]
        ]);
        //Slider select inputs can be missing from input if nothing was selected
        if (isset($input['telework'])) {
            $work_environment->telework_allowed_frequency_id = $input['telework'];
        }
        if (isset($input['flex_hours'])) {
            $work_environment->flexible_hours_frequency_id = $input['flex_hours'];
        }
        $work_environment->save();

        $team_culture = $manager->team_culture;
        $team_culture->fill([
            'team_size' => $input['team_size'],
            'gc_directory_url' => $input['gc_directory_url'],
            'en' => [
                'operating_context' => $input['operating_context']['en'],
                'what_we_value' => $input['what_we_value']['en'],
                'how_we_work' => $input['how_we_work']['en']
            ],
            'fr' => [
                'operating_context' => $input['operating_context']['fr'],
                'what_we_value' => $input['what_we_value']['fr'],
                'how_we_work' => $input['how_we_work']['fr']
            ]
        ]);
        $team_culture->save();

        //TODO: save workplace Photos

        //Use the button that was clicked to decide which element to redirect to
        switch ($input['submit']) {
            case 'about_me':
                $hash = '#managerProfileSectionAbout';
                break;
            case 'team_culture':
                $hash = '#managerProfileSectionCulture';
                break;
            case 'work_environment':
                $hash = '#managerProfileSectionEnvrionment';
                break;
            case 'leadership':
                $hash = '#managerProfileSectionLeadership';
                break;
            default:
                $hash = "";
                break;
        }

        return redirect( route('manager.profile.edit', $manager).$hash );

The expression return redirect(route('manager.profile.edit', $manager) . $hash) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

    }

}