TwitterHandleRule::passes() - Code Metrics - Inspection of "Merge pull request #1447 from GCTC-NTGC/bugfix/man..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — dev ( 69b6f1...3c5138 )

by Chris

created 2019-09-26 20:14 UTC

TwitterHandleRule::passes() A

↳ Parent: TwitterHandleRule

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	1
c	0
b	0
f	0
dl	0
loc	3
rs	10
cc	1
nc	1
nop	2

<?php

namespace App\Services\Validation\Rules;

use Illuminate\Contracts\Validation\Rule;
use Illuminate\Support\Facades\Lang;

class TwitterHandleRule implements Rule
{
    /**
     * Validation for Twitter handlers.
     *
     * @var string
     */
    const PATTERN = '^[A-Za-z0-9_]{1,15}$';

    /**
     *
     * Twitters Terms of Service only allows ". A username can only contain
     * alphanumeric characters (letters A-Z, numbers 0-9) with the exception
     * of underscores... A username cannot be longer than 15 characters."
     * This regex will allow only alphamumeric characters and the underscore.
     * Keep this handy if we need to validate other usernames.
     *
     * @param  string  $attribute

     * @param  mixed   $value

     * @return boolean
     */
    public function passes($attribute, $value)

    {
        return preg_match('/' . self::PATTERN . '/', $value);
    }

    /**
     * Get the validation error message.
     *
     * @return string
     */
    public function message()

    {
        return Lang::get('validation.custom.twitter_handle');
    }
}


1			<?php
2
3			namespace App\Services\Validation\Rules;
4
5			use Illuminate\Contracts\Validation\Rule;
6			use Illuminate\Support\Facades\Lang;
7
8			class TwitterHandleRule implements Rule
9			{
10			/**
11			* Validation for Twitter handlers.
12			*
13			* @var string
14			*/
15			const PATTERN = '^[A-Za-z0-9_]{1,15}$';
16
17			/**
18			*
19			* Twitters Terms of Service only allows ". A username can only contain
20			* alphanumeric characters (letters A-Z, numbers 0-9) with the exception
21			* of underscores... A username cannot be longer than 15 characters."
22			* This regex will allow only alphamumeric characters and the underscore.
23			* Keep this handy if we need to validate other usernames.
24			*
25			* @param string $attribute
			2 ignored issues – show Coding Style Documentation introduced 2019-09-17 14:49 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history... Coding Style introduced 2019-09-17 14:49 UTC by Report Bug Copy Issue Report Expected 1 spaces after parameter type; 2 found Loading history...
26			* @param mixed $value
			2 ignored issues – show Coding Style Documentation introduced 2019-09-17 14:49 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history... Coding Style introduced 2019-09-17 14:49 UTC by Report Bug Copy Issue Report Expected 2 spaces after parameter type; 3 found Loading history...
27			* @return boolean
28			*/
29			public function passes($attribute, $value)
			1 ignored issue – show introduced 2019-09-17 16:58 UTC by Report Bug Copy Issue Report Method \App\Services\Validation\Rules\TwitterHandleRule::passes() does not have parameter type hint for its parameter $attribute but it should be possible to add it based on @param annotation "string". Loading history... introduced 2019-09-17 16:58 UTC by Report Bug Copy Issue Report Method \App\Services\Validation\Rules\TwitterHandleRule::passes() does not have return type hint for its return value but it should be possible to add it based on @return annotation "boolean". Loading history... Coding Style introduced 2019-09-17 14:49 UTC by Report Bug Copy Issue Report Type hint "string" missing for $attribute Loading history...
30			{
31			return preg_match('/' . self::PATTERN . '/', $value);
32			}
33
34			/**
35			* Get the validation error message.
36			*
37			* @return string
38			*/
39			public function message()
			0 ignored issues – show introduced 2019-09-25 18:17 UTC by Report Bug Copy Issue Report Method \App\Services\Validation\Rules\TwitterHandleRule::message() does not have return type hint for its return value but it should be possible to add it based on @return annotation "string". Loading history...
40			{
41			return Lang::get('validation.custom.twitter_handle');
42			}
43			}
44

GCTC-NTGC / TalentCloud

Push — dev ( 69b6f1...3c5138 )

TwitterHandleRule::passes() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like