App\Services\Validation\Rules\TwitterHandleRule

Complexity

Total Complexity

2

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	passes()	0	3	1
A	message()	0	3	1

<?php

namespace App\Services\Validation\Rules;

use Illuminate\Contracts\Validation\Rule;
use Illuminate\Support\Facades\Lang;

class TwitterHandleRule implements Rule
{
    /**
     * Validation for Twitter handlers.
     *
     * @var string
     */
    const PATTERN = '^[A-Za-z0-9_]{1,15}$';

    /**
     *
     * Twitters Terms of Service only allows ". A username can only contain
     * alphanumeric characters (letters A-Z, numbers 0-9) with the exception
     * of underscores... A username cannot be longer than 15 characters."
     * This regex will allow only alphamumeric characters and the underscore.
     * Keep this handy if we need to validate other usernames.
     *
     * @param  string  $attribute

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @param  mixed   $value

Missing parameter comment

Expected 2 spaces after parameter type; 3 found

     * @return boolean
     */
    public function passes($attribute, $value)

Method \App\Services\Validation\Rules\TwitterHandleRule::passes() does not have parameter type hint for its parameter $attribute but it should be possible to add it based on @param annotation "string".

Method \App\Services\Validation\Rules\TwitterHandleRule::passes() does not have return type hint for its return value but it should be possible to add it based on @return annotation "boolean".

Type hint "string" missing for $attribute

    {
        return preg_match('/' . self::PATTERN . '/', $value);
    }

    /**
     * Get the validation error message.
     *
     * @return string
     */
    public function message()

Method \App\Services\Validation\Rules\TwitterHandleRule::message() does not have return type hint for its return value but it should be possible to add it based on @return annotation "string".

    {
        return Lang::get('validation.custom.twitter_handle');
    }
}