App\Http\Requests\StoreRatingGuideAnswer

Complexity

Total Complexity

5

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	rules()	0	6	1
A	authorize()	0	11	4

<?php

namespace App\Http\Requests;

use Illuminate\Foundation\Http\FormRequest;
use App\Models\RatingGuideAnswer;
use App\Models\RatingGuideQuestion;
use App\Services\Validation\Rules\ValidIdRule;
use App\Models\Criteria;

class StoreRatingGuideAnswer extends FormRequest
{
    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool

Expected "boolean" but found "bool" for function return type

     */
    public function authorize()

Method \App\Http\Requests\StoreRatingGuideAnswer::authorize() does not have return type hint for its return value but it should be possible to add it based on @return annotation "bool".

    {
        // Ensure the user can make answers, and is the owner of the question it answers.
        if ($this->user()->can('create', RatingGuideAnswer::class)) {
            $questionId = (int) $this->input("rating_guide_question_id");
            if ($questionId) {
                $question = RatingGuideQuestion::find($questionId);
                return $question && $question->job_poster->manager->user_id === $this->user()->id;
            }
        }
        return false;
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array

@return annotation of method \App\Http\Requests\StoreRatingGuideAnswer::rules() does not specify type hint for items of its traversable return value.

     */
    public function rules()

Method \App\Http\Requests\StoreRatingGuideAnswer::rules() does not have return type hint for its return value but it should be possible to add it based on @return annotation "array".

    {
        return [
            'rating_guide_question_id' => ['required', new ValidIdRule(RatingGuideQuestion::class)],
            'criterion_id' => ['nullable', new ValidIdRule(Criteria::class)],
            'expected_answer' => 'nullable|string',
        ];
    }
}