StoreRatingGuideAnswer::rules() - Code Metrics - Inspection of "merged in dev" - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/job-builder/step-03-ui ( dabf2e...dabf2e )

by Xander

created 2019-06-24 14:50 UTC

StoreRatingGuideAnswer::rules() A

↳ Parent: StoreRatingGuideAnswer

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
eloc	4
c	2
b	0
f	0
dl	0
loc	6
ccs	0
cts	4
cp	0
rs	10
cc	1
nc	1
nop	0
crap	2

<?php

namespace App\Http\Requests;

use Illuminate\Foundation\Http\FormRequest;
use App\Models\RatingGuideAnswer;
use App\Models\RatingGuideQuestion;
use App\Services\Validation\Rules\ValidIdRule;
use App\Models\Criteria;

class StoreRatingGuideAnswer extends FormRequest
{
    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool

     */
    public function authorize()

    {
        // Ensure the user can make answers, and is the owner of the question it answers.
        if ($this->user()->can('create', RatingGuideAnswer::class)) {
            $questionId = (int) $this->input("rating_guide_question_id");
            if ($questionId) {
                $question = RatingGuideQuestion::find($questionId);
                return $question && $question->job_poster->manager->user_id === $this->user()->id;
            }
        }
        return false;
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array

     */
    public function rules()

    {
        return [
            'rating_guide_question_id' => ['required', new ValidIdRule(RatingGuideQuestion::class)],
            'criterion_id' => ['nullable', new ValidIdRule(Criteria::class)],
            'expected_answer' => 'nullable|string',
        ];
    }
}


1			<?php
2
3			namespace App\Http\Requests;
4
5			use Illuminate\Foundation\Http\FormRequest;
6			use App\Models\RatingGuideAnswer;
7			use App\Models\RatingGuideQuestion;
8			use App\Services\Validation\Rules\ValidIdRule;
9			use App\Models\Criteria;
10
11			class StoreRatingGuideAnswer extends FormRequest
12			{
13			/**
14			* Determine if the user is authorized to make this request.
15			*
16			* @return bool
			1 ignored issue – show Coding Style introduced 2019-06-03 20:38 UTC by Report Bug Copy Issue Report Expected "boolean" but found "bool" for function return type Loading history...
17			*/
18			public function authorize()
			0 ignored issues – show introduced 2019-05-24 22:18 UTC by Report Bug Copy Issue Report Method \App\Http\Requests\StoreRatingGuideAnswer::authorize() does not have return type hint for its return value but it should be possible to add it based on @return annotation "bool". Loading history...
19			{
20			// Ensure the user can make answers, and is the owner of the question it answers.
21			if ($this->user()->can('create', RatingGuideAnswer::class)) {
22			$questionId = (int) $this->input("rating_guide_question_id");
23			if ($questionId) {
24			$question = RatingGuideQuestion::find($questionId);
25			return $question && $question->job_poster->manager->user_id === $this->user()->id;
26			}
27			}
28			return false;
29			}
30
31			/**
32			* Get the validation rules that apply to the request.
33			*
34			* @return array
			0 ignored issues – show introduced 2019-05-24 22:18 UTC by Report Bug Copy Issue Report @return annotation of method \App\Http\Requests\StoreRatingGuideAnswer::rules() does not specify type hint for items of its traversable return value. Loading history...
35			*/
36			public function rules()
			0 ignored issues – show introduced 2019-05-24 22:18 UTC by Report Bug Copy Issue Report Method \App\Http\Requests\StoreRatingGuideAnswer::rules() does not have return type hint for its return value but it should be possible to add it based on @return annotation "array". Loading history...
37			{
38			return [
39			'rating_guide_question_id' => ['required', new ValidIdRule(RatingGuideQuestion::class)],
40			'criterion_id' => ['nullable', new ValidIdRule(Criteria::class)],
41			'expected_answer' => 'nullable\|string',
42			];
43			}
44			}
45

GCTC-NTGC / TalentCloud

Push — feature/job-builder/step-03-ui ( dabf2e...dabf2e )

StoreRatingGuideAnswer::rules() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like