Completed
Pull Request — master (#280)
by Nicolas
15:24
created
CacheManager.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@
 block discarded – undo
62 62
      * Assign cache tags to a response
63 63
      *
64 64
      * @param Response $response
65
-     * @param array    $tags
65
+     * @param string[]    $tags
66 66
      * @param bool     $replace  Whether to replace the current tags on the
67 67
      *                           response
68 68
      *
Please login to merge, or discard this patch.
DependencyInjection/FOSHttpCacheExtension.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -413,6 +413,9 @@
 block discarded – undo
413 413
         }
414 414
     }
415 415
 
416
+    /**
417
+     * @param string $msg
418
+     */
416 419
     private function validateUrl($url, $msg)
417 420
     {
418 421
         $prefixed = $this->prefixSchema($url);
Please login to merge, or discard this patch.
HttpCache.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -14,9 +14,6 @@
 block discarded – undo
14 14
 use FOS\HttpCache\SymfonyCache\CacheEvent;
15 15
 use FOS\HttpCache\SymfonyCache\UserContextSubscriber;
16 16
 use Symfony\Bundle\FrameworkBundle\HttpCache\HttpCache as BaseHttpCache;
17
-use Symfony\Component\EventDispatcher\EventDispatcher;
18
-use Symfony\Component\EventDispatcher\EventDispatcherInterface;
19
-use Symfony\Component\EventDispatcher\EventSubscriberInterface;
20 17
 use Symfony\Component\HttpFoundation\Request;
21 18
 use Symfony\Component\HttpKernel\HttpKernelInterface;
22 19
 
Please login to merge, or discard this patch.
Tests/Unit/EventListener/UserContextSubscriberTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -191,7 +191,7 @@
 block discarded – undo
191 191
      * @param Request $request
192 192
      * @param bool    $match
193 193
      *
194
-     * @return \Mockery\MockInterface|RequestMatcherInterface
194
+     * @return \Mockery\MockInterface
195 195
      */
196 196
     private function getRequestMatcher(Request $request, $match)
197 197
     {
Please login to merge, or discard this patch.
Tests/Unit/SymfonyCache/EventDispatchingHttpCacheTest.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -154,6 +154,11 @@
 block discarded – undo
154 154
     private $request;
155 155
     private $response;
156 156
 
157
+    /**
158
+     * @param EventDispatchingHttpCacheTest $test
159
+     * @param Request $request
160
+     * @param Response $response
161
+     */
157 162
     public function __construct($test, $kernel, $request, $response = null)
158 163
     {
159 164
         $this->test = $test;
Please login to merge, or discard this patch.