Issues in Report.php (master) - Issues in master - FriendsOfApi/billogram - Measure and Improve Code Quality continuously with Scrutinizer

Issues (33)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Model/Report/Report.php (1 issue)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

namespace Billogram\Model\Report;

use Billogram\Exception\Domain\ValidationException;
use Billogram\Model\CreatableFromArray;

class Report implements CreatableFromArray
{
    /**
     * @var string
     */
    private $filename;

    /**
     * @var string
     */
    private $type;

    /**
     * @var string
     */
    private $fileType;

    /**
     * @var string
     */
    private $info;

    /**
     * @var string
     */
    private $createdAt;

    /**
     * @var string
     */
    private $content;

    /**
     * @return string
     */
    public function getFilename()
    {
        return $this->filename;
    }

    /**
     * @param string $filename
     *
     * @return Report
     */
    public function withFilename(string $filename)
    {
        $new = clone $this;
        $new->filename = $filename;

        return $new;
    }

    /**
     * @return string
     */
    public function getType()
    {
        return $this->type;
    }

    /**
     * @param string $type
     *
     * @return Report
     */
    public function withType(string $type)
    {
        $new = clone $this;
        $new->type = $type;

        return $new;
    }

    /**
     * @return string
     */
    public function getFileType()
    {
        return $this->fileType;
    }

    /**
     * @param string $fileType
     *
     * @return Report
     */
    public function withFileType(string $fileType)
    {
        $new = clone $this;
        $new->fileType = $fileType;

        return $new;
    }

    /**
     * @return string
     */
    public function getInfo()
    {
        return $this->info;
    }

    /**
     * @param string $info
     *
     * @return Report
     */
    public function withInfo(string $info)
    {
        $new = clone $this;
        $new->info = $info;

        return $new;
    }

    /**
     * @return string
     */
    public function getCreatedAt()
    {
        return $this->createdAt;
    }

    /**
     * @param string $createdAt
     *
     * @return Report
     */
    public function withCreatedAt(string $createdAt)
    {
        $new = clone $this;
        $new->createdAt = $createdAt;

        return $new;
    }

    /**
     * @return string
     */
    public function getContent()
    {
        return $this->content;
    }

    /**
     * @param string $content
     *
     * @return Report
     */
    public function withContent(string $content)
    {
        $new = clone $this;
        $new->content = $content;

        return $new;
    }

    /**
     * Create an API response object from the HTTP response from the API server.
     *
     * @param array $data
     *
     * @return self
     *
     * @throws ValidationException
     */
    public static function createFromArray(array $data)
    {
        if ('INVALID_PARAMETER' === $data['status'] && array_key_exists('message', $data['data'])) {
            throw new ValidationException($data['data']['message']);
        }
        $report = new self();
        $report->filename = $data['filename'] ?? null;
        $report->type = $data['type'] ?? null;
        $report->fileType = $data['file_type'] ?? null;
        $report->info = $data['info'] ?? null;
        $report->createdAt = isset($data['created_at']) ? new \DateTime($data['created_at']) : null;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $report->content = $data['content'] ?? null;

        return $report;
    }

    public function toArray()
    {
        // TODO write me
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Billogram\Model\Report;
6
7			use Billogram\Exception\Domain\ValidationException;
8			use Billogram\Model\CreatableFromArray;
9
10			class Report implements CreatableFromArray
11			{
12			/**
13			* @var string
14			*/
15			private $filename;
16
17			/**
18			* @var string
19			*/
20			private $type;
21
22			/**
23			* @var string
24			*/
25			private $fileType;
26
27			/**
28			* @var string
29			*/
30			private $info;
31
32			/**
33			* @var string
34			*/
35			private $createdAt;
36
37			/**
38			* @var string
39			*/
40			private $content;
41
42			/**
43			* @return string
44			*/
45			public function getFilename()
46			{
47			return $this->filename;
48			}
49
50			/**
51			* @param string $filename
52			*
53			* @return Report
54			*/
55			public function withFilename(string $filename)
56			{
57			$new = clone $this;
58			$new->filename = $filename;
59
60			return $new;
61			}
62
63			/**
64			* @return string
65			*/
66			public function getType()
67			{
68			return $this->type;
69			}
70
71			/**
72			* @param string $type
73			*
74			* @return Report
75			*/
76			public function withType(string $type)
77			{
78			$new = clone $this;
79			$new->type = $type;
80
81			return $new;
82			}
83
84			/**
85			* @return string
86			*/
87			public function getFileType()
88			{
89			return $this->fileType;
90			}
91
92			/**
93			* @param string $fileType
94			*
95			* @return Report
96			*/
97			public function withFileType(string $fileType)
98			{
99			$new = clone $this;
100			$new->fileType = $fileType;
101
102			return $new;
103			}
104
105			/**
106			* @return string
107			*/
108			public function getInfo()
109			{
110			return $this->info;
111			}
112
113			/**
114			* @param string $info
115			*
116			* @return Report
117			*/
118			public function withInfo(string $info)
119			{
120			$new = clone $this;
121			$new->info = $info;
122
123			return $new;
124			}
125
126			/**
127			* @return string
128			*/
129			public function getCreatedAt()
130			{
131			return $this->createdAt;
132			}
133
134			/**
135			* @param string $createdAt
136			*
137			* @return Report
138			*/
139			public function withCreatedAt(string $createdAt)
140			{
141			$new = clone $this;
142			$new->createdAt = $createdAt;
143
144			return $new;
145			}
146
147			/**
148			* @return string
149			*/
150			public function getContent()
151			{
152			return $this->content;
153			}
154
155			/**
156			* @param string $content
157			*
158			* @return Report
159			*/
160			public function withContent(string $content)
161			{
162			$new = clone $this;
163			$new->content = $content;
164
165			return $new;
166			}
167
168			/**
169			* Create an API response object from the HTTP response from the API server.
170			*
171			* @param array $data
172			*
173			* @return self
174			*
175			* @throws ValidationException
176			*/
177	1		public static function createFromArray(array $data)
178			{
179	1	View Code Duplication	if ('INVALID_PARAMETER' === $data['status'] && array_key_exists('message', $data['data'])) {
180			throw new ValidationException($data['data']['message']);
181			}
182	1		$report = new self();
183	1		$report->filename = $data['filename'] ?? null;
184	1		$report->type = $data['type'] ?? null;
185	1		$report->fileType = $data['file_type'] ?? null;
186	1		$report->info = $data['info'] ?? null;
187	1		$report->createdAt = isset($data['created_at']) ? new \DateTime($data['created_at']) : null;
			0 ignored issues – show Documentation Bug introduced 2017-08-27 16:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `isset($data['created_at'...a['created_at']) : null` can also be of type `object<DateTime>`. However, the property `$createdAt` is declared as type `string`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
188	1		$report->content = $data['content'] ?? null;
189
190	1		return $report;
191			}
192
193			public function toArray()
194			{
195			// TODO write me
196			}
197			}
198

FriendsOfApi / billogram

Issues (33)

Security Analysis no request data

src/Model/Report/Report.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like