Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
10 | class Report implements CreatableFromArray |
||
11 | { |
||
12 | /** |
||
13 | * @var string |
||
14 | */ |
||
15 | private $filename; |
||
16 | |||
17 | /** |
||
18 | * @var string |
||
19 | */ |
||
20 | private $type; |
||
21 | |||
22 | /** |
||
23 | * @var string |
||
24 | */ |
||
25 | private $fileType; |
||
26 | |||
27 | /** |
||
28 | * @var string |
||
29 | */ |
||
30 | private $info; |
||
31 | |||
32 | /** |
||
33 | * @var string |
||
34 | */ |
||
35 | private $createdAt; |
||
36 | |||
37 | /** |
||
38 | * @var string |
||
39 | */ |
||
40 | private $content; |
||
41 | |||
42 | /** |
||
43 | * @return string |
||
44 | */ |
||
45 | public function getFilename() |
||
49 | |||
50 | /** |
||
51 | * @param string $filename |
||
52 | * |
||
53 | * @return Report |
||
54 | */ |
||
55 | public function withFilename(string $filename) |
||
62 | |||
63 | /** |
||
64 | * @return string |
||
65 | */ |
||
66 | public function getType() |
||
70 | |||
71 | /** |
||
72 | * @param string $type |
||
73 | * |
||
74 | * @return Report |
||
75 | */ |
||
76 | public function withType(string $type) |
||
83 | |||
84 | /** |
||
85 | * @return string |
||
86 | */ |
||
87 | public function getFileType() |
||
91 | |||
92 | /** |
||
93 | * @param string $fileType |
||
94 | * |
||
95 | * @return Report |
||
96 | */ |
||
97 | public function withFileType(string $fileType) |
||
104 | |||
105 | /** |
||
106 | * @return string |
||
107 | */ |
||
108 | public function getInfo() |
||
112 | |||
113 | /** |
||
114 | * @param string $info |
||
115 | * |
||
116 | * @return Report |
||
117 | */ |
||
118 | public function withInfo(string $info) |
||
125 | |||
126 | /** |
||
127 | * @return string |
||
128 | */ |
||
129 | public function getCreatedAt() |
||
133 | |||
134 | /** |
||
135 | * @param string $createdAt |
||
136 | * |
||
137 | * @return Report |
||
138 | */ |
||
139 | public function withCreatedAt(string $createdAt) |
||
146 | |||
147 | /** |
||
148 | * @return string |
||
149 | */ |
||
150 | public function getContent() |
||
154 | |||
155 | /** |
||
156 | * @param string $content |
||
157 | * |
||
158 | * @return Report |
||
159 | */ |
||
160 | public function withContent(string $content) |
||
167 | |||
168 | /** |
||
169 | * Create an API response object from the HTTP response from the API server. |
||
170 | * |
||
171 | * @param array $data |
||
172 | * |
||
173 | * @return self |
||
174 | * |
||
175 | * @throws ValidationException |
||
176 | */ |
||
177 | 1 | public static function createFromArray(array $data) |
|
192 | |||
193 | public function toArray() |
||
197 | } |
||
198 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.