Test Failed
Pull Request — master (#19)
by Flo
04:06
created
src/Controller/Dispatcher.php 3 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
     }
130 130
 
131 131
     /**
132
-     * @param $file
132
+     * @param string $file
133 133
      * @return string
134 134
      * @codeCoverageIgnore
135 135
      */
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
     }
142 142
 
143 143
     /**
144
-     * @param $file
144
+     * @param string $file
145 145
      * @return string
146 146
      * @codeCoverageIgnore
147 147
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,6 @@
 block discarded – undo
9 9
 use Faulancer\Exception\ClassNotFoundException;
10 10
 use Faulancer\Exception\DispatchFailureException;
11 11
 use Faulancer\Exception\IncompatibleResponseException;
12
-use Faulancer\Form\AbstractFormHandler;
13 12
 use Faulancer\Http\JsonResponse;
14 13
 use Faulancer\Http\Request;
15 14
 use Faulancer\Http\Response;
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -239,7 +239,7 @@
 block discarded – undo
239 239
 
240 240
             array_splice($var, 0, 1);
241 241
 
242
-            if ($this->requestType === 'default'  && in_array($this->request->getMethod(), $data['method'])) {
242
+            if ($this->requestType === 'default' && in_array($this->request->getMethod(), $data['method'])) {
243 243
 
244 244
                 return [
245 245
                     'class'  => $data['controller'],
Please login to merge, or discard this patch.
src/Http/Response.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
 
50 50
     /**
51 51
      * Response constructor.
52
-     * @param mixed $content
52
+     * @param string $content
53 53
      */
54 54
     public function __construct($content = null)
55 55
     {
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
     /**
92 92
      * Get response body and set headers
93 93
      *
94
-     * @return mixed
94
+     * @return string
95 95
      */
96 96
     public function getContent()
97 97
     {
Please login to merge, or discard this patch.
src/Kernel.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@
 block discarded – undo
76 76
     }
77 77
 
78 78
     /**
79
-     * @param $request
79
+     * @param Request $request
80 80
      * @param $e
81 81
      * @return Http\Response
82 82
      * @codeCoverageIgnore
Please login to merge, or discard this patch.
src/ORM/Entity.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,6 @@
 block discarded – undo
8 8
 namespace Faulancer\ORM;
9 9
 
10 10
 use Faulancer\Service\AbstractControllerService;
11
-use Faulancer\Service\DbService;
12 11
 use Faulancer\ServiceLocator\ServiceLocator;
13 12
 use \ORM\EntityManager;
14 13
 
Please login to merge, or discard this patch.
src/Form/Type/Base/Select.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@
 block discarded – undo
58 58
         foreach ($definition['options'] as $val => $text) {
59 59
 
60 60
             $selected = $isSelected($val) === true ? ' selected="selected"' : '';
61
-            $option   = '<option value="' . $val .'"%s>' . $text . '</option>';
61
+            $option   = '<option value="' . $val . '"%s>' . $text . '</option>';
62 62
 
63 63
             $output .= sprintf($option, $selected);
64 64
 
Please login to merge, or discard this patch.
src/View/ViewController.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
      */
146 146
     public function getVariable(string $key)
147 147
     {
148
-        if(isset($this->variable[$key])) {
148
+        if (isset($this->variable[$key])) {
149 149
             return $this->variable[$key];
150 150
         }
151 151
 
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
      */
161 161
     public function hasVariable(string $key) :bool
162 162
     {
163
-        if(isset($this->variable[$key])) {
163
+        if (isset($this->variable[$key])) {
164 164
             return true;
165 165
         }
166 166
 
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
      */
176 176
     public function setVariables(array $variables = []) :self
177 177
     {
178
-        foreach($variables AS $key=>$value) {
178
+        foreach ($variables AS $key=>$value) {
179 179
             $this->setVariable($key, $value);
180 180
         }
181 181
 
@@ -292,8 +292,8 @@  discard block
 block discarded – undo
292 292
      */
293 293
     public function __destruct()
294 294
     {
295
-        unset( $this->variable );
296
-        unset( $this->template );
295
+        unset($this->variable);
296
+        unset($this->template);
297 297
     }
298 298
 
299 299
 }
300 300
\ No newline at end of file
Please login to merge, or discard this patch.
src/View/Helper/RenderView.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -31,8 +31,8 @@
 block discarded – undo
31 31
             $subview->setTemplatePath($view->getTemplatePath());
32 32
         }
33 33
 
34
-        $subview->setTemplate( $template );
35
-        $subview->setVariables( $variables );
34
+        $subview->setTemplate($template);
35
+        $subview->setVariables($variables);
36 36
         return $subview->render();
37 37
     }
38 38
 
Please login to merge, or discard this patch.
src/Controller/ErrorController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@
 block discarded – undo
65 65
             'line'    => $this->exception->getLine()
66 66
         ];
67 67
 
68
-        $trace  = $this->exception->getTrace();
68
+        $trace = $this->exception->getTrace();
69 69
 
70 70
         if (isset($trace[0]['line']) && $trace[0]['line'] !== $raiser['line']) {
71 71
             array_unshift($trace, $raiser);
Please login to merge, or discard this patch.
src/Http/XmlResponse.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -20,15 +20,15 @@  discard block
 block discarded – undo
20 20
      * @param \SimpleXMLElement $xml
21 21
      * @codeCoverageIgnore
22 22
      */
23
-    private function convertArrayToXml(\SimpleXMLElement &$xml, $data)
23
+    private function convertArrayToXml(\SimpleXMLElement & $xml, $data)
24 24
     {
25 25
         foreach ($data as $key=>$value) {
26 26
 
27
-            if(is_numeric($key)) {
27
+            if (is_numeric($key)) {
28 28
                 $key = 'item' . $key;
29 29
             }
30 30
 
31
-            if(is_array($value['value'])) {
31
+            if (is_array($value['value'])) {
32 32
 
33 33
                 $node = $this->generateNode($xml, $key, $value);
34 34
                 $this->convertArrayToXml($node, $value['value']);
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
      * @return null|\SimpleXMLElement
48 48
      * @codeCoverageIgnore
49 49
      */
50
-    private function generateNode(\SimpleXMLElement &$xml, $key, $value = null)
50
+    private function generateNode(\SimpleXMLElement & $xml, $key, $value = null)
51 51
     {
52 52
         $node = null;
53 53
 
Please login to merge, or discard this patch.