Firesphere\GoogleAPI\Extensions\SiteTreeExtension::updateCMSFields()

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function updateCMSFields(FieldList $fields)
    {
        if ($this->owner->LastAnalyticsUpdate) {
            $fields->addFieldToTab('Root.Analytics', ReadonlyField::create('VisitCount', 'Visit count'));

'VisitCount' of type string is incompatible with the type array expected by parameter $args of SilverStripe\View\ViewableData::create().

            $fields->addFieldToTab('Root.Analytics', ReadonlyField::create('LastAnalyticsUpdate', 'Last update from Google'));
        } else {
            $fields->removeByName(array_keys(static::$db));

Since $db is declared private, accessing it with static will lead to errors in possible sub-classes; you can either use self, or increase the visibility of $db to at least protected.

        }