Firesphere\GoogleAPI\Extensions\SiteTreeExtension

Complexity

Total Complexity

2

Size/Duplication

Total Lines	14
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	updateCMSFields()	0	7	2

<?php

namespace Firesphere\GoogleAPI\Extensions;

use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\ReadonlyField;
use SilverStripe\ORM\DataExtension;

/**
 * Class PageExtension
 *
 * @property \SilverStripe\CMS\Model\SiteTree|\Firesphere\GoogleAPI\Extensions\SiteTreeExtension $owner
 * @property int $VisitCount
 * @property string $LastAnalyticsUpdate
 */
class SiteTreeExtension extends DataExtension
{
    private static $db = [
        'VisitCount'          => 'Int',
        'LastAnalyticsUpdate' => 'Date'
    ];

    public function updateCMSFields(FieldList $fields)
    {
        if ($this->owner->LastAnalyticsUpdate) {
            $fields->addFieldToTab('Root.Analytics', ReadonlyField::create('VisitCount', 'Visit count'));

'VisitCount' of type string is incompatible with the type array expected by parameter $args of SilverStripe\View\ViewableData::create().

            $fields->addFieldToTab('Root.Analytics', ReadonlyField::create('LastAnalyticsUpdate', 'Last update from Google'));
        } else {
            $fields->removeByName(array_keys(static::$db));

Since $db is declared private, accessing it with static will lead to errors in possible sub-classes; you can either use self, or increase the visibility of $db to at least protected.

        }
    }
}