Larrock\Core\Traits\AdminMethodsIndex::index()

Complexity

Conditions	3
Paths	3

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	2	Features	1

<?php
    public function index()
    {
        if (isset($this->config->rows['category'])) {
            $data['app_category'] = LarrockCategory::getConfig();

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

            $data['categories'] = LarrockCategory::getModel()->whereComponent($this->config->name)->whereLevel(1)
                ->orderBy('position', 'DESC')->orderBy('updated_at', 'ASC')->with(['getChild', 'getParent'])->paginate(30);

            return view('larrock::admin.admin-builder.categories', $data);

The call to view() has too many arguments starting with $data.

The expression return view('larrock::admin.admin-builder.categories', $data) returns the type array<string,mixed> which is incompatible with the documented return type View.

        }

        if (array_key_exists('position', $this->config->rows)) {
            $data['data'] = $this->config->getModel()::orderBy('position', 'DESC')->paginate(30);
        } else {
            $data['data'] = $this->config->getModel()::paginate(30);
        }

        return view('larrock::admin.admin-builder.index', $data);

The expression return view('larrock::admin.admin-builder.index', $data) returns the type array<string,mixed> which is incompatible with the documented return type View.

    }