Larrock\Core\Traits\AdminMethodsIndex

Complexity

Total Complexity

3

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Importance

Changes	2
Bugs	2	Features	1

1 Method

Rating	Name	Duplication	Size	Complexity
A	index()	0	17	3

<?php

namespace Larrock\Core\Traits;

use LarrockCategory;

The type LarrockCategory was not found. Maybe you did not declare it correctly or list all dependencies?

use Larrock\Core\Component;

trait AdminMethodsIndex
{
    /** @var Component */
    protected $config;

    /**
     * Display a listing of the resource.
     *
     * @return \View
     */
    public function index()
    {
        if (isset($this->config->rows['category'])) {
            $data['app_category'] = LarrockCategory::getConfig();

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

            $data['categories'] = LarrockCategory::getModel()->whereComponent($this->config->name)->whereLevel(1)
                ->orderBy('position', 'DESC')->orderBy('updated_at', 'ASC')->with(['getChild', 'getParent'])->paginate(30);

            return view('larrock::admin.admin-builder.categories', $data);

The call to view() has too many arguments starting with $data.

The expression return view('larrock::admin.admin-builder.categories', $data) returns the type array<string,mixed> which is incompatible with the documented return type View.

        }

        if (array_key_exists('position', $this->config->rows)) {
            $data['data'] = $this->config->getModel()::orderBy('position', 'DESC')->paginate(30);
        } else {
            $data['data'] = $this->config->getModel()::paginate(30);
        }

        return view('larrock::admin.admin-builder.index', $data);

The expression return view('larrock::admin.admin-builder.index', $data) returns the type array<string,mixed> which is incompatible with the documented return type View.

    }
}