Larrock\Core\Traits\AdminMethodsEdit::edit()

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	2	Features	1

<?php
    public function edit($id)
    {
        $data['data'] = $this->config->getModel()::findOrFail($id);

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

        $data['app'] = $this->config->tabbable($data['data']);

        $validator = JsValidator::make($this->config->getValid($id));
        View::share('validator', $validator);

'validator' of type string is incompatible with the type array expected by parameter $| of Illuminate\Support\Facades\View::share().

        return view('larrock::admin.admin-builder.edit', $data);

The call to view() has too many arguments starting with $data.

The expression return view('larrock::admin.admin-builder.edit', $data) returns the type array<string,mixed> which is incompatible with the documented return type View.

    }