Larrock\Core\Traits\AdminMethodsEdit

Complexity

Total Complexity

1

Size/Duplication

Total Lines	19
Duplicated Lines	0 %

Importance

Changes	3
Bugs	2	Features	1

1 Method

Rating	Name	Duplication	Size	Complexity
A	edit()	0	9	1

<?php

namespace Larrock\Core\Traits;

use View;
use JsValidator;

The type JsValidator was not found. Maybe you did not declare it correctly or list all dependencies?

use Larrock\Core\Component;

trait AdminMethodsEdit
{
    /** @var Component */
    protected $config;

    /**
     * Show the form for editing the specified resource.
     * @param  int $id
     * @return View
     */
    public function edit($id)
    {
        $data['data'] = $this->config->getModel()::findOrFail($id);

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

        $data['app'] = $this->config->tabbable($data['data']);

        $validator = JsValidator::make($this->config->getValid($id));
        View::share('validator', $validator);

'validator' of type string is incompatible with the type array expected by parameter $| of Illuminate\Support\Facades\View::share().

        return view('larrock::admin.admin-builder.edit', $data);

The call to view() has too many arguments starting with $data.

The expression return view('larrock::admin.admin-builder.edit', $data) returns the type array<string,mixed> which is incompatible with the documented return type View.

    }
}