ErnadoO / qte

acp/main_module.php

Doc Comments +4 added lines, -1 removed lines

@@ -403,6 +403,9 @@ 
 		return $attr;
 	}
 
+	/**
+	 * @return string
+	 */
 	protected function qte_move($attr_row, $action = 'move_up', $steps = 1)
 	{
 		global $db, $table_prefix;
@@ -530,7 +533,7 @@ 
 	* Copy a permission (auth) option
 	*
 	* @param string		$auth_option		The name of the permission (auth) option
-	* @param int|false	$copy_from			If set, contains the id of the permission from which to copy the new one.
+	* @param string	$copy_from			If set, contains the id of the permission from which to copy the new one.
 	* @param bool		$clear_dest_perms	True if destination permissions should be deleted
 	* @return null
 	*/

Indentation +9 added lines, -9 removed lines

@@ -525,15 +525,15 @@
 	}
 
 	/**
-	* Permission Copy
-	*
-	* Copy a permission (auth) option
-	*
-	* @param string		$auth_option		The name of the permission (auth) option
-	* @param int|false	$copy_from			If set, contains the id of the permission from which to copy the new one.
-	* @param bool		$clear_dest_perms	True if destination permissions should be deleted
-	* @return null
-	*/
+	 * Permission Copy
+	 *
+	 * Copy a permission (auth) option
+	 *
+	 * @param string		$auth_option		The name of the permission (auth) option
+	 * @param int|false	$copy_from			If set, contains the id of the permission from which to copy the new one.
+	 * @param bool		$clear_dest_perms	True if destination permissions should be deleted
+	 * @return null
+	 */
 	private function _copy_permission($auth_option, $copy_from = false, $clear_dest_perms = true)
 	{
 		global $db, $phpbb_root_path, $phpEx;

qte.php

Spacing +17 added lines, -17 removed lines

@@ -69,16 +69,16 @@ 
 	*/
 	public function __construct(\phpbb\request\request $request, \phpbb\cache\driver\driver_interface $cache, \phpbb\db\driver\driver_interface $db, \phpbb\template\template $template, \phpbb\user $user, \phpbb\log\log $log, \phpbb\auth\auth $auth, $root_path, $php_ext, $table_prefix)
 	{
-		$this->request		= $request;
+		$this->request = $request;
 		$this->cache		= $cache;
-		$this->db			= $db;
-		$this->template		= $template;
+		$this->db = $db;
+		$this->template = $template;
 		$this->user			= $user;
-		$this->log			= $log;
+		$this->log = $log;
 		$this->auth			= $auth;
 
-		$this->root_path	= $root_path;
-		$this->php_ext		= $php_ext;
+		$this->root_path = $root_path;
+		$this->php_ext = $php_ext;
 		$this->table_prefix = $table_prefix;
 
 		$this->_get_attributes();
@@ -168,10 +168,10 @@ 
 	public function attr_select($forum_id, $author_id = 0, $attribute_id = 0, $viewtopic_url = '')
 	{
 		$show_select	= false;
-		$current_time	= time();
-		$can_edit		= $this->auth->acl_get('m_qte_attr_edit', $forum_id);
+		$current_time = time();
+		$can_edit = $this->auth->acl_get('m_qte_attr_edit', $forum_id);
 		$can_remove		= $this->auth->acl_get('m_qte_attr_del', $forum_id);
-		$is_author		= $this->user->data['is_registered'] && $this->user->data['user_id'] == $author_id;
+		$is_author = $this->user->data['is_registered'] && $this->user->data['user_id'] == $author_id;
 
 		// Basic auth
 		if (!$can_remove && !$can_edit && !$is_author)
@@ -181,7 +181,7 @@ 
 
 		foreach ($this->_attr as $attr)
 		{
-			if (!$this->auth->acl_get('f_qte_attr_'.$attr['attr_id'], $forum_id))
+			if (!$this->auth->acl_get('f_qte_attr_' . $attr['attr_id'], $forum_id))
 			{
 				continue;
 			}
@@ -251,7 +251,7 @@ 
 	{
 		foreach ($this->_attr as $attr)
 		{
-			$forum_allowed = $this->auth->acl_getf('f_qte_attr_'.$attr['attr_id'], true);
+			$forum_allowed = $this->auth->acl_getf('f_qte_attr_' . $attr['attr_id'], true);
 
 			if (isset($forum_allowed[$forum_id]))
 			{
@@ -284,7 +284,7 @@ 
 	{
 		foreach ($this->_attr as $attr)
 		{
-			$forum_allowed = $this->auth->acl_getf('f_qte_attr_'.$attr['attr_id'], true);
+			$forum_allowed = $this->auth->acl_getf('f_qte_attr_' . $attr['attr_id'], true);
 
 			if (isset($forum_allowed[$forum_id]))
 			{
@@ -395,8 +395,8 @@ 
 			return;
 		}
 
-		$can_edit		= $this->auth->acl_get('m_qte_attr_edit', $forum_id) || $this->auth->acl_get('f_qte_attr_'.$attribute_id, $forum_id) && $this->user->data['is_registered'] && $this->user->data['user_id'] == $author_id;
-		$can_remove		= $this->auth->acl_get('m_qte_attr_del', $forum_id);
+		$can_edit = $this->auth->acl_get('m_qte_attr_edit', $forum_id) || $this->auth->acl_get('f_qte_attr_' . $attribute_id, $forum_id) && $this->user->data['is_registered'] && $this->user->data['user_id'] == $author_id;
+		$can_remove = $this->auth->acl_get('m_qte_attr_del', $forum_id);
 
 		if (!$can_edit && $attribute_id != self::REMOVE || !$can_remove && $attribute_id == self::REMOVE)
 		{
@@ -470,8 +470,8 @@ 
 	*/
 	public function mcp_attr_apply($attribute_id = 0, $forum_id = 0, $topic_ids = array())
 	{
-		$can_edit		= $this->auth->acl_get('m_qte_attr_edit', $forum_id);
-		$can_remove		= $this->auth->acl_get('m_qte_attr_del', $forum_id);
+		$can_edit = $this->auth->acl_get('m_qte_attr_edit', $forum_id);
+		$can_remove = $this->auth->acl_get('m_qte_attr_del', $forum_id);
 
 		if (!$can_edit && $attribute_id != self::REMOVE || !$can_remove && $attribute_id == self::REMOVE)
 		{
@@ -582,7 +582,7 @@ 
 			$a_class_name = preg_replace('#[^a-z0-9 _-]#', '', strtolower($a_name));
 		}
 
-		return ' class="qte-attr ' . (isset($a_class_name) ?  $a_class_name : '') . '"' . (!empty($a_colour) ? ' style="color:#' . $a_colour . '; font-weight:bold;"' : '');
+		return ' class="qte-attr ' . (isset($a_class_name) ? $a_class_name : '') . '"' . (!empty($a_colour) ? ' style="color:#' . $a_colour . '; font-weight:bold;"' : '');
 	}
 
 	/**