ErnadoO / qte

acp/main_module.php

Doc Comments +3 added lines

@@ -462,6 +462,9 @@
 		}
 	}
 
+	/**
+	 * @return string
+	 */
 	protected function qte_move($attr_row, $action = 'move_up', $steps = 1)
 	{
 		global $db, $table_prefix;

qte.php

Spacing +12 added lines, -12 removed lines

@@ -69,16 +69,16 @@ 
 	*/
 	public function __construct(\phpbb\request\request $request, \phpbb\cache\driver\driver_interface $cache, \phpbb\config\config $config, \phpbb\db\driver\driver_interface $db, \phpbb\template\template $template, \phpbb\user $user, \phpbb\log\log $log, $root_path, $php_ext, $table_prefix)
 	{
-		$this->request		= $request;
-		$this->cache		= $cache;
-		$this->config		= $config;
-		$this->db			= $db;
-		$this->template		= $template;
-		$this->user			= $user;
-		$this->log			= $log;
-
-		$this->root_path	= $root_path;
-		$this->php_ext		= $php_ext;
+		$this->request = $request;
+		$this->cache = $cache;
+		$this->config = $config;
+		$this->db = $db;
+		$this->template = $template;
+		$this->user = $user;
+		$this->log = $log;
+
+		$this->root_path = $root_path;
+		$this->php_ext = $php_ext;
 		$this->table_prefix = $table_prefix;
 
 		$this->_get_attributes();
@@ -144,7 +144,7 @@ 
 			$result = $this->db->sql_query($sql);
 
 			$this->_name = array();
-			while ( $row = $this->db->sql_fetchrow($result) )
+			while ($row = $this->db->sql_fetchrow($result))
 			{
 				$this->_name[$row['user_id']] = array(
 					'user_id'		=> (int) $row['user_id'],
@@ -717,7 +717,7 @@ 
 			$a_class_name = preg_replace('#[^a-z0-9 _-]#', '', strtolower($a_name));
 		}
 
-		return ' class="qte-attr ' . (isset($a_class_name) ?  $a_class_name : '') . '"' . (!empty($a_colour) ? ' style="color:#' . $a_colour . '; font-weight:bold;"' : '');
+		return ' class="qte-attr ' . (isset($a_class_name) ? $a_class_name : '') . '"' . (!empty($a_colour) ? ' style="color:#' . $a_colour . '; font-weight:bold;"' : '');
 	}
 
 	/**

Indentation +128 added lines, -128 removed lines

@@ -54,19 +54,19 @@ 
 	private $_name = array();
 
 	/**
-	* Constructor
-	*
-	* @param \phpbb\request\request					$request			Request object
-	* @param \phpbb\cache\driver\driver_interface	$cache				Cache object
-	* @param \phpbb\config\config					$config				Config object
-	* @param \phpbb\db\driver\driver_interface 		$db					Database object
-	* @param \phpbb\template\template				$template			Template object
-	* @param \phpbb\user							$user				User object
-	* @param \phpbb\log\log							$log				Log object
-	* @param string									$root_path			phpBB root path
-	* @param string									$php_ext   			phpEx
-	* @param string									$table_prefix   	Prefix tables
-	*/
+	 * Constructor
+	 *
+	 * @param \phpbb\request\request					$request			Request object
+	 * @param \phpbb\cache\driver\driver_interface	$cache				Cache object
+	 * @param \phpbb\config\config					$config				Config object
+	 * @param \phpbb\db\driver\driver_interface 		$db					Database object
+	 * @param \phpbb\template\template				$template			Template object
+	 * @param \phpbb\user							$user				User object
+	 * @param \phpbb\log\log							$log				Log object
+	 * @param string									$root_path			phpBB root path
+	 * @param string									$php_ext   			phpEx
+	 * @param string									$table_prefix   	Prefix tables
+	 */
 	public function __construct(\phpbb\request\request $request, \phpbb\cache\driver\driver_interface $cache, \phpbb\config\config $config, \phpbb\db\driver\driver_interface $db, \phpbb\template\template $template, \phpbb\user $user, \phpbb\log\log $log, $root_path, $php_ext, $table_prefix)
 	{
 		$this->request		= $request;
@@ -86,12 +86,12 @@ 
 	}
 
 	/**
-	* Get topic attributes username
-	*
-	* @param	array	$topic_list	Topic ids
-	*
-	* @return	null
-	*/
+	 * Get topic attributes username
+	 *
+	 * @param	array	$topic_list	Topic ids
+	 *
+	 * @return	null
+	 */
 	public function get_users_by_topic_id($topic_list)
 	{
 		if (!empty($topic_list))
@@ -116,24 +116,24 @@ 
 	}
 
 	/**
-	* Get attribute name
-	*
-	* @param	int		$attr_id	The attribute id
-	*
-	* @return	string
-	*/
+	 * Get attribute name
+	 *
+	 * @param	int		$attr_id	The attribute id
+	 *
+	 * @return	string
+	 */
 	public function get_attr_name_by_id($attr_id)
 	{
 		return $this->_attr[$attr_id]['attr_name'];
 	}
 
 	/**
-	* Get attribute author
-	*
-	* @param	int		$user_id	User id
-	*
-	* @return	string
-	*/
+	 * Get attribute author
+	 *
+	 * @param	int		$user_id	User id
+	 *
+	 * @return	string
+	 */
 	public function get_users_by_user_id($user_id)
 	{
 		if (!isset($this->_name[$user_id]))
@@ -157,16 +157,16 @@ 
 	}
 
 	/**
-	* Generate a list of attributes based on permissions
-	*
-	* @param	int		$forum_id		Forum id
-	* @param	int		$author_id		Topic author id
-	* @param	int		$attribute_id	Current attribute id
-	* @param	array	$hide_attr		Groups which can't delete attribute in this forum
-	* @param	string	$viewtopic_url	Topic's url
-	*
-	* @return	null
-	*/
+	 * Generate a list of attributes based on permissions
+	 *
+	 * @param	int		$forum_id		Forum id
+	 * @param	int		$author_id		Topic author id
+	 * @param	int		$attribute_id	Current attribute id
+	 * @param	array	$hide_attr		Groups which can't delete attribute in this forum
+	 * @param	string	$viewtopic_url	Topic's url
+	 *
+	 * @return	null
+	 */
 	public function attr_select($forum_id = 0, $author_id = 0, $attribute_id = 0, $hide_attr = array(), $viewtopic_url = '')
 	{
 		// get current time once !
@@ -235,10 +235,10 @@ 
 	}
 
 	/**
-	* Generate a list of all attributes for search page
-	*
-	* @return	null
-	*/
+	 * Generate a list of all attributes for search page
+	 *
+	 * @return	null
+	 */
 	public function attr_search()
 	{
 		$show_select = false;
@@ -269,13 +269,13 @@ 
 	}
 
 	/**
-	* Generate a list of attributes for viewforum page
-	*
-	* @param	int		$forum_id		Forum id
-	* @param	int		$attribute_id	Current attribute id
-	*
-	* @return	null
-	*/
+	 * Generate a list of attributes for viewforum page
+	 *
+	 * @param	int		$forum_id		Forum id
+	 * @param	int		$attribute_id	Current attribute id
+	 *
+	 * @return	null
+	 */
 	public function attr_sort($forum_id = 0, $attribute_id = 0)
 	{
 		$show_select = false;
@@ -329,13 +329,13 @@ 
 	}
 
 	/**
-	* Generate a default attribute list for a forum
-	*
-	* @param	int		$forum_id		Forum id
-	* @param	int		$attribute_id	Current attribute id
-	*
-	* @return	null
-	*/
+	 * Generate a default attribute list for a forum
+	 *
+	 * @param	int		$forum_id		Forum id
+	 * @param	int		$attribute_id	Current attribute id
+	 *
+	 * @return	null
+	 */
 	public function attr_default($forum_id = 0, $attribute_id = 0)
 	{
 		$show_select = false;
@@ -389,14 +389,14 @@ 
 	}
 
 	/**
-	* Generate attribute for topic title
-	*
-	* @param	int		$attribute_id	Current attribute id
-	* @param	int		$user_id		Current attribute user id
-	* @param	int		$timestamp		Attribute timestamp
-	*
-	* @return	string					Attribute html code
-	*/
+	 * Generate attribute for topic title
+	 *
+	 * @param	int		$attribute_id	Current attribute id
+	 * @param	int		$user_id		Current attribute user id
+	 * @param	int		$timestamp		Attribute timestamp
+	 *
+	 * @return	string					Attribute html code
+	 */
 	public function attr_display($attribute_id = 0, $user_id = 0, $timestamp = 0)
 	{
 		if (empty($attribute_id) || empty($user_id) || empty($timestamp))
@@ -426,14 +426,14 @@ 
 	}
 
 	/**
-	* Generate attribute for page title
-	*
-	* @param	int		$attribute_id	Current attribute id
-	* @param	int		$user_id		Current attribute user id
-	* @param	int		$timestamp		Attribute timestamp
-	*
-	* @return	string					attribute html code
-	*/
+	 * Generate attribute for page title
+	 *
+	 * @param	int		$attribute_id	Current attribute id
+	 * @param	int		$user_id		Current attribute user id
+	 * @param	int		$timestamp		Attribute timestamp
+	 *
+	 * @return	string					attribute html code
+	 */
 	public function attr_title($attribute_id = 0, $user_id = 0, $timestamp = 0)
 	{
 		if (empty($attribute_id) || empty($user_id) || empty($timestamp))
@@ -460,16 +460,16 @@ 
 
 
 	/**
-	* Change topic attribute
-	*
-	* @param	int		$attribute_id		New attribute id
-	* @param	int		$topic_id			The id of the topic
-	* @param	int		$forum_id			The id of the forum
-	* @param	int		$topic_attribute	Current attribute id
-	* @param	array	$hide_attr			Groups which can't delete attribute in this forum
-	*
-	* @return	null
-	*/
+	 * Change topic attribute
+	 *
+	 * @param	int		$attribute_id		New attribute id
+	 * @param	int		$topic_id			The id of the topic
+	 * @param	int		$forum_id			The id of the forum
+	 * @param	int		$topic_attribute	Current attribute id
+	 * @param	array	$hide_attr			Groups which can't delete attribute in this forum
+	 *
+	 * @return	null
+	 */
 	public function attr_apply($attribute_id = 0, $topic_id = 0, $forum_id = 0, $topic_attribute = 0, $hide_attr = array())
 	{
 		if (empty($topic_id) || empty($forum_id) || empty($attribute_id))
@@ -547,13 +547,13 @@ 
 	}
 
 	/**
-	* Change topic attribute in mcp
-	*
-	* @param	int		$attribute_id		New attribute id
-	* @param	array	$topic_ids			Topics ids
-	*
-	* @return	null
-	*/
+	 * Change topic attribute in mcp
+	 *
+	 * @param	int		$attribute_id		New attribute id
+	 * @param	array	$topic_ids			Topics ids
+	 *
+	 * @return	null
+	 */
 	public function mcp_attr_apply($attribute_id = 0, $topic_ids = array())
 	{
 		if (!sizeof($topic_ids))
@@ -638,24 +638,24 @@ 
 	}
 
 	/**
-	* Getter...
-	*
-	* @return	array
-	*/
+	 * Getter...
+	 *
+	 * @return	array
+	 */
 	public function getAttr()
 	{
 		return $this->_attr;
 	}
 
 	/**
-	* Generate list of groups
-	*
-	* @param int		$group_ids		The default groups id to mark as selected
-	* @param array|bool	$exclude_ids	The group ids to exclude from the list, false (default) if you whish to exclude no id
-	* @param bool		$manage_founder If set to false (default) all groups are returned, if 0 only those groups returned not being managed by founders only, if 1 only those groups returned managed by founders only.
-	*
-	* @return string The list of options.
-	*/
+	 * Generate list of groups
+	 *
+	 * @param int		$group_ids		The default groups id to mark as selected
+	 * @param array|bool	$exclude_ids	The group ids to exclude from the list, false (default) if you whish to exclude no id
+	 * @param bool		$manage_founder If set to false (default) all groups are returned, if 0 only those groups returned not being managed by founders only, if 1 only those groups returned managed by founders only.
+	 *
+	 * @return string The list of options.
+	 */
 	public function qte_group_select($group_ids, $exclude_ids = array(), $manage_founder = false)
 	{
 		$exclude_sql = ($exclude_ids !== false && sizeof($exclude_ids)) ? 'WHERE ' . $this->db->sql_in_set('group_id', array_map('intval', $exclude_ids), true) : '';
@@ -688,12 +688,12 @@ 
 	}
 
 	/**
-	* Build class and style attribute
-	*
-	* @param	string	$a_name			Attribute name
-	* @param	string	$a_colour		Attribute color
-	* @return	string					html code
-	*/
+	 * Build class and style attribute
+	 *
+	 * @param	string	$a_name			Attribute name
+	 * @param	string	$a_colour		Attribute color
+	 * @return	string					html code
+	 */
 	public function attr_colour($a_name, $a_colour)
 	{
 		if ($a_name != $this->user->lang($a_name))
@@ -705,14 +705,14 @@ 
 	}
 
 	/**
-	* Check if user can apply an attribute
-	*
-	* @param	array	$attr_auth		Forum auth
-	* @param	int		$forum_id		Forum id
-	* @param	array	$user_groups	User's groups
-	* @param	int		$author_id		Topic author id
-	* @return	bool
-	*/
+	 * Check if user can apply an attribute
+	 *
+	 * @param	array	$attr_auth		Forum auth
+	 * @param	int		$forum_id		Forum id
+	 * @param	array	$user_groups	User's groups
+	 * @param	int		$author_id		Topic author id
+	 * @return	bool
+	 */
 	private function _check_auth_attribute($attr_auth, $forum_id, $user_groups, $author_id)
 	{
 		$forum_ids = $attr_auth['forums_ids'];
@@ -730,12 +730,12 @@ 
 	}
 
 	/**
-	* Check if user can delete an attribute
-	*
-	* @param	array	$user_groups	User's groups
-	* @param	array	$hide_attr		Groups which can't delete attribute in a forum
-	* @return	bool
-	*/
+	 * Check if user can delete an attribute
+	 *
+	 * @param	array	$user_groups	User's groups
+	 * @param	array	$hide_attr		Groups which can't delete attribute in a forum
+	 * @return	bool
+	 */
 	private function _check_auth_remove_attr(&$user_groups, $hide_attr)
 	{
 		// include that file !
@@ -761,10 +761,10 @@ 
 	}
 
 	/**
-	* Get attributes from database
-	*
-	* @return	null
-	*/
+	 * Get attributes from database
+	 *
+	 * @return	null
+	 */
 	private function _get_attributes()
 	{
 		if (($this->_attr = $this->cache->get('_attr')) === false)

search/fulltext_attribute.php

Doc Comments -12 removed lines

@@ -33,18 +33,6 @@
 	/**
 	* Performs a search on keywords depending on display specific params. You have to run split_keywords() first
 	*
-	* @param	array		$keywords_ary		contains each words to search
-	* @param	string		$terms				is either 'all' (use query as entered, words without prefix should default to "have to be in field") or 'any' (ignore search query parts and just return all posts that contain any of the specified words)
-	* @param	array		$sort_by_sql		contains SQL code for the ORDER BY part of a query
-	* @param	string		$sort_key			is the key of $sort_by_sql for the selected sorting
-	* @param	string		$sort_dir			is either a or d representing ASC and DESC
-	* @param	string		$sort_days			specifies the maximum amount of days a post may be old
-	* @param	array		$ex_cid_ary			specifies an array of category ids which should not be searched
-	* @param	int			$cat_id				is set to 0 or a topic id, if it is not 0 then only posts in this topic should be searched
-	* @param	array		&$id_ary			passed by reference, to be filled with ids for the page specified by $start and $per_page, should be ordered
-	* @param	int			$start				indicates the first index of the page
-	* @param	int			$per_page			number of ids each page is supposed to contain
-	* @return	int								total number of results
 	*/
 	public function attribute_search($attribute_id, $type, $terms, $sort_by_sql, $sort_key, $sort_dir, $sort_days, $ex_fid_ary, $post_visibility, $topic_id, $author_ary, $author_name, &$id_ary, &$start, $per_page)
 	{

Indentation +20 added lines, -20 removed lines

@@ -19,11 +19,11 @@ 
 	protected $db;
 
 	/**
-	* Constructor
-	*
-	* @param \phpbb\config\config				$config Config object
-	* @param \phpbb\db\driver\driver_interface	$db		Database object
-	*/
+	 * Constructor
+	 *
+	 * @param \phpbb\config\config				$config Config object
+	 * @param \phpbb\db\driver\driver_interface	$db		Database object
+	 */
 	public function __construct(\phpbb\config\config $config, \phpbb\db\driver\driver_interface $db)
 	{
 		$this->config	= $config;
@@ -31,21 +31,21 @@ 
 	}
 
 	/**
-	* Performs a search on keywords depending on display specific params. You have to run split_keywords() first
-	*
-	* @param	array		$keywords_ary		contains each words to search
-	* @param	string		$terms				is either 'all' (use query as entered, words without prefix should default to "have to be in field") or 'any' (ignore search query parts and just return all posts that contain any of the specified words)
-	* @param	array		$sort_by_sql		contains SQL code for the ORDER BY part of a query
-	* @param	string		$sort_key			is the key of $sort_by_sql for the selected sorting
-	* @param	string		$sort_dir			is either a or d representing ASC and DESC
-	* @param	string		$sort_days			specifies the maximum amount of days a post may be old
-	* @param	array		$ex_cid_ary			specifies an array of category ids which should not be searched
-	* @param	int			$cat_id				is set to 0 or a topic id, if it is not 0 then only posts in this topic should be searched
-	* @param	array		&$id_ary			passed by reference, to be filled with ids for the page specified by $start and $per_page, should be ordered
-	* @param	int			$start				indicates the first index of the page
-	* @param	int			$per_page			number of ids each page is supposed to contain
-	* @return	int								total number of results
-	*/
+	 * Performs a search on keywords depending on display specific params. You have to run split_keywords() first
+	 *
+	 * @param	array		$keywords_ary		contains each words to search
+	 * @param	string		$terms				is either 'all' (use query as entered, words without prefix should default to "have to be in field") or 'any' (ignore search query parts and just return all posts that contain any of the specified words)
+	 * @param	array		$sort_by_sql		contains SQL code for the ORDER BY part of a query
+	 * @param	string		$sort_key			is the key of $sort_by_sql for the selected sorting
+	 * @param	string		$sort_dir			is either a or d representing ASC and DESC
+	 * @param	string		$sort_days			specifies the maximum amount of days a post may be old
+	 * @param	array		$ex_cid_ary			specifies an array of category ids which should not be searched
+	 * @param	int			$cat_id				is set to 0 or a topic id, if it is not 0 then only posts in this topic should be searched
+	 * @param	array		&$id_ary			passed by reference, to be filled with ids for the page specified by $start and $per_page, should be ordered
+	 * @param	int			$start				indicates the first index of the page
+	 * @param	int			$per_page			number of ids each page is supposed to contain
+	 * @return	int								total number of results
+	 */
 	public function attribute_search($attribute_id, $type, $terms, $sort_by_sql, $sort_key, $sort_dir, $sort_days, $ex_fid_ary, $post_visibility, $topic_id, $author_ary, $author_name, &$id_ary, &$start, $per_page)
 	{
 		// generate a search_key from all the options to identify the results

Spacing +9 added lines, -9 removed lines

@@ -26,8 +26,8 @@ 
 	*/
 	public function __construct(\phpbb\config\config $config, \phpbb\db\driver\driver_interface $db)
 	{
-		$this->config	= $config;
-		$this->db		= $db;
+		$this->config = $config;
+		$this->db = $db;
 	}
 
 	/**
@@ -81,11 +81,11 @@ 
 		$id_ary = array();
 
 		// Create some display specific sql strings
-		$sql_attribute	= 't.topic_attr_id = ' . (int) $attribute_id;
+		$sql_attribute = 't.topic_attr_id = ' . (int) $attribute_id;
 		$sql_fora		= (sizeof($ex_fid_ary)) ? ' AND ' . $this->db->sql_in_set('p.forum_id', $ex_fid_ary, true) : '';
-		$sql_topic_id	= ($topic_id) ? ' AND p.topic_id = ' . (int) $topic_id : '';
+		$sql_topic_id = ($topic_id) ? ' AND p.topic_id = ' . (int) $topic_id : '';
 		$sql_time		= ($sort_days) ? ' AND p.post_time >= ' . (time() - ($sort_days * 86400)) : '';
-		$sql_firstpost	= ' AND p.post_id = t.topic_first_post_id';
+		$sql_firstpost = ' AND p.post_id = t.topic_first_post_id';
 
 		// Build sql strings for sorting
 		$sql_sort = $sort_by_sql[$sort_key] . (($sort_dir == 'a') ? ' ASC' : ' DESC');
@@ -93,13 +93,13 @@ 
 		switch ($sql_sort[0])
 		{
 			case 'u':
-				$sql_sort_table	= USERS_TABLE . ' u, ';
-				$sql_sort_join	= ($type == 'posts') ? ' AND u.user_id = p.poster_id ' : ' AND u.user_id = t.topic_poster ';
+				$sql_sort_table = USERS_TABLE . ' u, ';
+				$sql_sort_join = ($type == 'posts') ? ' AND u.user_id = p.poster_id ' : ' AND u.user_id = t.topic_poster ';
 			break;
 
 			case 'f':
-				$sql_sort_table	= FORUMS_TABLE . ' f, ';
-				$sql_sort_join	= ' AND f.forum_id = p.forum_id ';
+				$sql_sort_table = FORUMS_TABLE . ' f, ';
+				$sql_sort_join = ' AND f.forum_id = p.forum_id ';
 			break;
 		}
 

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -111,7 +111,7 @@ 
 		// Build the query for really selecting the post_ids
 		if ($type == 'posts')
 		{
-			$sql = "SELECT {$calc_results}p.post_id
+			$sql = "select {$calc_results}p.post_id
 				FROM " . $sql_sort_table . POSTS_TABLE . ' p, ' . TOPICS_TABLE . ' t ' . "
 				WHERE $sql_attribute
 					$sql_topic_id
@@ -125,7 +125,7 @@ 
 		}
 		else
 		{
-			$sql = "SELECT {$calc_results}t.topic_id
+			$sql = "select {$calc_results}t.topic_id
 				FROM " . $sql_sort_table . TOPICS_TABLE . ' t, ' . POSTS_TABLE . " p
 				WHERE $sql_attribute
 					$sql_topic_id

event/search_listener.php

Spacing +7 added lines, -7 removed lines

@@ -36,11 +36,11 @@ 
 
 	public function __construct(\phpbb\request\request $request, \phpbb\template\template $template, \phpbb\user $user, \ernadoo\qte\qte $qte, \ernadoo\qte\search\fulltext_attribute $qte_search)
 	{
-		$this->request		= $request;
-		$this->template		= $template;
-		$this->user			= $user;
-		$this->qte			= $qte;
-		$this->qte_search	= $qte_search;
+		$this->request = $request;
+		$this->template = $template;
+		$this->user = $user;
+		$this->qte = $qte;
+		$this->qte_search = $qte_search;
 	}
 
 	static public function getSubscribedEvents()
@@ -127,8 +127,8 @@ 
 	{
 		if ($this->searc_attr)
 		{
-			$keywords	= utf8_normalize_nfc($this->request->variable('keywords', '', true));
-			$author		= $this->request->variable('author', '', true);
+			$keywords = utf8_normalize_nfc($this->request->variable('keywords', '', true));
+			$author = $this->request->variable('author', '', true);
 
 			if (!$keywords && !$author)
 			{

event/main_listener.php

Spacing +4 added lines, -4 removed lines

@@ -102,7 +102,7 @@ 
 	public function viewtopic_attr_apply($event)
 	{
 		$attr_id = (int) $this->request->variable('attr_id', 0);
-		if ( $attr_id )
+		if ($attr_id)
 		{
 			$this->qte->get_users_by_topic_id(array($event['topic_id']));
 			$this->qte->attr_apply($attr_id, $event['topic_id'], $event['forum_id'], $event['topic_data']['topic_attr_id'], (array) unserialize(trim($event['topic_data']['hide_attr'])));
@@ -123,7 +123,7 @@ 
 
 				if ($topic_attribute != \ernadoo\qte\qte::KEEP)
 				{
-					$post_data['topic_attr_id']		= (int) $topic_attribute;
+					$post_data['topic_attr_id'] = (int) $topic_attribute;
 					$post_data['topic_attr_user']	= (int) $this->user->data['user_id'];
 					$post_data['topic_attr_time']	= time();
 
@@ -146,11 +146,11 @@ 
 
 		if ($event['post_data']['force_attr'])
 		{
-			if ($post_data['attr_id'] == \ernadoo\qte\qte::REMOVE && ($event['mode'] == 'post' || ($event['mode'] == 'edit' && $event['post_data']['topic_first_post_id'] == $event['post_id'])) )
+			if ($post_data['attr_id'] == \ernadoo\qte\qte::REMOVE && ($event['mode'] == 'post' || ($event['mode'] == 'edit' && $event['post_data']['topic_first_post_id'] == $event['post_id'])))
 			{
 				$error = $event['error'];
 				$error[] = $this->user->lang['QTE_ATTRIBUTE_UNSELECTED'];
-				$event['error'] = $error ;
+				$event['error'] = $error;
 
 				// init the value
 				$post_data['attr_id'] = 0;

event/mcp_listener.php

Spacing +2 added lines, -2 removed lines

@@ -70,7 +70,7 @@ 
 	{
 		$sql_ary = $event['sql_ary'];
 
-		$sql_ary['topic_attr_id']	= $event['topic_row']['topic_attr_id'];
+		$sql_ary['topic_attr_id'] = $event['topic_row']['topic_attr_id'];
 		$sql_ary['topic_attr_user'] = $event['topic_row']['topic_attr_user'];
 		$sql_ary['topic_attr_time'] = $event['topic_row']['topic_attr_time'];
 
@@ -81,7 +81,7 @@ 
 	{
 		$shadow = $event['shadow'];
 
-		$shadow['topic_attr_id']	= $event['row']['topic_attr_id'];
+		$shadow['topic_attr_id'] = $event['row']['topic_attr_id'];
 		$shadow['topic_attr_user']	= $event['row']['topic_attr_user'];
 		$shadow['topic_attr_time']	= $event['row']['topic_attr_time'];