Completed
Push — #12 ( 657da9...df1b81 )
by Erwan
01:55
created
qte.php 2 patches
Indentation   +108 added lines, -108 removed lines patch added patch discarded remove patch
@@ -54,19 +54,19 @@  discard block
 block discarded – undo
54 54
 	private $_name = array();
55 55
 
56 56
 	/**
57
-	* Constructor
58
-	*
59
-	* @param \phpbb\request\request					$request			Request object
60
-	* @param \phpbb\cache\driver\driver_interface	$cache				Cache object
61
-	* @param \phpbb\db\driver\driver_interface 		$db					Database object
62
-	* @param \phpbb\template\template				$template			Template object
63
-	* @param \phpbb\user							$user				User object
64
-	* @param \phpbb\log\log							$log				Log object
65
-	* @param \phpbb\auth\auth						$auth				Auth object
66
-	* @param string									$root_path			phpBB root path
67
-	* @param string									$php_ext   			phpEx
68
-	* @param string									$table_prefix   	Prefix tables
69
-	*/
57
+	 * Constructor
58
+	 *
59
+	 * @param \phpbb\request\request					$request			Request object
60
+	 * @param \phpbb\cache\driver\driver_interface	$cache				Cache object
61
+	 * @param \phpbb\db\driver\driver_interface 		$db					Database object
62
+	 * @param \phpbb\template\template				$template			Template object
63
+	 * @param \phpbb\user							$user				User object
64
+	 * @param \phpbb\log\log							$log				Log object
65
+	 * @param \phpbb\auth\auth						$auth				Auth object
66
+	 * @param string									$root_path			phpBB root path
67
+	 * @param string									$php_ext   			phpEx
68
+	 * @param string									$table_prefix   	Prefix tables
69
+	 */
70 70
 	public function __construct(\phpbb\request\request $request, \phpbb\cache\driver\driver_interface $cache, \phpbb\db\driver\driver_interface $db, \phpbb\template\template $template, \phpbb\user $user, \phpbb\log\log $log, \phpbb\auth\auth $auth, $root_path, $php_ext, $table_prefix)
71 71
 	{
72 72
 		$this->request		= $request;
@@ -86,12 +86,12 @@  discard block
 block discarded – undo
86 86
 	}
87 87
 
88 88
 	/**
89
-	* Get topic attributes username
90
-	*
91
-	* @param	array	$topic_list	Topic ids
92
-	*
93
-	* @return	null
94
-	*/
89
+	 * Get topic attributes username
90
+	 *
91
+	 * @param	array	$topic_list	Topic ids
92
+	 *
93
+	 * @return	null
94
+	 */
95 95
 	public function get_users_by_topic_id($topic_list)
96 96
 	{
97 97
 		if (!empty($topic_list))
@@ -116,24 +116,24 @@  discard block
 block discarded – undo
116 116
 	}
117 117
 
118 118
 	/**
119
-	* Get attribute name
120
-	*
121
-	* @param	int		$attr_id	The attribute id
122
-	*
123
-	* @return	string
124
-	*/
119
+	 * Get attribute name
120
+	 *
121
+	 * @param	int		$attr_id	The attribute id
122
+	 *
123
+	 * @return	string
124
+	 */
125 125
 	public function get_attr_name_by_id($attr_id)
126 126
 	{
127 127
 		return $this->_attr[$attr_id]['attr_name'];
128 128
 	}
129 129
 
130 130
 	/**
131
-	* Get attribute author
132
-	*
133
-	* @param	int		$user_id	User id
134
-	*
135
-	* @return	string
136
-	*/
131
+	 * Get attribute author
132
+	 *
133
+	 * @param	int		$user_id	User id
134
+	 *
135
+	 * @return	string
136
+	 */
137 137
 	public function get_users_by_user_id($user_id)
138 138
 	{
139 139
 		if (!isset($this->_name[$user_id]))
@@ -156,16 +156,16 @@  discard block
 block discarded – undo
156 156
 	}
157 157
 
158 158
 	/**
159
-	* Generate a list of attributes based on permissions
160
-	*
161
-	* @param	int		$forum_id		Forum id
162
-	* @param	int		$author_id		Topic author id
163
-	* @param	int		$attribute_id	Current attribute id
164
-	* @param	string	$viewtopic_url	Topic's url
165
-	* @param	string	$mode			Post mode
166
-	*
167
-	* @return	null
168
-	*/
159
+	 * Generate a list of attributes based on permissions
160
+	 *
161
+	 * @param	int		$forum_id		Forum id
162
+	 * @param	int		$author_id		Topic author id
163
+	 * @param	int		$attribute_id	Current attribute id
164
+	 * @param	string	$viewtopic_url	Topic's url
165
+	 * @param	string	$mode			Post mode
166
+	 *
167
+	 * @return	null
168
+	 */
169 169
 	public function attr_select($forum_id, $author_id = 0, $attribute_id = 0, $viewtopic_url = '', $mode = '')
170 170
 	{
171 171
 		$show_select	= false;
@@ -215,10 +215,10 @@  discard block
 block discarded – undo
215 215
 	}
216 216
 
217 217
 	/**
218
-	* Generate a list of all attributes for search page
219
-	*
220
-	* @return	null
221
-	*/
218
+	 * Generate a list of all attributes for search page
219
+	 *
220
+	 * @return	null
221
+	 */
222 222
 	public function attr_search()
223 223
 	{
224 224
 		foreach ($this->_attr as $attr)
@@ -238,13 +238,13 @@  discard block
 block discarded – undo
238 238
 	}
239 239
 
240 240
 	/**
241
-	* Generate a list of attributes for viewforum page
242
-	*
243
-	* @param	int		$forum_id		Forum id
244
-	* @param	int		$attribute_id	Current attribute id
245
-	*
246
-	* @return	null
247
-	*/
241
+	 * Generate a list of attributes for viewforum page
242
+	 *
243
+	 * @param	int		$forum_id		Forum id
244
+	 * @param	int		$attribute_id	Current attribute id
245
+	 *
246
+	 * @return	null
247
+	 */
248 248
 	public function attr_sort($forum_id = 0, $attribute_id = 0)
249 249
 	{
250 250
 		foreach ($this->_attr as $attr)
@@ -271,13 +271,13 @@  discard block
 block discarded – undo
271 271
 	}
272 272
 
273 273
 	/**
274
-	* Generate a default attribute list for a forum
275
-	*
276
-	* @param	int		$forum_id		Forum id
277
-	* @param	int		$attribute_id	Current attribute id
278
-	*
279
-	* @return	null
280
-	*/
274
+	 * Generate a default attribute list for a forum
275
+	 *
276
+	 * @param	int		$forum_id		Forum id
277
+	 * @param	int		$attribute_id	Current attribute id
278
+	 *
279
+	 * @return	null
280
+	 */
281 281
 	public function attr_default($forum_id = 0, $attribute_id = 0)
282 282
 	{
283 283
 		foreach ($this->_attr as $attr)
@@ -304,14 +304,14 @@  discard block
 block discarded – undo
304 304
 	}
305 305
 
306 306
 	/**
307
-	* Generate attribute for topic title
308
-	*
309
-	* @param	int		$attribute_id	Current attribute id
310
-	* @param	int		$user_id		Current attribute user id
311
-	* @param	int		$timestamp		Attribute timestamp
312
-	*
313
-	* @return	string					Attribute html code
314
-	*/
307
+	 * Generate attribute for topic title
308
+	 *
309
+	 * @param	int		$attribute_id	Current attribute id
310
+	 * @param	int		$user_id		Current attribute user id
311
+	 * @param	int		$timestamp		Attribute timestamp
312
+	 *
313
+	 * @return	string					Attribute html code
314
+	 */
315 315
 	public function attr_display($attribute_id = 0, $user_id = 0, $timestamp = 0)
316 316
 	{
317 317
 		if (empty($attribute_id) || empty($user_id) || empty($timestamp))
@@ -341,14 +341,14 @@  discard block
 block discarded – undo
341 341
 	}
342 342
 
343 343
 	/**
344
-	* Generate attribute for page title
345
-	*
346
-	* @param	int		$attribute_id	Current attribute id
347
-	* @param	int		$user_id		Current attribute user id
348
-	* @param	int		$timestamp		Attribute timestamp
349
-	*
350
-	* @return	string					attribute html code
351
-	*/
344
+	 * Generate attribute for page title
345
+	 *
346
+	 * @param	int		$attribute_id	Current attribute id
347
+	 * @param	int		$user_id		Current attribute user id
348
+	 * @param	int		$timestamp		Attribute timestamp
349
+	 *
350
+	 * @return	string					attribute html code
351
+	 */
352 352
 	public function attr_title($attribute_id = 0, $user_id = 0, $timestamp = 0)
353 353
 	{
354 354
 		if (empty($attribute_id) || empty($user_id) || empty($timestamp))
@@ -375,17 +375,17 @@  discard block
 block discarded – undo
375 375
 
376 376
 
377 377
 	/**
378
-	* Change topic attribute
379
-	*
380
-	* @param	int		$attribute_id		New attribute id
381
-	* @param	int		$topic_id			The id of the topic
382
-	* @param	int		$forum_id			The id of the forum
383
-	* @param	int		$topic_attribute	Current attribute id
384
-	* @param	int		$author_id			Topic author id
385
-	* @param	string	$viewtopic_url		URL to the topic page
386
-	*
387
-	* @return	null
388
-	*/
378
+	 * Change topic attribute
379
+	 *
380
+	 * @param	int		$attribute_id		New attribute id
381
+	 * @param	int		$topic_id			The id of the topic
382
+	 * @param	int		$forum_id			The id of the forum
383
+	 * @param	int		$topic_attribute	Current attribute id
384
+	 * @param	int		$author_id			Topic author id
385
+	 * @param	string	$viewtopic_url		URL to the topic page
386
+	 *
387
+	 * @return	null
388
+	 */
389 389
 	public function attr_apply($attribute_id = 0, $topic_id = 0, $forum_id = 0, $topic_attribute = 0, $author_id = 0, $viewtopic_url = '')
390 390
 	{
391 391
 		if (empty($topic_id) || empty($forum_id) || empty($attribute_id))
@@ -458,14 +458,14 @@  discard block
 block discarded – undo
458 458
 	}
459 459
 
460 460
 	/**
461
-	* Change topic attribute in mcp
462
-	*
463
-	* @param	int		$attribute_id		New attribute id
464
-	* @param	int		$forum_id			The id of the forum
465
-	* @param	array	$topic_ids			Topics ids
466
-	*
467
-	* @return	null
468
-	*/
461
+	 * Change topic attribute in mcp
462
+	 *
463
+	 * @param	int		$attribute_id		New attribute id
464
+	 * @param	int		$forum_id			The id of the forum
465
+	 * @param	array	$topic_ids			Topics ids
466
+	 *
467
+	 * @return	null
468
+	 */
469 469
 	public function mcp_attr_apply($attribute_id = 0, $forum_id = 0, $topic_ids = array())
470 470
 	{
471 471
 		$can_edit		= $this->auth->acl_get('m_qte_attr_edit', $forum_id);
@@ -551,10 +551,10 @@  discard block
 block discarded – undo
551 551
 	}
552 552
 
553 553
 	/**
554
-	* Getter...
555
-	*
556
-	* @return	array
557
-	*/
554
+	 * Getter...
555
+	 *
556
+	 * @return	array
557
+	 */
558 558
 	public function getAttr()
559 559
 	{
560 560
 		return $this->_attr;
@@ -567,12 +567,12 @@  discard block
 block discarded – undo
567 567
 	}
568 568
 
569 569
 	/**
570
-	* Build class and style attribute
571
-	*
572
-	* @param	string	$a_name			Attribute name
573
-	* @param	string	$a_colour		Attribute color
574
-	* @return	string					html code
575
-	*/
570
+	 * Build class and style attribute
571
+	 *
572
+	 * @param	string	$a_name			Attribute name
573
+	 * @param	string	$a_colour		Attribute color
574
+	 * @return	string					html code
575
+	 */
576 576
 	public function attr_colour($a_name, $a_colour)
577 577
 	{
578 578
 		if ($a_name != $this->user->lang($a_name))
@@ -584,10 +584,10 @@  discard block
 block discarded – undo
584 584
 	}
585 585
 
586 586
 	/**
587
-	* Get attributes from database
588
-	*
589
-	* @return	null
590
-	*/
587
+	 * Get attributes from database
588
+	 *
589
+	 * @return	null
590
+	 */
591 591
 	private function _get_attributes()
592 592
 	{
593 593
 		if (($this->_attr = $this->cache->get('_attr')) === false)
Please login to merge, or discard this patch.
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -69,16 +69,16 @@  discard block
 block discarded – undo
69 69
 	*/
70 70
 	public function __construct(\phpbb\request\request $request, \phpbb\cache\driver\driver_interface $cache, \phpbb\db\driver\driver_interface $db, \phpbb\template\template $template, \phpbb\user $user, \phpbb\log\log $log, \phpbb\auth\auth $auth, $root_path, $php_ext, $table_prefix)
71 71
 	{
72
-		$this->request		= $request;
72
+		$this->request = $request;
73 73
 		$this->cache		= $cache;
74
-		$this->db			= $db;
75
-		$this->template		= $template;
74
+		$this->db = $db;
75
+		$this->template = $template;
76 76
 		$this->user			= $user;
77
-		$this->log			= $log;
77
+		$this->log = $log;
78 78
 		$this->auth			= $auth;
79 79
 
80
-		$this->root_path	= $root_path;
81
-		$this->php_ext		= $php_ext;
80
+		$this->root_path = $root_path;
81
+		$this->php_ext = $php_ext;
82 82
 		$this->table_prefix = $table_prefix;
83 83
 
84 84
 		$this->_get_attributes();
@@ -169,16 +169,16 @@  discard block
 block discarded – undo
169 169
 	public function attr_select($forum_id, $author_id = 0, $attribute_id = 0, $viewtopic_url = '', $mode = '')
170 170
 	{
171 171
 		$show_select	= false;
172
-		$current_time	= time();
173
-		$can_edit		= (bool) $this->auth->acl_get('m_qte_attr_edit', $forum_id);
172
+		$current_time = time();
173
+		$can_edit = (bool) $this->auth->acl_get('m_qte_attr_edit', $forum_id);
174 174
 		$can_remove		= (bool) $this->auth->acl_get('m_qte_attr_del', $forum_id);
175
-		$is_author		= (bool) ($this->user->data['is_registered'] && $this->user->data['user_id'] == $author_id);
175
+		$is_author = (bool) ($this->user->data['is_registered'] && $this->user->data['user_id'] == $author_id);
176 176
 
177 177
 		if ($can_edit || $is_author || $mode == 'post')
178 178
 		{
179 179
 			foreach ($this->_attr as $attr)
180 180
 			{
181
-				if (!$this->auth->acl_get('f_qte_attr_'.$attr['attr_id'], $forum_id))
181
+				if (!$this->auth->acl_get('f_qte_attr_' . $attr['attr_id'], $forum_id))
182 182
 				{
183 183
 					continue;
184 184
 				}
@@ -249,7 +249,7 @@  discard block
 block discarded – undo
249 249
 	{
250 250
 		foreach ($this->_attr as $attr)
251 251
 		{
252
-			$forum_allowed = $this->auth->acl_getf('f_qte_attr_'.$attr['attr_id'], true);
252
+			$forum_allowed = $this->auth->acl_getf('f_qte_attr_' . $attr['attr_id'], true);
253 253
 
254 254
 			if (isset($forum_allowed[$forum_id]))
255 255
 			{
@@ -282,7 +282,7 @@  discard block
 block discarded – undo
282 282
 	{
283 283
 		foreach ($this->_attr as $attr)
284 284
 		{
285
-			$forum_allowed = $this->auth->acl_getf('f_qte_attr_'.$attr['attr_id'], true);
285
+			$forum_allowed = $this->auth->acl_getf('f_qte_attr_' . $attr['attr_id'], true);
286 286
 
287 287
 			if (isset($forum_allowed[$forum_id]))
288 288
 			{
@@ -393,8 +393,8 @@  discard block
 block discarded – undo
393 393
 			return;
394 394
 		}
395 395
 
396
-		$can_edit		= $this->auth->acl_get('m_qte_attr_edit', $forum_id) || $this->auth->acl_get('f_qte_attr_'.$attribute_id, $forum_id) && $this->user->data['is_registered'] && $this->user->data['user_id'] == $author_id;
397
-		$can_remove		= $this->auth->acl_get('m_qte_attr_del', $forum_id);
396
+		$can_edit = $this->auth->acl_get('m_qte_attr_edit', $forum_id) || $this->auth->acl_get('f_qte_attr_' . $attribute_id, $forum_id) && $this->user->data['is_registered'] && $this->user->data['user_id'] == $author_id;
397
+		$can_remove = $this->auth->acl_get('m_qte_attr_del', $forum_id);
398 398
 
399 399
 		if (!$can_edit && $attribute_id != self::REMOVE || !$can_remove && $attribute_id == self::REMOVE)
400 400
 		{
@@ -468,8 +468,8 @@  discard block
 block discarded – undo
468 468
 	*/
469 469
 	public function mcp_attr_apply($attribute_id = 0, $forum_id = 0, $topic_ids = array())
470 470
 	{
471
-		$can_edit		= $this->auth->acl_get('m_qte_attr_edit', $forum_id);
472
-		$can_remove		= $this->auth->acl_get('m_qte_attr_del', $forum_id);
471
+		$can_edit = $this->auth->acl_get('m_qte_attr_edit', $forum_id);
472
+		$can_remove = $this->auth->acl_get('m_qte_attr_del', $forum_id);
473 473
 
474 474
 		if (!$can_edit && $attribute_id != self::REMOVE || !$can_remove && $attribute_id == self::REMOVE)
475 475
 		{
@@ -580,7 +580,7 @@  discard block
 block discarded – undo
580 580
 			$a_class_name = preg_replace('#[^a-z0-9 _-]#', '', strtolower($a_name));
581 581
 		}
582 582
 
583
-		return ' class="qte-attr ' . (isset($a_class_name) ?  $a_class_name : '') . '"' . (!empty($a_colour) ? ' style="color:#' . $a_colour . '; font-weight:bold;"' : '');
583
+		return ' class="qte-attr ' . (isset($a_class_name) ? $a_class_name : '') . '"' . (!empty($a_colour) ? ' style="color:#' . $a_colour . '; font-weight:bold;"' : '');
584 584
 	}
585 585
 
586 586
 	/**
Please login to merge, or discard this patch.
event/main_listener.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -33,9 +33,9 @@  discard block
 block discarded – undo
33 33
 
34 34
 	public function __construct(\phpbb\request\request $request, \phpbb\template\template $template, \phpbb\user $user, \phpbb\log\log $log, \ernadoo\qte\qte $qte)
35 35
 	{
36
-		$this->request	= $request;
37
-		$this->template	= $template;
38
-		$this->user		= $user;
36
+		$this->request = $request;
37
+		$this->template = $template;
38
+		$this->user = $user;
39 39
 		$this->log		= $log;
40 40
 		$this->qte		= $qte;
41 41
 	}
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
 
118 118
 			if ($topic_attribute != \ernadoo\qte\qte::KEEP)
119 119
 			{
120
-				$post_data['topic_attr_id']		= (int) $topic_attribute;
120
+				$post_data['topic_attr_id'] = (int) $topic_attribute;
121 121
 				$post_data['topic_attr_user']	= (int) $this->user->data['user_id'];
122 122
 				$post_data['topic_attr_time']	= time();
123 123
 
@@ -139,11 +139,11 @@  discard block
 block discarded – undo
139 139
 
140 140
 		if ($event['post_data']['force_attr'])
141 141
 		{
142
-			if ($post_data['attr_id'] == \ernadoo\qte\qte::REMOVE && ($event['mode'] == 'post' || ($event['mode'] == 'edit' && $event['post_data']['topic_first_post_id'] == $event['post_id'])) )
142
+			if ($post_data['attr_id'] == \ernadoo\qte\qte::REMOVE && ($event['mode'] == 'post' || ($event['mode'] == 'edit' && $event['post_data']['topic_first_post_id'] == $event['post_id'])))
143 143
 			{
144 144
 				$error = $event['error'];
145 145
 				$error[] = $this->user->lang['QTE_ATTRIBUTE_UNSELECTED'];
146
-				$event['error'] = $error ;
146
+				$event['error'] = $error;
147 147
 
148 148
 				// init the value
149 149
 				$post_data['attr_id'] = 0;
Please login to merge, or discard this patch.